181229 2018-01-02 16:59:20 -0800 Web Inspector: Clicking source location link in Console unexpectedly jumps to Network tab 2018-01-02 18:52:10 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1385317 0 joepeck 2018-01-02 16:59:20 -0800 Clicking source location link in Console unexpectedly jumps to Network tab We recently made it possible to open resources in the Network tab. In many cases we don't expect to jump there and would rather go to the Resources tab or Debugger tab, even if we were more recently in the Network Tab. Do our usual preferences of ignoring the Search and Network tabs. Test: <script>console.error("here");</script> Steps to Reproduce: 1. Inspect test page 2. Show Network Tab 3. Show Elements Tab 4. Show Split Console 5. Click link next to "here" => Expected to go to Resources/Debugger tab and not Network tab 1385318 1 joepeck 2018-01-02 16:59:26 -0800 <rdar://problem/36075219> 1385321 2 330353 joepeck 2018-01-02 17:03:33 -0800 Created attachment 330353 [PATCH] Proposed Fix 1385358 3 330353 mattbaker 2018-01-02 18:30:45 -0800 Comment on attachment 330353 [PATCH] Proposed Fix r=me, nice cleanup. 1385362 4 330353 commit-queue 2018-01-02 18:52:09 -0800 Comment on attachment 330353 [PATCH] Proposed Fix Clearing flags on attachment: 330353 Committed r226347: <https://trac.webkit.org/changeset/226347> 1385363 5 commit-queue 2018-01-02 18:52:10 -0800 All reviewed patches have been landed. Closing bug. 330353 2018-01-02 17:03:33 -0800 2018-01-02 18:52:09 -0800 [PATCH] Proposed Fix console-link-1.patch text/plain 5075 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE5Zjk1MzY5NWYxLi5iZTI1OTRlMzQ0MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xICsxLDIxIEBACisyMDE4LTAxLTAyICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog Q2xpY2tpbmcgc291cmNlIGxvY2F0aW9uIGxpbmsgaW4gQ29uc29sZSB1bmV4cGVjdGVkbHkganVt cHMgdG8gTmV0d29yayB0YWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MTIyOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYwNzUyMTk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgQ2xlYW51cCBsaW5raWZ5VVJMQXNOb2RlLiBJZ25v cmUgU2VhcmNoIHRhYiBpbiBnZW5lcmljIGhhbmRsZVBvc3NpYmxlTGlua0NsaWNrCisgICAgICAg IHdoZW4gbm90IGFscmVhZHkgaW4gdGhlIFNlYXJjaCB0YWIuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0NhbGxGcmFtZVZpZXcuanM6CisgICAgICAgIChXSS5DYWxsRnJhbWVWaWV3 KToKKyAgICAgICAgSWdub3JlIFNlYXJjaCBhbmQgTmV0d29yayB0YWIgaW4gQ2FsbEZyYW1lIGxp bmtzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpzOgorICAg ICAgICAoV0kuVGFiQnJvd3Nlci5wcm90b3R5cGUuYmVzdFRhYkNvbnRlbnRWaWV3Rm9yUmVwcmVz ZW50ZWRPYmplY3QpOgorICAgICAgICBJbXByb3ZlIHN0eWxlLgorCiA9PSBSb2xsZWQgb3ZlciB0 byBDaGFuZ2VMb2ctMjAxOC0wMS0wMSA9PQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IGRiNmM4ZDY2MGMwLi4wYjc1Y2ViOTYwOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWlu LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5q cwpAQCAtNzc1LDcgKzc3NSw3IEBAIFdJLnVwZGF0ZVZpc2liaWxpdHlTdGF0ZSA9IGZ1bmN0aW9u KHZpc2libGUpCiAKIFdJLmhhbmRsZVBvc3NpYmxlTGlua0NsaWNrID0gZnVuY3Rpb24oZXZlbnQs IGZyYW1lLCBvcHRpb25zID0ge30pCiB7Ci0gICAgdmFyIGFuY2hvckVsZW1lbnQgPSBldmVudC50 YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFtZSgiYSIpOworICAgIGxldCBhbmNo b3JFbGVtZW50ID0gZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoTm9kZU5hbWUo ImEiKTsKICAgICBpZiAoIWFuY2hvckVsZW1lbnQgfHwgIWFuY2hvckVsZW1lbnQuaHJlZikKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCkBAIC03ODgsNyArNzg4LDEwIEBAIFdJLmhhbmRsZVBvc3Np YmxlTGlua0NsaWNrID0gZnVuY3Rpb24oZXZlbnQsIGZyYW1lLCBvcHRpb25zID0ge30pCiAgICAg ZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsKIAot ICAgIHRoaXMub3BlblVSTChhbmNob3JFbGVtZW50LmhyZWYsIGZyYW1lLCBPYmplY3Quc2hhbGxv d01lcmdlKG9wdGlvbnMsIHtsaW5lTnVtYmVyOiBhbmNob3JFbGVtZW50LmxpbmVOdW1iZXJ9KSk7 CisgICAgdGhpcy5vcGVuVVJMKGFuY2hvckVsZW1lbnQuaHJlZiwgZnJhbWUsIE9iamVjdC5zaGFs bG93TWVyZ2Uob3B0aW9ucywgeworICAgICAgICBsaW5lTnVtYmVyOiBhbmNob3JFbGVtZW50Lmxp bmVOdW1iZXIsCisgICAgICAgIGlnbm9yZVNlYXJjaFRhYjogIVdJLmlzU2hvd2luZ1NlYXJjaFRh YigpLAorICAgIH0pKTsKIAogICAgIHJldHVybiB0cnVlOwogfTsKQEAgLTk4MSw2ICs5ODQsMTEg QEAgV0kuaXNTaG93aW5nTmV0d29ya1RhYiA9IGZ1bmN0aW9uKCkKICAgICByZXR1cm4gdGhpcy50 YWJCcm93c2VyLnNlbGVjdGVkVGFiQ29udGVudFZpZXcgaW5zdGFuY2VvZiBXSS5OZXR3b3JrVGFi Q29udGVudFZpZXc7CiB9OwogCitXSS5pc1Nob3dpbmdTZWFyY2hUYWIgPSBmdW5jdGlvbigpCit7 CisgICAgcmV0dXJuIHRoaXMudGFiQnJvd3Nlci5zZWxlY3RlZFRhYkNvbnRlbnRWaWV3IGluc3Rh bmNlb2YgV0kuU2VhcmNoVGFiQ29udGVudFZpZXc7Cit9OworCiBXSS5zaG93VGltZWxpbmVUYWIg PSBmdW5jdGlvbigpCiB7CiAgICAgdmFyIHRhYkNvbnRlbnRWaWV3ID0gdGhpcy50YWJCcm93c2Vy LmJlc3RUYWJDb250ZW50Vmlld0ZvckNsYXNzKFdJLlRpbWVsaW5lVGFiQ29udGVudFZpZXcpOwpA QCAtMjM1OSwyMCArMjM2NywxMyBAQCBXSS5zb3VyY2VDb2RlRm9yVVJMID0gZnVuY3Rpb24odXJs KQogICAgIHJldHVybiBzb3VyY2VDb2RlIHx8IG51bGw7CiB9OwogCi1XSS5saW5raWZ5VVJMQXNO b2RlID0gZnVuY3Rpb24odXJsLCBsaW5rVGV4dCwgY2xhc3NlcykKK1dJLmxpbmtpZnlVUkxBc05v ZGUgPSBmdW5jdGlvbih1cmwsIGxpbmtUZXh0LCBjbGFzc05hbWUpCiB7Ci0gICAgaWYgKCFsaW5r VGV4dCkKLSAgICAgICAgbGlua1RleHQgPSB1cmw7Ci0KLSAgICBjbGFzc2VzID0gY2xhc3NlcyA/ IGNsYXNzZXMgKyAiICIgOiAiIjsKLQotICAgIHZhciBhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiYSIpOworICAgIGxldCBhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOwogICAgIGEu aHJlZiA9IHVybDsKLSAgICBhLmNsYXNzTmFtZSA9IGNsYXNzZXM7Ci0KLSAgICBhLnRleHRDb250 ZW50ID0gbGlua1RleHQ7CisgICAgYS5jbGFzc05hbWUgPSBjbGFzc05hbWUgfHwgIiI7CisgICAg YS50ZXh0Q29udGVudCA9IGxpbmtUZXh0IHx8IHVybDsKICAgICBhLnN0eWxlLm1heFdpZHRoID0g IjEwMCUiOwotCiAgICAgcmV0dXJuIGE7CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYWxsRnJhbWVWaWV3LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FsbEZyYW1lVmlldy5qcwppbmRleCA1 YTE3MjE5YTEyYS4uMWE3NGIwZGJhNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbGxGcmFtZVZpZXcuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FsbEZyYW1lVmlldy5qcwpAQCAtMzcsNyAr MzcsMTAgQEAgV0kuQ2FsbEZyYW1lVmlldyA9IGNsYXNzIENhbGxGcmFtZVZpZXcgZXh0ZW5kcyBX SS5PYmplY3QKIAogICAgICAgICB2YXIgc291cmNlQ29kZUxvY2F0aW9uID0gY2FsbEZyYW1lLnNv dXJjZUNvZGVMb2NhdGlvbjsKICAgICAgICAgaWYgKHNvdXJjZUNvZGVMb2NhdGlvbikgewotICAg ICAgICAgICAgV0kubGlua2lmeUVsZW1lbnQoY2FsbEZyYW1lRWxlbWVudCwgc291cmNlQ29kZUxv Y2F0aW9uKTsKKyAgICAgICAgICAgIFdJLmxpbmtpZnlFbGVtZW50KGNhbGxGcmFtZUVsZW1lbnQs IHNvdXJjZUNvZGVMb2NhdGlvbiwgeworICAgICAgICAgICAgICAgIGlnbm9yZU5ldHdvcmtUYWI6 IHRydWUsCisgICAgICAgICAgICAgICAgaWdub3JlU2VhcmNoVGFiOiB0cnVlLAorICAgICAgICAg ICAgfSk7CiAKICAgICAgICAgICAgIHZhciBsaW5rRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoImEiKTsKICAgICAgICAgICAgIGxpbmtFbGVtZW50LmNsYXNzTGlzdC5hZGQoInNvdXJj ZS1saW5rIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UYWJCcm93c2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGFiQnJvd3Nlci5qcwppbmRleCAyZTk1ZmVhMjA3Yi4uNjE1ZjAyY2UxODkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJy b3dzZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFiQnJvd3Nlci5qcwpAQCAtMTIyLDE2ICsxMjIsMTMgQEAgV0kuVGFiQnJvd3NlciA9IGNsYXNz IFRhYkJyb3dzZXIgZXh0ZW5kcyBXSS5WaWV3CiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2Vy dCghdGhpcy5zZWxlY3RlZFRhYkNvbnRlbnRWaWV3IHx8IHRoaXMuc2VsZWN0ZWRUYWJDb250ZW50 VmlldyA9PT0gdGhpcy5fcmVjZW50VGFiQ29udGVudFZpZXdzWzBdKTsKIAotICAgICAgICBmb3Ig KHZhciB0YWJDb250ZW50VmlldyBvZiB0aGlzLl9yZWNlbnRUYWJDb250ZW50Vmlld3MpIHsKKyAg ICAgICAgZm9yIChsZXQgdGFiQ29udGVudFZpZXcgb2YgdGhpcy5fcmVjZW50VGFiQ29udGVudFZp ZXdzKSB7CiAgICAgICAgICAgICBpZiAob3B0aW9ucy5pZ25vcmVTZWFyY2hUYWIgJiYgdGFiQ29u dGVudFZpZXcgaW5zdGFuY2VvZiBXSS5TZWFyY2hUYWJDb250ZW50VmlldykKICAgICAgICAgICAg ICAgICBjb250aW51ZTsKLQogICAgICAgICAgICAgaWYgKG9wdGlvbnMuaWdub3JlTmV0d29ya1Rh YiAmJiB0YWJDb250ZW50VmlldyBpbnN0YW5jZW9mIFdJLk5ldHdvcmtUYWJDb250ZW50VmlldykK ICAgICAgICAgICAgICAgICBjb250aW51ZTsKLQogICAgICAgICAgICAgaWYgKG9wdGlvbnMuaWdu b3JlUmVzb3VyY2VzVGFiICYmIHRhYkNvbnRlbnRWaWV3IGluc3RhbmNlb2YgV0kuUmVzb3VyY2Vz VGFiQ29udGVudFZpZXcpCiAgICAgICAgICAgICAgICAgY29udGludWU7Ci0KICAgICAgICAgICAg IGlmIChvcHRpb25zLmlnbm9yZURlYnVnZ2VyVGFiICYmIHRhYkNvbnRlbnRWaWV3IGluc3RhbmNl b2YgV0kuRGVidWdnZXJUYWJDb250ZW50VmlldykKICAgICAgICAgICAgICAgICBjb250aW51ZTsK IAo=