181187 2017-12-29 09:35:11 -0800 [WPE][GTK] Implement the assignment of ProcessIdentifiers to child processes 2018-01-02 14:45:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson mcatanzaro bugs-noreply clopez commit-queue don.olmstead mcatanzaro oldest_to_newest 1384954 0 beidson 2017-12-29 09:35:11 -0800 Non-Cocoa ports need to implement the assignment of ProcessIdentifiers to child processes in WK2 https://trac.webkit.org/changeset/226308/webkit added the notion of a "ProcessIdentifier" in child processes. The Identifier is created by the UI process and vended out to child processes as they are launched. I added the initialization of the identifier in the Cocoa process launching code, but added it for the Unixes was not something I could do blind. Somebody with the expertise and build setup needs to: - Make sure the LaunchOptions ProcessIdentifier in the UI process propagates to the child process (This will probably be done via argv?) - Make sure the child process extracts that process identifier and sets it properly on the ChildProcessInitializationParameters - Remove the code in ChildProcess::initialize that handles a missing process identifier as it is invalid for it to be missing. 1384956 1 mcatanzaro 2017-12-29 10:16:54 -0800 It looks like we only have ProcessLauncherGLib and ProcessLauncherMac. I'll look into this for ProcessLauncherGLib, which covers the WPE and GTK ports. Those are the only upstream WK2 ports right now (asides the WIP Windows port) so I believe no other ports should need to be updated. 1384957 2 mcatanzaro 2017-12-29 10:17:12 -0800 (And thanks for filing the bug. ;) 1384960 3 clopez 2017-12-29 11:12:20 -0800 What about non-Glib and non-Cocoa ports like WinCairo? I guess this needs to be implemented there as well, doesn't it? 1384965 4 mcatanzaro 2017-12-29 12:35:35 -0800 (In reply to Carlos Alberto Lopez Perez from comment #3) > What about non-Glib and non-Cocoa ports like WinCairo? I guess this needs to > be implemented there as well, doesn't it? This is for WK2. Windows support is WIP, and I don't see a ProcessLauncherWin yet. 1385082 5 330300 mcatanzaro 2018-01-01 14:10:14 -0800 Created attachment 330300 Patch 1385092 6 330300 beidson 2018-01-01 18:30:45 -0800 Comment on attachment 330300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330300&action=review LGTM > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:97 > + GUniquePtr<gchar> processIdentifier(g_strdup_printf("%" PRIu64, m_launchOptions.processIdentifier.toUInt64())); Whole patch is precisely what I tried to do blind except I had no way of verifying this line. :) Thanks! 1385158 7 330300 commit-queue 2018-01-02 10:17:20 -0800 Comment on attachment 330300 Patch Clearing flags on attachment: 330300 Committed r226327: <https://trac.webkit.org/changeset/226327> 1385159 8 commit-queue 2018-01-02 10:17:22 -0800 All reviewed patches have been landed. Closing bug. 1385243 9 mcatanzaro 2018-01-02 13:42:06 -0800 I broke the plugin process. 1385261 10 mcatanzaro 2018-01-02 14:45:44 -0800 Committed r226337: <https://trac.webkit.org/changeset/226337> 330300 2018-01-01 14:10:14 -0800 2018-01-02 10:17:20 -0800 Patch bug-181187-20180101161014.patch text/plain 5443 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2NjQwNDIzNzMzYmQzMGJi ZGYyNTkwODI2OTE1ZmU5YmY4OGQ4NzkuLmYwZDI3MTczZDRmMTVmNmExZDVlOWM5YmVmMTAxZDRl NjZiZjVkYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDEtMDEgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10g SW1wbGVtZW50IHRoZSBhc3NpZ25tZW50IG9mIFByb2Nlc3NJZGVudGlmaWVycyB0byBjaGlsZCBw cm9jZXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MTE4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2hhcmVkL0NoaWxkUHJvY2Vzcy5jcHA6IE1ha2UgdGhlIFByb2Nlc3NJZGVudGlmaWVyIG1h bmRhdG9yeS4KKyAgICAgICAgKFdlYktpdDo6Q2hpbGRQcm9jZXNzOjppbml0aWFsaXplKToKKyAg ICAgICAgKiBTaGFyZWQvdW5peC9DaGlsZFByb2Nlc3NNYWluLmNwcDogSW5pdGlhbGl6ZSBDaGls ZFByb2Nlc3NJbml0aWFsaXphdGlvblBhcmFtZXRlcnMgd2l0aCB0aGUKKyAgICAgICAgUHJvY2Vz c0lkZW50aWZpZXIuCisgICAgICAgIChXZWJLaXQ6OkNoaWxkUHJvY2Vzc01haW5CYXNlOjpwYXJz ZUNvbW1hbmRMaW5lKToKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9Qcm9jZXNz TGF1bmNoZXJHTGliLmNwcDogQ29weSB0aGUgUHJvY2Vzc0lkZW50aWZpZXIgZnJvbQorICAgICAg ICBMYXVuY2hPcHRpb25zIGludG8gYXJndi4KKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5j aGVyOjpsYXVuY2hQcm9jZXNzKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL3dwZS9XZWJQcm9jZXNz TWFpbldQRS5jcHA6IEV4cGVjdCB0aGUgV1BFIHNvY2tldCBJRCBsYXRlciBpbiB0aGUgY29tbWFu ZCBsaW5lLgorCiAyMDE3LTEyLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIFtBdHRhY2htZW50IFN1cHBvcnRdIFJlbW92ZSBjdXJyZW50IG1hY09T IHN1cHBvcnQgZm9yIGRyYWdnaW5nIGZpbGUtYmFja2VkIGF0dGFjaG1lbnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9DaGlsZFByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9T aGFyZWQvQ2hpbGRQcm9jZXNzLmNwcAppbmRleCAyOThlYWE3MmRmYmFhMWZhMDlkZjNiNTZlZTEy MWUzMGFmY2NiYjA0Li42OTk0ZDNkZjk1MGYxNzNhZDc4ODkyOTBjZmU3MGQ2ZDhjYjY2MDRkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9DaGlsZFByb2Nlc3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL0NoaWxkUHJvY2Vzcy5jcHAKQEAgLTY0LDE2ICs2NCw4IEBAIHN0 YXRpYyB2b2lkIGRpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlKElQQzo6Q29ubmVjdGlvbiop CiAKIHZvaWQgQ2hpbGRQcm9jZXNzOjppbml0aWFsaXplKGNvbnN0IENoaWxkUHJvY2Vzc0luaXRp YWxpemF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKIHsKLSNpZiBQTEFURk9STShDT0NPQSkK LSAgICBpZiAoIXBhcmFtZXRlcnMucHJvY2Vzc0lkZW50aWZpZXIpCi0gICAgICAgIFJFTEVBU0Vf QVNTRVJUX1dJVEhfTUVTU0FHRShmYWxzZSwgIlVuYWJsZSB0byBpbml0aWFsaXplIGNoaWxkIHBy b2Nlc3Mgd2l0aG91dCBhIFdlYkNvcmUgcHJvY2VzcyBpZGVudGlmaWVyIik7Ci0jZWxzZQotICAg IGlmICghcGFyYW1ldGVycy5wcm9jZXNzSWRlbnRpZmllcikKLSAgICAgICAgTE9HX0VSUk9SKCJB bGwgY2hpbGQgcHJvY2Vzc2VzIHNob3VsZCBoYXZlIGEgV2ViQ29yZTo6UHJvY2Vzc0lkZW50aWZp ZXIgdmVuZGVkIGJ5IHRoZSBVSSBwcm9jZXNzLCBidXQgdGhpcyBvbmUgZG9lc24ndC4gVGhpcyB3 aWxsIGNhdXNlIHRoaW5ncyB0byBicmVhay4iKTsKLSNlbmRpZgotCi0gICAgaWYgKHBhcmFtZXRl cnMucHJvY2Vzc0lkZW50aWZpZXIpCi0gICAgICAgIFByb2Nlc3M6OnNldElkZW50aWZpZXIoKnBh cmFtZXRlcnMucHJvY2Vzc0lkZW50aWZpZXIpOworICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVT U0FHRShwYXJhbWV0ZXJzLnByb2Nlc3NJZGVudGlmaWVyLCAiVW5hYmxlIHRvIGluaXRpYWxpemUg Y2hpbGQgcHJvY2VzcyB3aXRob3V0IGEgV2ViQ29yZSBwcm9jZXNzIGlkZW50aWZpZXIiKTsKKyAg ICBQcm9jZXNzOjpzZXRJZGVudGlmaWVyKCpwYXJhbWV0ZXJzLnByb2Nlc3NJZGVudGlmaWVyKTsK IAogICAgIHBsYXRmb3JtSW5pdGlhbGl6ZSgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC91bml4L0NoaWxkUHJvY2Vzc01haW4uY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQv dW5peC9DaGlsZFByb2Nlc3NNYWluLmNwcAppbmRleCA2MjhiZTY4N2FjMTZjMWNkZWZmMDE0MDNk ZWYxMThjN2FiODdlNTgwLi43ZjY5YWY4OGNlNDgyZGU2ODEzNDQyNDYyMGVlYjU4YTIwYWYyZDI5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC91bml4L0NoaWxkUHJvY2Vzc01haW4u Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3VuaXgvQ2hpbGRQcm9jZXNzTWFpbi5jcHAK QEAgLTI2LDE3ICsyNiwxOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNoaWxk UHJvY2Vzc01haW4uaCIKIAorI2luY2x1ZGUgPFdlYkNvcmUvUHJvY2Vzcy5oPgogI2luY2x1ZGUg PHN0ZGxpYi5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogYm9vbCBDaGlsZFByb2Nlc3NNYWlu QmFzZTo6cGFyc2VDb21tYW5kTGluZShpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7Ci0gICAgQVNT RVJUKGFyZ2MgPj0gMik7Ci0gICAgaWYgKGFyZ2MgPCAyKQorICAgIEFTU0VSVChhcmdjID49IDMp OworICAgIGlmIChhcmdjIDwgMykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgbV9wYXJh bWV0ZXJzLmNvbm5lY3Rpb25JZGVudGlmaWVyID0gYXRvaShhcmd2WzFdKTsKKyAgICBtX3BhcmFt ZXRlcnMucHJvY2Vzc0lkZW50aWZpZXIgPSBtYWtlT2JqZWN0SWRlbnRpZmllcjxXZWJDb3JlOjpQ cm9jZXNzSWRlbnRpZmllclR5cGU+KGF0b2xsKGFyZ3ZbMV0pKTsKKyAgICBtX3BhcmFtZXRlcnMu Y29ubmVjdGlvbklkZW50aWZpZXIgPSBhdG9pKGFyZ3ZbMl0pOwogICAgIHJldHVybiB0cnVlOwog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL1By b2Nlc3NMYXVuY2hlckdMaWIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIv Z2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcAppbmRleCA5M2JiODFmNDY0OWU1YzlmYzRjOTk1 ZDVkMzA2OTliNWIyMjBkYzI4Li5jYzljMDRkZThjZGQ2YzVlMGQxMjZiYjQyNDI3Y2NmNzBlNDZm MThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL1By b2Nlc3NMYXVuY2hlckdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5j aGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHAKQEAgLTk0LDggKzk0LDkgQEAgdm9pZCBQ cm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgIH0KIAogICAgIHJlYWxFeGVjdXRh YmxlUGF0aCA9IEZpbGVTeXN0ZW06OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihleGVjdXRhYmxl UGF0aCk7CisgICAgR1VuaXF1ZVB0cjxnY2hhcj4gcHJvY2Vzc0lkZW50aWZpZXIoZ19zdHJkdXBf cHJpbnRmKCIlIiBQUkl1NjQsIG1fbGF1bmNoT3B0aW9ucy5wcm9jZXNzSWRlbnRpZmllci50b1VJ bnQ2NCgpKSk7CiAgICAgR1VuaXF1ZVB0cjxnY2hhcj4gd2Via2l0U29ja2V0KGdfc3RyZHVwX3By aW50ZigiJWQiLCBzb2NrZXRQYWlyLmNsaWVudCkpOwotICAgIHVuc2lnbmVkIG5hcmdzID0gNDsg Ly8gc2l6ZSBvZiB0aGUgYXJndiBhcnJheSBmb3IgZ19zcGF3bl9hc3luYygpCisgICAgdW5zaWdu ZWQgbmFyZ3MgPSA1OyAvLyBzaXplIG9mIHRoZSBhcmd2IGFycmF5IGZvciBnX3NwYXduX2FzeW5j KCkKIAogI2lmIFBMQVRGT1JNKFdQRSkKICAgICBHVW5pcXVlUHRyPGdjaGFyPiB3cGVTb2NrZXQ7 CkBAIC0xMjQsNiArMTI1LDcgQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3Mo KQogICAgICAgICBhcmd2W2krK10gPSBjb25zdF9jYXN0PGNoYXIqPihhcmcuZGF0YSgpKTsKICNl bmRpZgogICAgIGFyZ3ZbaSsrXSA9IGNvbnN0X2Nhc3Q8Y2hhcio+KHJlYWxFeGVjdXRhYmxlUGF0 aC5kYXRhKCkpOworICAgIGFyZ3ZbaSsrXSA9IHByb2Nlc3NJZGVudGlmaWVyLmdldCgpOwogICAg IGFyZ3ZbaSsrXSA9IHdlYmtpdFNvY2tldC5nZXQoKTsKICNpZiBQTEFURk9STShXUEUpCiAgICAg aWYgKG1fbGF1bmNoT3B0aW9ucy5wcm9jZXNzVHlwZSA9PSBQcm9jZXNzTGF1bmNoZXI6OlByb2Nl c3NUeXBlOjpXZWIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mvd3BlL1dl YlByb2Nlc3NNYWluV1BFLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy93cGUvV2ViUHJv Y2Vzc01haW5XUEUuY3BwCmluZGV4IGNkMTM3YmNlN2M2NTE2NWU5NmNmZjU3M2EzMzMxNzg2ZDgy NTE1NTYuLjEwMTUzYTU0YWY2MTU3OTc3ZDJiZjIyNTE1NmRkNmNlY2ZkZTk4ODkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy93cGUvV2ViUHJvY2Vzc01haW5XUEUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy93cGUvV2ViUHJvY2Vzc01haW5XUEUuY3BwCkBA IC01MiwxNCArNTIsMTQgQEAgcHVibGljOgogCiAgICAgYm9vbCBwYXJzZUNvbW1hbmRMaW5lKGlu dCBhcmdjLCBjaGFyKiogYXJndikgb3ZlcnJpZGUKICAgICB7Ci0gICAgICAgIEFTU0VSVChhcmdj ID09IDMpOwotICAgICAgICBpZiAoYXJnYyA8IDMpCisgICAgICAgIEFTU0VSVChhcmdjID09IDQp OworICAgICAgICBpZiAoYXJnYyA8IDQpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAg ICAgICAgaWYgKCFDaGlsZFByb2Nlc3NNYWluQmFzZTo6cGFyc2VDb21tYW5kTGluZShhcmdjLCBh cmd2KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICBpbnQgd3BlRmQgPSBh dG9pKGFyZ3ZbMl0pOworICAgICAgICBpbnQgd3BlRmQgPSBhdG9pKGFyZ3ZbM10pOwogICAgICAg ICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goCiAgICAgICAgICAgICBbd3BlRmRdIHsKICAgICAg ICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChpczxQbGF0Zm9ybURpc3BsYXlXUEU+KFBsYXRmb3Jt RGlzcGxheTo6c2hhcmVkRGlzcGxheSgpKSk7Cg==