181184 2017-12-28 17:20:48 -0800 [JSC] Remove unused JSTypes 2018-01-02 12:58:57 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki darin fpizlo jfbastien keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1384900 0 ysuzuki 2017-12-28 17:20:48 -0800 [JSC] Remove unused JSTypes 1384901 1 330237 ysuzuki 2017-12-28 17:22:01 -0800 Created attachment 330237 Patch 1384904 2 330237 saam 2017-12-28 18:12:43 -0800 Comment on attachment 330237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330237&action=review > Source/JavaScriptCore/runtime/JSType.h:25 > enum JSType : uint8_t { You don’t need to change any of these values in the LLInt? 1384977 3 330237 ysuzuki 2017-12-30 11:04:07 -0800 Comment on attachment 330237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330237&action=review >> Source/JavaScriptCore/runtime/JSType.h:25 >> enum JSType : uint8_t { > > You don’t need to change any of these values in the LLInt? In LLInt, they are already changed to `constexpr ...`. So we do not need to change it :) 1384978 4 ysuzuki 2017-12-30 11:05:39 -0800 Committed r226311: <https://trac.webkit.org/changeset/226311> 1385212 5 webkit-bug-importer 2018-01-02 12:58:57 -0800 <rdar://problem/36260879> 330237 2017-12-28 17:22:01 -0800 2017-12-28 18:12:43 -0800 Patch bug-181184-20171229102200.patch text/plain 3051 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 ZGRlMjZiODE0YmQ2OTBhZjA5YThmMTA3YWIxMzY5MmUzZTcwZGUyLi42OGRiMDY4NjhiYzkxMDlj OGE5YWRjMTZiMzFhY2Y2Y2RhOTU4NzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0xMi0yOCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBSZW1vdmUgdW51c2VkIEpTVHlwZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTE4NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEpTVHlwZSBpbmNsdWRlcyBzb21l IHVudXNlZCB0eXBlcyBzdWNoIGFzIE51bGxUeXBlLiBUaGV5IGFyZSBmb3IKKyAgICAgICAgcHJp bWl0aXZlIHZhbHVlcyBpbiBvbGQgZGF5cy4gQnV0IG5vdyBKU1R5cGUgaXMgb25seSB1c2VkIGZv ciBKU0NlbGxzLgorCisgICAgICAgICogcnVudGltZS9KU1R5cGUuaDoKKyAgICAgICAgKiBydW50 aW1lL1R5cGVkQXJyYXlUeXBlLmNwcDoKKyAgICAgICAgKEpTQzo6dHlwZUZvclR5cGVkQXJyYXlU eXBlKToKKwogMjAxNy0xMi0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255 LmNvbT4KIAogICAgICAgICBbV2luXVtDTWFrZV0gVXNlIGFkZF9jdXN0b21fY29tbWFuZCB0byBj b3B5IGVhY2ggZm9yd2FyZGluZyBoZWFkZXIgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTVHlwZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNUeXBlLmgKaW5kZXggNTc3ZDE4ZTAyNWMxMWE5OTJjZTE2Yzg1MGNiMjIxOGUyMWM2YzAz Ni4uMWVkODQ3MDliZGM2MWU1Y2I5ZWVjMzdmYTk4NDFhYzlmMjZhNDkyYiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNUeXBlLmgKQEAgLTIzLDEyICsyMyw2IEBACiBuYW1lc3BhY2Ug SlNDIHsKIAogZW51bSBKU1R5cGUgOiB1aW50OF90IHsKLSAgICBVbnNwZWNpZmllZFR5cGUsCi0g ICAgVW5kZWZpbmVkVHlwZSwKLSAgICBCb29sZWFuVHlwZSwKLSAgICBOdW1iZXJUeXBlLAotICAg IE51bGxUeXBlLAotCiAgICAgLy8gVGhlIENlbGxUeXBlIHZhbHVlIG11c3QgY29tZSBiZWZvcmUg YW55IEpTVHlwZSB0aGF0IGlzIGEgSlNDZWxsLgogICAgIENlbGxUeXBlLAogICAgIFN0cmluZ1R5 cGUsCkBAIC0zOCwxMyArMzIsMTMgQEAgZW51bSBKU1R5cGUgOiB1aW50OF90IHsKICAgICBDdXN0 b21HZXR0ZXJTZXR0ZXJUeXBlLAogICAgIEFQSVZhbHVlV3JhcHBlclR5cGUsCiAKLSAgICBFdmFs RXhlY3V0YWJsZVR5cGUsCiAgICAgUHJvZ3JhbUV4ZWN1dGFibGVUeXBlLAogICAgIE1vZHVsZVBy b2dyYW1FeGVjdXRhYmxlVHlwZSwKKyAgICBFdmFsRXhlY3V0YWJsZVR5cGUsCiAgICAgRnVuY3Rp b25FeGVjdXRhYmxlVHlwZSwKLSAgICBXZWJBc3NlbWJseUV4ZWN1dGFibGVUeXBlLAogCiAgICAg VW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGVUeXBlLAorCiAgICAgVW5saW5rZWRQcm9ncmFtQ29k ZUJsb2NrVHlwZSwKICAgICBVbmxpbmtlZE1vZHVsZVByb2dyYW1Db2RlQmxvY2tUeXBlLAogICAg IFVubGlua2VkRXZhbENvZGVCbG9ja1R5cGUsCkBAIC02OCw2ICs2Miw3IEBAIGVudW0gSlNUeXBl IDogdWludDhfdCB7CiAgICAgV2l0aFNjb3BlVHlwZSwKICAgICBEaXJlY3RBcmd1bWVudHNUeXBl LAogICAgIFNjb3BlZEFyZ3VtZW50c1R5cGUsCisgICAgQ2xvbmVkQXJndW1lbnRzVHlwZSwKIAog ICAgIEFycmF5VHlwZSwKICAgICBEZXJpdmVkQXJyYXlUeXBlLApAQCAtMTAxLDkgKzk2LDYgQEAg ZW51bSBKU1R5cGUgOiB1aW50OF90IHsKICAgICBKU1dlYWtTZXRUeXBlLAogCiAgICAgV2ViQXNz ZW1ibHlGdW5jdGlvblR5cGUsCi0KLSAgICBDbG9uZWRBcmd1bWVudHNUeXBlLAotCiAgICAgV2Vi QXNzZW1ibHlUb0pTQ2FsbGVlVHlwZSwKIAogICAgIExhc3RKU0NPYmplY3RUeXBlID0gV2ViQXNz ZW1ibHlUb0pTQ2FsbGVlVHlwZSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1R5cGVkQXJyYXlUeXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1R5cGVkQXJyYXlUeXBlLmNwcAppbmRleCA2MDg3NWEyMDk4MDk3OWY3ZDY3ODUxNDA4OGM4N2Ey OTk4NTA3ZmE2Li40N2QzN2E4OTA2MmRhMTEwMTAzODg0M2NjMTQxYTlmNTQyN2RkMzJjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UeXBlZEFycmF5VHlwZS5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVHlwZWRBcnJheVR5cGUuY3BwCkBA IC0zNyw3ICszNyw3IEBAIEpTVHlwZSB0eXBlRm9yVHlwZWRBcnJheVR5cGUoVHlwZWRBcnJheVR5 cGUgdHlwZSkKICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICBjYXNlIE5vdFR5cGVkQXJyYXk6CiAg ICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgIHJldHVybiBVbnNw ZWNpZmllZFR5cGU7CisgICAgICAgIHJldHVybiBJbnQ4QXJyYXlUeXBlOwogICAgIGNhc2UgVHlw ZUludDg6CiAgICAgICAgIHJldHVybiBJbnQ4QXJyYXlUeXBlOwogICAgIGNhc2UgVHlwZVVpbnQ4 OgpAQCAtNjEsNyArNjEsNyBAQCBKU1R5cGUgdHlwZUZvclR5cGVkQXJyYXlUeXBlKFR5cGVkQXJy YXlUeXBlIHR5cGUpCiAKICAgICBkZWZhdWx0OgogICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1Rf UkVBQ0hFRCgpOwotICAgICAgICByZXR1cm4gVW5zcGVjaWZpZWRUeXBlOworICAgICAgICByZXR1 cm4gSW50OEFycmF5VHlwZTsKICAgICB9CiB9CiAK