181133 2017-12-22 11:53:40 -0800 generate_offset_extractor.rb should not print to stderr by default 2017-12-22 12:31:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue ews-watchlist fpizlo keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1384509 0 mcatanzaro 2017-12-22 11:53:40 -0800 Currently we have a build that is completely quiet between CMake time and install time, with the sole exception of generate_offset_extractor.rb, which always prints one line to stderr: [206/2826] Generating ../../DerivedSou...s/JavaScriptCore/LLIntDesiredOffsets.h Only dealing with backends: ["X86_64"] It doesn't seem to be adding any value. Can we just get rid of it? 1384510 1 330135 mcatanzaro 2017-12-22 11:55:00 -0800 Created attachment 330135 Patch 1384512 2 mark.lam 2017-12-22 12:06:49 -0800 (In reply to Michael Catanzaro from comment #0) > Currently we have a build that is completely quiet between CMake time and > install time, with the sole exception of generate_offset_extractor.rb, which > always prints one line to stderr: > > [206/2826] Generating > ../../DerivedSou...s/JavaScriptCore/LLIntDesiredOffsets.h > Only dealing with backends: ["X86_64"] > > It doesn't seem to be adding any value. Can we just get rid of it? Fil added this back in r172777. I suspect it is to aid in debugging whether the offlineasm successfully generated the expected backends (this is meaningful for builds that generate code for supporting multiple backends). That said, I think that code in the offlineasm has been stable for years now, and it isn't that hard to add this print back should we need to debug this in the future. So, I do not object to removing it. 1384519 3 330135 commit-queue 2017-12-22 12:30:27 -0800 Comment on attachment 330135 Patch Clearing flags on attachment: 330135 Committed r226270: <https://trac.webkit.org/changeset/226270> 1384520 4 commit-queue 2017-12-22 12:30:28 -0800 All reviewed patches have been landed. Closing bug. 1384521 5 webkit-bug-importer 2017-12-22 12:31:26 -0800 <rdar://problem/36197253> 330135 2017-12-22 11:55:00 -0800 2017-12-22 12:30:27 -0800 Patch bug-181133-20171222135459.patch text/plain 1424 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NzUzMmZmYzQzZWJjNTNmMjRjNWRkODU0YjYyZTU0ODAxYjZmNWMyLi4wMDA5OTk5ZTEyYTYwNDE4 NTliZDY2ZWJmYjBkNjM0MjZhMzE5ZGM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0xMi0yMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgZ2VuZXJhdGVfb2Zmc2V0X2V4dHJhY3Rvci5yYiBzaG91bGQg bm90IHByaW50IHRvIHN0ZGVyciBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODExMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uZWVkZWQgcHJpbnQgb3V0cHV0LgorCisg ICAgICAgICogb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdG9yLnJiOgorCiAyMDE3 LTEyLTIyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBEdXBsaWNhdGVkIHN5bWJvbHMgaW4gbGliamF2YXNjcmlwdGNvcmVndGsgYW5k IGxpYndlYmtpdDJndGsgY2FuIGNhdXNlIGNyYXNoZXMgaW4gcHJvZHVjdGlvbiBidWlsZHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29mZnNl dF9leHRyYWN0b3IucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9nZW5lcmF0 ZV9vZmZzZXRfZXh0cmFjdG9yLnJiCmluZGV4IDA1MjAwOGMwZDZmODdiNGE5MTNiZGIwOWE5YWUx ODI5YTVlNjM2MWMuLmZmZjM5ODI1NWY2NzhkZDJkYjQyMmRlMjQ5MWZiOTJhN2IwOTljMjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29mZnNl dF9leHRyYWN0b3IucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2Vu ZXJhdGVfb2Zmc2V0X2V4dHJhY3Rvci5yYgpAQCAtNDAsNyArNDAsNiBAQCBpbnB1dEZsbm0gPSBB UkdWLnNoaWZ0CiBvdXRwdXRGbG5tID0gQVJHVi5zaGlmdAogCiB2YWxpZEJhY2tlbmRzID0gY2Fu b25pY2FsaXplQmFja2VuZE5hbWVzKEFSR1Yuc2hpZnQuc3BsaXQoL1ssXHNdKy8pKQotJHN0ZGVy ci5wdXRzICJPbmx5IGRlYWxpbmcgd2l0aCBiYWNrZW5kczogI3t2YWxpZEJhY2tlbmRzfSIKIGlu Y2x1ZGVPbmx5QmFja2VuZHModmFsaWRCYWNrZW5kcykKIAogZGVmIGVtaXRNYWdpY051bWJlcgo=