181128 2017-12-22 09:10:43 -0800 [JSC] IntlCollator and IntlNumberFormat has static fields with same name 2017-12-22 15:35:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1384479 0 ticaiolima 2017-12-22 09:10:43 -0800 IntlCollator and IntlNumberFormat has static fields with same name. It means that if they are placed into same UnifiedSource the compilation will report a variable redefinition. 1384488 1 330127 ticaiolima 2017-12-22 09:49:45 -0800 Created attachment 330127 Patch 1384569 2 330127 ysuzuki 2017-12-22 15:08:30 -0800 Comment on attachment 330127 Patch r=me 1384576 3 330127 commit-queue 2017-12-22 15:33:18 -0800 Comment on attachment 330127 Patch Clearing flags on attachment: 330127 Committed r226283: <https://trac.webkit.org/changeset/226283> 1384577 4 commit-queue 2017-12-22 15:33:21 -0800 All reviewed patches have been landed. Closing bug. 1384578 5 webkit-bug-importer 2017-12-22 15:35:07 -0800 <rdar://problem/36198187> 330127 2017-12-22 09:49:45 -0800 2017-12-22 15:33:18 -0800 Patch bug-181128-20171222144944.patch text/plain 4400 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZDRlYTVmN2U0Y2YyZjVhNTAxODIwMDljNzFiMmMxYjEyYTcxODdlLi5kZTk1NWI1MTk4ZjM0MzUx N2EwNzViYWQ2ZjMzNWYxMjE1NWY0MzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0xMi0yMiAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0pTQ10gSW50bENvbGxhdG9yIGFuZCBJbnRsTnVtYmVyRm9ybWF0IGhhcyBz dGF0aWMgZmllbGRzIHdpdGggc2FtZSBuYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODExMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBNaW5vciBmaXhlcyBpbnRvIEludGxOdW1iZXJGb3JtYXQ6Omlu aXRpYWxpemVOdW1iZXJGb3JtYXQgYW5kCisgICAgICAgIEludGxDb2xsYXRvcjo6aW5pdGlhbGl6 ZUNvbGxhdG9yIHRoYXQgbWFrZXMgSlNDIHVuaWZpZWQgc291cmNlcworICAgICAgICBjb21waWxl LiBUaGVzZSBmaWxlcyB3ZXJlIGdlbmVyYXRpbmcgY29tcGlsYXRpb24gZXJyb3Igd2hlbiBwbGFj ZWQgYXQKKyAgICAgICAgdGhlIHNhbWUgVW5pZmllZFNvdXJjZS5jcHAsIGJlY2F1c2UgdGhleSBo YWQgc3RhdGljIHZhcmlhYmxlcyB3aXRoIHNhbWUgbmFtZS4KKworICAgICAgICAqIHJ1bnRpbWUv SW50bENvbGxhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6SW50bENvbGxhdG9yOjppbml0aWFsaXpl Q29sbGF0b3IpOgorICAgICAgICAqIHJ1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHA6CisgICAg ICAgIChKU0M6OkludGxOdW1iZXJGb3JtYXQ6OmluaXRpYWxpemVOdW1iZXJGb3JtYXQpOgorCiAy MDE3LTEyLTIyICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAg ICAgIFtERkddIFVuaWZ5IGJ1bmNoIG9mIERGRyAzMmJpdCBjb2RlIGludG8gNjRiaXQgY29kZQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bENvbGxhdG9yLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxDb2xsYXRvci5jcHAKaW5kZXgg N2NiZTU0ZWZkMDJiM2RlMzg5ZmQwZTY1ZDNlYjgzMjY5NGY1M2Y1MC4uYjJkNDhhNDJmODlmNzhj YzA2ZGNjN2ZhYTU3OTViYzhiZWJmZWE3OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSW50bENvbGxhdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9JbnRsQ29sbGF0b3IuY3BwCkBAIC00Niw3ICs0Niw3IEBAIG5hbWVzcGFjZSBKU0Mg ewogCiBjb25zdCBDbGFzc0luZm8gSW50bENvbGxhdG9yOjpzX2luZm8gPSB7ICJPYmplY3QiLCAm QmFzZTo6c19pbmZvLCBudWxscHRyLCBudWxscHRyLCBDUkVBVEVfTUVUSE9EX1RBQkxFKEludGxD b2xsYXRvcikgfTsKIAotc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IHJlbGV2YW50RXh0ZW5zaW9u S2V5c1szXSA9IHsgImNvIiwgImtuIiwgImtmIiB9Oworc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0 IHJlbGV2YW50Q29sbGF0b3JFeHRlbnNpb25LZXlzWzNdID0geyAiY28iLCAia24iLCAia2YiIH07 CiBzdGF0aWMgY29uc3Qgc2l6ZV90IGluZGV4T2ZFeHRlbnNpb25LZXlDbyA9IDA7CiBzdGF0aWMg Y29uc3Qgc2l6ZV90IGluZGV4T2ZFeHRlbnNpb25LZXlLbiA9IDE7CiBzdGF0aWMgY29uc3Qgc2l6 ZV90IGluZGV4T2ZFeHRlbnNpb25LZXlLZiA9IDI7CkBAIC0yNjAsNyArMjYwLDcgQEAgdm9pZCBJ bnRsQ29sbGF0b3I6OmluaXRpYWxpemVDb2xsYXRvcihFeGVjU3RhdGUmIHN0YXRlLCBKU1ZhbHVl IGxvY2FsZXMsIEpTVmFsdWUKICAgICAvLyAxNy4gTGV0IHJlbGV2YW50RXh0ZW5zaW9uS2V5cyBi ZSB0aGUgdmFsdWUgb2YgJUNvbGxhdG9yJS5bW3JlbGV2YW50RXh0ZW5zaW9uS2V5c11dLgogICAg IC8vIDE4LiBMZXQgciBiZSBSZXNvbHZlTG9jYWxlKCVDb2xsYXRvciUuW1thdmFpbGFibGVMb2Nh bGVzXV0sIHJlcXVlc3RlZExvY2FsZXMsIG9wdCwgcmVsZXZhbnRFeHRlbnNpb25LZXlzLCBsb2Nh bGVEYXRhKS4KICAgICBhdXRvJiBhdmFpbGFibGVMb2NhbGVzID0gc3RhdGUuanNDYWxsZWUoKS0+ Z2xvYmFsT2JqZWN0KCktPmludGxDb2xsYXRvckF2YWlsYWJsZUxvY2FsZXMoKTsKLSAgICBhdXRv IHJlc3VsdCA9IHJlc29sdmVMb2NhbGUoc3RhdGUsIGF2YWlsYWJsZUxvY2FsZXMsIHJlcXVlc3Rl ZExvY2FsZXMsIG9wdCwgcmVsZXZhbnRFeHRlbnNpb25LZXlzLCBXVEZfQVJSQVlfTEVOR1RIKHJl bGV2YW50RXh0ZW5zaW9uS2V5cyksIGxvY2FsZURhdGEpOworICAgIGF1dG8gcmVzdWx0ID0gcmVz b2x2ZUxvY2FsZShzdGF0ZSwgYXZhaWxhYmxlTG9jYWxlcywgcmVxdWVzdGVkTG9jYWxlcywgb3B0 LCByZWxldmFudENvbGxhdG9yRXh0ZW5zaW9uS2V5cywgV1RGX0FSUkFZX0xFTkdUSChyZWxldmFu dENvbGxhdG9yRXh0ZW5zaW9uS2V5cyksIGxvY2FsZURhdGEpOwogCiAgICAgLy8gMTkuIFNldCBj b2xsYXRvci5bW2xvY2FsZV1dIHRvIHRoZSB2YWx1ZSBvZiByLltbbG9jYWxlXV0uCiAgICAgbV9s b2NhbGUgPSByZXN1bHQuZ2V0KEFTQ0lJTGl0ZXJhbCgibG9jYWxlIikpOwpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsTnVtYmVyRm9ybWF0LmNwcAppbmRleCBjMmZi ODM0NjNhMzQ0NDc3YTBmYjRlZmI0YTQzNWZlM2VlNzcyNzFiLi5mNDE1OTczYjhkMDRhZjA2YWI1 YjdhMmE4YjI4MTcyYTQwMzdjYWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9JbnRsTnVtYmVyRm9ybWF0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9JbnRsTnVtYmVyRm9ybWF0LmNwcApAQCAtNDIsNyArNDIsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKIAogY29uc3QgQ2xhc3NJbmZvIEludGxOdW1iZXJGb3JtYXQ6OnNfaW5mbyA9IHsgIk9i amVjdCIsICZCYXNlOjpzX2luZm8sIG51bGxwdHIsIG51bGxwdHIsIENSRUFURV9NRVRIT0RfVEFC TEUoSW50bE51bWJlckZvcm1hdCkgfTsKIAotc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IHJlbGV2 YW50RXh0ZW5zaW9uS2V5c1sxXSA9IHsgIm51IiB9Oworc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0 IHJlbGV2YW50TnVtYmVyRXh0ZW5zaW9uS2V5c1sxXSA9IHsgIm51IiB9OwogCiB2b2lkIEludGxO dW1iZXJGb3JtYXQ6OlVOdW1iZXJGb3JtYXREZWxldGVyOjpvcGVyYXRvcigpKFVOdW1iZXJGb3Jt YXQqIG51bWJlckZvcm1hdCkgY29uc3QKIHsKQEAgLTE5NCw3ICsxOTQsNyBAQCB2b2lkIEludGxO dW1iZXJGb3JtYXQ6OmluaXRpYWxpemVOdW1iZXJGb3JtYXQoRXhlY1N0YXRlJiBzdGF0ZSwgSlNW YWx1ZSBsb2NhbGVzLAogICAgIC8vIDExLiBMZXQgbG9jYWxlRGF0YSBiZSAlTnVtYmVyRm9ybWF0 JS5bW2xvY2FsZURhdGFdXS4KICAgICAvLyAxMi4gTGV0IHIgYmUgUmVzb2x2ZUxvY2FsZSglTnVt YmVyRm9ybWF0JS5bW2F2YWlsYWJsZUxvY2FsZXNdXSwgcmVxdWVzdGVkTG9jYWxlcywgb3B0LCAl TnVtYmVyRm9ybWF0JS5bW3JlbGV2YW50RXh0ZW5zaW9uS2V5c11dLCBsb2NhbGVEYXRhKS4KICAg ICBhdXRvJiBhdmFpbGFibGVMb2NhbGVzID0gc3RhdGUuanNDYWxsZWUoKS0+Z2xvYmFsT2JqZWN0 KCktPmludGxOdW1iZXJGb3JtYXRBdmFpbGFibGVMb2NhbGVzKCk7Ci0gICAgYXV0byByZXN1bHQg PSByZXNvbHZlTG9jYWxlKHN0YXRlLCBhdmFpbGFibGVMb2NhbGVzLCByZXF1ZXN0ZWRMb2NhbGVz LCBvcHQsIHJlbGV2YW50RXh0ZW5zaW9uS2V5cywgV1RGX0FSUkFZX0xFTkdUSChyZWxldmFudEV4 dGVuc2lvbktleXMpLCBJbnRsTkZJbnRlcm5hbDo6bG9jYWxlRGF0YSk7CisgICAgYXV0byByZXN1 bHQgPSByZXNvbHZlTG9jYWxlKHN0YXRlLCBhdmFpbGFibGVMb2NhbGVzLCByZXF1ZXN0ZWRMb2Nh bGVzLCBvcHQsIHJlbGV2YW50TnVtYmVyRXh0ZW5zaW9uS2V5cywgV1RGX0FSUkFZX0xFTkdUSChy ZWxldmFudE51bWJlckV4dGVuc2lvbktleXMpLCBJbnRsTkZJbnRlcm5hbDo6bG9jYWxlRGF0YSk7 CiAKICAgICAvLyAxMy4gU2V0IG51bWJlckZvcm1hdC5bW2xvY2FsZV1dIHRvIHRoZSB2YWx1ZSBv ZiByLltbbG9jYWxlXV0uCiAgICAgbV9sb2NhbGUgPSByZXN1bHQuZ2V0KEFTQ0lJTGl0ZXJhbCgi bG9jYWxlIikpOwo=