181126 2017-12-22 07:41:12 -0800 REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close 2018-03-08 09:28:06 -0800 1 1 1 Unclassified WebKit Web Inspector Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cedric.bellegarde webkit-unassigned aperez bugs-noreply cgarcia clopez inspector-bugzilla-changes mcatanzaro webkit-bug-importer oldest_to_newest 1384468 0 cedric.bellegarde 2017-12-22 07:41:12 -0800 When enabling inspector with "developer-extras", the inspector window opened from default webkit menu can't be closed. Adding a webkit_web_view_get_inspector() call fixes the issue. (Was not present in 2.16) Exemple: #!/usr/bin/python from gi.repository import WebKit2 from gi.repository import Gtk def close(window): Gtk.main_quit() def main(): Gtk.init() view = WebKit2.WebView() settings = view.get_settings() settings.set_property("enable-developer-extras", True) view.load_uri("http://google.fr") window = Gtk.Window() window.add(view) window.connect("destroy", close) window.show_all() Gtk.main() main() 1384518 1 mcatanzaro 2017-12-22 12:25:52 -0800 This one, I can reproduce. 2.18.3 is fine, trunk is not. 1384528 2 mcatanzaro 2017-12-22 12:43:19 -0800 We could probably fix it by calling webkitWebInspectorCreate during WebKitWebView construction, instead of doing it lazily, but there's probably a better way, if we could figure out what changed here. 1385110 3 cgarcia 2018-01-02 05:10:50 -0800 I can't reproduce this. 1403705 4 mcatanzaro 2018-03-05 12:22:31 -0800 (In reply to Carlos Garcia Campos from comment #3) > I can't reproduce this. Did you try the example in the first comment? MiniBrowser and epiphany both calls webkit_web_view_get_inspector(), which avoids the problem, so you won't be able to reproduce there. 1404287 5 cgarcia 2018-03-07 00:39:34 -0800 I broke this in r218089 1404288 6 335176 cgarcia 2018-03-07 00:44:07 -0800 Created attachment 335176 Patch 1404291 7 aperez 2018-03-07 00:58:03 -0800 I can reproduce this with Dinghy (https://github.com/aperezdc/dinghy), which is is a WPE launcher/browser. It can be built with against WebKitGTK+ as well passing “-DDY_USE_WEBKITGTK=ON” to CMake. The issue is present in both ports. 1404619 8 cgarcia 2018-03-07 22:37:52 -0800 Committed r229396: <https://trac.webkit.org/changeset/229396> 1404765 9 webkit-bug-importer 2018-03-08 09:28:05 -0800 <rdar://problem/38265943> 1404766 10 webkit-bug-importer 2018-03-08 09:28:06 -0800 <rdar://problem/38265944> 335176 2018-03-07 00:44:07 -0800 2018-03-07 06:46:18 -0800 Patch wk2-inspector-detach.diff text/plain 1614 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNWZjOTRlZmU1OWEuLmM4MDg3ZThjMzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE4LTAzLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMTgwODkpOiBbR1RLXSB3ZWJraXRfd2ViX3Zp ZXdfZ2V0X2luc3BlY3RvcigpIG5lZWRzIHRvIGJlIGNhbGxlZCwgb3RoZXJ3aXNlIGluc3BlY3Rv ciBkb2VzIG5vdCBjbG9zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTgxMTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IHRoZSBjb25kaXRpb24gdG8gZGVjaWRlIHdoZXRoZXIgdG8gZGV0YWNoIHRo ZSBpbnNwZWN0b3IgdmlldyBvdXJzZWx2ZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dl Ykluc3BlY3RvclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJv eHk6OnBsYXRmb3JtRGV0YWNoKTogUmVtb3ZlIHRoZSBpbnNwZWN0b3IgdmlldyBmcm9tIGl0cyBw YXJlbnQgaWYgd2UgZG9uJ3QgaGF2ZSBhIGNsaWVudAorICAgICAgICBvciB0aGUgY2xpZW50IGRp ZG4ndCBkZXRhY2ggaXQuCisKIDIwMTgtMDMtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RL LmNtYWtlIGFuZCBORVdTIGZvciAyLjE5LjkyIHJlbGVhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcAppbmRleCA3OGJlMDg3 MmIzYy4uNDlhZWNiZTU4MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0 ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Z3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcApAQCAtMzk2LDcgKzM5Niw3IEBAIHZvaWQgV2Vi SW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAg R1JlZlB0cjxHdGtXaWRnZXQ+IGluc3BlY3RvclZpZXcgPSBtX2luc3BlY3RvclZpZXc7Ci0gICAg aWYgKG1fY2xpZW50ICYmICFtX2NsaWVudC0+ZGV0YWNoKCp0aGlzKSkgeworICAgIGlmICghbV9j bGllbnQgfHwgIW1fY2xpZW50LT5kZXRhY2goKnRoaXMpKSB7CiAgICAgICAgIC8vIERldGFjaCBp cyBjYWxsZWQgd2hlbiBtX2lzQXR0YWNoZWQgaXMgdHJ1ZSwgYnV0IGl0IGNvdWxkIGNhbGxlZCBi ZWZvcmUKICAgICAgICAgLy8gdGhlIGluc3BlY3RvciBpcyBvcGVuZWQgaWYgdGhlIGluc3BlY3Rv ciBpcyBzaG93bi9jbG9zZWQgcXVpY2tseS4gU28sCiAgICAgICAgIC8vIHdlIG1pZ2h0IG5vdCBo YXZlIGEgcGFyZW50IHlldC4K