181113 2017-12-21 17:55:10 -0800 [WinCairo] fix build after r226245 2017-12-21 19:35:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned cdumez commit-queue don.olmstead esprehn+autocc ews-watchlist gyuyoung.kim keith_miller webkit-bug-importer oldest_to_newest 1384340 0 chris.reid 2017-12-21 17:55:10 -0800 c:\webkit-buildslave\win-cairo-release\build\source\webcore\html\AttachmentTypes.h(42): error C2039: 'optional': is not a member of 'std' https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/9487/steps/compile-webkit/logs/stdio 1384344 1 330087 chris.reid 2017-12-21 18:01:08 -0800 Created attachment 330087 Patch 1384345 2 don.olmstead 2017-12-21 18:04:12 -0800 This error seems to have been triggered by the unified sources build. In the changeset that caused the failure some files were moved which looks to have changed the group of source files. It looks like previously whatever sources were included before had included <wtf/Optional.h> so there were no build errors. More stuff like this is likely to happen with the unified builds so we should probably look at how to prevent this from happening. 1384365 3 330087 commit-queue 2017-12-21 19:34:31 -0800 Comment on attachment 330087 Patch Clearing flags on attachment: 330087 Committed r226256: <https://trac.webkit.org/changeset/226256> 1384366 4 commit-queue 2017-12-21 19:34:32 -0800 All reviewed patches have been landed. Closing bug. 1384367 5 webkit-bug-importer 2017-12-21 19:35:21 -0800 <rdar://problem/36190022> 330087 2017-12-21 18:01:08 -0800 2017-12-21 19:34:31 -0800 Patch 181113.diff text/plain 993 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZWFmNzFjZmVhOC4uNzMyYjg3NDcyYmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0xMi0yMSAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBmaXggYnVpbGQgYWZ0ZXIgcjIyNjI0NQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMTEzCisKKyAg ICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBodG1sL0F0dGFjaG1lbnRUeXBlcy5oOiBB ZGRlZCBhbiBpbmNsdWRlIGZvciBzdGQ6Om9wdGlvbmFsCisKIDIwMTctMTItMjEgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbUmVuZGVyVHJlZUJ1aWxkZXJdIE1v dmUgUmVuZGVyUnVieUFzSW5saW5lOjphZGRDaGlsZCBtdXRhdGlvbiB0byBhIFJlbmRlclRyZWVC dWlsZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0F0dGFjaG1lbnRUeXBlcy5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9BdHRhY2htZW50VHlwZXMuaAppbmRleCBkZGI1ZjFmZDA2 OC4uNTY1ZGU5MThlNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQXR0YWNobWVu dFR5cGVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9BdHRhY2htZW50VHlwZXMuaApAQCAt MjcsNiArMjcsOCBAQAogCiAjaWYgRU5BQkxFKEFUVEFDSE1FTlRfRUxFTUVOVCkKIAorI2luY2x1 ZGUgPHd0Zi9PcHRpb25hbC5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGVudW0gY2xhc3Mg QXR0YWNobWVudERpc3BsYXlNb2RlIHsK