181112 2017-12-21 17:47:53 -0800 lowering get_by_val to GetById inside bytecode parser should check for BadType exit kind 2017-12-21 19:06:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1384338 0 saam 2017-12-21 17:47:53 -0800 We do a CheckStringIdent on the string identifier. This may exit for BadType. This leads to an infinite exit loop in Speedometer. Fixing this isn't a speedup, but we should fix it. 1384341 1 330085 saam 2017-12-21 17:57:20 -0800 Created attachment 330085 patch 1384343 2 330085 mark.lam 2017-12-21 17:59:12 -0800 Comment on attachment 330085 patch r=me 1384358 3 330085 commit-queue 2017-12-21 19:05:21 -0800 Comment on attachment 330085 patch Clearing flags on attachment: 330085 Committed r226254: <https://trac.webkit.org/changeset/226254> 1384359 4 commit-queue 2017-12-21 19:05:23 -0800 All reviewed patches have been landed. Closing bug. 1384360 5 webkit-bug-importer 2017-12-21 19:06:36 -0800 <rdar://problem/36189779> 330085 2017-12-21 17:57:20 -0800 2017-12-21 19:05:21 -0800 patch c-backup.diff text/plain 2501 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2MjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE3LTEyLTIxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGxvd2VyaW5nIGdldF9ieV92YWwgdG8gR2V0QnlJZCBpbnNpZGUgYnl0ZWNvZGUgcGFyc2VyIHNo b3VsZCBjaGVjayBmb3IgQmFkVHlwZSBleGl0IGtpbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBSZWFjdCBzdWJ0ZXN0IGluIFNwZWVkb21ldGVy IGhhcyBhIGdldF9ieV92YWwgaXQgYWx3YXlzIGNvbnZlcnRzCisgICAgICAgIGludG8gYSBHZXRC eUlkIGluIHRoZSBERkcuIFRoaXMgR2V0QnlJZCBhbHdheXMgZXhpdHMgYmVjYXVzZSBvZiB0aGUg aW5jb21pbmcKKyAgICAgICAgaWRlbnRpZmllciBpcyBhIHJvcGUuIFRoaXMgcGF0Y2ggZml4ZXMg dGhpcyBpbmZpbml0ZSBleGl0IGxvb3AKKyAgICAgICAgYnkgb25seSBkb2luZyB0aGlzIHRyYW5z Zm9ybWF0aW9uIGlmIHdlIGhhdmVuJ3QgZXhpdGVkIGR1ZSB0byBCYWRUeXBlLgorCisgICAgICAg ICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29k ZVBhcnNlcjo6cGFyc2VCbG9jayk6CisKIDIwMTctMTItMjEgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBXVEY6OlBvaXNvbmVkVW5pcXVlUHRyIHRvIHJlcGxh Y2Ugc3RkOjp1bmlxdWVfcHRyIHdoZW4gcG9pc29uaW5nIGlzIGRlc2lyZWQuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkocmV2aXNp b24gMjI2MjUyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4NzUsNyArNDg3NSwxMiBAQCB2b2lkIEJ5dGVDb2Rl UGFyc2VyOjpwYXJzZUJsb2NrKHVuc2lnbmVkCiAgICAgICAgICAgICAgICAgQnlWYWxJbmZvKiBi eVZhbEluZm8gPSBtX2lubGluZVN0YWNrVG9wLT5tX2J5VmFsSW5mb3MuZ2V0KENvZGVPcmlnaW4o Y3VycmVudENvZGVPcmlnaW4oKS5ieXRlY29kZUluZGV4KSk7CiAgICAgICAgICAgICAgICAgLy8g RklYTUU6IFdoZW4gdGhlIGJ5dGVjb2RlIGlzIG5vdCBjb21waWxlZCBpbiB0aGUgYmFzZWxpbmUg SklULCBieVZhbEluZm8gYmVjb21lcyBudWxsLgogICAgICAgICAgICAgICAgIC8vIEF0IHRoYXQg dGltZSwgdGhlcmUgaXMgbm8gaW5mb3JtYXRpb24uCi0gICAgICAgICAgICAgICAgaWYgKGJ5VmFs SW5mbyAmJiBieVZhbEluZm8tPnN0dWJJbmZvICYmICFieVZhbEluZm8tPnRvb2tTbG93UGF0aCAm JiAhbV9pbmxpbmVTdGFja1RvcC0+bV9leGl0UHJvZmlsZS5oYXNFeGl0U2l0ZShtX2N1cnJlbnRJ bmRleCwgQmFkSWRlbnQpICYmICFtX2lubGluZVN0YWNrVG9wLT5tX2V4aXRQcm9maWxlLmhhc0V4 aXRTaXRlKG1fY3VycmVudEluZGV4LCBCYWRDZWxsKSkgeworICAgICAgICAgICAgICAgIGlmIChi eVZhbEluZm8KKyAgICAgICAgICAgICAgICAgICAgJiYgYnlWYWxJbmZvLT5zdHViSW5mbworICAg ICAgICAgICAgICAgICAgICAmJiAhYnlWYWxJbmZvLT50b29rU2xvd1BhdGgKKyAgICAgICAgICAg ICAgICAgICAgJiYgIW1faW5saW5lU3RhY2tUb3AtPm1fZXhpdFByb2ZpbGUuaGFzRXhpdFNpdGUo bV9jdXJyZW50SW5kZXgsIEJhZElkZW50KQorICAgICAgICAgICAgICAgICAgICAmJiAhbV9pbmxp bmVTdGFja1RvcC0+bV9leGl0UHJvZmlsZS5oYXNFeGl0U2l0ZShtX2N1cnJlbnRJbmRleCwgQmFk VHlwZSkKKyAgICAgICAgICAgICAgICAgICAgJiYgIW1faW5saW5lU3RhY2tUb3AtPm1fZXhpdFBy b2ZpbGUuaGFzRXhpdFNpdGUobV9jdXJyZW50SW5kZXgsIEJhZENlbGwpKSB7CiAgICAgICAgICAg ICAgICAgICAgIGNvbXBpbGVkQXNHZXRCeUlkID0gdHJ1ZTsKICAgICAgICAgICAgICAgICAgICAg aWRlbnRpZmllck51bWJlciA9IG1fZ3JhcGguaWRlbnRpZmllcnMoKS5lbnN1cmUoYnlWYWxJbmZv LT5jYWNoZWRJZC5pbXBsKCkpOwogICAgICAgICAgICAgICAgICAgICBVbmlxdWVkU3RyaW5nSW1w bCogdWlkID0gbV9ncmFwaC5pZGVudGlmaWVycygpW2lkZW50aWZpZXJOdW1iZXJdOwo=