181099 2017-12-21 13:32:56 -0800 Storage Access API: Allow requests from non-sandboxed iframes 2017-12-21 14:50:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham cdumez commit-queue dbates esprehn+autocc ews-watchlist kangil.han webkit-bug-importer oldest_to_newest 1384233 0 wilander 2017-12-21 13:32:56 -0800 We should change the policy so that non-sandboxed iframes are allowed to use the API. If the iframe is sandboxed, it still needs the 'allow-storage-access-by-user-activation' token. 1384234 1 webkit-bug-importer 2017-12-21 13:33:23 -0800 <rdar://problem/36184501> 1384235 2 330056 wilander 2017-12-21 13:37:19 -0800 Created attachment 330056 Patch 1384275 3 330056 bfulgham 2017-12-21 14:41:38 -0800 Comment on attachment 330056 Patch Looks good. r=me. 1384277 4 330056 wilander 2017-12-21 14:42:10 -0800 Comment on attachment 330056 Patch Thanks, Brent! 1384279 5 330056 commit-queue 2017-12-21 14:50:41 -0800 Comment on attachment 330056 Patch Clearing flags on attachment: 330056 Committed r226244: <https://trac.webkit.org/changeset/226244> 1384280 6 commit-queue 2017-12-21 14:50:43 -0800 All reviewed patches have been landed. Closing bug. 330056 2017-12-21 13:37:19 -0800 2017-12-21 14:50:41 -0800 Patch bug-181099-20171221133718.patch text/plain 7319 wilander SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNjIzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTIxICBKb2huIFdp bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFN0b3JhZ2UgQWNjZXNzIEFQ STogQWxsb3cgcmVxdWVzdHMgZnJvbSBub24tc2FuZGJveGVkIGlmcmFtZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTA5OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzYxODQ1MDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBDaGFuZ2VkIGV4aXN0aW5nIHRlc3RzLgorCisg ICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpy ZXF1ZXN0U3RvcmFnZUFjY2Vzcyk6CisKIDIwMTctMTItMjEgIEplcmVteSBKb25lcyAgPGplcmVt eWpAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBGVUxMU0NSRUVOX0FQSSBmZWF0dXJlIGRl ZmluZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDIyNjIzNSkKKysr IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc1MDcs OCArNzUwNyw4IEBAIHZvaWQgRG9jdW1lbnQ6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKFJlZjwKICAg ICAgICAgcmV0dXJuOwogICAgIH0KICAgICAKLSAgICAvLyBUaGVyZSBoYXMgdG8gYmUgYSBzYW5k Ym94IGFuZCBpdCBoYXMgdG8gYWxsb3cgdGhlIHN0b3JhZ2UgYWNjZXNzIEFQSSB0byBiZSBjYWxs ZWQuCi0gICAgaWYgKHNhbmRib3hGbGFncygpID09IFNhbmRib3hOb25lIHx8IGlzU2FuZGJveGVk KFNhbmRib3hTdG9yYWdlQWNjZXNzQnlVc2VyQWN0aXZhdGlvbikpIHsKKyAgICAvLyBJZiB0aGVy ZSBpcyBhIHNhbmRib3gsIGl0IGhhcyB0byBhbGxvdyB0aGUgc3RvcmFnZSBhY2Nlc3MgQVBJIHRv IGJlIGNhbGxlZC4KKyAgICBpZiAoc2FuZGJveEZsYWdzKCkgIT0gU2FuZGJveE5vbmUgJiYgaXNT YW5kYm94ZWQoU2FuZGJveFN0b3JhZ2VBY2Nlc3NCeVVzZXJBY3RpdmF0aW9uKSkgewogICAgICAg ICBwcm9taXNlLT5yZWplY3QoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNjIzNSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTIxICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBw bGUuY29tPgorCisgICAgICAgIFN0b3JhZ2UgQWNjZXNzIEFQSTogQWxsb3cgcmVxdWVzdHMgZnJv bSBub24tc2FuZGJveGVkIGlmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MTA5OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYxODQ1MDE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRw L3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVxdWVzdC1hbmQtZGVueS1zdG9yYWdlLWFjY2Vzcy1jcm9z cy1vcmlnaW4taWZyYW1lLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3N0b3Jh Z2VBY2Nlc3MvcmVxdWVzdC1hbmQtZGVueS1zdG9yYWdlLWFjY2Vzcy1jcm9zcy1vcmlnaW4taWZy YW1lLmh0bWw6CisgICAgICAgICogaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3JlcXVlc3QtYW5k LWdyYW50LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9yaWdpbi1ub24tc2FuZGJveGVkLWlmcmFtZS1l eHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3JlcXVlc3Qt YW5kLWdyYW50LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9yaWdpbi1ub24tc2FuZGJveGVkLWlmcmFt ZS5odG1sOgorCiAyMDE3LTEyLTIxICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFN0b3JhZ2UgQWNjZXNzIEFQSTogTWFrZSBEb2N1bWVudExvYWRlcjo6d2ls bFNlbmRSZXF1ZXN0KCkgYW5kIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkZXRhY2hlZEZyb21QYXJl bnQyKCkgdGVsbCB0aGUgbmV0d29yayBwcm9jZXNzIHRvIGdldCByaWQgb2YgYW55IHN1YiBmcmFt ZSBhY2Nlc3MgZW50cmllcwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNj ZXNzL3JlcXVlc3QtYW5kLWRlbnktc3RvcmFnZS1hY2Nlc3MtY3Jvc3Mtb3JpZ2luLWlmcmFtZS1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdl QWNjZXNzL3JlcXVlc3QtYW5kLWRlbnktc3RvcmFnZS1hY2Nlc3MtY3Jvc3Mtb3JpZ2luLWlmcmFt ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDIyNjIzNSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVz dHMvc3RvcmFnZUFjY2Vzcy9yZXF1ZXN0LWFuZC1kZW55LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9y aWdpbi1pZnJhbWUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNSBAQAot VGVzdHMgdGhhdCBjcm9zcy1vcmlnaW4gaWZyYW1lIHN0b3JhZ2UgYWNjZXNzIGlzIGRlbmllZCBp ZiB0aGUgaWZyYW1lIGlzIG5vdCBzYW5kYm94ZWQuCitDT05GSVJNOiBEbyB5b3Ugd2FudCB0byB1 c2UgeW91ciBsb2NhbGhvc3QgSUQgb24gMTI3LjAuMC4xPworVGVzdHMgdGhhdCBjcm9zcy1vcmln aW4gaWZyYW1lIHN0b3JhZ2UgYWNjZXNzIGlzIGRlbmllZCBpZiB0aGUgaWZyYW1lIGlzIG5vdCBz YW5kYm94ZWQgYW5kIHRoZSB1c2VyIGRlY2xpbmVzLgogCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCiAKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZXF1ZXN0 LWFuZC1kZW55LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9yaWdpbi1pZnJhbWUuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVxdWVzdC1hbmQt ZGVueS1zdG9yYWdlLWFjY2Vzcy1jcm9zcy1vcmlnaW4taWZyYW1lLmh0bWwJKHJldmlzaW9uIDIy NjIzNSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZXF1ZXN0LWFu ZC1kZW55LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9yaWdpbi1pZnJhbWUuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtNCw3ICs0LDcgQEAKICAgICA8c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2Vz L2pzLXRlc3QuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJj ZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0PgotICAgICAgICBkZXNjcmlw dGlvbigiVGVzdHMgdGhhdCBjcm9zcy1vcmlnaW4gaWZyYW1lIHN0b3JhZ2UgYWNjZXNzIGlzIGRl bmllZCBpZiB0aGUgaWZyYW1lIGlzIG5vdCBzYW5kYm94ZWQuIik7CisgICAgICAgIGRlc2NyaXB0 aW9uKCJUZXN0cyB0aGF0IGNyb3NzLW9yaWdpbiBpZnJhbWUgc3RvcmFnZSBhY2Nlc3MgaXMgZGVu aWVkIGlmIHRoZSBpZnJhbWUgaXMgbm90IHNhbmRib3hlZCBhbmQgdGhlIHVzZXIgZGVjbGluZXMu Iik7CiAgICAgICAgIGpzVGVzdElzQXN5bmMgPSB0cnVlOwogCiAgICAgICAgIGNvbnN0IGhvc3RV bmRlclRlc3QgPSAibG9jYWxob3N0OjgwMDAiOwpAQCAtNzAsNiArNzAsNiBAQAogICAgIDwvc2Ny aXB0PgogPC9oZWFkPgogPGJvZHk+Ci0gICAgPGlmcmFtZSBvbmxvYWQ9InJ1blRlc3QoKSIgaWQ9 InRoZUlmcmFtZSIgc3JjPSJodHRwOi8vbG9jYWxob3N0OjgwMDAvc3RvcmFnZUFjY2Vzcy9yZXNv dXJjZXMvcmVxdWVzdC1zdG9yYWdlLWFjY2Vzcy1pZnJhbWUuaHRtbCN1c2VyU2hvdWxkRGVueUFj Y2Vzcyx1c2VyU2hvdWxkTm90QmVDb25zdWx0ZWQscG9saWN5U2hvdWxkRGVueUFjY2Vzcyxpc05v dFNhbWVPcmlnaW5JZnJhbWUiPjwvaWZyYW1lPgorICAgIDxpZnJhbWUgb25sb2FkPSJydW5UZXN0 KCkiIGlkPSJ0aGVJZnJhbWUiIHNyYz0iaHR0cDovL2xvY2FsaG9zdDo4MDAwL3N0b3JhZ2VBY2Nl c3MvcmVzb3VyY2VzL3JlcXVlc3Qtc3RvcmFnZS1hY2Nlc3MtaWZyYW1lLmh0bWwjdXNlclNob3Vs ZERlbnlBY2Nlc3MsdXNlclNob3VsZEJlQ29uc3VsdGVkLHBvbGljeVNob3VsZEdyYW50QWNjZXNz LGlzTm90U2FtZU9yaWdpbklmcmFtZSI+PC9pZnJhbWU+CiA8L2JvZHk+CiA8L2h0bWw+ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9y YWdlQWNjZXNzL3JlcXVlc3QtYW5kLWdyYW50LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9yaWdpbi1u b24tc2FuZGJveGVkLWlmcmFtZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3JlcXVlc3QtYW5kLWdyYW50LXN0b3JhZ2UtYWNj ZXNzLWNyb3NzLW9yaWdpbi1ub24tc2FuZGJveGVkLWlmcmFtZS1leHBlY3RlZC50eHQJKHJldmlz aW9uIDIyNjIzNSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZXF1 ZXN0LWFuZC1ncmFudC1zdG9yYWdlLWFjY2Vzcy1jcm9zcy1vcmlnaW4tbm9uLXNhbmRib3hlZC1p ZnJhbWUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDkgKzEsMTAgQEAKLVRlc3Rz IHRoYXQgY3Jvc3Mtb3JpZ2luIGlmcmFtZSBzdG9yYWdlIGFjY2VzcyBpcyBkZW5pZWQgaWYgdGhl IGlmcmFtZSBpcyBub3Qgc2FuZGJveGVkLgorQ09ORklSTTogRG8geW91IHdhbnQgdG8gdXNlIHlv dXIgbG9jYWxob3N0IElEIG9uIDEyNy4wLjAuMT8KK1Rlc3RzIHRoYXQgY3Jvc3Mtb3JpZ2luIGlm cmFtZSBzdG9yYWdlIGFjY2VzcyBpcyBncmFudGVkIGlmIHRoZSBpZnJhbWUgaXMgbm90IHNhbmRi b3hlZCBhbmQgdGhlIHVzZXIgYWNjZXB0cy4KIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgog CiAKLVBBU1MgU3RvcmFnZSBhY2Nlc3Mgd2FzIGRlbmllZC4gZG9jdW1lbnQuY29va2llID09ICwg Y29va2llcyBzZWVuIHNlcnZlci1zaWRlID09ICJObyBjb29raWVzIgorUEFTUyBTdG9yYWdlIGFj Y2VzcyB3YXMgZ3JhbnRlZC4gZG9jdW1lbnQuY29va2llID09ICwgY29va2llcyBzZWVuIHNlcnZl ci1zaWRlID09ICJObyBjb29raWVzIgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQog CiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nl c3MvcmVxdWVzdC1hbmQtZ3JhbnQtc3RvcmFnZS1hY2Nlc3MtY3Jvc3Mtb3JpZ2luLW5vbi1zYW5k Ym94ZWQtaWZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9z dG9yYWdlQWNjZXNzL3JlcXVlc3QtYW5kLWdyYW50LXN0b3JhZ2UtYWNjZXNzLWNyb3NzLW9yaWdp bi1ub24tc2FuZGJveGVkLWlmcmFtZS5odG1sCShyZXZpc2lvbiAyMjYyMzUpCisrKyBMYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVxdWVzdC1hbmQtZ3JhbnQtc3RvcmFnZS1h Y2Nlc3MtY3Jvc3Mtb3JpZ2luLW5vbi1zYW5kYm94ZWQtaWZyYW1lLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTQsNyArNCw3IEBACiAgICAgPHNjcmlwdCBzcmM9Ii9qcy10ZXN0LXJlc291cmNlcy9q cy10ZXN0LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2Vz L3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KLSAgICAgICAgZGVzY3JpcHRp b24oIlRlc3RzIHRoYXQgY3Jvc3Mtb3JpZ2luIGlmcmFtZSBzdG9yYWdlIGFjY2VzcyBpcyBkZW5p ZWQgaWYgdGhlIGlmcmFtZSBpcyBub3Qgc2FuZGJveGVkLiIpOworICAgICAgICBkZXNjcmlwdGlv bigiVGVzdHMgdGhhdCBjcm9zcy1vcmlnaW4gaWZyYW1lIHN0b3JhZ2UgYWNjZXNzIGlzIGdyYW50 ZWQgaWYgdGhlIGlmcmFtZSBpcyBub3Qgc2FuZGJveGVkIGFuZCB0aGUgdXNlciBhY2NlcHRzLiIp OwogICAgICAgICBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIAogICAgICAgICBjb25zdCBob3N0VW5k ZXJUZXN0ID0gImxvY2FsaG9zdDo4MDAwIjsKQEAgLTcwLDYgKzcwLDYgQEAKICAgICA8L3Njcmlw dD4KIDwvaGVhZD4KIDxib2R5PgotICAgIDxpZnJhbWUgb25sb2FkPSJydW5UZXN0KCkiIGlkPSJ0 aGVJZnJhbWUiIHNyYz0iaHR0cDovL2xvY2FsaG9zdDo4MDAwL3N0b3JhZ2VBY2Nlc3MvcmVzb3Vy Y2VzL3JlcXVlc3Qtc3RvcmFnZS1hY2Nlc3MtaWZyYW1lLmh0bWwjdXNlclNob3VsZEdyYW50QWNj ZXNzLHVzZXJTaG91bGROb3RCZUNvbnN1bHRlZCxwb2xpY3lTaG91bGREZW55QWNjZXNzLGlzTm90 U2FtZU9yaWdpbklmcmFtZSI+PC9pZnJhbWU+CisgICAgPGlmcmFtZSBvbmxvYWQ9InJ1blRlc3Qo KSIgaWQ9InRoZUlmcmFtZSIgc3JjPSJodHRwOi8vbG9jYWxob3N0OjgwMDAvc3RvcmFnZUFjY2Vz cy9yZXNvdXJjZXMvcmVxdWVzdC1zdG9yYWdlLWFjY2Vzcy1pZnJhbWUuaHRtbCN1c2VyU2hvdWxk R3JhbnRBY2Nlc3MsdXNlclNob3VsZEJlQ29uc3VsdGVkLHBvbGljeVNob3VsZEdyYW50QWNjZXNz LGlzTm90U2FtZU9yaWdpbklmcmFtZSI+PC9pZnJhbWU+CiA8L2JvZHk+CiA8L2h0bWw+ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=