181094 2017-12-21 11:42:15 -0800 [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal 2017-12-21 13:28:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1384184 0 zalan 2017-12-21 11:42:15 -0800 ssia 1384185 1 330046 zalan 2017-12-21 11:44:26 -0800 Created attachment 330046 Patch 1384187 2 330046 koivisto 2017-12-21 11:46:12 -0800 Comment on attachment 330046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330046&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:65 > + auto insertInternal = [&](RenderElement& parentCandidate) { I bet there is a better name somewhere! 1384188 3 zalan 2017-12-21 11:46:51 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 330046 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330046&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:65 > > + auto insertInternal = [&](RenderElement& parentCandidate) { > > I bet there is a better name somewhere! I am 100% sure there is! 1384203 4 330050 zalan 2017-12-21 12:26:15 -0800 Created attachment 330050 Patch 1384218 5 330050 koivisto 2017-12-21 12:58:08 -0800 Comment on attachment 330050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330050&action=review > Source/WebCore/ChangeLog:3 > + [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal Lies. 1384219 6 330050 commit-queue 2017-12-21 12:59:16 -0800 Comment on attachment 330050 Patch Clearing flags on attachment: 330050 Committed r226237: <https://trac.webkit.org/changeset/226237> 1384220 7 commit-queue 2017-12-21 12:59:17 -0800 All reviewed patches have been landed. Closing bug. 1384221 8 webkit-bug-importer 2017-12-21 13:00:34 -0800 <rdar://problem/36183940> 1384231 9 zalan 2017-12-21 13:28:03 -0800 (In reply to Antti Koivisto from comment #5) > Comment on attachment 330050 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330050&action=review > > > Source/WebCore/ChangeLog:3 > > + [RenderTreeBuilder] Move repeating code to RenderTreeBuilder::insertInternal > > Lies. so true! 330046 2017-12-21 11:44:26 -0800 2017-12-21 12:26:14 -0800 Patch bug-181094-20171221114425.patch text/plain 3305 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUyMzc3NzM5ZmU2ZDE0 NGU3ZTY5NDE2Y2Q5NTg5MGJmMjY5NGMzZS4uMGFhNDcyNmI1ZDI1MTRiMTgwMGNhN2U3MTE0ZTg4 ZjYxNDE3Yzg1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEyLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBNb3ZlIHJlcGVhdGluZyBjb2RlIHRvIFJlbmRlclRyZWVCdWlsZGVyOjppbnNlcnRJbnRlcm5h bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVHJlZUJ1aWxkZXI6Omluc2VydENoaWxkKToKKwogMjAxNy0xMi0yMSAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgaW5pdGlhbCBET00gc3VwcG9y dCBmb3IgTWVkaWEgQ2FwYWJpbGl0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcAppbmRleCA3YmEwMDc5MDMzMGNj ZWM0ZTE1ZDJlNTYyZGIzMWFlOGRmOGVlOTZmLi4wMWY1YjlmMjUwOWJkZGFlMDc5MWViNzI3NDYw ZGZiOWI2Mjg4NzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRp bmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91 cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKQEAgLTYyLDYgKzYyLDE0IEBAIFJlbmRlclRy ZWVCdWlsZGVyOjp+UmVuZGVyVHJlZUJ1aWxkZXIoKQogCiB2b2lkIFJlbmRlclRyZWVCdWlsZGVy OjppbnNlcnRDaGlsZChSZW5kZXJFbGVtZW50JiBwYXJlbnQsIFJlbmRlclB0cjxSZW5kZXJPYmpl Y3Q+IGNoaWxkLCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkKQogeworICAgIGF1dG8gaW5zZXJ0 SW50ZXJuYWwgPSBbJl0oUmVuZGVyRWxlbWVudCYgcGFyZW50Q2FuZGlkYXRlKSB7CisgICAgICAg IGlmICgmcGFyZW50ID09ICZwYXJlbnRDYW5kaWRhdGUpIHsKKyAgICAgICAgICAgIHBhcmVudC5h ZGRDaGlsZCgqdGhpcywgV1RGTW92ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsKKyAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgfQorICAgICAgICBpbnNlcnRDaGlsZChwYXJlbnRDYW5kaWRhdGUs IFdURk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CisgICAgfTsKKwogICAgIEFTU0VSVCgmcGFy ZW50LnZpZXcoKSA9PSAmbV92aWV3KTsKIAogICAgIGlmIChpczxSZW5kZXJUZXh0PihiZWZvcmVD aGlsZCkpIHsKQEAgLTcwLDMyICs3OCwxNyBAQCB2b2lkIFJlbmRlclRyZWVCdWlsZGVyOjppbnNl cnRDaGlsZChSZW5kZXJFbGVtZW50JiBwYXJlbnQsIFJlbmRlclB0cjxSZW5kZXJPYmplYwogICAg IH0KIAogICAgIGlmIChpczxSZW5kZXJUYWJsZVJvdz4ocGFyZW50KSkgewotICAgICAgICBhdXRv JiBwYXJlbnRDYW5kaWRhdGUgPSB0YWJsZUJ1aWxkZXIoKS5maW5kT3JDcmVhdGVQYXJlbnRGb3JD aGlsZChkb3duY2FzdDxSZW5kZXJUYWJsZVJvdz4ocGFyZW50KSwgKmNoaWxkLCBiZWZvcmVDaGls ZCk7Ci0gICAgICAgIGlmICgmcGFyZW50ICE9ICZwYXJlbnRDYW5kaWRhdGUpIHsKLSAgICAgICAg ICAgIGluc2VydENoaWxkKHBhcmVudENhbmRpZGF0ZSwgV1RGTW92ZShjaGlsZCksIGJlZm9yZUNo aWxkKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotICAgICAgICBwYXJlbnQuYWRk Q2hpbGQoKnRoaXMsIFdURk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CisgICAgICAgIGluc2Vy dEludGVybmFsKHRhYmxlQnVpbGRlcigpLmZpbmRPckNyZWF0ZVBhcmVudEZvckNoaWxkKGRvd25j YXN0PFJlbmRlclRhYmxlUm93PihwYXJlbnQpLCAqY2hpbGQsIGJlZm9yZUNoaWxkKSk7CiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKICAgICBpZiAoaXM8UmVuZGVyVGFibGVTZWN0aW9uPihwYXJl bnQpKSB7Ci0gICAgICAgIGF1dG8mIHBhcmVudENhbmRpZGF0ZSA9IHRhYmxlQnVpbGRlcigpLmZp bmRPckNyZWF0ZVBhcmVudEZvckNoaWxkKGRvd25jYXN0PFJlbmRlclRhYmxlU2VjdGlvbj4ocGFy ZW50KSwgKmNoaWxkLCBiZWZvcmVDaGlsZCk7Ci0gICAgICAgIGlmICgmcGFyZW50ICE9ICZwYXJl bnRDYW5kaWRhdGUpIHsKLSAgICAgICAgICAgIGluc2VydENoaWxkKHBhcmVudENhbmRpZGF0ZSwg V1RGTW92ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAg ICAgfQotICAgICAgICBwYXJlbnQuYWRkQ2hpbGQoKnRoaXMsIFdURk1vdmUoY2hpbGQpLCBiZWZv cmVDaGlsZCk7CisgICAgICAgIGluc2VydEludGVybmFsKHRhYmxlQnVpbGRlcigpLmZpbmRPckNy ZWF0ZVBhcmVudEZvckNoaWxkKGRvd25jYXN0PFJlbmRlclRhYmxlU2VjdGlvbj4ocGFyZW50KSwg KmNoaWxkLCBiZWZvcmVDaGlsZCkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgaWYg KGlzPFJlbmRlclRhYmxlPihwYXJlbnQpKSB7Ci0gICAgICAgIGF1dG8mIHBhcmVudENhbmRpZGF0 ZSA9IHRhYmxlQnVpbGRlcigpLmZpbmRPckNyZWF0ZVBhcmVudEZvckNoaWxkKGRvd25jYXN0PFJl bmRlclRhYmxlPihwYXJlbnQpLCAqY2hpbGQsIGJlZm9yZUNoaWxkKTsKLSAgICAgICAgaWYgKCZw YXJlbnQgIT0gJnBhcmVudENhbmRpZGF0ZSkgewotICAgICAgICAgICAgaW5zZXJ0Q2hpbGQocGFy ZW50Q2FuZGlkYXRlLCBXVEZNb3ZlKGNoaWxkKSwgYmVmb3JlQ2hpbGQpOwotICAgICAgICAgICAg cmV0dXJuOwotICAgICAgICB9Ci0gICAgICAgIHBhcmVudC5hZGRDaGlsZCgqdGhpcywgV1RGTW92 ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsKKyAgICAgICAgaW5zZXJ0SW50ZXJuYWwodGFibGVCdWls ZGVyKCkuZmluZE9yQ3JlYXRlUGFyZW50Rm9yQ2hpbGQoZG93bmNhc3Q8UmVuZGVyVGFibGU+KHBh cmVudCksICpjaGlsZCwgYmVmb3JlQ2hpbGQpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo= 330050 2017-12-21 12:26:15 -0800 2017-12-21 12:59:16 -0800 Patch bug-181094-20171221122615.patch text/plain 3341 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUyMzc3NzM5ZmU2ZDE0 NGU3ZTY5NDE2Y2Q5NTg5MGJmMjY5NGMzZS4uOTQxMWI4OWE3ZDcyZGE3MmYzYTY4MmI3NGViYTll MzcwODI5MWYyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEyLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBNb3ZlIHJlcGVhdGluZyBjb2RlIHRvIFJlbmRlclRyZWVCdWlsZGVyOjppbnNlcnRJbnRlcm5h bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCisKKyAgICAgICAgKiByZW5k ZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVHJlZUJ1aWxkZXI6Omluc2VydENoaWxkKToKKwogMjAxNy0xMi0yMSAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgaW5pdGlhbCBET00gc3VwcG9y dCBmb3IgTWVkaWEgQ2FwYWJpbGl0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcAppbmRleCA3YmEwMDc5MDMzMGNj ZWM0ZTE1ZDJlNTYyZGIzMWFlOGRmOGVlOTZmLi44OTVkNmYxZjc2MjMwYWQ2YTQ4NmU4ODE0MjE4 MWVjZjE1NDNhOTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRp bmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91 cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKQEAgLTYyLDYgKzYyLDE0IEBAIFJlbmRlclRy ZWVCdWlsZGVyOjp+UmVuZGVyVHJlZUJ1aWxkZXIoKQogCiB2b2lkIFJlbmRlclRyZWVCdWlsZGVy OjppbnNlcnRDaGlsZChSZW5kZXJFbGVtZW50JiBwYXJlbnQsIFJlbmRlclB0cjxSZW5kZXJPYmpl Y3Q+IGNoaWxkLCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkKQogeworICAgIGF1dG8gaW5zZXJ0 UmVjdXJzaXZlSWZOZWVkZWQgPSBbJl0oUmVuZGVyRWxlbWVudCYgcGFyZW50Q2FuZGlkYXRlKSB7 CisgICAgICAgIGlmICgmcGFyZW50ID09ICZwYXJlbnRDYW5kaWRhdGUpIHsKKyAgICAgICAgICAg IHBhcmVudC5hZGRDaGlsZCgqdGhpcywgV1RGTW92ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICBpbnNlcnRDaGlsZChwYXJlbnRD YW5kaWRhdGUsIFdURk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CisgICAgfTsKKwogICAgIEFT U0VSVCgmcGFyZW50LnZpZXcoKSA9PSAmbV92aWV3KTsKIAogICAgIGlmIChpczxSZW5kZXJUZXh0 PihiZWZvcmVDaGlsZCkpIHsKQEAgLTcwLDMyICs3OCwxNyBAQCB2b2lkIFJlbmRlclRyZWVCdWls ZGVyOjppbnNlcnRDaGlsZChSZW5kZXJFbGVtZW50JiBwYXJlbnQsIFJlbmRlclB0cjxSZW5kZXJP YmplYwogICAgIH0KIAogICAgIGlmIChpczxSZW5kZXJUYWJsZVJvdz4ocGFyZW50KSkgewotICAg ICAgICBhdXRvJiBwYXJlbnRDYW5kaWRhdGUgPSB0YWJsZUJ1aWxkZXIoKS5maW5kT3JDcmVhdGVQ YXJlbnRGb3JDaGlsZChkb3duY2FzdDxSZW5kZXJUYWJsZVJvdz4ocGFyZW50KSwgKmNoaWxkLCBi ZWZvcmVDaGlsZCk7Ci0gICAgICAgIGlmICgmcGFyZW50ICE9ICZwYXJlbnRDYW5kaWRhdGUpIHsK LSAgICAgICAgICAgIGluc2VydENoaWxkKHBhcmVudENhbmRpZGF0ZSwgV1RGTW92ZShjaGlsZCks IGJlZm9yZUNoaWxkKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotICAgICAgICBw YXJlbnQuYWRkQ2hpbGQoKnRoaXMsIFdURk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CisgICAg ICAgIGluc2VydFJlY3Vyc2l2ZUlmTmVlZGVkKHRhYmxlQnVpbGRlcigpLmZpbmRPckNyZWF0ZVBh cmVudEZvckNoaWxkKGRvd25jYXN0PFJlbmRlclRhYmxlUm93PihwYXJlbnQpLCAqY2hpbGQsIGJl Zm9yZUNoaWxkKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBpZiAoaXM8UmVuZGVy VGFibGVTZWN0aW9uPihwYXJlbnQpKSB7Ci0gICAgICAgIGF1dG8mIHBhcmVudENhbmRpZGF0ZSA9 IHRhYmxlQnVpbGRlcigpLmZpbmRPckNyZWF0ZVBhcmVudEZvckNoaWxkKGRvd25jYXN0PFJlbmRl clRhYmxlU2VjdGlvbj4ocGFyZW50KSwgKmNoaWxkLCBiZWZvcmVDaGlsZCk7Ci0gICAgICAgIGlm ICgmcGFyZW50ICE9ICZwYXJlbnRDYW5kaWRhdGUpIHsKLSAgICAgICAgICAgIGluc2VydENoaWxk KHBhcmVudENhbmRpZGF0ZSwgV1RGTW92ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsKLSAgICAgICAg ICAgIHJldHVybjsKLSAgICAgICAgfQotICAgICAgICBwYXJlbnQuYWRkQ2hpbGQoKnRoaXMsIFdU Rk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CisgICAgICAgIGluc2VydFJlY3Vyc2l2ZUlmTmVl ZGVkKHRhYmxlQnVpbGRlcigpLmZpbmRPckNyZWF0ZVBhcmVudEZvckNoaWxkKGRvd25jYXN0PFJl bmRlclRhYmxlU2VjdGlvbj4ocGFyZW50KSwgKmNoaWxkLCBiZWZvcmVDaGlsZCkpOwogICAgICAg ICByZXR1cm47CiAgICAgfQogCiAgICAgaWYgKGlzPFJlbmRlclRhYmxlPihwYXJlbnQpKSB7Ci0g ICAgICAgIGF1dG8mIHBhcmVudENhbmRpZGF0ZSA9IHRhYmxlQnVpbGRlcigpLmZpbmRPckNyZWF0 ZVBhcmVudEZvckNoaWxkKGRvd25jYXN0PFJlbmRlclRhYmxlPihwYXJlbnQpLCAqY2hpbGQsIGJl Zm9yZUNoaWxkKTsKLSAgICAgICAgaWYgKCZwYXJlbnQgIT0gJnBhcmVudENhbmRpZGF0ZSkgewot ICAgICAgICAgICAgaW5zZXJ0Q2hpbGQocGFyZW50Q2FuZGlkYXRlLCBXVEZNb3ZlKGNoaWxkKSwg YmVmb3JlQ2hpbGQpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0gICAgICAgIHBh cmVudC5hZGRDaGlsZCgqdGhpcywgV1RGTW92ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsKKyAgICAg ICAgaW5zZXJ0UmVjdXJzaXZlSWZOZWVkZWQodGFibGVCdWlsZGVyKCkuZmluZE9yQ3JlYXRlUGFy ZW50Rm9yQ2hpbGQoZG93bmNhc3Q8UmVuZGVyVGFibGU+KHBhcmVudCksICpjaGlsZCwgYmVmb3Jl Q2hpbGQpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo=