181077 2017-12-20 21:22:47 -0800 DeferredLoadingScope incorrectly disabled images or enables deferred loading 2017-12-20 22:50:39 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1384025 0 rniwa 2017-12-20 21:22:47 -0800 DeferredLoadingScope incorrectly disabled images or enables deferred loading 1384026 1 330005 rniwa 2017-12-20 21:24:30 -0800 Created attachment 330005 Fixes the bug 1384033 2 330005 wenson_hsieh 2017-12-20 22:06:24 -0800 Comment on attachment 330005 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=330005&action=review > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:14 > + imageLoaded = false; Let's remove this before landing (...unless it's a special global flag used by one of the test harness scripts?) > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:16 > + setTimeout(() => finishJSTest(), 1000); Let's remove this too. 1384034 3 rniwa 2017-12-20 22:09:39 -0800 (In reply to Wenson Hsieh from comment #2) > Comment on attachment 330005 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330005&action=review > > > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:14 > > + imageLoaded = false; > > Let's remove this before landing (...unless it's a special global flag used > by one of the test harness scripts?) Oops, yeah, this was a debugging code. Removed. > > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:16 > > + setTimeout(() => finishJSTest(), 1000); > > Let's remove this too. Ditto. Thanks for the review. 1384041 4 rniwa 2017-12-20 22:48:50 -0800 Committed r226216: <https://trac.webkit.org/changeset/226216> 1384043 5 webkit-bug-importer 2017-12-20 22:50:39 -0800 <rdar://problem/36172298> 330005 2017-12-20 21:24:30 -0800 2017-12-20 22:06:24 -0800 Fixes the bug bug-181077-20171220212430.patch text/plain 6998 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNjIxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE3LTEyLTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERlZmVycmVkTG9hZGluZ1Njb3Bl IGluY29ycmVjdGx5IGRpc2FibGVkIGltYWdlcyBvciBlbmFibGVzIGRlZmVycmVkIGxvYWRpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTA3Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRo ZSBidWcgdGhhdCBEZWZlcnJlZExvYWRpbmdTY29wZTo6fkRlZmVycmVkTG9hZGluZ1Njb3BlIHdh cyBjaGVja2luZyB0aGUgd3JvbmcgZmxhZworICAgICAgICBmb3IgcmVzdG9yaW5nIHRoZSBkaXNh YmxlZG5lc3Mgb2YgaW1hZ2VzIGFuZCBkZWZlcnJlZCBsb2FkaW5nLgorCisgICAgICAgIFRlc3Q6 IGVkaXRpbmcvcGFzdGVib2FyZC9wYXN0aW5nLXdpdGgtaW1hZ2VzLWRpc2FibGVkLXNob3VsZC1u b3QtZW5hYmxlLWRlZmVycmVkLWxvYWRpbmcuaHRtbAorCisgICAgICAgICogZWRpdGluZy9jb2Nv YS9XZWJDb250ZW50UmVhZGVyQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpEZWZlcnJlZExv YWRpbmdTY29wZTo6fkRlZmVycmVkTG9hZGluZ1Njb3BlKTogRml4ZWQgdGhlIGJ1Zy4KKyAgICAg ICAgKiB0ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6 OnBhZ2VEZWZlcnNMb2FkaW5nKTogQWRkZWQgZm9yIHRlc3RpbmcuCisgICAgICAgICogdGVzdGlu Zy9JbnRlcm5hbHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6IEFkZGVkIHBh Z2VEZWZlcnNMb2FkaW5nLgorCiAyMDE3LTEyLTIwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNp ZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtBdHRhY2htZW50IFN1cHBvcnRdIEF0dGFjaG1lbnQg cmVwbGFjZW1lbnQgbG9naWMgc2hvdWxkIG5vdCBkZXBlbmQgb24gc3VicmVzb3VyY2UgVVJMIGF0 dHJpYnV0ZSByZXBsYWNlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9X ZWJDb250ZW50UmVhZGVyQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRp dGluZy9jb2NvYS9XZWJDb250ZW50UmVhZGVyQ29jb2EubW0JKHJldmlzaW9uIDIyNjIwMikKKysr IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvV2ViQ29udGVudFJlYWRlckNvY29hLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0yMzksOSArMjM5LDkgQEAgcHVibGljOgogCiAgICAgfkRlZmVycmVk TG9hZGluZ1Njb3BlKCkKICAgICB7Ci0gICAgICAgIGlmIChtX2RpZEVuYWJsZWREZWZlcnJlZExv YWRpbmcpCi0gICAgICAgICAgICBtX2NhY2hlZFJlc291cmNlTG9hZGVyLT5zZXRJbWFnZXNFbmFi bGVkKHRydWUpOwogICAgICAgICBpZiAobV9kaWREaXNhYmxlSW1hZ2UpCisgICAgICAgICAgICBt X2NhY2hlZFJlc291cmNlTG9hZGVyLT5zZXRJbWFnZXNFbmFibGVkKHRydWUpOworICAgICAgICBp ZiAobV9kaWRFbmFibGVkRGVmZXJyZWRMb2FkaW5nKQogICAgICAgICAgICAgbV9mcmFtZS0+cGFn ZSgpLT5zZXREZWZlcnNMb2FkaW5nKGZhbHNlKTsKICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL0ludGVybmFscy5jcHAJKHJldmlzaW9uIDIyNjIwMikKKysrIFNvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzY5NCw2ICszNjk0LDE0 IEBAIHZvaWQgSW50ZXJuYWxzOjpzZXRQYWdlRGVmZXJzTG9hZGluZyhib28KICAgICAgICAgcGFn ZS0+c2V0RGVmZXJzTG9hZGluZyhkZWZlcnNMb2FkaW5nKTsKIH0KIAorRXhjZXB0aW9uT3I8Ym9v bD4gSW50ZXJuYWxzOjpwYWdlRGVmZXJzTG9hZGluZygpCit7CisgICAgRG9jdW1lbnQqIGRvY3Vt ZW50ID0gY29udGV4dERvY3VtZW50KCk7CisgICAgaWYgKCFkb2N1bWVudCB8fCAhZG9jdW1lbnQt PnBhZ2UoKSkKKyAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IEludmFsaWRBY2Nlc3NFcnJvciB9 OworICAgIHJldHVybiBkb2N1bWVudC0+cGFnZSgpLT5kZWZlcnNMb2FkaW5nKCk7Cit9CisKIFJl ZlB0cjxGaWxlPiBJbnRlcm5hbHM6OmNyZWF0ZUZpbGUoY29uc3QgU3RyaW5nJiBwYXRoKQogewog ICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGNvbnRleHREb2N1bWVudCgpOwpJbmRleDogU291cmNl L1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL0ludGVybmFscy5oCShyZXZpc2lvbiAyMjYyMDIpCisrKyBTb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL0ludGVybmFscy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MzAsNiArNTMwLDcgQEAg cHVibGljOgogICAgIFN0cmluZyBwYWdlTWVkaWFTdGF0ZSgpOwogCiAgICAgdm9pZCBzZXRQYWdl RGVmZXJzTG9hZGluZyhib29sKTsKKyAgICBFeGNlcHRpb25Pcjxib29sPiBwYWdlRGVmZXJzTG9h ZGluZygpOwogCiAgICAgUmVmUHRyPEZpbGU+IGNyZWF0ZUZpbGUoY29uc3QgU3RyaW5nJik7CiAg ICAgdm9pZCBxdWV1ZU1pY3JvVGFzayhpbnQpOwpJbmRleDogU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50 ZXJuYWxzLmlkbAkocmV2aXNpb24gMjI2MjAyKQorKysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC00ODQsNiArNDg0LDcgQEAgZW51bSBFdmVu dFRocm90dGxpbmdCZWhhdmlvciB7CiAgICAgRE9NU3RyaW5nIHBhZ2VNZWRpYVN0YXRlKCk7CiAK ICAgICB2b2lkIHNldFBhZ2VEZWZlcnNMb2FkaW5nKGJvb2xlYW4gZGVmZXJzTG9hZGluZyk7Cisg ICAgW01heVRocm93RXhjZXB0aW9uXSBib29sZWFuIHBhZ2VEZWZlcnNMb2FkaW5nKCk7CiAKICAg ICBGaWxlPyBjcmVhdGVGaWxlKERPTVN0cmluZyB1cmwpOwogICAgIHZvaWQgcXVldWVNaWNyb1Rh c2sobG9uZyB0ZXN0TnVtYmVyKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNjIwMikKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEy LTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERlZmVycmVk TG9hZGluZ1Njb3BlIGluY29ycmVjdGx5IGRpc2FibGVkIGltYWdlcyBvciBlbmFibGVzIGRlZmVy cmVkIGxvYWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MTA3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZGVkIGEgcmVncmVzc2lvbiB0ZXN0LgorCisgICAgICAgICogZWRpdGluZy9wYXN0ZWJv YXJkL3Bhc3Rpbmctd2l0aC1pbWFnZXMtZGlzYWJsZWQtc2hvdWxkLW5vdC1lbmFibGUtZGVmZXJy ZWQtbG9hZGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvcGFzdGVi b2FyZC9wYXN0aW5nLXdpdGgtaW1hZ2VzLWRpc2FibGVkLXNob3VsZC1ub3QtZW5hYmxlLWRlZmVy cmVkLWxvYWRpbmcuaHRtbDogQWRkZWQuCisKIDIwMTctMTItMjAgIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIE1lc3NhZ2VQ b3J0Ojpjb250ZXh0RGVzdHJveWVkIGluIGh0dHAvdGVzdHMvc2VjdXJpdHkvTWVzc2FnZVBvcnQv ZXZlbnQtbGlzdGVuZXItY29udGV4dC5odG1sLCB1c3VhbGx5IGF0dHJpYnV0ZWQgdG8gbGF0ZXIg dGVzdHMuCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGluZy13aXRo LWltYWdlcy1kaXNhYmxlZC1zaG91bGQtbm90LWVuYWJsZS1kZWZlcnJlZC1sb2FkaW5nLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcGFz dGluZy13aXRoLWltYWdlcy1kaXNhYmxlZC1zaG91bGQtbm90LWVuYWJsZS1kZWZlcnJlZC1sb2Fk aW5nLWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bh c3RlYm9hcmQvcGFzdGluZy13aXRoLWltYWdlcy1kaXNhYmxlZC1zaG91bGQtbm90LWVuYWJsZS1k ZWZlcnJlZC1sb2FkaW5nLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE3 IEBACitUaGlzIHRlc3RzIG1ha2VzIHN1cmUgdGhhdCBwYXN0aW5nIGNvbnRlbnQgd2hpbGUgZGVm ZXJyZWQgbG9hZGluZyBpcyBlbmFibGVkIGRvZXMgbm90IGVuYWJsZSBpbWFnZXMuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitpbnRlcm5hbHMuc2V0dGluZ3Muc2V0SW1hZ2VzRW5h YmxlZChmYWxzZSkKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCJjb3B5IikKK1BBU1MgZWRpdG9yLnF1 ZXJ5U2VsZWN0b3IoImltZyIpLndpZHRoIGlzIDc2CitzZXRUaW1lb3V0KHdhaXRGb3JJbWFnZXNU b0JlRGlzYWJsZWQsIDApCitQQVNTIGludGVybmFscy5wYWdlRGVmZXJzTG9hZGluZygpIGlzIGZh bHNlCitkb2N1bWVudC5leGVjQ29tbWFuZCgicGFzdGUiKQorUEFTUyBpbnRlcm5hbHMucGFnZURl ZmVyc0xvYWRpbmcoKSBpcyBmYWxzZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCitoZWxsbworCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3Rl Ym9hcmQvcGFzdGluZy13aXRoLWltYWdlcy1kaXNhYmxlZC1zaG91bGQtbm90LWVuYWJsZS1kZWZl cnJlZC1sb2FkaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0 ZWJvYXJkL3Bhc3Rpbmctd2l0aC1pbWFnZXMtZGlzYWJsZWQtc2hvdWxkLW5vdC1lbmFibGUtZGVm ZXJyZWQtbG9hZGluZy5odG1sCShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcv cGFzdGVib2FyZC9wYXN0aW5nLXdpdGgtaW1hZ2VzLWRpc2FibGVkLXNob3VsZC1ub3QtZW5hYmxl LWRlZmVycmVkLWxvYWRpbmcuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQwIEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxkaXYgaWQ9ImVkaXRvciIgY29udGVudGVk aXRhYmxlPmhlbGxvPGltZyBzcmM9Ii4uL3Jlc291cmNlcy9hYmUucG5nIj48L2Rpdj4KKzxzY3Jp cHQ+CisKK2Rlc2NyaXB0aW9uKCdUaGlzIHRlc3RzIG1ha2VzIHN1cmUgdGhhdCBwYXN0aW5nIGNv bnRlbnQgd2hpbGUgZGVmZXJyZWQgbG9hZGluZyBpcyBlbmFibGVkIGRvZXMgbm90IGVuYWJsZSBp bWFnZXMuJykKKworaWYgKCF3aW5kb3cuaW50ZXJuYWxzKQorICAgIHRlc3RGYWlsZWQoJ1RoaXMg dGVzdCByZXF1aXJlcyBpbnRlcm5hbHMuc2V0dGluZ3MnKTsKK2Vsc2UgeworICAgIGpzVGVzdElz QXN5bmMgPSB0cnVlOworICAgIGltYWdlTG9hZGVkID0gZmFsc2U7CisKKyAgICBzZXRUaW1lb3V0 KCgpID0+IGZpbmlzaEpTVGVzdCgpLCAxMDAwKTsKKworICAgIHdpbmRvdy5vbmxvYWQgPSAoKSA9 PiB7CisgICAgICAgIGVkaXRvci5mb2N1cygpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgic2VsZWN0QWxsIik7CisgICAgICAgIGV2YWxBbmRMb2coJ2ludGVybmFscy5zZXR0aW5ncy5z ZXRJbWFnZXNFbmFibGVkKGZhbHNlKScpOworICAgICAgICBldmFsQW5kTG9nKCdkb2N1bWVudC5l eGVjQ29tbWFuZCgiY29weSIpJyk7CisgICAgICAgIHNob3VsZEJlKCdlZGl0b3IucXVlcnlTZWxl Y3RvcigiaW1nIikud2lkdGgnLCAnNzYnKTsKKyAgICAgICAgZXZhbEFuZExvZygnc2V0VGltZW91 dCh3YWl0Rm9ySW1hZ2VzVG9CZURpc2FibGVkLCAwKScpOworICAgIH0KKworICAgIGZ1bmN0aW9u IHdhaXRGb3JJbWFnZXNUb0JlRGlzYWJsZWQoKQorICAgIHsKKyAgICAgICAgc2hvdWxkQmVGYWxz ZSgnaW50ZXJuYWxzLnBhZ2VEZWZlcnNMb2FkaW5nKCknKTsKKyAgICAgICAgZXZhbEFuZExvZygn ZG9jdW1lbnQuZXhlY0NvbW1hbmQoInBhc3RlIiknKTsKKyAgICAgICAgc2hvdWxkQmVGYWxzZSgn aW50ZXJuYWxzLnBhZ2VEZWZlcnNMb2FkaW5nKCknKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7 CisgICAgfQorCit9CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=