181065 2017-12-20 16:29:59 -0800 [AppleWin] Auxiliary libraries should be updated within build-webkit 2017-12-21 11:15:59 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180990 1 don.olmstead don.olmstead achristensen bfulgham commit-queue lforschler pvollan webkit-bug-importer oldest_to_newest 1383880 0 don.olmstead 2017-12-20 16:29:59 -0800 Currently all ports are updating their own auxiliary libraries within the context of build-webkit with the exception of AppleWin which uses update-webkit. This should be moved into build-webkit for consistency. This also causes a problem with webkit-patch when developing on WinCairo. WinCairo has its own set of requirements and when update-webkit is called by webkit-patch it will act as though the port is AppleWin and download the auxiliary library zip and overwrite what is present in WinCairoRequirements. This makes the build fail within EWS. 1383883 1 329963 don.olmstead 2017-12-20 16:31:52 -0800 Created attachment 329963 Patch Removes update-auxiliary-libs from update-webkit and into build-webkit. 1384172 2 329963 commit-queue 2017-12-21 11:13:44 -0800 Comment on attachment 329963 Patch Clearing flags on attachment: 329963 Committed r226232: <https://trac.webkit.org/changeset/226232> 1384173 3 commit-queue 2017-12-21 11:13:45 -0800 All reviewed patches have been landed. Closing bug. 1384175 4 webkit-bug-importer 2017-12-21 11:15:59 -0800 <rdar://problem/36181856> 329963 2017-12-20 16:31:52 -0800 2017-12-21 11:13:44 -0800 Patch bug-181065.diff text/plain 3338 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYWU4 OWJlNzVhNi4uYmJhNGVmNjQwMGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNy0xMi0yMCAgRG9uIE9sbXN0ZWFk ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIFtBcHBsZVdpbl0gQXV4aWxpYXJ5 IGxpYnJhcmllcyBzaG91bGQgYmUgdXBkYXRlZCB3aXRoaW4gYnVpbGQtd2Via2l0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEwNjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEVXU1Rvb2xzL1N0YXJ0 LVF1ZXVlLnBzMToKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKGNN YWtlQXJnc0Zyb21GZWF0dXJlcyk6IERlbGV0ZWQuCisgICAgICAgICh3cml0ZUNvbmdyYXRzKTog RGVsZXRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQ6CisKIDIwMTctMTItMjAg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBBbHRl cm5hdGl2ZSBQcmVzZW50YXRpb24gQnV0dG9uCmRpZmYgLS1naXQgYS9Ub29scy9FV1NUb29scy9T dGFydC1RdWV1ZS5wczEgYi9Ub29scy9FV1NUb29scy9TdGFydC1RdWV1ZS5wczEKaW5kZXggOGVk MDIzNmRhMDkuLjNkN2JhMzhkMThlIDEwMDY0NAotLS0gYS9Ub29scy9FV1NUb29scy9TdGFydC1R dWV1ZS5wczEKKysrIGIvVG9vbHMvRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxCkBAIC04Myw3ICs4 Myw3IEBAIHdoaWxlICgkdHJ1ZSkgewogICAgIENsZWFuLVB5dGhvbkM7CiAgICAgQ2xlYW4tR2l0 OwogCi0gICAgcGVybCAuL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdCAtLW5vLWF1eGlsaWFy eS1saWJzOworICAgIHBlcmwgLi9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQ7CiAgICAgcHl0 aG9uIC4vVG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2ggJHF1ZXVlIC0tYm90LWlkPSRuYW1lIC0t bm8tY29uZmlybSAtLWV4aXQtYWZ0ZXItaXRlcmF0aW9uICRpdGVyYXRpb25zOwogICAgIHB5dGhv biAvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCiB9CmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CmluZGV4IGZlNmI3M2Y1ZWYyLi4xZTMyZTE1MTlkYSAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTI0 NCw2ICsyNDQsOCBAQCBpZiAoaXNBcHBsZUNvY29hV2ViS2l0KCkpIHsKICAgICAjIENvcHkgV2Vi S2l0U3VwcG9ydExpYnJhcnkgdG8gdGhlIGNvcnJlY3QgbG9jYXRpb24gaW4gV2ViS2l0TGlicmFy aWVzIHNvIGl0IGNhbiBiZSBmb3VuZC4KICAgICAjIFdpbGwgZmFpbCBpZiBXZWJLaXRTdXBwb3J0 TGlicmFyeS56aXAgaXMgbm90IGluIHNvdXJjZSByb290LgogICAgIChzeXN0ZW0oInBlcmwgVG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LXN1cHBvcnQtbGlicyIpID09IDApIG9yIGRpZTsKKyAg ICAoc3lzdGVtKCJwZXJsIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1hdXhpbGlhcnktbGli cyIpID09IDApIG9yIGRpZTsKKyAgICBzZXR1cEFwcGxlV2luRW52KCkKIH0KIAogaWYgKGlzQW55 V2luZG93cygpKSB7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQgYi9U b29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQKaW5kZXggZTg4N2MyM2QzOTIuLjkwMjQzMzFjNmRi IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQKKysrIGIvVG9vbHMvU2Ny aXB0cy91cGRhdGUtd2Via2l0CkBAIC00MywxOCArNDMsMTEgQEAgdXNlIHdlYmtpdGRpcnM7CiBt eSAkcXVpZXQgPSAnJzsKIG15ICRzaG93SGVscDsKIAotIyBUaGlzIGNhbGwgaXMgbmVlZGVkIHRv IGVhdCAtLXdpbmNhaXJvIGFyZ3VtZW50IGFuZCBhdm9pZCB1bmtub3duIG9wdGlvbiBlcnJvci4K LSMgRklYTUU6IEFsbG93IHBvcnQgb3B0aW9ucyBleHBsaWNpdGx5IG9yIG1ha2UgdGhpcyBzY3Jp cHQgcG9ydC1hZ25vc3RpYy4KLWRldGVybWluZVBvcnROYW1lKCk7Ci0KIGNoZGlyV2ViS2l0KCk7 CiAKLW15ICRhdXhpbGlhcnlMaWJzID0gMTsKLQogbXkgJGdldE9wdGlvbnNSZXN1bHQgPSBHZXRP cHRpb25zKAogICAgICdofGhlbHAnICA9PiBcJHNob3dIZWxwLAogICAgICdxfHF1aWV0JyA9PiBc JHF1aWV0LAotICAgICdhdXhpbGlhcnktbGlicyEnID0+IFwkYXV4aWxpYXJ5TGlicywKICk7CiAK IGlmICghJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dIZWxwKSB7CkBAIC02Miw3ICs1NSw2IEBA IGlmICghJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dIZWxwKSB7CiBVc2FnZTogQHtbIGJhc2Vu YW1lKCQwKSBdfSBbb3B0aW9uc10KICAgLWh8LS1oZWxwICAgICAgICAgICAgICAgICBzaG93IHRo ZSBoZWxwIG1lc3NhZ2UKICAgLXF8LS1xdWlldCAgICAgICAgICAgICAgICBwYXNzIC1xIHRvIHN2 biB1cGRhdGUgZm9yIHF1aWV0IHVwZGF0ZXMKLSAgLS1bbm8tXWF1eGlsaWFyeS1saWJzICAgICBb ZG9uXCd0XSB1cGRhdGUgdGhlIGF1eGlsaWFyeSBsaWJyYXJpZXMgZm9yIFdpbmRvd3MgKGRlZmF1 bHQ6IHVwZGF0ZSkKIF9fRU5EX18KICAgICBleGl0IDE7CiB9CkBAIC03NywxNCArNjksNCBAQCBw cmludCAiVXBkYXRpbmcgT3BlblNvdXJjZVxuIiB1bmxlc3MgJHF1aWV0OwogcnVuU3ZuVXBkYXRl QW5kUmVzb2x2ZUNoYW5nZUxvZ3MoQHN2bk9wdGlvbnMpIGlmIGlzU1ZOKCk7CiBydW5HaXRVcGRh dGUoKSBpZiBpc0dpdCgpOwogCi1pZiAoaXNBcHBsZVdpbldlYktpdCgpICYmICRhdXhpbGlhcnlM aWJzKSB7Ci0gICAgc3lzdGVtKCReWCwgRmlsZTo6U3BlYy0+Y2F0ZmlsZSgiVG9vbHMiLCAiU2Ny aXB0cyIsICJ1cGRhdGUtd2Via2l0LWF1eGlsaWFyeS1saWJzIikpID09IDAgb3IgZGllOwotICAg IGlmIChpc1dpbkNhaXJvKCkpIHsKLSAgICAgICAgIyBXaW5DYWlybyBzaGFyZXMgdGhlIGF1eGls aWFyeSBsaWJzIGZyb20gdGhlIEFwcGxlIHBvcnQuCi0gICAgICAgIHN5c3RlbSgkXlgsIEZpbGU6 OlNwZWMtPmNhdGZpbGUoIlRvb2xzIiwgIlNjcmlwdHMiLCAidXBkYXRlLXdlYmtpdC13aW5jYWly by1saWJzIikpID09IDAgb3IgZGllOwotICAgIH0KLX0KLQotc2V0dXBBcHBsZVdpbkVudigpIGlm IGlzQXBwbGVXaW5XZWJLaXQoKTsKLQogZXhpdCAwOwo=