181057 2017-12-20 14:51:05 -0800 com.apple.WebKit.WebContent.Development crashed in com.apple.WebCore: WebCore::UserMediaRequest::stop + 126 2018-01-03 16:20:42 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181264 InRadar P2 Normal --- 1 youennf youennf commit-queue darin eric.carlson ryanhaddad webkit-bug-importer youennf oldest_to_newest 1383841 0 youennf 2017-12-20 14:51:05 -0800 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000110e3a4ee WebCore::UserMediaRequest::stop() + 126 1 com.apple.WebCore 0x00000001104d49d8 WebCore::ScriptExecutionContext::stopActiveDOMObjects() + 152 2 com.apple.WebCore 0x00000001104d44c9 WebCore::Document::prepareForDestruction() + 761 3 com.apple.WebCore 0x000000011142e641 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::DumbPtrTraits<WebCore::FrameView> >&&) + 177 4 com.apple.WebCore 0x0000000110497e62 WebCore::Frame::createView(WebCore::IntSize const&, WebCore::Color const&, bool, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool) + 82 5 com.apple.WebKit 0x0000000105309804 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage() + 338 6 com.apple.WebCore 0x000000011139ef49 WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) + 409 7 com.apple.WebCore 0x0000000110496f1f WebCore::FrameLoader::commitProvisionalLoad() + 335 8 com.apple.WebCore 0x0000000111384ef1 WebCore::DocumentLoader::finishedLoading() + 353 9 com.apple.WebCore 0x000000011049666b WebCore::DocumentLoader::maybeLoadEmpty() + 891 10 com.apple.WebCore 0x00000001104960af WebCore::DocumentLoader::startLoadingMainResource() + 591 11 com.apple.WebCore 0x000000011139e056 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL) + 694 12 com.apple.WebCore 0x00000001113b58cb W 1383844 1 329956 youennf 2017-12-20 14:53:28 -0800 Created attachment 329956 Patch 1383855 2 329956 eric.carlson 2017-12-20 15:24:13 -0800 Comment on attachment 329956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329956&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:280 > + Ref<UserMediaRequest> protectedThis(*this); This is quite subtle, so I it think it would be a good idea to add a comment about why it is necessary to protect this because of the side effects of clearing m_pendingActivationMediaStream. 1383857 3 329958 youennf 2017-12-20 15:32:10 -0800 Created attachment 329958 Patch for landing 1383860 4 329958 commit-queue 2017-12-20 15:33:40 -0800 Comment on attachment 329958 Patch for landing Rejecting attachment 329958 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 329958, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/5780780 1383862 5 329959 youennf 2017-12-20 15:41:07 -0800 Created attachment 329959 Patch for landing 1383874 6 329959 commit-queue 2017-12-20 16:13:13 -0800 Comment on attachment 329959 Patch for landing Clearing flags on attachment: 329959 Committed r226203: <https://trac.webkit.org/changeset/226203> 1383875 7 commit-queue 2017-12-20 16:13:14 -0800 All reviewed patches have been landed. Closing bug. 1383876 8 webkit-bug-importer 2017-12-20 16:14:44 -0800 <rdar://problem/36167175> 1384119 9 329959 darin 2017-12-21 09:33:03 -0800 Comment on attachment 329959 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=329959&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:280 > + // Protecting 'it'this' since nulling m_pendingActivationMediaStream might destroy it. Typ: 'it'this' 1384120 10 darin 2017-12-21 09:33:18 -0800 (In reply to Darin Adler from comment #9) > Typ: 'it'this' Typo: Typ 1384392 11 youennf 2017-12-21 21:04:10 -0800 Reopening to attach new patch. 1384393 12 330107 youennf 2017-12-21 21:04:12 -0800 Created attachment 330107 Fixed typo 1384400 13 330107 commit-queue 2017-12-21 21:37:52 -0800 Comment on attachment 330107 Fixed typo Clearing flags on attachment: 330107 Committed r226258: <https://trac.webkit.org/changeset/226258> 1384401 14 commit-queue 2017-12-21 21:37:53 -0800 All reviewed patches have been landed. Closing bug. 1385558 15 ryanhaddad 2018-01-03 13:31:37 -0800 This change caused LayoutTest http/tests/media/media-stream/disconnected-frame.html to consistently fail an assertion: ASSERTION FAILED: !m_adoptionIsRequired /Volumes/Data/slave/highsierra-debug/build/WebKitBuild/Debug/usr/local/include/wtf/RefCounted.h(44) : void WTF::RefCountedBase::ref() const 1 0x33849168d WTFCrash 2 0x32801fa4e WTF::RefCountedBase::ref() const 3 0x32968a92b WTF::Ref<WebCore::UserMediaRequest, WTF::DumbPtrTraits<WebCore::UserMediaRequest> >::Ref(WebCore::UserMediaRequest&) 4 0x32968829d WTF::Ref<WebCore::UserMediaRequest, WTF::DumbPtrTraits<WebCore::UserMediaRequest> >::Ref(WebCore::UserMediaRequest&) 5 0x329688214 WebCore::UserMediaRequest::stop() 6 0x329ec3fd5 WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded(WebCore::ActiveDOMObject&) 7 0x329cf6cd3 WebCore::ActiveDOMObject::suspendIfNeeded() 8 0x329686dab WebCore::UserMediaRequest::UserMediaRequest(WebCore::Document&, WebCore::MediaStreamRequest&&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::MediaStream> >&&) 9 0x329686c4d WebCore::UserMediaRequest::UserMediaRequest(WebCore::Document&, WebCore::MediaStreamRequest&&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::MediaStream> >&&) 10 0x329686b36 WebCore::UserMediaRequest::create(WebCore::Document&, WebCore::MediaStreamRequest&&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::MediaStream> >&&) 11 0x329644d6d WebCore::MediaDevices::getUserMedia(WebCore::MediaDevices::StreamConstraints const&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::MediaStream> >&&) const 12 0x328bcc968 WebCore::jsMediaDevicesPrototypeFunctionGetUserMediaBody(JSC::ExecState*, WebCore::JSMediaDevices*, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&, JSC::ThrowScope&) 13 0x328bccf38 long long WebCore::IDLOperationReturningPromise<WebCore::JSMediaDevices>::call<&(WebCore::jsMediaDevicesPrototypeFunctionGetUserMediaBody(JSC::ExecState*, WebCore::JSMediaDevices*, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&, JSC::ThrowScope&)), (WebCore::PromiseExecutionScope)0, (WebCore::CastedThisErrorBehavior)2>(JSC::ExecState&, char const*)::'lambda'(JSC::ExecState&, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&)::operator()(JSC::ExecState&, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&) const 14 0x328bccaba JSC::JSValue WebCore::callPromiseFunction<(WebCore::PromiseExecutionScope)0, long long WebCore::IDLOperationReturningPromise<WebCore::JSMediaDevices>::call<&(WebCore::jsMediaDevicesPrototypeFunctionGetUserMediaBody(JSC::ExecState*, WebCore::JSMediaDevices*, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&, JSC::ThrowScope&)), (WebCore::PromiseExecutionScope)0, (WebCore::CastedThisErrorBehavior)2>(JSC::ExecState&, char const*)::'lambda'(JSC::ExecState&, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&)>(JSC::ExecState&, long long WebCore::IDLOperationReturningPromise<WebCore::JSMediaDevices>::call<&(WebCore::jsMediaDevicesPrototypeFunctionGetUserMediaBody(JSC::ExecState*, WebCore::JSMediaDevices*, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&, JSC::ThrowScope&)), (WebCore::PromiseExecutionScope)0, (WebCore::CastedThisErrorBehavior)2>(JSC::ExecState&, char const*)::'lambda'(JSC::ExecState&, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&)) 15 0x328bbc0f5 long long WebCore::IDLOperationReturningPromise<WebCore::JSMediaDevices>::call<&(WebCore::jsMediaDevicesPrototypeFunctionGetUserMediaBody(JSC::ExecState*, WebCore::JSMediaDevices*, WTF::Ref<WebCore::DeferredPromise, WTF::DumbPtrTraits<WebCore::DeferredPromise> >&&, JSC::ThrowScope&)), (WebCore::PromiseExecutionScope)0, (WebCore::CastedThisErrorBehavior)2>(JSC::ExecState&, char const*) 16 0x328bbb6bc WebCore::jsMediaDevicesPrototypeFunctionGetUserMedia(JSC::ExecState*) 17 0x473f17601178 18 0x336ff3d04 llint_entry 19 0x336ff3d04 llint_entry 20 0x336ff3d04 llint_entry 21 0x336febdf2 vmEntryToJavaScript 22 0x337d4443e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 23 0x337ceb475 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 24 0x337f518ea JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 25 0x337f519c9 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) 26 0x337f51c6d JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) 27 0x3298872db WebCore::JSMainThreadExecState::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) 28 0x3298c1932 WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) 29 0x329e23c22 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) 30 0x329e1b6aa WebCore::EventTarget::fireEventListeners(WebCore::Event&) 31 0x32a58db78 WebCore::DOMWindow::dispatchEvent(WebCore::Event&, WebCore::EventTarget*) LEAK: 2 WebPageProxy https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r226357%20(1424)/results.html 1385595 16 youennf 2018-01-03 16:20:33 -0800 Filed https://bugs.webkit.org/show_bug.cgi?id=181264 for the crash. Will upload a fix quickly. 329956 2017-12-20 14:53:28 -0800 2017-12-20 15:32:09 -0800 Patch bug-181057-20171220145327.patch text/plain 2057 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVmYTU0NjFjOWUxMjFh NDQ2NmYxY2JhNmVjMzNjOTkyYmRjZTAwYS4uN2VjMzc0MTJjZDJlZWVlNjBhMzYyYTllZjc1MDJm MWJhODJmYmQyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTEyLTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBjb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgY3Jhc2hlZCBpbiBjb20uYXBwbGUuV2ViQ29yZTogV2Vi Q29yZTo6VXNlck1lZGlhUmVxdWVzdDo6c3RvcCArIDEyNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L21lZGlhc3RyZWFtIHRl c3RzIHRvIG5vdCBjcmFzaCBhbnltb3JlLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVh bS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJNZWRpYVJlcXVl c3Q6OnN0b3ApOgorCisyMDE3LTEyLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KKwogICAgICAgICBEbyBub3Qgc2VhcmNoIGZvciBzZXJ2aWNlIHdvcmtlciByZWdpc3RyYXRp b24gaW4gY2FzZSBvZiBub24gSFRUUCBuYXZpZ2F0aW9uIGxvYWRzCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA5NzYKICAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM2MTU3MzIyPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKaW5kZXggNjdhMmQ0ZjM5NWZmMzlmOWUwZTVh YWU2MWI0NDAzMzNhODM4ODZlMS4uOWY2MWVjZWU4N2NiNWIxN2FjYTI0YTYyNjM4NTA4MmU5NDVl MzRlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2Vy TWVkaWFSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L1VzZXJNZWRpYVJlcXVlc3QuY3BwCkBAIC0yNzcsMTUgKzI3NywxMyBAQCB2b2lkIFVzZXJNZWRp YVJlcXVlc3Q6OmRlbnkoTWVkaWFBY2Nlc3NEZW5pYWxSZWFzb24gcmVhc29uLCBjb25zdCBTdHJp bmcmIGludmFsaQogCiB2b2lkIFVzZXJNZWRpYVJlcXVlc3Q6OnN0b3AoKQogewotICAgIGF1dG8m IGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KCptX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQp OwotICAgIGF1dG8qIGNvbnRyb2xsZXIgPSBVc2VyTWVkaWFDb250cm9sbGVyOjpmcm9tKGRvY3Vt ZW50LnBhZ2UoKSk7CisgICAgUmVmPFVzZXJNZWRpYVJlcXVlc3Q+IHByb3RlY3RlZFRoaXMoKnRo aXMpOwogCiAgICAgbV9wZW5kaW5nQWN0aXZhdGlvbk1lZGlhU3RyZWFtID0gbnVsbHB0cjsKLSAg ICBpZiAoIWNvbnRyb2xsZXIpCi0gICAgICAgIHJldHVybjsKIAotICAgIFJlZjxVc2VyTWVkaWFS ZXF1ZXN0PiBwcm90ZWN0ZWRUaGlzKCp0aGlzKTsKLSAgICBjb250cm9sbGVyLT5jYW5jZWxVc2Vy TWVkaWFBY2Nlc3NSZXF1ZXN0KCp0aGlzKTsKKyAgICBhdXRvJiBkb2N1bWVudCA9IGRvd25jYXN0 PERvY3VtZW50PigqbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKKyAgICBpZiAoYXV0byogY29u dHJvbGxlciA9IFVzZXJNZWRpYUNvbnRyb2xsZXI6OmZyb20oZG9jdW1lbnQucGFnZSgpKSkKKyAg ICAgICAgY29udHJvbGxlci0+Y2FuY2VsVXNlck1lZGlhQWNjZXNzUmVxdWVzdCgqdGhpcyk7CiB9 CiAKIGNvbnN0IGNoYXIqIFVzZXJNZWRpYVJlcXVlc3Q6OmFjdGl2ZURPTU9iamVjdE5hbWUoKSBj b25zdAo= 329958 2017-12-20 15:32:10 -0800 2017-12-20 15:41:05 -0800 Patch for landing bug-181057-20171220153209.patch text/plain 2149 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVmYTU0NjFjOWUxMjFh NDQ2NmYxY2JhNmVjMzNjOTkyYmRjZTAwYS4uN2VjMzc0MTJjZDJlZWVlNjBhMzYyYTllZjc1MDJm MWJhODJmYmQyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTEyLTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBjb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgY3Jhc2hlZCBpbiBjb20uYXBwbGUuV2ViQ29yZTogV2Vi Q29yZTo6VXNlck1lZGlhUmVxdWVzdDo6c3RvcCArIDEyNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L21lZGlhc3RyZWFtIHRl c3RzIHRvIG5vdCBjcmFzaCBhbnltb3JlLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVh bS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJNZWRpYVJlcXVl c3Q6OnN0b3ApOgorCisyMDE3LTEyLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KKwogICAgICAgICBEbyBub3Qgc2VhcmNoIGZvciBzZXJ2aWNlIHdvcmtlciByZWdpc3RyYXRp b24gaW4gY2FzZSBvZiBub24gSFRUUCBuYXZpZ2F0aW9uIGxvYWRzCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA5NzYKICAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM2MTU3MzIyPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKaW5kZXggNjdhMmQ0ZjM5NWZmMzlmOWUwZTVh YWU2MWI0NDAzMzNhODM4ODZlMS4uMzNkZTBiNjRiNmUwYmM1YzQ3Y2YxMWIwZDA0MWVjZjM4ZDc5 MTRkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2Vy TWVkaWFSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L1VzZXJNZWRpYVJlcXVlc3QuY3BwCkBAIC0yNzcsMTUgKzI3NywxNCBAQCB2b2lkIFVzZXJNZWRp YVJlcXVlc3Q6OmRlbnkoTWVkaWFBY2Nlc3NEZW5pYWxSZWFzb24gcmVhc29uLCBjb25zdCBTdHJp bmcmIGludmFsaQogCiB2b2lkIFVzZXJNZWRpYVJlcXVlc3Q6OnN0b3AoKQogewotICAgIGF1dG8m IGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KCptX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQp OwotICAgIGF1dG8qIGNvbnRyb2xsZXIgPSBVc2VyTWVkaWFDb250cm9sbGVyOjpmcm9tKGRvY3Vt ZW50LnBhZ2UoKSk7CisgICAgLy8gUHJvdGVjdGluZyAnaXQndGhpcycgc2luY2UgbnVsbGluZyBt X3BlbmRpbmdBY3RpdmF0aW9uTWVkaWFTdHJlYW0gbWlnaHQgZGVzdHJveSBpdC4KKyAgICBSZWY8 VXNlck1lZGlhUmVxdWVzdD4gcHJvdGVjdGVkVGhpcygqdGhpcyk7CiAKICAgICBtX3BlbmRpbmdB Y3RpdmF0aW9uTWVkaWFTdHJlYW0gPSBudWxscHRyOwotICAgIGlmICghY29udHJvbGxlcikKLSAg ICAgICAgcmV0dXJuOwogCi0gICAgUmVmPFVzZXJNZWRpYVJlcXVlc3Q+IHByb3RlY3RlZFRoaXMo KnRoaXMpOwotICAgIGNvbnRyb2xsZXItPmNhbmNlbFVzZXJNZWRpYUFjY2Vzc1JlcXVlc3QoKnRo aXMpOworICAgIGF1dG8mIGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KCptX3NjcmlwdEV4 ZWN1dGlvbkNvbnRleHQpOworICAgIGlmIChhdXRvKiBjb250cm9sbGVyID0gVXNlck1lZGlhQ29u dHJvbGxlcjo6ZnJvbShkb2N1bWVudC5wYWdlKCkpKQorICAgICAgICBjb250cm9sbGVyLT5jYW5j ZWxVc2VyTWVkaWFBY2Nlc3NSZXF1ZXN0KCp0aGlzKTsKIH0KIAogY29uc3QgY2hhciogVXNlck1l ZGlhUmVxdWVzdDo6YWN0aXZlRE9NT2JqZWN0TmFtZSgpIGNvbnN0Cg== 329959 2017-12-20 15:41:07 -0800 2017-12-21 21:04:08 -0800 Patch for landing bug-181057-20171220154106.patch text/plain 2147 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVmYTU0NjFjOWUxMjFh NDQ2NmYxY2JhNmVjMzNjOTkyYmRjZTAwYS4uOWVjMjhkMTk1NjM0NTgyNmFlZmRjY2NiOGRlMmRh NTc5YjgzNGI2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTEyLTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBjb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgY3Jhc2hlZCBpbiBjb20uYXBwbGUuV2ViQ29yZTogV2Vi Q29yZTo6VXNlck1lZGlhUmVxdWVzdDo6c3RvcCArIDEyNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBDYXJsc29uLgorCisgICAgICAgIENvdmVyZWQgYnkgZmFzdC9tZWRpYXN0cmVhbSB0ZXN0 cyB0byBub3QgY3Jhc2ggYW55bW9yZS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0v VXNlck1lZGlhUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVc2VyTWVkaWFSZXF1ZXN0 OjpzdG9wKToKKworMjAxNy0xMi0yMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CisKICAgICAgICAgRG8gbm90IHNlYXJjaCBmb3Igc2VydmljZSB3b3JrZXIgcmVnaXN0cmF0aW9u IGluIGNhc2Ugb2Ygbm9uIEhUVFAgbmF2aWdhdGlvbiBsb2FkcwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwOTc2CiAgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zNjE1NzMyMj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCmluZGV4IDY3YTJkNGYzOTVmZjM5ZjllMGU1YWFl NjFiNDQwMzMzYTgzODg2ZTEuLjMzZGUwYjY0YjZlMGJjNWM0N2NmMTFiMGQwNDFlY2YzOGQ3OTE0 ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1l ZGlhUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9V c2VyTWVkaWFSZXF1ZXN0LmNwcApAQCAtMjc3LDE1ICsyNzcsMTQgQEAgdm9pZCBVc2VyTWVkaWFS ZXF1ZXN0OjpkZW55KE1lZGlhQWNjZXNzRGVuaWFsUmVhc29uIHJlYXNvbiwgY29uc3QgU3RyaW5n JiBpbnZhbGkKIAogdm9pZCBVc2VyTWVkaWFSZXF1ZXN0OjpzdG9wKCkKIHsKLSAgICBhdXRvJiBk b2N1bWVudCA9IGRvd25jYXN0PERvY3VtZW50PigqbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KTsK LSAgICBhdXRvKiBjb250cm9sbGVyID0gVXNlck1lZGlhQ29udHJvbGxlcjo6ZnJvbShkb2N1bWVu dC5wYWdlKCkpOworICAgIC8vIFByb3RlY3RpbmcgJ2l0J3RoaXMnIHNpbmNlIG51bGxpbmcgbV9w ZW5kaW5nQWN0aXZhdGlvbk1lZGlhU3RyZWFtIG1pZ2h0IGRlc3Ryb3kgaXQuCisgICAgUmVmPFVz ZXJNZWRpYVJlcXVlc3Q+IHByb3RlY3RlZFRoaXMoKnRoaXMpOwogCiAgICAgbV9wZW5kaW5nQWN0 aXZhdGlvbk1lZGlhU3RyZWFtID0gbnVsbHB0cjsKLSAgICBpZiAoIWNvbnRyb2xsZXIpCi0gICAg ICAgIHJldHVybjsKIAotICAgIFJlZjxVc2VyTWVkaWFSZXF1ZXN0PiBwcm90ZWN0ZWRUaGlzKCp0 aGlzKTsKLSAgICBjb250cm9sbGVyLT5jYW5jZWxVc2VyTWVkaWFBY2Nlc3NSZXF1ZXN0KCp0aGlz KTsKKyAgICBhdXRvJiBkb2N1bWVudCA9IGRvd25jYXN0PERvY3VtZW50PigqbV9zY3JpcHRFeGVj dXRpb25Db250ZXh0KTsKKyAgICBpZiAoYXV0byogY29udHJvbGxlciA9IFVzZXJNZWRpYUNvbnRy b2xsZXI6OmZyb20oZG9jdW1lbnQucGFnZSgpKSkKKyAgICAgICAgY29udHJvbGxlci0+Y2FuY2Vs VXNlck1lZGlhQWNjZXNzUmVxdWVzdCgqdGhpcyk7CiB9CiAKIGNvbnN0IGNoYXIqIFVzZXJNZWRp YVJlcXVlc3Q6OmFjdGl2ZURPTU9iamVjdE5hbWUoKSBjb25zdAo= 330107 2017-12-21 21:04:12 -0800 2017-12-21 21:37:52 -0800 Fixed typo bug-181057-20171221220411.patch text/plain 1576 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ1NDM4M2FkZmY2NDdk YzUwMGE1NjU4N2MxYzJkZjgzNTk4ZmE1ZC4uZjgyNWMwYTkyNGM2NWJkOWU2ODY2ZWFkODYxN2Fl ZjIyNGE5ZWFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEyLTIxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBjb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgY3Jhc2hlZCBpbiBjb20uYXBwbGUuV2ViQ29yZTogV2Vi Q29yZTo6VXNlck1lZGlhUmVxdWVzdDo6c3RvcCArIDEyNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDU3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zNjE2NzE3NT4KKworICAgICAgICBVbnJldmlld2VkLgorCisgICAgICAgICogTW9kdWxlcy9t ZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJN ZWRpYVJlcXVlc3Q6OnN0b3ApOiBGaXhlZCBjb21tZW50IHR5cG8uCisKIDIwMTctMTItMjEgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFNlcnZpY2VXb3JrZXJU aHJlYWRQcm94eSBzaG91bGQgc2V0IHRoZSBjb3JyZWN0IGNvb2tpZSBhbmQgY2FjaGUgcGFydGl0 aW9uaW5nIG9wdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCmluZGV4IDIxZTJjOTI2NTY4NWM5ZmJjYzg3OWFm OGE4MTAyMmY0MTJjNDk2ZmQuLjYyMGZkNjJlOGRjYTM1NjQwNGVlOWNiYzhlOTdlZGMyMWI5YjBl ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1l ZGlhUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9V c2VyTWVkaWFSZXF1ZXN0LmNwcApAQCAtMjk5LDcgKzI5OSw3IEBAIHZvaWQgVXNlck1lZGlhUmVx dWVzdDo6ZGVueShNZWRpYUFjY2Vzc0RlbmlhbFJlYXNvbiByZWFzb24sIGNvbnN0IFN0cmluZyYg aW52YWxpCiAKIHZvaWQgVXNlck1lZGlhUmVxdWVzdDo6c3RvcCgpCiB7Ci0gICAgLy8gUHJvdGVj dGluZyAnaXQndGhpcycgc2luY2UgbnVsbGluZyBtX3BlbmRpbmdBY3RpdmF0aW9uTWVkaWFTdHJl YW0gbWlnaHQgZGVzdHJveSBpdC4KKyAgICAvLyBQcm90ZWN0aW5nICd0aGlzJyBzaW5jZSBudWxs aW5nIG1fcGVuZGluZ0FjdGl2YXRpb25NZWRpYVN0cmVhbSBtaWdodCBkZXN0cm95IGl0LgogICAg IFJlZjxVc2VyTWVkaWFSZXF1ZXN0PiBwcm90ZWN0ZWRUaGlzKCp0aGlzKTsKIAogICAgIG1fcGVu ZGluZ0FjdGl2YXRpb25NZWRpYVN0cmVhbSA9IG51bGxwdHI7Cg==