181056 2017-12-20 14:18:29 -0800 [CMake][Win] Add a way to set CMAKE_IGNORE_PATH 2017-12-20 19:40:26 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180990 1 don.olmstead don.olmstead achristensen annulen bfulgham commit-queue lforschler pvollan webkit-bug-importer oldest_to_newest 1383827 0 don.olmstead 2017-12-20 14:18:29 -0800 WinCairo EWS is detecting copies of libpng, libjpeg, and other dependencies of WebKit within Strawberry Perl's distribution. This is preventing EWS from functioning properly. Within CMake the variable CMAKE_IGNORE_PATH can be used to prevent CMake from searching paths. So providing a way to set this seems to be the correct approach. 1383830 1 329954 don.olmstead 2017-12-20 14:30:55 -0800 Created attachment 329954 Patch Added WEBKIT_IGNORE_PATH as a way to set things within a windows build 1383963 2 don.olmstead 2017-12-20 18:08:09 -0800 Ok I tested this within a container that WinCairo's EWS is using and it will end up ignoring the directories specified in the environment variable. Would like to get this landed before spinning back up the EWS bots. 1383991 3 329954 annulen 2017-12-20 19:16:37 -0800 Comment on attachment 329954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329954&action=review > Source/cmake/OptionsWin.cmake:94 > + set(CMAKE_IGNORE_PATH $ENV{WEBKIT_IGNORE_PATH}) Huh, I didn't know such variable exists :) 1383996 4 329954 commit-queue 2017-12-20 19:39:52 -0800 Comment on attachment 329954 Patch Clearing flags on attachment: 329954 Committed r226212: <https://trac.webkit.org/changeset/226212> 1383997 5 commit-queue 2017-12-20 19:39:54 -0800 All reviewed patches have been landed. Closing bug. 1383998 6 webkit-bug-importer 2017-12-20 19:40:26 -0800 <rdar://problem/36170547> 329954 2017-12-20 14:30:55 -0800 2017-12-20 19:39:52 -0800 Patch bug-181056.diff text/plain 942 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyN2NhMjkwNDg4YS4uMGRk OGU1YjU1OGYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0xMi0yMCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtDTWFrZV1bV2luXSBBZGQgYSB3YXkgdG8gc2V0IENNQUtFX0lHTk9SRV9Q QVRICisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEw NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlOgorCiAyMDE3LTEyLTIwICBEYW5pZWwgQmF0ZXMg IDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQWx0ZXJuYXRpdmUgUHJlc2Vu dGF0aW9uIEJ1dHRvbgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2Ug Yi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZQppbmRleCAxZDI4M2M2NTRhYi4uOTFiODdj ODVjY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCkBAIC05MCw2ICs5MCwxMCBAQCBlbmRpZiAoKQog CiBXRUJLSVRfT1BUSU9OX0VORCgpCiAKK2lmIChERUZJTkVEIEVOVntXRUJLSVRfSUdOT1JFX1BB VEh9KQorICAgIHNldChDTUFLRV9JR05PUkVfUEFUSCAkRU5We1dFQktJVF9JR05PUkVfUEFUSH0p CitlbmRpZiAoKQorCiBpZiAoTk9UIFdFQktJVF9MSUJSQVJJRVNfRElSKQogICAgIGlmIChERUZJ TkVEIEVOVntXRUJLSVRfTElCUkFSSUVTfSkKICAgICAgICAgc2V0KFdFQktJVF9MSUJSQVJJRVNf RElSICIkRU5We1dFQktJVF9MSUJSQVJJRVN9IikK