181055 2017-12-20 14:00:17 -0800 webkitpy: simctl cannot handle partial runtime version matches 2017-12-20 20:38:00 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap beidson commit-queue ews-watchlist glenn krollin lforschler webkit-bug-importer oldest_to_newest 1383820 0 jbedard 2017-12-20 14:00:17 -0800 simctl should be able to handle partial runtime version matches. For example, a runtime for iOS 11.0.1 should match a request for an iOS 11 runtime. 1383821 1 webkit-bug-importer 2017-12-20 14:00:46 -0800 <rdar://problem/36163798> 1383826 2 329953 jbedard 2017-12-20 14:16:28 -0800 Created attachment 329953 Patch 1383835 3 krollin 2017-12-20 14:47:12 -0800 WFM 1383865 4 329953 ap 2017-12-20 15:43:17 -0800 Comment on attachment 329953 Patch It seems worth having some regression tests (both positive and negative matches). 1383866 5 jbedard 2017-12-20 15:45:02 -0800 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 329953 [details] > Patch > > It seems worth having some regression tests (both positive and negative > matches). I will add some tests. Generally, this behavior is already pretty well tested in webkitpy/common/version_unittest.py. 1383869 6 329961 jbedard 2017-12-20 15:59:15 -0800 Created attachment 329961 Patch 1384014 7 329961 commit-queue 2017-12-20 20:37:58 -0800 Comment on attachment 329961 Patch Clearing flags on attachment: 329961 Committed r226214: <https://trac.webkit.org/changeset/226214> 1384015 8 commit-queue 2017-12-20 20:38:00 -0800 All reviewed patches have been landed. Closing bug. 329953 2017-12-20 14:16:28 -0800 2017-12-20 15:59:13 -0800 Patch bug-181055-20171220141627.patch text/plain 1717 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNjIwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTEyLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogc2ltY3RsIGNhbm5vdCBoYW5kbGUgcGFydGlhbCBydW50 aW1lIHZlcnNpb24gbWF0Y2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgxMDU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjE2Mzc5OD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIHJlcXVlc3Qg Zm9yIGEgc2ltdWxhdG9yIHJ1bnRpbWUgb2YgaU9TIDExIHNob3VsZCBiZSBmdWxmaWxsZWQgYnkK KyAgICAgICAgaU9TIDExLjAuMS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUv c2ltdWxhdG9yLnB5OgorICAgICAgICAoU2ltdWxhdG9yLnJ1bnRpbWUpOiBBbGxvdyBmb3IgcGFy dGlhbCBtYXRjaGluZyBvZiBpT1MgcnVudGltZSB2ZXJzaW9ucy4KKwogMjAxNy0xMi0yMCAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFya2VyU3VicmFuZ2Uu U3ViZGl2aWRlR3JhbW1hckFuZFNlbGVjdGlvbk92ZXJsYXB7RnJvbnRtb3N0LCBGcm9udG1vc3RX aXRoTG9uZ2VzdEVmZmVjdGl2ZVJhbmdlfSBhcmUgZmFpbGluZwpJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHJldmlzaW9uIDIyNjEzNCkKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00 MTAsNiArNDEwLDE2IEBAIGNsYXNzIFNpbXVsYXRvcihvYmplY3QpOgogICAgICAgICAgICAgaWYg aWRlbnRpZmllciBhbmQgcnVudGltZS5pZGVudGlmaWVyICE9IGlkZW50aWZpZXI6CiAgICAgICAg ICAgICAgICAgY29udGludWUKICAgICAgICAgICAgIHJldHVybiBydW50aW1lCisKKyAgICAgICAg IyBBbGxvdyBmb3IgYSBwYXJ0aWFsIHZlcnNpb24gbWF0Y2gKKyAgICAgICAgZm9yIHJ1bnRpbWUg aW4gc2VsZi5ydW50aW1lczoKKyAgICAgICAgICAgIGlmIHZlcnNpb24gYW5kIHJ1bnRpbWUudmVy c2lvbiBub3QgaW4gdmVyc2lvbjoKKyAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAg ICAgaWYgaXNfaW50ZXJuYWxfcnVudGltZSBhbmQgcnVudGltZS5pc19pbnRlcm5hbF9ydW50aW1l ICE9IGlzX2ludGVybmFsX3J1bnRpbWU6CisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAg ICAgICAgIGlmIGlkZW50aWZpZXIgYW5kIHJ1bnRpbWUuaWRlbnRpZmllciAhPSBpZGVudGlmaWVy OgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICByZXR1cm4gcnVudGltZQog ICAgICAgICByZXR1cm4gTm9uZQogCiAgICAgZGVmIGZpbmRfZGV2aWNlX2J5X3VkaWQoc2VsZiwg dWRpZCk6Cg== 329961 2017-12-20 15:59:15 -0800 2017-12-20 20:37:58 -0800 Patch bug-181055-20171220155914.patch text/plain 4444 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNjIwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE3LTEyLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogc2ltY3RsIGNhbm5vdCBoYW5kbGUgcGFydGlhbCBydW50 aW1lIHZlcnNpb24gbWF0Y2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgxMDU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjE2Mzc5OD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisgICAgICAgIEEgcmVx dWVzdCBmb3IgYSBzaW11bGF0b3IgcnVudGltZSBvZiBpT1MgMTEgc2hvdWxkIGJlIGZ1bGZpbGxl ZCBieQorICAgICAgICBpT1MgMTEuMC4xLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94 Y29kZS9zaW11bGF0b3IucHk6CisgICAgICAgIChTaW11bGF0b3IucnVudGltZSk6IEFsbG93IGZv ciBwYXJ0aWFsIG1hdGNoaW5nIG9mIGlPUyBydW50aW1lIHZlcnNpb25zLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yX3VuaXR0ZXN0LnB5OgorICAgICAgICAodGVz dF9mYWlsZWRfcGFydGlhbF92ZXJzaW9uX21hdGNoKTogVGVzdCB0aGF0IHBhcnRpYWwgdmVyc2lv biBtYXBwaW5nIGRvZXMKKyAgICAgICAgbm90IGdpdmUgZmFsc2UgcG9zaXRpdmVzLgorCiAyMDE3 LTEyLTIwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBNYXJr ZXJTdWJyYW5nZS5TdWJkaXZpZGVHcmFtbWFyQW5kU2VsZWN0aW9uT3ZlcmxhcHtGcm9udG1vc3Qs IEZyb250bW9zdFdpdGhMb25nZXN0RWZmZWN0aXZlUmFuZ2V9IGFyZSBmYWlsaW5nCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQkocmV2aXNpb24gMjI2MjAy KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHdvcmtpbmcg Y29weSkKQEAgLTQxMCw2ICs0MTAsMTYgQEAgY2xhc3MgU2ltdWxhdG9yKG9iamVjdCk6CiAgICAg ICAgICAgICBpZiBpZGVudGlmaWVyIGFuZCBydW50aW1lLmlkZW50aWZpZXIgIT0gaWRlbnRpZmll cjoKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAgcmV0dXJuIHJ1bnRpbWUK KworICAgICAgICAjIEFsbG93IGZvciBhIHBhcnRpYWwgdmVyc2lvbiBtYXRjaAorICAgICAgICBm b3IgcnVudGltZSBpbiBzZWxmLnJ1bnRpbWVzOgorICAgICAgICAgICAgaWYgdmVyc2lvbiBhbmQg cnVudGltZS52ZXJzaW9uIG5vdCBpbiB2ZXJzaW9uOgorICAgICAgICAgICAgICAgIGNvbnRpbnVl CisgICAgICAgICAgICBpZiBpc19pbnRlcm5hbF9ydW50aW1lIGFuZCBydW50aW1lLmlzX2ludGVy bmFsX3J1bnRpbWUgIT0gaXNfaW50ZXJuYWxfcnVudGltZToKKyAgICAgICAgICAgICAgICBjb250 aW51ZQorICAgICAgICAgICAgaWYgaWRlbnRpZmllciBhbmQgcnVudGltZS5pZGVudGlmaWVyICE9 IGlkZW50aWZpZXI6CisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgICAgIHJldHVy biBydW50aW1lCiAgICAgICAgIHJldHVybiBOb25lCiAKICAgICBkZWYgZmluZF9kZXZpY2VfYnlf dWRpZChzZWxmLCB1ZGlkKToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2lt dWxhdG9yX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv eGNvZGUvc2ltdWxhdG9yX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMjYyMDIpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvcl91bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtNTgsNiArNTgsNyBAQCBpT1MgOC40ICg4LjQuMSAtIDEySDMyMSkgKGNvbS5hcHBsZS5D b3JlCiB0dk9TIDkuMCAoOS4wIC0gMTNUNTM0N2wpIChjb20uYXBwbGUuQ29yZVNpbXVsYXRvci5T aW1SdW50aW1lLnR2T1MtOS0wKQogd2F0Y2hPUyAyLjAgKDIuMCAtIDEzUzM0MykgKGNvbS5hcHBs ZS5Db3JlU2ltdWxhdG9yLlNpbVJ1bnRpbWUud2F0Y2hPUy0yLTApCiBpT1MgMTAuMCAoMTAuMCAt IDE0MjgwKSAtIGNvbS5hcHBsZS5Db3JlU2ltdWxhdG9yLlNpbVJ1bnRpbWUuaU9TLTEwLTAKK2lP UyAxMS4wLjEgKDExLjAuMSAtIDE1MjgwKSAtIGNvbS5hcHBsZS5Db3JlU2ltdWxhdG9yLlNpbVJ1 bnRpbWUuaU9TLTExLTAKID09IERldmljZXMgPT0KIC0tIGlPUyA4LjAgLS0KICAgICBpUGhvbmUg NHMgKDY4RDlBNzkyLUUzQTktNDYyQi1CMjExLTc2MkM2QTVEMzc3OSkgKFNodXRkb3duKQpAQCAt NzcsNiArNzgsOCBAQCBBcHBsZSBUViAxMDgwcCAoNTUyODFBQkUtOUMyNy00MzhCLUFENTAtCiAt LSB3YXRjaE9TIDIuMCAtLQogICAgIEFwcGxlIFdhdGNoIC0gMzhtbSAoMDAxMzhDRDItRDMwQy00 MzgwLUEzMEUtQTcwQjg4RTFBM0M1KSAoU2h1dGRvd24pCiAgICAgQXBwbGUgV2F0Y2ggLSA0Mm1t ICgxODZBRDg1RS05QkU1LTQ3MzQtQkMzMy1ERjUwNDg0QUFGRjApIChTaHV0ZG93bikKKy0tIGlP UyAxMS4wIC0tCisgICAgaVBob25lIDcgKDQ4RTZDQTczLTRCRjctNDE1My1CRUUyLTczNkNEODgx RkVCRCkgKFNodXRkb3duKSAodW5hdmFpbGFibGUsIHJ1bnRpbWUgcHJvZmlsZSBub3QgZm91bmQp CiAnJycpCiAgICAgICAgIHNpbXVsYXRvciA9IFNpbXVsYXRvcihob3N0PXNlbGYuX2hvc3QpCiAg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoMTIsIGxlbihzaW11bGF0b3IuZGV2aWNlX3R5cGVzKSkK QEAgLTEyOSw3ICsxMzIsNyBAQCBBcHBsZSBUViAxMDgwcCAoNTUyODFBQkUtOUMyNy00MzhCLUFE NTAtCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ0FwcGxlIFdhdGNoIC0gNDJtbScsIGRldmlj ZV90eXBlX2FwcGxlX3dhdGNoXzQybW0ubmFtZSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgn Y29tLmFwcGxlLkNvcmVTaW11bGF0b3IuU2ltRGV2aWNlVHlwZS5BcHBsZS1XYXRjaC00Mm1tJywg ZGV2aWNlX3R5cGVfYXBwbGVfd2F0Y2hfNDJtbS5pZGVudGlmaWVyKQogCi0gICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoNiwgbGVuKHNpbXVsYXRvci5ydW50aW1lcykpCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoNywgbGVuKHNpbXVsYXRvci5ydW50aW1lcykpCiAKICAgICAgICAgcnVudGltZV9p b3NfOCA9IHNpbXVsYXRvci5ydW50aW1lc1swXQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCdj b20uYXBwbGUuQ29yZVNpbXVsYXRvci5TaW1SdW50aW1lLmlPUy04LTAnLCBydW50aW1lX2lvc184 LmlkZW50aWZpZXIpCkBAIC0zMzIsNiArMzM1LDE3IEBAIGlPUyA4LjAgSW50ZXJuYWwgKDguMCAt IFVua25vd24pIChjb20uYXAKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChWZXJzaW9uKDgsIDAp LCBydW50aW1lX2lvc184X2ludGVybmFsLnZlcnNpb24pCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoMCwgbGVuKHJ1bnRpbWVfaW9zXzhfaW50ZXJuYWwuZGV2aWNlcykpCiAKKyAgICBkZWYgdGVz dF9mYWlsZWRfcGFydGlhbF92ZXJzaW9uX21hdGNoKHNlbGYpOgorICAgICAgICBzZWxmLl9zZXRf ZXhwZWN0ZWRfeGNydW5fc2ltY3RsX2xpc3QoJycnPT0gRGV2aWNlIFR5cGVzID09CitpUGhvbmUg NiAoY29tLmFwcGxlLkNvcmVTaW11bGF0b3IuU2ltRGV2aWNlVHlwZS5pUGhvbmUtNikKKz09IFJ1 bnRpbWVzID09CitpT1MgMTEuMC4xICgxMS4wLjEgLSAxNTI4MCkgLSBjb20uYXBwbGUuQ29yZVNp bXVsYXRvci5TaW1SdW50aW1lLmlPUy0xMS0wCis9PSBEZXZpY2VzID09CistLSBpT1MgMTEuMSAt LQoraVBob25lIDYgKDQ4RTZDQTczLTRCRjctNDE1My1CRUUyLTczNkNEODgxRkVCRCkgKFNodXRk b3duKQorICAgICAgICAnJycpCisgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKEFzc2VydGlvbkVy cm9yLCBsYW1iZGE6IFNpbXVsYXRvcihob3N0PXNlbGYuX2hvc3QpKQorCiAgICAgZGVmIHRlc3Rf ZGV2aWNlX3BhaXJzKHNlbGYpOgogICAgICAgICAiIiIgVGVzdHMgdGhhdCBEZXZpY2UgUGFpcnMg aGVhZGVyIGRvZXMgbm90IGNhdXNlIHBhcnNpbmcgZXhjZXB0aW9uICIiIgogICAgICAgICBzZWxm Ll9zZXRfZXhwZWN0ZWRfeGNydW5fc2ltY3RsX2xpc3QoJycnPT0gRGV2aWNlIFR5cGVzID09Cg==