181046 2017-12-20 10:42:18 -0800 stderr and _IONBF used without including stdio.h 2017-12-20 17:11:03 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Local Build All Other RESOLVED FIXED InRadar P2 Normal --- 1 lantw44 webkit-unassigned achristensen commit-queue ggaren webkit-bug-importer oldest_to_newest 1383724 0 lantw44 2017-12-20 10:42:18 -0800 This causes compilation error on FreeBSD: FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o /usr/bin/clang++ -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_bmalloc -DDATA_DIR=\"share\" -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -I../../Source/bmalloc -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -march=corei7 -B/home/lantw44/.local/bin -pipe -O3 -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -O3 -DNDEBUG -fPIC -MD -MT Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o -c ../../Source/bmalloc/bmalloc/IsoTLS.cpp ../../Source/bmalloc/bmalloc/IsoTLS.cpp:63:21: error: use of undeclared identifier 'stderr' setvbuf(stderr, NULL, _IONBF, 0); ^ ../../Source/bmalloc/bmalloc/IsoTLS.cpp:63:35: error: use of undeclared identifier '_IONBF' setvbuf(stderr, NULL, _IONBF, 0); ^ 2 errors generated. 1383729 1 329934 lantw44 2017-12-20 10:43:39 -0800 Created attachment 329934 Patch 1383903 2 329934 commit-queue 2017-12-20 17:07:53 -0800 Comment on attachment 329934 Patch Clearing flags on attachment: 329934 Committed r226204: <https://trac.webkit.org/changeset/226204> 1383904 3 commit-queue 2017-12-20 17:07:54 -0800 All reviewed patches have been landed. Closing bug. 1383911 4 webkit-bug-importer 2017-12-20 17:11:03 -0800 <rdar://problem/36168329> 329934 2017-12-20 10:43:39 -0800 2017-12-20 17:07:53 -0800 Patch bug-181046-20171221024326.patch text/plain 1008 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggYmEzMjEyOTI4ZjVkZTU3 NDAxNzRiNjdlYjY1NzI4ZWEyNDVmOWFmZC4uZDlmYTBiNDEzZmFmYTc0YTJiMjkxMTkxMzk5YjU5 MTY2YWVlYjc2OCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTEyLTIwICBUaW5n LVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBJbmNsdWRlIHN0ZGlvLmgg YmVmb3JlIHVzaW5nIHN0ZGVyciBhbmQgX0lPTkJGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEwNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJtYWxsb2MvSXNvVExTLmNwcDoKKwogMjAxNy0xMi0x NCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSAt V3N0cmljdC1wcm90b3R5cGVzIGZvciBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvSXNvVExTLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvVExTLmNwcApp bmRleCAyMjU5YThjYWQzNTg3ZTc2NDI3OGRhYTBmZjkxN2Y4MWIwYmZiNmU0Li40N2YwMGI4N2Nl MjY2OTgxNmM2ZWFhYWNmNTAyOWNhY2Q1ZGU2ZTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxv Yy9ibWFsbG9jL0lzb1RMUy5jcHAKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29UTFMu Y3BwCkBAIC0zMSw2ICszMSw4IEBACiAjaW5jbHVkZSAiSXNvVExTSW5saW5lcy5oIgogI2luY2x1 ZGUgIklzb1RMU0xheW91dC5oIgogCisjaW5jbHVkZSA8c3RkaW8uaD4KKwogbmFtZXNwYWNlIGJt YWxsb2MgewogCiAjaWYgIUhBVkVfUFRIUkVBRF9NQUNIREVQX0gK