181044 2017-12-20 09:38:13 -0800 [RenderTreeBuilder] Replace remaining addChild calls with RenderTreeBuilder::insert 2017-12-20 12:07:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1383694 0 zalan 2017-12-20 09:38:13 -0800 ssia 1383696 1 webkit-bug-importer 2017-12-20 09:38:47 -0800 <rdar://problem/36157613> 1383700 2 329928 zalan 2017-12-20 09:43:33 -0800 Created attachment 329928 Patch 1383780 3 329928 commit-queue 2017-12-20 12:07:56 -0800 Comment on attachment 329928 Patch Clearing flags on attachment: 329928 Committed r226196: <https://trac.webkit.org/changeset/226196> 1383781 4 commit-queue 2017-12-20 12:07:57 -0800 All reviewed patches have been landed. Closing bug. 329928 2017-12-20 09:43:33 -0800 2017-12-20 12:07:56 -0800 Patch bug-181044-20171220094332.patch text/plain 3858 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ2MDgyNDRkN2YxZWM3 MmFhMGQ0YmNlYWIyNmQwZTFiZGJiY2EwMi4uN2RlZmE5YmY4YmIwYjMxMmYyYTM1MTJkMDg5ZDM2 ZGRjYzFhZThmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTEyLTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBSZXBsYWNlIHJlbWFpbmluZyBhZGRDaGlsZCBjYWxscyB3aXRoIFJlbmRlclRyZWVCdWlsZGVy OjppbnNlcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MTA0NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYxNTc2MTM+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0 ZXN0IGNhc2VzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjphZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJFbGVtZW50OjphZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRWxl bWVudDo6YWRkQ2hpbGRJZ25vcmluZ0NvbnRpbnVhdGlvbik6IERlbGV0ZWQuCisKIDIwMTctMTIt MjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbUmVuZGVyVHJl ZUJ1aWxkZXJdIE1vdmUgZmluZGluZy10aGUtcGFyZW50L2NyZWF0aW5nLXdyYXBwZXIgbG9naWMg ZnJvbSBSZW5kZXJUYWJsZTo6YWRkQ2hpbGQgdG8gUmVuZGVyVHJlZUJ1aWxkZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IGZjOWRjOTQxMDk4YzUyYjYwOWQx N2YwZjExN2Q5YTI3OWI5YTIzMzQuLjFmN2QyOWYzZDRjMGM5NDJkYzNhNzkwMzQzNTRmYzA4ZWZj YjI5ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtNTYy LDkgKzU2Miw5IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmFkZENoaWxkSWdub3JpbmdDb250aW51YXRp b24oUmVuZGVyVHJlZUJ1aWxkZXImIGJ1aWxkZXIsIFJlbmRlCiAgICAgICAgICAgICAgICAgKSB7 CiAgICAgICAgICAgICAgICAgLy8gSW5zZXJ0IHRoZSBjaGlsZCBpbnRvIHRoZSBhbm9ueW1vdXMg YmxvY2sgYm94IGluc3RlYWQgb2YgaGVyZS4KICAgICAgICAgICAgICAgICBpZiAobmV3Q2hpbGQt PmlzSW5saW5lKCkgfHwgYmVmb3JlQ2hpbGQtPnBhcmVudCgpLT5maXJzdENoaWxkKCkgIT0gYmVm b3JlQ2hpbGQpCi0gICAgICAgICAgICAgICAgICAgIGJlZm9yZUNoaWxkLT5wYXJlbnQoKS0+YWRk Q2hpbGQoYnVpbGRlciwgV1RGTW92ZShuZXdDaGlsZCksIGJlZm9yZUNoaWxkKTsKKyAgICAgICAg ICAgICAgICAgICAgYnVpbGRlci5pbnNlcnRDaGlsZCgqYmVmb3JlQ2hpbGQtPnBhcmVudCgpLCBX VEZNb3ZlKG5ld0NoaWxkKSwgYmVmb3JlQ2hpbGQpOwogICAgICAgICAgICAgICAgIGVsc2UKLSAg ICAgICAgICAgICAgICAgICAgYWRkQ2hpbGQoYnVpbGRlciwgV1RGTW92ZShuZXdDaGlsZCksIGJl Zm9yZUNoaWxkLT5wYXJlbnQoKSk7CisgICAgICAgICAgICAgICAgICAgIGJ1aWxkZXIuaW5zZXJ0 Q2hpbGQoKnRoaXMsIFdURk1vdmUobmV3Q2hpbGQpLCBiZWZvcmVDaGlsZC0+cGFyZW50KCkpOwog ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCmluZGV4IDMxYTM2MTFkZjgzNjNjYzU2YzljZGUy OWYyODYwZDVhYWU5YzIwYTIuLjg3OTYzMWY1NzdlNGE0ZGJlNDExYzNkZTE1ZTIzZjY0ZDc1NWFi MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKQEAgLTUx MSw2ICs1MTEsMTEgQEAgdm9pZCBSZW5kZXJFbGVtZW50OjphZGRDaGlsZChSZW5kZXJUcmVlQnVp bGRlciYgYnVpbGRlciwgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4KICAgICBTVkdSZW5kZXJTdXBw b3J0OjpjaGlsZEFkZGVkKCp0aGlzLCBjaGlsZCk7CiB9CiAKK3ZvaWQgUmVuZGVyRWxlbWVudDo6 YWRkQ2hpbGRJZ25vcmluZ0NvbnRpbnVhdGlvbihSZW5kZXJUcmVlQnVpbGRlciYgYnVpbGRlciwg UmVuZGVyUHRyPFJlbmRlck9iamVjdD4gbmV3Q2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hp bGQpCit7CisgICAgYnVpbGRlci5pbnNlcnRDaGlsZCgqdGhpcywgV1RGTW92ZShuZXdDaGlsZCks IGJlZm9yZUNoaWxkKTsKK30KKwogUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gUmVuZGVyRWxlbWVu dDo6dGFrZUNoaWxkKFJlbmRlck9iamVjdCYgb2xkQ2hpbGQpCiB7CiAgICAgcmV0dXJuIHRha2VD aGlsZEludGVybmFsKG9sZENoaWxkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxl bWVudC5oCmluZGV4IDVlNjZlNTE2MDNjODQ1NGYzNTdmNDE3YzljNjU1MjEwZmQ1Y2Y4ZDcuLjE4 YzhmNTdhZmZmYTljOGFjMTQ2ZjhjYjdiYWI3ZjY3NzRhNjhlOTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuaApAQCAtODgsNyArODgsNyBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIGJvb2wgaXNDaGlsZEFsbG93ZWQoY29uc3QgUmVuZGVyT2JqZWN0JiwgY29uc3Qg UmVuZGVyU3R5bGUmKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCB2b2lkIGFk ZENoaWxkKFJlbmRlclRyZWVCdWlsZGVyJiwgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4sIFJlbmRl ck9iamVjdCogYmVmb3JlQ2hpbGQpOwotICAgIHZpcnR1YWwgdm9pZCBhZGRDaGlsZElnbm9yaW5n Q29udGludWF0aW9uKFJlbmRlclRyZWVCdWlsZGVyJiBidWlsZGVyLCBSZW5kZXJQdHI8UmVuZGVy T2JqZWN0PiBuZXdDaGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCA9IG51bGxwdHIpIHsg YWRkQ2hpbGQoYnVpbGRlciwgV1RGTW92ZShuZXdDaGlsZCksIGJlZm9yZUNoaWxkKTsgfQorICAg IHZpcnR1YWwgdm9pZCBhZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKFJlbmRlclRyZWVCdWls ZGVyJiwgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gbmV3Q2hpbGQsIFJlbmRlck9iamVjdCogYmVm b3JlQ2hpbGQgPSBudWxscHRyKTsKICAgICB2aXJ0dWFsIFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+ IHRha2VDaGlsZChSZW5kZXJPYmplY3QmKSBXQVJOX1VOVVNFRF9SRVRVUk47CiAgICAgdm9pZCBy ZW1vdmVBbmREZXN0cm95Q2hpbGQoUmVuZGVyT2JqZWN0Jik7CiAK