181042 2017-12-20 09:32:46 -0800 Do not reuse resource for memory cache if selected service worker differs 2017-12-20 10:32:26 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson dbates ews-watchlist ggaren japhet webkit-bug-importer youennf oldest_to_newest 1383691 0 cdumez 2017-12-20 09:32:46 -0800 Do not reuse resource for memory cache if selected service worker differs. 1383695 1 329926 cdumez 2017-12-20 09:38:20 -0800 Created attachment 329926 Patch 1383711 2 329926 youennf 2017-12-20 10:10:39 -0800 Comment on attachment 329926 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329926&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:1028 > + if (cachedResourceRequest.options().serviceWorkerIdentifier != existingResource->options().serviceWorkerIdentifier) { I think we should add a comment or a FIXME to state that this area is under specified and that we should try specificying/validating this with other browsers. Now it feels safer to do that to limit weird bugs/flakinesses. 1383716 3 cdumez 2017-12-20 10:30:11 -0800 Committed r226188: <https://trac.webkit.org/changeset/226188> 1383718 4 webkit-bug-importer 2017-12-20 10:32:26 -0800 <rdar://problem/36158813> 329926 2017-12-20 09:38:20 -0800 2017-12-20 10:10:39 -0800 Patch bug-181042-20171220093819.patch text/plain 6247 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDk2NjY5NWMwZTYwYWQy Mjc0ZDQzZTcwMTVlNDI1OTA3ZjFkMDUyMC4uMGM0NzVmZjZiY2IyYzI0YzNhZmZkNjFjZTEwNDI1 NGE3ODNhMzZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRG8gbm90IHJldXNlIHJlc291 cmNlIGZvciBtZW1vcnkgY2FjaGUgaWYgc2VsZWN0ZWQgc2VydmljZSB3b3JrZXIgZGlmZmVycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDQyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogbG9hZGVyL2NhY2hl L0NhY2hlZFJlc291cmNlLmg6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZTo6b3B0 aW9ucyBjb25zdCk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlTG9hZGVyOjpkZXRlcm1pbmVS ZXZhbGlkYXRpb25Qb2xpY3kgY29uc3QpOgorCiAyMDE3LTEyLTE5ICBUaW1vdGh5IEhhdGNoZXIg IDx0aW1vdGh5QGhhdGNoZXIubmFtZT4KIAogICAgICAgICBCdWlsZCBmYWlsdXJlIGluIFdlYkdM MiB3aGVuIFZpZGVvIGZlYXR1cmUgaXMgZGlzYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L2NhY2hlL0NhY2hlZFJlc291cmNlLmgKaW5kZXggMzVmNzhjZTUxZTY1MDBlZDYxN2RkZmMyZWRm MmVmOWMxYzY4NmVkZi4uN2I1ZmVhNDliMTA3NDM2NjFiNDNlMGM0NmFmYjA5YzhlMzBlYmZmZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmgKQEAgLTIz NCw3ICsyMzQsNyBAQCBwdWJsaWM6CiAgICAgRGF0YUJ1ZmZlcmluZ1BvbGljeSBkYXRhQnVmZmVy aW5nUG9saWN5KCkgY29uc3QgeyByZXR1cm4gbV9vcHRpb25zLmRhdGFCdWZmZXJpbmdQb2xpY3k7 IH0KIAogICAgIGJvb2wgYWxsb3dzQ2FjaGluZygpIGNvbnN0IHsgcmV0dXJuIG1fb3B0aW9ucy5j YWNoaW5nUG9saWN5ID09IENhY2hpbmdQb2xpY3k6OkFsbG93Q2FjaGluZzsgfQotICAgIGNvbnN0 IEZldGNoT3B0aW9ucyYgb3B0aW9ucygpIGNvbnN0IHsgcmV0dXJuIG1fb3B0aW9uczsgfQorICAg IGNvbnN0IFJlc291cmNlTG9hZGVyT3B0aW9ucyYgb3B0aW9ucygpIGNvbnN0IHsgcmV0dXJuIG1f b3B0aW9uczsgfQogCiAgICAgdmlydHVhbCB2b2lkIGRlc3Ryb3lEZWNvZGVkRGF0YSgpIHsgfQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VM b2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9h ZGVyLmNwcAppbmRleCBhYzFmODlhMzY1ZjQzMTQxZTZlYzEzN2UyZTcyODJmNTAxMWVhMzRjLi4y YjM2YjdjZThjYzM0ZDE3MGEwNzE1NmMzYTAwMDBhNGFkMDgzMDBkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTEw MjQsNiArMTAyNCwxMyBAQCBDYWNoZWRSZXNvdXJjZUxvYWRlcjo6UmV2YWxpZGF0aW9uUG9saWN5 IENhY2hlZFJlc291cmNlTG9hZGVyOjpkZXRlcm1pbmVSZXZhbGlkYQogICAgIGlmIChyZXF1ZXN0 LmNhY2hlUG9saWN5KCkgPT0gUmVmcmVzaEFueUNhY2hlRGF0YSkKICAgICAgICAgcmV0dXJuIFJl bG9hZDsKIAorI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKKyAgICBpZiAoY2FjaGVkUmVzb3Vy Y2VSZXF1ZXN0Lm9wdGlvbnMoKS5zZXJ2aWNlV29ya2VySWRlbnRpZmllciAhPSBleGlzdGluZ1Jl c291cmNlLT5vcHRpb25zKCkuc2VydmljZVdvcmtlcklkZW50aWZpZXIpIHsKKyAgICAgICAgTE9H KFJlc291cmNlTG9hZGluZywgIkNhY2hlZFJlc291cmNlTG9hZGVyOjpkZXRlcm1pbmVSZXZhbGlk YXRpb25Qb2xpY3kgcmVsb2FkaW5nIGJlY2F1c2Ugc2VsZWN0ZWQgc2VydmljZSB3b3JrZXIgZGlm ZmVycyIpOworICAgICAgICByZXR1cm4gUmVsb2FkOworICAgIH0KKyNlbmRpZgorCiAgICAgLy8g V2UgYWxyZWFkeSBoYXZlIGEgcHJlbG9hZCBnb2luZyBmb3IgdGhpcyBVUkwuCiAgICAgaWYgKGZv clByZWxvYWQgPT0gRm9yUHJlbG9hZDo6WWVzICYmIGV4aXN0aW5nUmVzb3VyY2UtPmlzUHJlbG9h ZGVkKCkpCiAgICAgICAgIHJldHVybiBVc2U7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjU1NGMxOWM1Y2YzODllYTBjMTMy ZDUzYTI2OTQ5N2RiOTk4ZDU2MC4uOWY3ZmM5M2JhYThiY2QzNTZmMjM4M2E1MzhlZGVkMDA0OWVl ODk1OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEyLTIwICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRG8gbm90IHJldXNlIHJlc291cmNlIGZvciBtZW1v cnkgY2FjaGUgaWYgc2VsZWN0ZWQgc2VydmljZSB3b3JrZXIgZGlmZmVycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCB0ZXN0IGZyb20gZmxha3kg bGlzdCBub3cgdGhhdCBpdCBpcyBjb25zaXN0ZW50bHkgcGFzc2luZy4KKworICAgICAgICAqIFRl c3RFeHBlY3RhdGlvbnM6CisKIDIwMTctMTItMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBzY29wZVVSTCBzaG91bGQgc3RhcnQgd2l0aCB0aGUgcHJvdmlkZWQg c2NyaXB0VVJMCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA3Y2JhOWQ5NjExZGFm OTU4OGU3MTEyYTQ3ZTdlODk3ZGExM2IyMjg2Li5lOTI3MDM4YTg4ZGIzNWZmZGM4NjFiNmQ0OGYw NmE5MmI5NDAyYjM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxNy0xMi0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAg ICAgIERvIG5vdCByZXVzZSByZXNvdXJjZSBmb3IgbWVtb3J5IGNhY2hlIGlmIHNlbGVjdGVkIHNl cnZpY2Ugd29ya2VyIGRpZmZlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4MTA0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlYmFzZWxpbmUgV1BUIHRlc3Qgbm93IHRoYXQgaXQgaXMgY29uc2lzdGVu dGx5IHBhc3NpbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3Jr ZXJzL3NlcnZpY2Utd29ya2VyL3VucmVnaXN0ZXItY29udHJvbGxlci5odHRwcy1leHBlY3RlZC50 eHQ6CisKIDIwMTctMTItMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBzY29wZVVSTCBzaG91bGQgc3RhcnQgd2l0aCB0aGUgcHJvdmlkZWQgc2NyaXB0VVJMCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVz dEV4cGVjdGF0aW9ucwppbmRleCA3MTlmZmE3N2UzMWMxZWZmMjI0OTZjMjlhZjVhODBkZjg5OWQ5 NDM4Li42ZmRmYTMxNmIwYzBiYzM2ZWI3NmE1ZmY1NjUxMjRjZWIwMjAyNzRmIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTE4MCw3ICsxODAsNiBAQCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9wZXJmb3JtYW5jZS10aW1lbAogaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3Jr ZXIvcmVnaXN0cmF0aW9uLXNlcnZpY2Utd29ya2VyLWF0dHJpYnV0ZXMuaHR0cHMuaHRtbCBbIFBh c3MgRmFpbHVyZSBdCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29y a2Vycy9zZXJ2aWNlLXdvcmtlci9zZXJ2aWNlLXdvcmtlci1jc3AtY29ubmVjdC5odHRwcy5odG1s IFsgUGFzcyBGYWlsdXJlIF0KIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2Vydmlj ZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL3VuY29udHJvbGxlZC1wYWdlLmh0dHBzLmh0bWwgWyBQ YXNzIEZhaWx1cmUgXQotaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdv cmtlcnMvc2VydmljZS13b3JrZXIvdW5yZWdpc3Rlci1jb250cm9sbGVyLmh0dHBzLmh0bWwgWyBQ YXNzIEZhaWx1cmUgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdv cmtlcnMvc2VydmljZS13b3JrZXIvd2Vic29ja2V0Lmh0dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUg XQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2Vydmlj ZS13b3JrZXIvd2luZG93Y2xpZW50LW5hdmlnYXRlLmh0dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUg XQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zdHJlYW1zL3JlYWRhYmxlLWJ5dGUt c3RyZWFtcy9kZXRhY2hlZC1idWZmZXJzLnNlcnZpY2V3b3JrZXIuaHR0cHMuaHRtbCBbIFBhc3Mg RmFpbHVyZSBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci91bnJlZ2lzdGVyLWNvbnRy b2xsZXIuaHR0cHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvdW5yZWdpc3Rlci1j b250cm9sbGVyLmh0dHBzLWV4cGVjdGVkLnR4dAppbmRleCA3ZGQ4ZTAwN2FjZWRlMWEzNmRhZGM3 MmIzODQxMzBlZGM1Yjk1NDA1Li4yMjVlM2FhM2M4OTNkNTEzODg5MjAyZGUwODQ3MzgxYmY1NzA5 NmUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci91bnJlZ2lzdGVyLWNvbnRyb2xsZXIu aHR0cHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL3VucmVnaXN0ZXItY29u dHJvbGxlci5odHRwcy1leHBlY3RlZC50eHQKQEAgLTEsNiArMSw2IEBACiAKIAogUEFTUyBVbnJl Z2lzdGVyIGRvZXMgbm90IGFmZmVjdCBleGlzdGluZyBjb250cm9sbGVyIAotRkFJTCBVbnJlZ2lz dGVyIHByZXZlbnRzIGNvbnRyb2wgb2Ygc3Vic2VxdWVudCBuYXZpZ2F0aW9ucyBhc3NlcnRfdW5y ZWFjaGVkOiB1bmV4cGVjdGVkIHJlamVjdGlvbjogYXNzZXJ0X2VxdWFsczogcmVxdWVzdHMgc2hv dWxkIG5vdCBiZSBpbnRlcmNlcHRlZCBleHBlY3RlZCAiYSBzaW1wbGUgdGV4dCBmaWxlXG4iIGJ1 dCBnb3QgImludGVyY2VwdGVkIGJ5IHNlcnZpY2Ugd29ya2VyIiBSZWFjaGVkIHVucmVhY2hhYmxl IGNvZGUKK1BBU1MgVW5yZWdpc3RlciBwcmV2ZW50cyBjb250cm9sIG9mIHN1YnNlcXVlbnQgbmF2 aWdhdGlvbnMgCiBQQVNTIFVucmVnaXN0ZXIgcHJldmVudHMgbmV3IGNvbnRyb2xsZWUgZXZlbiBp ZiByZWdpc3RyYXRpb24gaXMgc3RpbGwgaW4gdXNlIAogCg==