18104 2008-03-25 23:43:17 -0700 REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html 2008-03-26 13:54:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED Regression P1 Normal --- 1 mitz mitz slewis oldest_to_newest 75268 0 mitz 2008-03-25 23:43:17 -0700 editing/inserting/12882.html leaks two InlineBox instances. This is a regression from the incremental line layout with floats patch(es). 75276 1 mitz 2008-03-26 01:20:02 -0700 // If a float's geometry has changed, give up on syncing with clean lines. if (floats[floatIndex].rect != IntRect(f->m_left, f->m_top, f->m_width, f->m_bottom - f->m_top)) endLine = 0; The idea was to avoid the endLineMatched condition, but zeroing out endLine also avoids the "Delete all the remaining lines" branch, leading to the leak. 75351 2 20096 mitz 2008-03-26 13:40:14 -0700 Created attachment 20096 Make sure to destroy unmatched clean lines No layout test regressions 75355 3 20096 andersca 2008-03-26 13:48:06 -0700 Comment on attachment 20096 Make sure to destroy unmatched clean lines r=me 75356 4 mitz 2008-03-26 13:54:32 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/31328>. 20096 2008-03-26 13:40:14 -0700 2008-03-26 13:48:06 -0700 Make sure to destroy unmatched clean lines 18104_r1.diff text/plain 2338 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDMtMjYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEwNAorICAgICAgICAg IFJFR1JFU1NJT046IExFQUs6IDIgSW5saW5lQm94IGluIGVkaXRpbmcvaW5zZXJ0aW5nLzEyODgy Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9iaWRpLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckJsb2NrOjpsYXlvdXRJbmxpbmVDaGlsZHJlbik6IFdoZW4gZGVjaWRpbmcgdG8gZGl0 Y2gKKyAgICAgICAgb2xkIGNsZWFuIGxpbmVzIChkdWUgdG8gY2hhbmdlZCBvciBuZXdseS1hZGRl ZCBmbG9hdHMpLCBrZWVwIHRoZQorICAgICAgICByZWZlcmVuY2UgdG8gdGhvc2UgbGluZXMgc28g dGhleSBjYW4gYmUgcHJvcGVybHkgZGVsZXRlZCBpbiB0aGUgZW5kLAorICAgICAgICBhbmQgdXNl IGEgc2VwYXJhdGUgZmxhZyB0byBzaWduYWwgdGhhdCBubyBtYXRjaGluZyBzaG91bGQgYmUgYXR0 ZW1wdGVkLgorCiAyMDA4LTAzLTI2ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAg ICAgICAgU3BlY3VsYXRpdmUgV2luZG93cyBidWlsZCBmaXguCkluZGV4OiBXZWJDb3JlL3JlbmRl cmluZy9iaWRpLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9iaWRpLmNwcAko cmV2aXNpb24gMzEzMjUpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9iaWRpLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODczLDEwICs4NzMsMTEgQEAgdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0SW5saW5l Q2hpbGRyZW4oYgogICAgICAgICAgICAgbmV3TGluZShsYXN0Um9vdEJveCgpLT5vYmplY3QoKS0+ bGFzdENoaWxkKCktPnN0eWxlKCktPmNsZWFyKCkpOwogCiAgICAgICAgIGJvb2wgZW5kTGluZU1h dGNoZWQgPSBmYWxzZTsKKyAgICAgICAgYm9vbCBjaGVja0ZvckVuZExpbmVNYXRjaCA9IGVuZExp bmU7CiAKICAgICAgICAgd2hpbGUgKCFlbmQuYXRFbmQoKSkgewogICAgICAgICAgICAgLy8gRklY TUU6IElzIHRoaXMgY2hlY2sgbmVjZXNzYXJ5IGJlZm9yZSB0aGUgZmlyc3QgaXRlcmF0aW9uIG9y IGNhbiBpdCBiZSBtb3ZlZCB0byB0aGUgZW5kPwotICAgICAgICAgICAgaWYgKGVuZExpbmUgJiYg KGVuZExpbmVNYXRjaGVkID0gbWF0Y2hlZEVuZExpbmUoc3RhcnQsIGNsZWFuTGluZVN0YXJ0LCBj bGVhbkxpbmVCaWRpU3RhdHVzLCBlbmRMaW5lLCBlbmRMaW5lWVBvcywgcmVwYWludEJvdHRvbSwg cmVwYWludFRvcCkpKQorICAgICAgICAgICAgaWYgKGNoZWNrRm9yRW5kTGluZU1hdGNoICYmIChl bmRMaW5lTWF0Y2hlZCA9IG1hdGNoZWRFbmRMaW5lKHN0YXJ0LCBjbGVhbkxpbmVTdGFydCwgY2xl YW5MaW5lQmlkaVN0YXR1cywgZW5kTGluZSwgZW5kTGluZVlQb3MsIHJlcGFpbnRCb3R0b20sIHJl cGFpbnRUb3ApKSkKICAgICAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICAgICAgYmV0d2Vl bk1pZHBvaW50cyA9IGZhbHNlOwpAQCAtOTUxLDcgKzk1Miw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6 OmxheW91dElubGluZUNoaWxkcmVuKGIKICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKGYtPm1f cmVuZGVyZXIgPT0gZmxvYXRzW2Zsb2F0SW5kZXhdLm9iamVjdCk7CiAgICAgICAgICAgICAgICAg ICAgIC8vIElmIGEgZmxvYXQncyBnZW9tZXRyeSBoYXMgY2hhbmdlZCwgZ2l2ZSB1cCBvbiBzeW5j aW5nIHdpdGggY2xlYW4gbGluZXMuCiAgICAgICAgICAgICAgICAgICAgIGlmIChmbG9hdHNbZmxv YXRJbmRleF0ucmVjdCAhPSBJbnRSZWN0KGYtPm1fbGVmdCwgZi0+bV90b3AsIGYtPm1fd2lkdGgs IGYtPm1fYm90dG9tIC0gZi0+bV90b3ApKQotICAgICAgICAgICAgICAgICAgICAgICAgZW5kTGlu ZSA9IDA7CisgICAgICAgICAgICAgICAgICAgICAgICBjaGVja0ZvckVuZExpbmVNYXRjaCA9IGZh bHNlOwogICAgICAgICAgICAgICAgICAgICBmbG9hdEluZGV4Kys7CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgIGxhc3RGbG9hdCA9IG1fZmxvYXRpbmdPYmplY3RzLT5sYXN0KCk7 Cg==