<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>181037</bug_id>
          
          <creation_ts>2017-12-20 08:31:42 -0800</creation_ts>
          <short_desc>Refactor RenderMathMLMenclose to remove LayoutRect member modified during layout</short_desc>
          <delta_ts>2017-12-26 00:02:48 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>MathML</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=161126</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>180348</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Frédéric Wang Nélar">fred.wang</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alex</cc>
    
    <cc>jfernandez</cc>
    
    <cc>lambda</cc>
    
    <cc>rego</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1383645</commentid>
    <comment_count>0</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2017-12-20 08:31:42 -0800</bug_when>
    <thetext>fred@igalia-fwang:~/webkit/WebKit$ grep m_ Source/WebCore/rendering/mathml/RenderMathMLMenclose.h 
    LayoutRect m_contentRect;

This is similar to bug 180151. We can probably refactor the code so that we don&apos;t need m_contentRect. The RenderMathMLRow::getContentBoundingBox function introduced in bug 180348 should help to do it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1384697</commentid>
    <comment_count>1</comment_count>
    <who name="Minsheng Liu">lambda</who>
    <bug_when>2017-12-26 00:02:48 -0800</bug_when>
    <thetext>Is this really necessary? If we decide to introduce a const method to replace m_contentRect, then we need to recompute the content bounding box every time we paint, which seems quite costly to me. How about caching the content bounding box in RenderMathMLRow so that we do not need to cache it twice? That seems more manageable.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>