181034 2017-12-20 07:33:22 -0800 Replace a FIXME comment in CanvasGradient::addColorStop(). 2017-12-21 06:52:43 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P5 Trivial --- 1 Ms2ger Ms2ger cdumez commit-queue dbates dino esprehn+autocc ews-watchlist gyuyoung.kim webkit-bug-importer oldest_to_newest 1383629 0 Ms2ger 2017-12-20 07:33:22 -0800 . 1383630 1 329917 Ms2ger 2017-12-20 07:37:13 -0800 Created attachment 329917 Patch 1383788 2 329917 dbates 2017-12-20 12:45:12 -0800 Comment on attachment 329917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329917&action=review > Source/WebCore/html/canvas/CanvasGradient.cpp:51 > + // Passing null for canvas ensures that currentColor is treated as black, > + // as required by the standard. > Color color = parseColorOrCurrentColor(colorString, nullptr /*canvas*/); The updated comment is good. Even better would be a layout test to both document this behavior and ensure we do not regress it. Do we have an existing test? If not, please write one. 1384087 3 Ms2ger 2017-12-21 05:50:49 -0800 LayoutTests/imported/w3c/canvas/2d.gradient.object.current.html is checking this and passing. 1384090 4 330030 Ms2ger 2017-12-21 06:18:03 -0800 Created attachment 330030 Patch 1384093 5 330030 commit-queue 2017-12-21 06:51:53 -0800 Comment on attachment 330030 Patch Clearing flags on attachment: 330030 Committed r226220: <https://trac.webkit.org/changeset/226220> 1384094 6 commit-queue 2017-12-21 06:51:54 -0800 All reviewed patches have been landed. Closing bug. 1384095 7 webkit-bug-importer 2017-12-21 06:52:43 -0800 <rdar://problem/36177424> 329917 2017-12-20 07:37:13 -0800 2017-12-21 06:17:59 -0800 Patch bug-181034-20171220163712.patch text/plain 1617 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWI4YWE3YWE0MTI3N2Vj OWM0MDMxZDdiMzk3YzhhOTRhOGYyNjQ4Mi4uOGM0ZWRlNGZmNDhmZTQwNThiMGIwYTRlZDI5Yjhm ODI3MDIyNzYzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTIwICBNczJn ZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXBsYWNlIGEgRklYTUUgY29tbWVu dCBpbiBDYW52YXNHcmFkaWVudDo6YWRkQ29sb3JTdG9wKCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEwMzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM6IG5vIGJlaGF2aW9yIGNo YW5nZXMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNHcmFkaWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDYW52YXNHcmFkaWVudDo6YWRkQ29sb3JTdG9wKToKKwogMjAxNy0xMi0x NyAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9yYWdl IEFjY2VzcyBBUEk6IE1ha2UgZG9jdW1lbnQuaGFzU3RvcmFnZUFjY2VzcygpIHJldHJpZXZlIGN1 cnJlbnQgc3RhdHVzIGZyb20gdGhlIG5ldHdvcmsgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQuY3BwCmluZGV4IDlkYTI0ZjE5NjE3NzBmM2U5NmU5 M2M2YmQ4NzZjYzM0MDE0ZDQ4OTAuLmFiYWI5ZGZiMjhjNTkwMTU2ZDZlOWE3NjhmNTZlNTUyZmNj ZWE0MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc0dyYWRp ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNHcmFkaWVudC5j cHAKQEAgLTQ2LDcgKzQ2LDggQEAgRXhjZXB0aW9uT3I8dm9pZD4gQ2FudmFzR3JhZGllbnQ6OmFk ZENvbG9yU3RvcChmbG9hdCB2YWx1ZSwgY29uc3QgU3RyaW5nJiBjb2xvclMKICAgICBpZiAoISh2 YWx1ZSA+PSAwICYmIHZhbHVlIDw9IDEpKQogICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgSW5k ZXhTaXplRXJyb3IgfTsKIAotICAgIC8vIEZJWE1FOiBQYXNzaW5nIG51bGwgZm9yIGNhbnZhcyBt ZWFucyB0aGlzIHdvbid0IHdvcmsgZm9yIGN1cnJlbnQgY29sb3IuIElzIHRoYXQgT0s/CisgICAg Ly8gUGFzc2luZyBudWxsIGZvciBjYW52YXMgZW5zdXJlcyB0aGF0IGN1cnJlbnRDb2xvciBpcyB0 cmVhdGVkIGFzIGJsYWNrLAorICAgIC8vIGFzIHJlcXVpcmVkIGJ5IHRoZSBzdGFuZGFyZC4KICAg ICBDb2xvciBjb2xvciA9IHBhcnNlQ29sb3JPckN1cnJlbnRDb2xvcihjb2xvclN0cmluZywgbnVs bHB0ciAvKmNhbnZhcyovKTsKICAgICBpZiAoIWNvbG9yLmlzVmFsaWQoKSkgewogI2lmIEVOQUJM RShEQVNIQk9BUkRfU1VQUE9SVCkK 330030 2017-12-21 06:18:03 -0800 2017-12-21 06:51:53 -0800 Patch bug-181034-20171221151801.patch text/plain 1651 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWI4YWE3YWE0MTI3N2Vj OWM0MDMxZDdiMzk3YzhhOTRhOGYyNjQ4Mi4uZDkyMmQzMjMyOTJmMjZiMWViNmU2OWMzZDc4ZmFh YWMyMjM1YWM3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTIwICBNczJn ZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXBsYWNlIGEgRklYTUUgY29tbWVu dCBpbiBDYW52YXNHcmFkaWVudDo6YWRkQ29sb3JTdG9wKCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEwMzQKKworICAgICAgICBSZXZpZXdlZCBi eSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgVGVzdHM6IExheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9jYW52YXMvMmQuZ3JhZGllbnQub2JqZWN0LmN1cnJlbnQuaHRtbAorCisgICAgICAgICogaHRt bC9jYW52YXMvQ2FudmFzR3JhZGllbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzR3Jh ZGllbnQ6OmFkZENvbG9yU3RvcCk6CisKIDIwMTctMTItMTcgIEpvaG4gV2lsYW5kZXIgIDx3aWxh bmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcmFnZSBBY2Nlc3MgQVBJOiBNYWtlIGRvY3Vt ZW50Lmhhc1N0b3JhZ2VBY2Nlc3MoKSByZXRyaWV2ZSBjdXJyZW50IHN0YXR1cyBmcm9tIHRoZSBu ZXR3b3JrIHByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc0dyYWRpZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc0dyYWRp ZW50LmNwcAppbmRleCA5ZGEyNGYxOTYxNzcwZjNlOTZlOTNjNmJkODc2Y2MzNDAxNGQ0ODkwLi5h YmFiOWRmYjI4YzU5MDE1NmQ2ZTlhNzY4ZjU2ZTU1MmZjY2VhNDMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNHcmFkaWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQuY3BwCkBAIC00Niw3ICs0Niw4IEBAIEV4 Y2VwdGlvbk9yPHZvaWQ+IENhbnZhc0dyYWRpZW50OjphZGRDb2xvclN0b3AoZmxvYXQgdmFsdWUs IGNvbnN0IFN0cmluZyYgY29sb3JTCiAgICAgaWYgKCEodmFsdWUgPj0gMCAmJiB2YWx1ZSA8PSAx KSkKICAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IEluZGV4U2l6ZUVycm9yIH07CiAKLSAgICAv LyBGSVhNRTogUGFzc2luZyBudWxsIGZvciBjYW52YXMgbWVhbnMgdGhpcyB3b24ndCB3b3JrIGZv ciBjdXJyZW50IGNvbG9yLiBJcyB0aGF0IE9LPworICAgIC8vIFBhc3NpbmcgbnVsbCBmb3IgY2Fu dmFzIGVuc3VyZXMgdGhhdCBjdXJyZW50Q29sb3IgaXMgdHJlYXRlZCBhcyBibGFjaywKKyAgICAv LyBhcyByZXF1aXJlZCBieSB0aGUgc3RhbmRhcmQuCiAgICAgQ29sb3IgY29sb3IgPSBwYXJzZUNv bG9yT3JDdXJyZW50Q29sb3IoY29sb3JTdHJpbmcsIG51bGxwdHIgLypjYW52YXMqLyk7CiAgICAg aWYgKCFjb2xvci5pc1ZhbGlkKCkpIHsKICNpZiBFTkFCTEUoREFTSEJPQVJEX1NVUFBPUlQpCg==