181014 2017-12-19 17:31:33 -0800 MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing 2017-12-20 12:00:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates ews-watchlist simon.fraser webkit-bug-importer oldest_to_newest 1383456 0 dbates 2017-12-19 17:31:33 -0800 From <https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2063/steps/run-api-tests/logs/stdio>: [[ FAIL MarkerSubrange.SubdivideGrammarAndSelectionOverlapFrontmost /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:193 Value of: results[i] Actual: (50, 60, GrammarError) Expected: expectedSubranges[i] Which is: (50, 60, Selection) FAIL MarkerSubrange.SubdivideGrammarAndSelectionOverlapFrontmostWithLongestEffectiveRange /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:208 Value of: results.size() Actual: 3 Expected: expectedSubranges.size() Which is: 2 ]] 1383458 1 dbates 2017-12-19 17:34:38 -0800 Temporarily disabled running the tests and committed this in <https://trac.webkit.org/changeset/226165>. 1383761 2 329938 dbates 2017-12-20 11:29:30 -0800 Created attachment 329938 Patch and unit test 1383763 3 ews-watchlist 2017-12-20 11:31:41 -0800 Attachment 329938 did not pass style-queue: ERROR: Source/WebCore/rendering/MarkerSubrange.cpp:100: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1383773 4 329938 dbates 2017-12-20 11:59:39 -0800 Comment on attachment 329938 Patch and unit test Clearing flags on attachment: 329938 Committed r226194: <https://trac.webkit.org/changeset/226194> 1383774 5 dbates 2017-12-20 11:59:41 -0800 All reviewed patches have been landed. Closing bug. 1383775 6 webkit-bug-importer 2017-12-20 12:00:34 -0800 <rdar://problem/36161355> 329938 2017-12-20 11:29:30 -0800 2017-12-20 11:59:39 -0800 Patch and unit test bug-181014-20171220112929.patch text/plain 6783 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEwN2VmYjY3OTc2ZjQ1 MDhjNWFkMmI3ZTY0ZjVhYTdiOWYwODIxYS4uYmExYTU3ODFhZDkxOTZlZjIwNDg0MjA3ZDczYmIw N2FkZGU4ZWNlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTEyLTIwICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYXJrZXJTdWJyYW5nZS5T dWJkaXZpZGVHcmFtbWFyQW5kU2VsZWN0aW9uT3ZlcmxhcHtGcm9udG1vc3QsIEZyb250bW9zdFdp dGhMb25nZXN0RWZmZWN0aXZlUmFuZ2V9IGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEwMTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBhbiBpc3N1ZSBpbiB0aGUgc3ViZGl2 aXNpb24gYWxnb3JpdGhtIHdoZXJlIHRoZSByZXR1cm5lZCBzdWJyYW5nZXMgbWF5IG5vdCBiZSBw YWludCBvcmRlcgorICAgICAgICBvciByZXZlcnNlIHBhaW50IG9yZGVyIHdoZW4gdXNpbmcgdGhl IGRlZmF1bHQgb3ZlcmxhcCBzdHJhdGVneSAoT3ZlcmxhcFN0cmF0ZWd5OjpOb25lKSBhbmQKKyAg ICAgICAgZWl0aGVyIE92ZXJsYXBTdHJhdGVneTo6RnJvbnRtb3N0IG9yIE92ZXJsYXBTdHJhdGVn eTo6RnJvbnRtb3N0V2l0aExvbmdlc3RFZmZlY3RpdmVSYW5nZSwgcmVzcGVjdGl2ZWx5LgorCisg ICAgICAgIEN1cnJlbnRseSB3ZSBjb21wdXRlIHRoZSBvdmVybGFwcGluZyBzdWJyYW5nZXMgdXAg dG8gc29tZSBwb2ludCBwX2kgb24gdGhlIGxpbmUgYnkgc3dlZXBpbmcgZnJvbSB0aGUKKyAgICAg ICAgc3RhcnQgb2YgdGhlIGxpbmUgdGhyb3VnaCBhbGwgdGhlIHVuY2xvc2VkIHN1YnJhbmdlcy4g VGhlIHVuY2xvc2VkIHN1YnJhbmdlcyBhcmUgc29ydGVkIGFsb25nIHRoZSBsaW5lLgorICAgICAg ICBUaGF0IGlzLCB0aGV5IGFyZSBub3Qgc29ydGVkIGJ5IHBhaW50IG9yZGVyIG9yIHJldmVyc2Ug cGFpbnQgb3JkZXIuIFRoZXJlZm9yZSB3ZSBtdXN0IHRha2UgY2FyZSB0bworICAgICAgICBlbnN1 cmUgdGhhdCB3ZSByZXR1cm4gdGhlIGNvbXB1dGVkIG92ZXJsYXBwaW5nIHN1YnJhbmdlcyB3aXRo IHJlc3BlY3QgdG8gcGFpbnQgb3JkZXIvcmV2ZXJzZSBwYWludCBvcmRlci4KKworICAgICAgICAq IHJlbmRlcmluZy9NYXJrZXJTdWJyYW5nZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzdWJkaXZp ZGUpOgorCiAyMDE3LTEyLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBTdXBwb3J0IHNlcnZpY2Ugd29ya2VyIGludGVyY2VwdGlvbiBvZiByZXF1ZXN0IHdp dGggYmxvYiBib2R5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTWFya2Vy U3VicmFuZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL01hcmtlclN1YnJhbmdlLmNw cAppbmRleCBjY2M2MzJkOTJkNGQ1NDgzMWFkYjNiYjUyOGZhOTZjZGFlMTZiNzdhLi5kNTc4MWVi YzhjYzExNzI4ODA5YzUzYTdmYTAyOWU5ZDRkN2Q1YzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvTWFya2VyU3VicmFuZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9NYXJrZXJTdWJyYW5nZS5jcHAKQEAgLTcwLDcgKzcwLDcgQEAgVmVjdG9yPE1hcmtl clN1YnJhbmdlPiBzdWJkaXZpZGUoY29uc3QgVmVjdG9yPE1hcmtlclN1YnJhbmdlPiYgc3VicmFu Z2VzLCBPdmVybGEKICAgICAgICAgICAgIGlmIChvdmVybGFwU3RyYXRlZ3kgPT0gT3ZlcmxhcFN0 cmF0ZWd5OjpGcm9udG1vc3QgfHwgb3ZlcmxhcFN0cmF0ZWd5ID09IE92ZXJsYXBTdHJhdGVneTo6 RnJvbnRtb3N0V2l0aExvbmdlc3RFZmZlY3RpdmVSYW5nZSkgewogICAgICAgICAgICAgICAgIHN0 ZDo6b3B0aW9uYWw8dW5zaWduZWQ+IGZyb250bW9zdDsKICAgICAgICAgICAgICAgICBmb3IgKHVu c2lnbmVkIGogPSAwOyBqIDwgaTsgKytqKSB7Ci0gICAgICAgICAgICAgICAgICAgIGlmICghcHJv Y2Vzc2VkU3VicmFuZ2VzLmNvbnRhaW5zKG9mZnNldHNbal0uc3VicmFuZ2UpKQorICAgICAgICAg ICAgICAgICAgICBpZiAoIXByb2Nlc3NlZFN1YnJhbmdlcy5jb250YWlucyhvZmZzZXRzW2pdLnN1 YnJhbmdlKSAmJiAoIWZyb250bW9zdCB8fCBvZmZzZXRzW2pdLnN1YnJhbmdlLT50eXBlID4gb2Zm c2V0c1sqZnJvbnRtb3N0XS5zdWJyYW5nZS0+dHlwZSkpCiAgICAgICAgICAgICAgICAgICAgICAg ICBmcm9udG1vc3QgPSBqOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBpZiAo ZnJvbnRtb3N0KSB7CkBAIC04NCw2ICs4NCw3IEBAIFZlY3RvcjxNYXJrZXJTdWJyYW5nZT4gc3Vi ZGl2aWRlKGNvbnN0IFZlY3RvcjxNYXJrZXJTdWJyYW5nZT4mIHN1YnJhbmdlcywgT3ZlcmxhCiAg ICAgICAgICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKHsgb2Zmc2V0U29GYXIsIG9mZnNl dHNbaV0udmFsdWUsIG9mZnNldHNbZnJvbnRtb3N0LnZhbHVlKCldLnN1YnJhbmdlLT50eXBlLCBv ZmZzZXRzW2Zyb250bW9zdC52YWx1ZSgpXS5zdWJyYW5nZS0+bWFya2VyIH0pOwogICAgICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgLy8gVGhlIGFw cGVuZGVkIHN1YnJhbmdlcyBtYXkgbm90IGJlIGluIHBhaW50IG9yZGVyLiBXZSB3aWxsIGZpeCB0 aGlzIHVwIGF0IHRoZSBlbmQgb2YgdGhpcyBmdW5jdGlvbi4KICAgICAgICAgICAgICAgICBmb3Ig KHVuc2lnbmVkIGogPSAwOyBqIDwgaTsgKytqKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICgh cHJvY2Vzc2VkU3VicmFuZ2VzLmNvbnRhaW5zKG9mZnNldHNbal0uc3VicmFuZ2UpKQogICAgICAg ICAgICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCh7IG9mZnNldFNvRmFyLCBvZmZzZXRzW2ld LnZhbHVlLCBvZmZzZXRzW2pdLnN1YnJhbmdlLT50eXBlLCBvZmZzZXRzW2pdLnN1YnJhbmdlLT5t YXJrZXIgfSk7CkBAIC05NCw2ICs5NSw5IEBAIFZlY3RvcjxNYXJrZXJTdWJyYW5nZT4gc3ViZGl2 aWRlKGNvbnN0IFZlY3RvcjxNYXJrZXJTdWJyYW5nZT4mIHN1YnJhbmdlcywgT3ZlcmxhCiAgICAg ICAgIGlmIChvZmZzZXRzW2ldLmtpbmQgPT0gT2Zmc2V0OjpFbmQpCiAgICAgICAgICAgICBwcm9j ZXNzZWRTdWJyYW5nZXMuYWRkKG9mZnNldHNbaV0uc3VicmFuZ2UpOwogICAgIH0KKyAgICAvLyBG aXggdXA7IHNvcnQgdGhlIHN1YnJhbmdlcyBzbyB0aGF0IHRoZXkgYXJlIGluIHBhaW50IG9yZGVy LgorICAgIGlmIChvdmVybGFwU3RyYXRlZ3kgPT0gT3ZlcmxhcFN0cmF0ZWd5OjpOb25lKQorICAg ICAgICBzdGQ6OnNvcnQocmVzdWx0LmJlZ2luKCksIHJlc3VsdC5lbmQoKSwgW10gKGNvbnN0IE1h cmtlclN1YnJhbmdlJiBhLCBjb25zdCBNYXJrZXJTdWJyYW5nZSYgYikgeyByZXR1cm4gYS5zdGFy dE9mZnNldCA8IGIuc3RhcnRPZmZzZXQgfHwgKGEuc3RhcnRPZmZzZXQgPT0gYi5zdGFydE9mZnNl dCAmJiBhLnR5cGUgPCBiLnR5cGUpOyB9KTsKICAgICByZXR1cm4gcmVzdWx0OwogfQogCmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2FlODliZTc1 YTYxZjFjMDVhYTBiYjYzMTc1ZGU4MDFmMzZmMjJmMS4uNThiNzAxMjZlMDdlNjViMTM5YTJjMGEy ZTNkYmEzZjdhZGI3NjBkNSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTIwICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYXJrZXJTdWJyYW5nZS5TdWJkaXZpZGVHcmFt bWFyQW5kU2VsZWN0aW9uT3ZlcmxhcHtGcm9udG1vc3QsIEZyb250bW9zdFdpdGhMb25nZXN0RWZm ZWN0aXZlUmFuZ2V9IGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODEwMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGRzIGEgbmV3IHRlc3QgdG8gZW5zdXJlIHdlIGNvbXB1dGUgb3Zl cmxhcHBpbmcgc3VicmFuZ2VzIGluIHBhaW50IG9yZGVyIGZvciB0aGUgZGVmYXVsdAorICAgICAg ICBvdmVybGFwIHN0cmF0ZWd5LiBFbmFibGUgdGVzdHMgTWFya2VyU3VicmFuZ2UuU3ViZGl2aWRl R3JhbW1hckFuZFNlbGVjdGlvbk92ZXJsYXB7RnJvbnRtb3N0LCBGcm9udG1vc3RXaXRoTG9uZ2Vz dEVmZmVjdGl2ZVJhbmdlfQorICAgICAgICBub3cgdGhhdCB0aGV5IHBhc3MuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTWFya2VyU3VicmFuZ2UuY3BwOgorICAgICAg ICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTctMTItMjAgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBBbHRlcm5hdGl2ZSBQcmVzZW50YXRp b24gQnV0dG9uCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUv TWFya2VyU3VicmFuZ2UuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL01h cmtlclN1YnJhbmdlLmNwcAppbmRleCBkODBlMWY1MDg2NDY1ZDNjOWExMTczMTk2MDU5ODc4YmMw ZDk3NTcwLi4yOTVmNDM3MDg4M2NiYzg3OWFlMTNhODFiZWZmYjk2NDNjZWMwY2E1IDEwMDY0NAot LS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvTWFya2VyU3VicmFuZ2UuY3Bw CisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9NYXJrZXJTdWJyYW5nZS5j cHAKQEAgLTE3NCw3ICsxNzQsMjggQEAgVEVTVChNYXJrZXJTdWJyYW5nZSwgU3ViZGl2aWRlU3Bl bGxpbmdBbmRHcmFtbWFyQ29tcGxpY2F0ZWRGcm9udG1vc3QpCiAgICAgICAgIEVYUEVDVF9FUShl eHBlY3RlZFN1YnJhbmdlc1tpXSwgcmVzdWx0c1tpXSk7CiB9CiAKLVRFU1QoTWFya2VyU3VicmFu Z2UsIERJU0FCTEVEX1N1YmRpdmlkZUdyYW1tYXJBbmRTZWxlY3Rpb25PdmVybGFwRnJvbnRtb3N0 KQorVEVTVChNYXJrZXJTdWJyYW5nZSwgU3ViZGl2aWRlR3JhbW1hckFuZFNlbGVjdGlvbk92ZXJs YXApCit7CisgICAgVmVjdG9yPE1hcmtlclN1YnJhbmdlPiBzdWJyYW5nZXMgeworICAgICAgICBN YXJrZXJTdWJyYW5nZSB7IDAsIDQwLCBNYXJrZXJTdWJyYW5nZTo6R3JhbW1hckVycm9yIH0sCisg ICAgICAgIE1hcmtlclN1YnJhbmdlIHsgMiwgNjAsIE1hcmtlclN1YnJhbmdlOjpTZWxlY3Rpb24g fSwKKyAgICAgICAgTWFya2VyU3VicmFuZ2UgeyA1MCwgNjAsIE1hcmtlclN1YnJhbmdlOjpHcmFt bWFyRXJyb3IgfSwKKyAgICB9OworICAgIFZlY3RvcjxNYXJrZXJTdWJyYW5nZT4gZXhwZWN0ZWRT dWJyYW5nZXMgeworICAgICAgICBNYXJrZXJTdWJyYW5nZSB7IDAsIDIsIE1hcmtlclN1YnJhbmdl OjpHcmFtbWFyRXJyb3IgfSwKKyAgICAgICAgTWFya2VyU3VicmFuZ2UgeyAyLCA0MCwgTWFya2Vy U3VicmFuZ2U6OkdyYW1tYXJFcnJvciB9LAorICAgICAgICBNYXJrZXJTdWJyYW5nZSB7IDIsIDQw LCBNYXJrZXJTdWJyYW5nZTo6U2VsZWN0aW9uIH0sCisgICAgICAgIE1hcmtlclN1YnJhbmdlIHsg NDAsIDUwLCBNYXJrZXJTdWJyYW5nZTo6U2VsZWN0aW9uIH0sCisgICAgICAgIE1hcmtlclN1YnJh bmdlIHsgNTAsIDYwLCBNYXJrZXJTdWJyYW5nZTo6R3JhbW1hckVycm9yIH0sCisgICAgICAgIE1h cmtlclN1YnJhbmdlIHsgNTAsIDYwLCBNYXJrZXJTdWJyYW5nZTo6U2VsZWN0aW9uIH0sCisgICAg fTsKKyAgICBhdXRvIHJlc3VsdHMgPSBzdWJkaXZpZGUoc3VicmFuZ2VzKTsKKyAgICBBU1NFUlRf RVEoZXhwZWN0ZWRTdWJyYW5nZXMuc2l6ZSgpLCByZXN1bHRzLnNpemUoKSk7CisgICAgZm9yIChz aXplX3QgaSA9IDA7IGkgPCBleHBlY3RlZFN1YnJhbmdlcy5zaXplKCk7ICsraSkKKyAgICAgICAg RVhQRUNUX0VRKGV4cGVjdGVkU3VicmFuZ2VzW2ldLCByZXN1bHRzW2ldKTsKK30KKworVEVTVChN YXJrZXJTdWJyYW5nZSwgU3ViZGl2aWRlR3JhbW1hckFuZFNlbGVjdGlvbk92ZXJsYXBGcm9udG1v c3QpCiB7CiAgICAgVmVjdG9yPE1hcmtlclN1YnJhbmdlPiBzdWJyYW5nZXMgewogICAgICAgICBN YXJrZXJTdWJyYW5nZSB7IDAsIDQwLCBNYXJrZXJTdWJyYW5nZTo6R3JhbW1hckVycm9yIH0sCkBA IC0xOTMsNyArMjE0LDcgQEAgVEVTVChNYXJrZXJTdWJyYW5nZSwgRElTQUJMRURfU3ViZGl2aWRl R3JhbW1hckFuZFNlbGVjdGlvbk92ZXJsYXBGcm9udG1vc3QpCiAgICAgICAgIEVYUEVDVF9FUShl eHBlY3RlZFN1YnJhbmdlc1tpXSwgcmVzdWx0c1tpXSk7CiB9CiAKLVRFU1QoTWFya2VyU3VicmFu Z2UsIERJU0FCTEVEX1N1YmRpdmlkZUdyYW1tYXJBbmRTZWxlY3Rpb25PdmVybGFwRnJvbnRtb3N0 V2l0aExvbmdlc3RFZmZlY3RpdmVSYW5nZSkKK1RFU1QoTWFya2VyU3VicmFuZ2UsIFN1YmRpdmlk ZUdyYW1tYXJBbmRTZWxlY3Rpb25PdmVybGFwRnJvbnRtb3N0V2l0aExvbmdlc3RFZmZlY3RpdmVS YW5nZSkKIHsKICAgICBWZWN0b3I8TWFya2VyU3VicmFuZ2U+IHN1YnJhbmdlcyB7CiAgICAgICAg IE1hcmtlclN1YnJhbmdlIHsgMCwgNDAsIE1hcmtlclN1YnJhbmdlOjpHcmFtbWFyRXJyb3IgfSwK