181008 2017-12-19 16:11:08 -0800 Layout Test http/tests/images/image-supports-video.html is flaky 2018-01-19 10:10:56 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=179178 InRadar P2 Normal --- 1 jlewis3 jer.noble commit-queue eric.carlson jer.noble ryanhaddad webkit-bug-importer youennf oldest_to_newest 1383401 0 jlewis3 2017-12-19 16:11:08 -0800 The following layout test is flaky on macOS WK! http/tests/images/image-supports-video.html Probable cause: Test was flaky from the initial commit in https://trac.webkit.org/changeset/225472/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fimages%2Fimage-supports-video.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r226129%20(5383)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/5383 diff: --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/images/image-supports-video-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/images/image-supports-video-actual.txt @@ -1,2 +1,2 @@ -PASS: video source selected. +FAIL: <img> threw error. 1383402 1 webkit-bug-importer 2017-12-19 16:11:29 -0800 <rdar://problem/36143943> 1383426 2 jlewis3 2017-12-19 16:59:52 -0800 Marked as flaky on macOS WK1: https://trac.webkit.org/changeset/226159/webkit 1383942 3 jer.noble 2017-12-20 17:46:42 -0800 From the access_log.txt on the failing test, I see a request for the initial image URL (meaning the test passed), but not for the redirected URL.ng e.g., on a passing run: 127.0.0.1 - - [20/Dec/2017:12:17:29 -0800] "GET /resources/redirect-to-video-if-accepted.php?video=test.mp4 HTTP/1.1" 301 - 1356 127.0.0.1 - - [20/Dec/2017:12:17:29 -0800] "GET /resources/test.mp4 HTTP/1.1" 200 192844 1862 and on a failing run: 127.0.0.1 - - [09/Dec/2017:13:51:01 -0800] "GET /resources/redirect-to-video-if-accepted.php?video=test.mp4 HTTP/1.1" 301 - 1163 (with no matching request for "test.mp4".) Could we be hitting a weird memory cache corner case? 1383964 4 jer.noble 2017-12-20 18:10:33 -0800 This may be just another instance of bug #77538, which is worked around by adding a cache-control error. 1390421 5 331599 jer.noble 2018-01-17 22:42:10 -0800 Created attachment 331599 Patch 1390449 6 331599 commit-queue 2018-01-18 00:33:19 -0800 Comment on attachment 331599 Patch Clearing flags on attachment: 331599 Committed r227137: <https://trac.webkit.org/changeset/227137> 1390450 7 commit-queue 2018-01-18 00:33:20 -0800 All reviewed patches have been landed. Closing bug. 1390983 8 ryanhaddad 2018-01-19 09:49:42 -0800 *** Bug 181862 has been marked as a duplicate of this bug. *** 1390984 9 ryanhaddad 2018-01-19 09:50:49 -0800 This test is still flaky after https://trac.webkit.org/changeset/227137 1391002 10 jer.noble 2018-01-19 10:10:56 -0800 (In reply to Ryan Haddad from comment #9) > This test is still flaky after https://trac.webkit.org/changeset/227137 Crud. 331599 2018-01-17 22:42:10 -0800 2018-01-18 00:33:19 -0800 Patch bug-181008-20180117224209.patch text/plain 2204 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MDA4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTRjMDAyZWQ5ODk4ZmMzYTYyMWY2 NTkwODc0ZGNmODEzMmIzOWY2OC4uMTJmOTM0ZTlmNDMwMGE4Y2ZkMTg4MDUxZGZhYjhkZDBlYzg5 MWZiNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTE3ICBKZXIgTm9ibGUgIDxqZXIu bm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IGh0dHAvdGVzdHMvaW1hZ2Vz L2ltYWdlLXN1cHBvcnRzLXZpZGVvLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTAwOAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzYxNDM5NDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2VuZCBhICJDYWNoZS1jb250cm9sOiBub2NhY2hlIiBoZWFkZXIgZnJvbSB0aGUgSFRU UCBzZXJ2ZXIgd2hlbiB0aGUgaW1hZ2UgcmVzb3VyY2UgaXMKKyAgICAgICAgcmVxdWVzdGVkLgor CisgICAgICAgICogaHR0cC90ZXN0cy9yZXNvdXJjZXMvcmVkaXJlY3QtdG8tdmlkZW8taWYtYWNj ZXB0ZWQucGhwOgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9uczoK KwogMjAxOC0wMS0xNyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWJWVFQgc2VydmVkIHZpYSBITFMgbmV2ZXIgcmVzdWx0cyBpbiBjdWVzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlcy9yZWRpcmVjdC10by12aWRlby1pZi1h Y2NlcHRlZC5waHAgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlcy9yZWRpcmVjdC10 by12aWRlby1pZi1hY2NlcHRlZC5waHAKaW5kZXggZTYxNGUxNmY1MmZkZTUwZTNlYjY3MzZjZTI2 ODkwOTkzYWQwMDZjZC4uOTNiZWY4MjM2ODM1ODc4YTA3YWM1NjhmYWMyNzk2ZmVkYmZlMWI0YyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZXMvcmVkaXJlY3QtdG8t dmlkZW8taWYtYWNjZXB0ZWQucGhwCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3Vy Y2VzL3JlZGlyZWN0LXRvLXZpZGVvLWlmLWFjY2VwdGVkLnBocApAQCAtMiw2ICsyLDcgQEAKIGlm IChzdHJwb3MoJF9TRVJWRVJbJ0hUVFBfQUNDRVBUJ10sICd2aWRlby8qJykgIT09IGZhbHNlKSB7 CiAgICAgaGVhZGVyKCdIVFRQLzEuMSAzMDEgTW92ZWQgUGVybWFuZW50bHknKTsKICAgICBoZWFk ZXIoJ0xvY2F0aW9uOiAnIC4gJF9HRVRbJ3ZpZGVvJ10pOworICAgIGhlYWRlcignQ2FjaGUtQ29u dHJvbDogbm8tY2FjaGUsIG11c3QtcmV2YWxpZGF0ZScpOwogICAgIHJldHVybjsKIH0KIApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQ3MTMz ZWJiMzVkZDllOTYyZjA5ZmNlNTUzNTAwMTY2MmM5YzA3NDAuLjJhZjRkMzQ0NDIwMjFlZTJkNWJk NWVmNTczYjFlNTE5MjY0YTQxNmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy13azEvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sx L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTQ4NSw3ICs0ODUsNSBAQCB3ZWJraXQub3JnL2IvMTc5NTAw IGFjY2Vzc2liaWxpdHkvbWFjL0FPTS1yZWxhdGlvbi1wcm9wZXJ0eS5odG1sIFsgU2tpcCBdCiAj IFVzZXItaW5zdGFsbGVkIGZvbnRzIHRlc3QgaW5mcmFzdHJ1Y3R1cmUgaXMgbm90IHByZXNlbnQg aW4gV0sxCiB3ZWJraXQub3JnL2IvMTgwMDYyIGZhc3QvdGV4dC91c2VyLWluc3RhbGxlZC1mb250 cyBbIEltYWdlT25seUZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTgxMDA4IGh0dHAvdGVzdHMv aW1hZ2VzL2ltYWdlLXN1cHBvcnRzLXZpZGVvLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCiB3ZWJr aXQub3JnL2IvMTgwOTk3IHN2Zy9hbmltYXRpb25zL3NtaWwtbGVhay1lbGVtZW50LWluc3RhbmNl cy1ub0Jhc2VWYWxSZWYuc3ZnIFsgUGFzcyBGYWlsdXJlIF0KIAo=