181005 2017-12-19 15:41:03 -0800 Web Inspector: add TestPage.debug() to inspect evaluations being sent to Inspector page 2018-01-04 12:38:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes jlewis3 joepeck webkit-bug-importer oldest_to_newest 1383371 0 bburg 2017-12-19 15:41:03 -0800 I used this once and I liked it. 1383373 1 329842 bburg 2017-12-19 15:42:51 -0800 Created attachment 329842 Patch 1383375 2 329842 joepeck 2017-12-19 15:44:23 -0800 Comment on attachment 329842 Patch rs=me 1383397 3 329842 commit-queue 2017-12-19 16:06:47 -0800 Comment on attachment 329842 Patch Clearing flags on attachment: 329842 Committed r226155: <https://trac.webkit.org/changeset/226155> 1383398 4 commit-queue 2017-12-19 16:06:49 -0800 All reviewed patches have been landed. Closing bug. 1383399 5 webkit-bug-importer 2017-12-19 16:07:20 -0800 <rdar://problem/36143853> 1383893 6 jlewis3 2017-12-20 16:43:47 -0800 This patch has caused a layout test to start failing consistently on macOS WK2 Debug testers: Test: http/tests/inspector/network/har/har-page.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html build: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r226199%20(1886)/results.html diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt @@ -87,7 +87,7 @@ "size": 0, "compression": 0, "mimeType": "application/x-javascript", - "text": "<filtered text (6707)>" + "text": "<filtered text (7039)>" }, "redirectURL": "", "headersSize": "<filtered>", 1383947 7 jlewis3 2017-12-20 17:49:05 -0800 Reverted r226155 for reason: This caused test failures. Committed r226207: <https://trac.webkit.org/changeset/226207> 1383970 8 joepeck 2017-12-20 18:23:11 -0800 All that was needed was a rebase... 1385889 9 bburg 2018-01-04 12:38:11 -0800 Committed r226414: <https://trac.webkit.org/changeset/226414> 329842 2017-12-19 15:42:51 -0800 2017-12-19 16:06:47 -0800 Patch bug-181005-20171219154251.patch text/plain 2925 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1OTc0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWFhZGJmZmNmNzM2NDkxNWI3M2Nk OTM5YzRjOTY3YjEwMzY5ODIxOC4uNDA4NmFlMzk3YTc3Y2E4NjkxYWM2MWMyN2NkOWU1NGJiYzA1 ZGY0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEyLTE5ICBCcmlhbiBCdXJnICA8YmJ1 cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFkZCBUZXN0UGFnZS5kZWJ1 ZygpIHRvIGluc3BlY3QgZXZhbHVhdGlvbnMgYmVpbmcgc2VudCB0byBJbnNwZWN0b3IgcGFnZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMDA1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBUZXN0 UGFnZS5kZWJ1ZygpIGlzIGNhbGxlZCwgZHVtcCBvdXQgYWxsIGNvZGUgdGhhdCBpcyBzZW50IHRv IGJlIGV2YWx1YXRlZCBpbgorICAgICAgICB0aGUgaW5zcGVjdG9yIHBhZ2UuIFRoaXMgaXMgdXNl ZnVsIGZvciBkZWJ1Z2dpbmcgaW5pdGlhbGl6YXRpb24gYW5kIEluc3BlY3RvclRlc3QuYXdhaXRF dmVudC4KKworICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlcy9pbnNwZWN0 b3ItdGVzdC5qczoKKyAgICAgICAgKHJ1blRlc3QpOgorICAgICAgICAoVGVzdFBhZ2UuZGVidWcp OgorICAgICAgICAoVGVzdFBhZ2UuZXZhbHVhdGVJbldlYkluc3BlY3Rvcik6CisgICAgICAgIChU ZXN0UGFnZS5kaXNwYXRjaEV2ZW50VG9Gcm9udGVuZCk6CisKIDIwMTctMTItMTggIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5zcGVjdG9y VGVzdC5ldmFsdWF0ZUluUGFnZSBzaG91bGQgcmV0dXJuIGEgcmVqZWN0aW9uIGlmIGFuIGVycm9y IHdhcyB0aHJvd24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L3Jlc291cmNlcy9pbnNwZWN0b3ItdGVzdC5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5z cGVjdG9yL3Jlc291cmNlcy9pbnNwZWN0b3ItdGVzdC5qcwppbmRleCA0YjY4MmNkOTE1OTE5MmVl NDYxZmIyNzkxMmUxZWFmNzJlZjI3NmMxLi41OTY1MTIwNTY3OGIzNzg4MDhkMjczODI0MDViOTNh ODY0OWM1ZjM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9y ZXNvdXJjZXMvaW5zcGVjdG9yLXRlc3QuanMKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9p bnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzCkBAIC05Nyw4ICs5Nyw4IEBAIGZ1 bmN0aW9uIHJ1blRlc3QoKQogICAgIGxldCBpbml0aWFsaXphdGlvbkNvZGVTdHJpbmcgPSBgKCR7 cnVuSW5pdGlhbGl6YXRpb25NZXRob2RzSW5Gcm9udGVuZC50b1N0cmluZygpfSkoWyR7VGVzdFBh Z2UuX2luaXRpYWxpemVyc31dKTtgOwogICAgIGxldCB0ZXN0RnVuY3Rpb25Db2RlU3RyaW5nID0g YCgke3J1blRlc3RNZXRob2RJbkZyb250ZW5kLnRvU3RyaW5nKCl9KSgke3Rlc3RGdW5jdGlvbi50 b1N0cmluZygpfSk7YDsKIAotICAgIHRlc3RSdW5uZXIuZXZhbHVhdGVJbldlYkluc3BlY3Rvcihp bml0aWFsaXphdGlvbkNvZGVTdHJpbmcpOwotICAgIHRlc3RSdW5uZXIuZXZhbHVhdGVJbldlYklu c3BlY3Rvcih0ZXN0RnVuY3Rpb25Db2RlU3RyaW5nKTsKKyAgICBUZXN0UGFnZS5ldmFsdWF0ZUlu V2ViSW5zcGVjdG9yKGluaXRpYWxpemF0aW9uQ29kZVN0cmluZyk7CisgICAgVGVzdFBhZ2UuZXZh bHVhdGVJbldlYkluc3BlY3Rvcih0ZXN0RnVuY3Rpb25Db2RlU3RyaW5nKTsKIH0KIAogZnVuY3Rp b24gcnVuVGVzdEhUVFBTKCkKQEAgLTEzOSw2ICsxMzksMjAgQEAgVGVzdFBhZ2UuZGVidWdMb2cg PSBmdW5jdGlvbihtZXNzYWdlKQogICAgIHdpbmRvdy5hbGVydChtZXNzYWdlKTsKIH0KIAorLy8g VXNlIHRoaXMgdG8gZHVtcCBldmFsdWF0aW9ucyB0aGF0IGFyZSBzZW50IGZyb20gdGhlIFRlc3RQ YWdlIHRvIHRoZSBJbnNwZWN0b3JUZXN0IHBhZ2UuCitUZXN0UGFnZS5kZWJ1ZyA9IGZ1bmN0aW9u KCkKK3sKKyAgICB0aGlzLmR1bXBJbnNwZWN0b3JQYWdlRXZhbHVhdGlvbnMgPSB0cnVlOworfQor CitUZXN0UGFnZS5ldmFsdWF0ZUluV2ViSW5zcGVjdG9yID0gZnVuY3Rpb24oY29kZSkKK3sKKyAg ICBpZiAodGhpcy5kdW1wSW5zcGVjdG9yUGFnZUV2YWx1YXRpb25zKQorICAgICAgICB0aGlzLmRl YnVnTG9nKGNvZGUpOworCisgICAgdGVzdFJ1bm5lci5ldmFsdWF0ZUluV2ViSW5zcGVjdG9yKGNv ZGUpOworfQorCiAvLyBBZGQgYW5kIGNsZWFyIHRlc3Qgb3V0cHV0IGZyb20gdGhlIHJlc3VsdHMg d2luZG93LgogVGVzdFBhZ2UuYWRkUmVzdWx0ID0gZnVuY3Rpb24odGV4dCkKIHsKQEAgLTE2Miw3 ICsxNzYsNyBAQCBUZXN0UGFnZS5sb2cgPSBUZXN0UGFnZS5hZGRSZXN1bHQ7CiBUZXN0UGFnZS5k aXNwYXRjaEV2ZW50VG9Gcm9udGVuZCA9IGZ1bmN0aW9uKGV2ZW50TmFtZSwgZGF0YSkKIHsKICAg ICBsZXQgZGlzcGF0Y2hFdmVudENvZGVTdHJpbmcgPSBgSW5zcGVjdG9yVGVzdC5kaXNwYXRjaEV2 ZW50VG9MaXN0ZW5lcnMoJHtKU09OLnN0cmluZ2lmeShldmVudE5hbWUpfSwgJHtKU09OLnN0cmlu Z2lmeShkYXRhKX0pO2A7Ci0gICAgdGVzdFJ1bm5lci5ldmFsdWF0ZUluV2ViSW5zcGVjdG9yKGRp c3BhdGNoRXZlbnRDb2RlU3RyaW5nKTsKKyAgICB0aGlzLmV2YWx1YXRlSW5XZWJJbnNwZWN0b3Io ZGlzcGF0Y2hFdmVudENvZGVTdHJpbmcpOwogfTsKIAogVGVzdFBhZ2UuYWxsb3dVbmNhdWdodEV4 Y2VwdGlvbnMgPSBmYWxzZTsK