180998 2017-12-19 14:09:09 -0800 Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration 2017-12-19 15:40:42 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1383297 0 joepeck 2017-12-19 14:09:09 -0800 Network Table - Update the Time column to include the total duration not just the download duration It was confusing to have the "Time" not match the popover. Previously it was just the download duration, which excluded the queueing / connection time, which can grow large. Just make this the total time. 1383300 1 webkit-bug-importer 2017-12-19 14:10:14 -0800 <rdar://problem/36140424> 1383306 2 329822 joepeck 2017-12-19 14:16:59 -0800 Created attachment 329822 [PATCH] Proposed Fix 1383364 3 329822 mattbaker 2017-12-19 15:21:22 -0800 Comment on attachment 329822 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329822&action=review r=me, with a comment. > Source/WebInspectorUI/UserInterface/Models/Resource.js:545 > + get downloadDuration() Are there plans to use `downloadDuration` in the very near future? If not let's remove it. I think `totalDuration` makes sense as a name event with out, since we have a `receiveDuration`. 1383366 4 joepeck 2017-12-19 15:31:09 -0800 (In reply to Matt Baker from comment #3) > Comment on attachment 329822 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329822&action=review > > r=me, with a comment. > > > Source/WebInspectorUI/UserInterface/Models/Resource.js:545 > > + get downloadDuration() > > Are there plans to use `downloadDuration` in the very near future? If not > let's remove it. I think `totalDuration` makes sense as a name event with > out, since we have a `receiveDuration`. Okay, I'll remove it. 1383370 5 joepeck 2017-12-19 15:40:42 -0800 <https://trac.webkit.org/r226151> 329822 2017-12-19 14:16:59 -0800 2017-12-19 15:39:24 -0800 [PATCH] Proposed Fix time-1.patch text/plain 4491 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZjOWYyZjYzMzdlLi5iNzY4MGE2NWM4MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTctMTItMTkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBOZXR3b3JrIFRhYmxlIC0gVXBkYXRlIHRoZSBUaW1lIGNvbHVtbiB0byBpbmNsdWRlIHRoZSB0 b3RhbCBkdXJhdGlvbiBub3QganVzdCB0aGUgZG93bmxvYWQgZHVyYXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDk5OAorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzYxNDA0MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qczoKKyAgICAg ICAgKFdJLlJlc291cmNlLnByb3RvdHlwZS5nZXQgZG93bmxvYWREdXJhdGlvbik6CisgICAgICAg IChXSS5SZXNvdXJjZS5wcm90b3R5cGUuZ2V0IHRvdGFsRHVyYXRpb24pOgorICAgICAgICAoV0ku UmVzb3VyY2UucHJvdG90eXBlLmdldCBkdXJhdGlvbik6IERlbGV0ZWQuCisgICAgICAgIFJlbmFt ZSBhbmQgZ3JvdXAgZ2V0dGVycyB0byBiZSBjbGVhcmVyLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5ldHdv cmtUYWJsZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fZW50cnlGb3JSZXNvdXJjZSk6CisgICAgICAg IFVzZSB0aGUgdG90YWxEdXJhdGlvbiBmb3IgdGhlIG5ldHdvcmsgdGFibGUgdGltZSBjb2x1bW4u CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVGltZWxpbmVEYXRhR3Jp ZE5vZGUuanM6CisgICAgICAgIChXSS5SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWROb2RlLnByb3Rv dHlwZS5fbW91c2VvdmVyUmVjb3JkQmFyIGdyYXBoRGF0YVNvdXJjZS5nZXQgc2Vjb25kc1BlclBp eGVsKToKKyAgICAgICAgVXNpbmcgdGhlIGRvd25sb2FkRHVyYXRpb24gc2VlbXMgaW5jb3JyZWN0 IGhlcmUuCisKIDIwMTctMTItMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3JrIFRhYmxlIC0gUmVkZXNpZ24gdGhl IHdhdGVyZmFsbCBwb3BvdmVyIHNob3dpbmcgdGltaW5nIGRhdGEKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcwppbmRleCBk NDI5MGJmMTQ4MS4uZWZiODczMGZiOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMKQEAgLTUzMiwxMSArNTMyLDYg QEAgV0kuUmVzb3VyY2UgPSBjbGFzcyBSZXNvdXJjZSBleHRlbmRzIFdJLlNvdXJjZUNvZGUKICAg ICAgICAgcmV0dXJuIHRoaXMudGltaW5nRGF0YS5yZXNwb25zZUVuZCB8fCB0aGlzLmxhc3REYXRh UmVjZWl2ZWRUaW1lc3RhbXAgfHwgdGhpcy5yZXNwb25zZVJlY2VpdmVkVGltZXN0YW1wIHx8IHRo aXMubGFzdFJlZGlyZWN0UmVjZWl2ZWRUaW1lc3RhbXAgfHwgdGhpcy5yZXF1ZXN0U2VudFRpbWVz dGFtcDsKICAgICB9CiAKLSAgICBnZXQgZHVyYXRpb24oKQotICAgIHsKLSAgICAgICAgcmV0dXJu IHRoaXMudGltaW5nRGF0YS5yZXNwb25zZUVuZCAtIHRoaXMudGltaW5nRGF0YS5yZXF1ZXN0U3Rh cnQ7Ci0gICAgfQotCiAgICAgZ2V0IGxhdGVuY3koKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRo aXMudGltaW5nRGF0YS5yZXNwb25zZVN0YXJ0IC0gdGhpcy50aW1pbmdEYXRhLnJlcXVlc3RTdGFy dDsKQEAgLTU0Nyw2ICs1NDIsMTYgQEAgV0kuUmVzb3VyY2UgPSBjbGFzcyBSZXNvdXJjZSBleHRl bmRzIFdJLlNvdXJjZUNvZGUKICAgICAgICAgcmV0dXJuIHRoaXMudGltaW5nRGF0YS5yZXNwb25z ZUVuZCAtIHRoaXMudGltaW5nRGF0YS5yZXNwb25zZVN0YXJ0OwogICAgIH0KIAorICAgIGdldCBk b3dubG9hZER1cmF0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLnRpbWluZ0RhdGEu cmVzcG9uc2VFbmQgLSB0aGlzLnRpbWluZ0RhdGEucmVxdWVzdFN0YXJ0OworICAgIH0KKworICAg IGdldCB0b3RhbER1cmF0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLnRpbWluZ0Rh dGEucmVzcG9uc2VFbmQgLSB0aGlzLnRpbWluZ0RhdGEuc3RhcnRUaW1lOworICAgIH0KKwogICAg IGdldCBjYWNoZWQoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRoaXMuX2NhY2hlZDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtU YWJsZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggMmQ3OGNmZWJjYWUuLjg3N2Vi MGI5NmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwpAQCAtMTE5 Niw3ICsxMTk2LDcgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3Jr VGFibGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAgICAgIGNhY2hl ZDogcmVzb3VyY2UuY2FjaGVkLAogICAgICAgICAgICAgcmVzb3VyY2VTaXplOiByZXNvdXJjZS5z aXplLAogICAgICAgICAgICAgdHJhbnNmZXJTaXplOiAhaXNOYU4ocmVzb3VyY2UubmV0d29ya1Rv dGFsVHJhbnNmZXJTaXplKSA/IHJlc291cmNlLm5ldHdvcmtUb3RhbFRyYW5zZmVyU2l6ZSA6IHJl c291cmNlLmVzdGltYXRlZFRvdGFsVHJhbnNmZXJTaXplLAotICAgICAgICAgICAgdGltZTogcmVz b3VyY2UuZHVyYXRpb24sCisgICAgICAgICAgICB0aW1lOiByZXNvdXJjZS50b3RhbER1cmF0aW9u LAogICAgICAgICAgICAgcHJvdG9jb2w6IHJlc291cmNlLnByb3RvY29sLAogICAgICAgICAgICAg cHJpb3JpdHk6IHJlc291cmNlLnByaW9yaXR5LAogICAgICAgICAgICAgcmVtb3RlQWRkcmVzczog cmVzb3VyY2UucmVtb3RlQWRkcmVzcywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRpbWVsaW5l RGF0YUdyaWROb2RlLmpzCmluZGV4IDhjNmI2YTIwYjQ0Li45YjQ2NWY0ZDRmNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VUaW1l bGluZURhdGFHcmlkTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWROb2RlLmpzCkBAIC0zODQsNyArMzg0 LDcgQEAgV0kuUmVzb3VyY2VUaW1lbGluZURhdGFHcmlkTm9kZSA9IGNsYXNzIFJlc291cmNlVGlt ZWxpbmVEYXRhR3JpZE5vZGUgZXh0ZW5kcyBXSS4KICAgICAgICAgICAgIHBvcG92ZXJDb250ZW50 RWxlbWVudC5hcHBlbmRDaGlsZChwb3BvdmVyRGF0YUdyaWQuZWxlbWVudCk7CiAKICAgICAgICAg ICAgIGxldCBncmFwaERhdGFTb3VyY2UgPSB7Ci0gICAgICAgICAgICAgICAgZ2V0IHNlY29uZHNQ ZXJQaXhlbCgpIHsgcmV0dXJuIHJlc291cmNlLmR1cmF0aW9uIC8gV0kuUmVzb3VyY2VUaW1lbGlu ZURhdGFHcmlkTm9kZS5Qb3BvdmVyR3JhcGhDb2x1bW5XaWR0aFBpeGVsczsgfSwKKyAgICAgICAg ICAgICAgICBnZXQgc2Vjb25kc1BlclBpeGVsKCkgeyByZXR1cm4gcmVzb3VyY2UudG90YWxEdXJh dGlvbiAvIFdJLlJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuUG9wb3ZlckdyYXBoQ29sdW1u V2lkdGhQaXhlbHM7IH0sCiAgICAgICAgICAgICAgICAgZ2V0IHplcm9UaW1lKCkgeyByZXR1cm4g cmVzb3VyY2UuZmlyc3RUaW1lc3RhbXA7IH0sCiAgICAgICAgICAgICAgICAgZ2V0IHN0YXJ0VGlt ZSgpIHsgcmV0dXJuIHJlc291cmNlLmZpcnN0VGltZXN0YW1wOyB9LAogICAgICAgICAgICAgICAg IGdldCBjdXJyZW50VGltZSgpIHsgcmV0dXJuIHRoaXMuZW5kVGltZTsgfSwK