180994 2017-12-19 13:23:56 -0800 [RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from RenderTableSection::addChild to RenderTreeBuilder 2017-12-19 14:15:24 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1383254 0 zalan 2017-12-19 13:23:56 -0800 ssia. 1383256 1 webkit-bug-importer 2017-12-19 13:24:56 -0800 <rdar://problem/36139222> 1383258 2 329804 zalan 2017-12-19 13:26:23 -0800 Created attachment 329804 Patch 1383302 3 329804 commit-queue 2017-12-19 14:15:22 -0800 Comment on attachment 329804 Patch Clearing flags on attachment: 329804 Committed r226140: <https://trac.webkit.org/changeset/226140> 1383303 4 commit-queue 2017-12-19 14:15:24 -0800 All reviewed patches have been landed. Closing bug. 329804 2017-12-19 13:26:23 -0800 2017-12-19 14:15:22 -0800 Patch bug-180994-20171219132623.patch text/plain 7403 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQzODgwZjlkYWVjOThk YjE4NDM0MmJlY2ZjMjUxODkwN2IwNzdjYy4uNDNlMGZmZTA0MTViMTdmYTk5MTM3NGUyNzVjY2Q1 NjNlZDgzODViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEyLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBNb3ZlIGZpbmRpbmctdGhlLXBhcmVudC9jcmVhdGluZy13cmFwcGVyIGxvZ2ljIGZyb20gUmVu ZGVyVGFibGVTZWN0aW9uOjphZGRDaGlsZCB0byBSZW5kZXJUcmVlQnVpbGRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwOTk0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNjEzOTIyMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIGluIHByZXBhcmF0aW9uIGZvciByZW1vdmluZyBhbGwg dHJlZSBtdXRhdGlvbiBmcm9tIHJlbmRlcmVyaW5nIGNvZGUuCisKKyAgICAgICAgQ292ZXJlZCBi eSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVTZWN0aW9uOjphZGRDaGlsZCk6 CisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRyZWVCdWlsZGVyOjppbnNlcnRDaGlsZCk6CisgICAgICAg ICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyVGFibGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVHJlZUJ1aWxkZXI6OlRhYmxlOjpmaW5kT3JDcmVhdGVQYXJlbnRG b3JDaGlsZCk6CisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVy VGFibGUuaDoKKwogMjAxNy0xMi0xOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtSZW5kZXJUcmVlQnVpbGRlcl0gTW92ZSBmaW5kaW5nLXRoZS1wYXJlbnQvY3Jl YXRpbmctd3JhcHBlciBsb2dpYyBmcm9tIFJlbmRlclRhYmxlUm93OjphZGRDaGlsZCB0byBSZW5k ZXJUcmVlQnVpbGRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlU2VjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVT ZWN0aW9uLmNwcAppbmRleCAzYTQ2NWY4Y2JjODA0YjM0NGYyNmNkYWJlMjlmODRkMDI1ZDRiYTI0 Li5mZTJiOTA0ZGJlZTM1MTMwYjIzZGZkY2E3MjNkNzZlZTg3MDhiNmE1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcApAQCAtMTIzLDQzICsx MjMsNiBAQCB2b2lkIFJlbmRlclRhYmxlU2VjdGlvbjo6d2lsbEJlUmVtb3ZlZEZyb21UcmVlKCkK IAogdm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OmFkZENoaWxkKFJlbmRlclRyZWVCdWlsZGVyJiBi dWlsZGVyLCBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBjaGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZv cmVDaGlsZCkKIHsKLSAgICBpZiAoIWlzPFJlbmRlclRhYmxlUm93PigqY2hpbGQpKSB7Ci0gICAg ICAgIFJlbmRlck9iamVjdCogbGFzdCA9IGJlZm9yZUNoaWxkOwotICAgICAgICBpZiAoIWxhc3Qp Ci0gICAgICAgICAgICBsYXN0ID0gbGFzdFJvdygpOwotICAgICAgICBpZiAoaXM8UmVuZGVyVGFi bGVSb3c+KGxhc3QpICYmIGxhc3QtPmlzQW5vbnltb3VzKCkgJiYgIWxhc3QtPmlzQmVmb3JlT3JB ZnRlckNvbnRlbnQoKSkgewotICAgICAgICAgICAgUmVuZGVyVGFibGVSb3cmIHJvdyA9IGRvd25j YXN0PFJlbmRlclRhYmxlUm93PigqbGFzdCk7Ci0gICAgICAgICAgICBpZiAoYmVmb3JlQ2hpbGQg PT0gJnJvdykKLSAgICAgICAgICAgICAgICBiZWZvcmVDaGlsZCA9IHJvdy5maXJzdENlbGwoKTsK LSAgICAgICAgICAgIGJ1aWxkZXIuaW5zZXJ0Q2hpbGQocm93LCBXVEZNb3ZlKGNoaWxkKSwgYmVm b3JlQ2hpbGQpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0KLSAgICAgICAgaWYg KGJlZm9yZUNoaWxkICYmICFiZWZvcmVDaGlsZC0+aXNBbm9ueW1vdXMoKSAmJiBiZWZvcmVDaGls ZC0+cGFyZW50KCkgPT0gdGhpcykgewotICAgICAgICAgICAgUmVuZGVyT2JqZWN0KiByb3cgPSBi ZWZvcmVDaGlsZC0+cHJldmlvdXNTaWJsaW5nKCk7Ci0gICAgICAgICAgICBpZiAoaXM8UmVuZGVy VGFibGVSb3c+KHJvdykgJiYgcm93LT5pc0Fub255bW91cygpKSB7Ci0gICAgICAgICAgICAgICAg YnVpbGRlci5pbnNlcnRDaGlsZChkb3duY2FzdDxSZW5kZXJUYWJsZVJvdz4oKnJvdyksIFdURk1v dmUoY2hpbGQpKTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9Ci0gICAg ICAgIH0KLQotICAgICAgICAvLyBJZiBiZWZvcmVDaGlsZCBpcyBpbnNpZGUgYW4gYW5vbnltb3Vz IGNlbGwvcm93LCBpbnNlcnQgaW50byB0aGUgY2VsbCBvciBpbnRvCi0gICAgICAgIC8vIHRoZSBh bm9ueW1vdXMgcm93IGNvbnRhaW5pbmcgaXQsIGlmIHRoZXJlIGlzIG9uZS4KLSAgICAgICAgUmVu ZGVyT2JqZWN0KiBsYXN0Qm94ID0gbGFzdDsKLSAgICAgICAgd2hpbGUgKGxhc3RCb3ggJiYgbGFz dEJveC0+cGFyZW50KCktPmlzQW5vbnltb3VzKCkgJiYgIWlzPFJlbmRlclRhYmxlUm93PigqbGFz dEJveCkpCi0gICAgICAgICAgICBsYXN0Qm94ID0gbGFzdEJveC0+cGFyZW50KCk7Ci0gICAgICAg IGlmIChpczxSZW5kZXJUYWJsZVJvdz4obGFzdEJveCkgJiYgbGFzdEJveC0+aXNBbm9ueW1vdXMo KSAmJiAhbGFzdEJveC0+aXNCZWZvcmVPckFmdGVyQ29udGVudCgpKSB7Ci0gICAgICAgICAgICBi dWlsZGVyLmluc2VydENoaWxkKGRvd25jYXN0PFJlbmRlclRhYmxlUm93PigqbGFzdEJveCksIFdU Rk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAg IH0KLQotICAgICAgICBhdXRvIG5ld1JvdyA9IFJlbmRlclRhYmxlUm93OjpjcmVhdGVBbm9ueW1v dXNXaXRoUGFyZW50UmVuZGVyZXIoKnRoaXMpOwotICAgICAgICBhdXRvJiByb3cgPSAqbmV3Um93 OwotICAgICAgICBidWlsZGVyLmluc2VydENoaWxkKCp0aGlzLCBXVEZNb3ZlKG5ld1JvdyksIGJl Zm9yZUNoaWxkKTsKLSAgICAgICAgYnVpbGRlci5pbnNlcnRDaGlsZChyb3csIFdURk1vdmUoY2hp bGQpKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIGlmIChiZWZvcmVDaGlsZCkKICAg ICAgICAgc2V0TmVlZHNDZWxsUmVjYWxjKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCmluZGV4IGQ1ZGQyODFj MzczNDM4NjZhOThhOGQwYjBkMWIyYWY4MTU5M2UwNzEuLmUxODQyZDgxNDJlMDZhY2IzMjhkNjRj YTg2NjI4ZmI0Mjc4ODU2YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91 cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcApAQCAtNjcsNiArNjcsMTYgQEAgdm9p ZCBSZW5kZXJUcmVlQnVpbGRlcjo6aW5zZXJ0Q2hpbGQoUmVuZGVyRWxlbWVudCYgcGFyZW50LCBS ZW5kZXJQdHI8UmVuZGVyT2JqZWMKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChp czxSZW5kZXJUYWJsZVNlY3Rpb24+KHBhcmVudCkpIHsKKyAgICAgICAgYXV0byYgcGFyZW50Q2Fu ZGlkYXRlID0gbV90YWJsZUJ1aWxkZXItPmZpbmRPckNyZWF0ZVBhcmVudEZvckNoaWxkKGRvd25j YXN0PFJlbmRlclRhYmxlU2VjdGlvbj4ocGFyZW50KSwgKmNoaWxkLCBiZWZvcmVDaGlsZCk7Cisg ICAgICAgIGlmICgmcGFyZW50ICE9ICZwYXJlbnRDYW5kaWRhdGUpIHsKKyAgICAgICAgICAgIGlu c2VydENoaWxkKHBhcmVudENhbmRpZGF0ZSwgV1RGTW92ZShjaGlsZCksIGJlZm9yZUNoaWxkKTsK KyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICBwYXJlbnQuYWRkQ2hpbGQo KnRoaXMsIFdURk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CisgICAgICAgIHJldHVybjsKKyAg ICB9CisKICAgICBpZiAoaXM8UmVuZGVyUnVieVJ1bj4ocGFyZW50KSkgewogICAgICAgICBydWJ5 UnVuSW5zZXJ0Q2hpbGQoZG93bmNhc3Q8UmVuZGVyUnVieVJ1bj4ocGFyZW50KSwgV1RGTW92ZShj aGlsZCksIGJlZm9yZUNoaWxkKTsKICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyVGFibGUuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyVGFibGUu Y3BwCmluZGV4IGQ3OWZmZmZlNjZkODNhYTdjNWFhYmIxNGY4NDhhYzNmMDk5YjQ0MmIuLjYwYThk YjQwYjU1ZmNkNWViMmJiYzM2NDAzNzc4M2MyMmE3Mzg0OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlclRhYmxlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJUYWJs ZS5jcHAKQEAgLTgyLDQgKzgyLDM5IEBAIFJlbmRlckVsZW1lbnQmIFJlbmRlclRyZWVCdWlsZGVy OjpUYWJsZTo6ZmluZE9yQ3JlYXRlUGFyZW50Rm9yQ2hpbGQoUmVuZGVyVGFibGVSCiAgICAgcmV0 dXJuIGNlbGw7CiB9CiAKK1JlbmRlckVsZW1lbnQmIFJlbmRlclRyZWVCdWlsZGVyOjpUYWJsZTo6 ZmluZE9yQ3JlYXRlUGFyZW50Rm9yQ2hpbGQoUmVuZGVyVGFibGVTZWN0aW9uJiBwYXJlbnQsIGNv bnN0IFJlbmRlck9iamVjdCYgY2hpbGQsIFJlbmRlck9iamVjdComIGJlZm9yZUNoaWxkKQorewor ICAgIGlmIChpczxSZW5kZXJUYWJsZVJvdz4oY2hpbGQpKQorICAgICAgICByZXR1cm4gcGFyZW50 OworCisgICAgYXV0byogbGFzdENoaWxkID0gYmVmb3JlQ2hpbGQgPyBiZWZvcmVDaGlsZCA6IHBh cmVudC5sYXN0Um93KCk7CisgICAgaWYgKGlzPFJlbmRlclRhYmxlUm93PihsYXN0Q2hpbGQpICYm IGxhc3RDaGlsZC0+aXNBbm9ueW1vdXMoKSAmJiAhbGFzdENoaWxkLT5pc0JlZm9yZU9yQWZ0ZXJD b250ZW50KCkpIHsKKyAgICAgICAgaWYgKGJlZm9yZUNoaWxkID09IGxhc3RDaGlsZCkKKyAgICAg ICAgICAgIGJlZm9yZUNoaWxkID0gZG93bmNhc3Q8UmVuZGVyVGFibGVSb3c+KCpsYXN0Q2hpbGQp LmZpcnN0Q2VsbCgpOworICAgICAgICByZXR1cm4gZG93bmNhc3Q8UmVuZGVyRWxlbWVudD4oKmxh c3RDaGlsZCk7CisgICAgfQorCisgICAgaWYgKGJlZm9yZUNoaWxkICYmICFiZWZvcmVDaGlsZC0+ aXNBbm9ueW1vdXMoKSAmJiBiZWZvcmVDaGlsZC0+cGFyZW50KCkgPT0gJnBhcmVudCkgeworICAg ICAgICBhdXRvKiByb3cgPSBiZWZvcmVDaGlsZC0+cHJldmlvdXNTaWJsaW5nKCk7CisgICAgICAg IGlmIChpczxSZW5kZXJUYWJsZVJvdz4ocm93KSAmJiByb3ctPmlzQW5vbnltb3VzKCkpIHsKKyAg ICAgICAgICAgIGJlZm9yZUNoaWxkID0gbnVsbHB0cjsKKyAgICAgICAgICAgIHJldHVybiBkb3du Y2FzdDxSZW5kZXJFbGVtZW50Pigqcm93KTsKKyAgICAgICAgfQorICAgIH0KKworICAgIC8vIElm IGJlZm9yZUNoaWxkIGlzIGluc2lkZSBhbiBhbm9ueW1vdXMgY2VsbC9yb3csIGluc2VydCBpbnRv IHRoZSBjZWxsIG9yIGludG8KKyAgICAvLyB0aGUgYW5vbnltb3VzIHJvdyBjb250YWluaW5nIGl0 LCBpZiB0aGVyZSBpcyBvbmUuCisgICAgYXV0byogcGFyZW50Q2FuZGlkYXRlID0gbGFzdENoaWxk OworICAgIHdoaWxlIChwYXJlbnRDYW5kaWRhdGUgJiYgcGFyZW50Q2FuZGlkYXRlLT5wYXJlbnQo KS0+aXNBbm9ueW1vdXMoKSAmJiAhaXM8UmVuZGVyVGFibGVSb3c+KCpwYXJlbnRDYW5kaWRhdGUp KQorICAgICAgICBwYXJlbnRDYW5kaWRhdGUgPSBwYXJlbnRDYW5kaWRhdGUtPnBhcmVudCgpOwor ICAgIGlmIChpczxSZW5kZXJUYWJsZVJvdz4ocGFyZW50Q2FuZGlkYXRlKSAmJiBwYXJlbnRDYW5k aWRhdGUtPmlzQW5vbnltb3VzKCkgJiYgIXBhcmVudENhbmRpZGF0ZS0+aXNCZWZvcmVPckFmdGVy Q29udGVudCgpKQorICAgICAgICByZXR1cm4gZG93bmNhc3Q8UmVuZGVyRWxlbWVudD4oKnBhcmVu dENhbmRpZGF0ZSk7CisKKyAgICBhdXRvIG5ld1JvdyA9IFJlbmRlclRhYmxlUm93OjpjcmVhdGVB bm9ueW1vdXNXaXRoUGFyZW50UmVuZGVyZXIocGFyZW50KTsKKyAgICBhdXRvJiByb3cgPSAqbmV3 Um93OworICAgIG1fYnVpbGRlci5pbnNlcnRDaGlsZChwYXJlbnQsIFdURk1vdmUobmV3Um93KSwg YmVmb3JlQ2hpbGQpOworICAgIGJlZm9yZUNoaWxkID0gbnVsbHB0cjsKKyAgICByZXR1cm4gcm93 OworfQorCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcv UmVuZGVyVHJlZUJ1aWxkZXJUYWJsZS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0 aW5nL1JlbmRlclRyZWVCdWlsZGVyVGFibGUuaAppbmRleCBiM2Y2Y2U2Y2YwZmYwNmQyNDdkMDA2 NjFlZWYxMTMwNjkxMTI4Y2U5Li5kN2M1MDVjODc0ZjZhODZjNjQ2ODg4NjUwMjAzYTFiN2JmYzk1 MWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVy VHJlZUJ1aWxkZXJUYWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGlu Zy9SZW5kZXJUcmVlQnVpbGRlclRhYmxlLmgKQEAgLTM5LDYgKzM5LDcgQEAgcHVibGljOgogICAg IFRhYmxlKFJlbmRlclRyZWVCdWlsZGVyJik7CiAKICAgICBSZW5kZXJFbGVtZW50JiBmaW5kT3JD cmVhdGVQYXJlbnRGb3JDaGlsZChSZW5kZXJUYWJsZVJvdyYgcGFyZW50LCBjb25zdCBSZW5kZXJP YmplY3QmIGNoaWxkLCBSZW5kZXJPYmplY3QqJiBiZWZvcmVDaGlsZCk7CisgICAgUmVuZGVyRWxl bWVudCYgZmluZE9yQ3JlYXRlUGFyZW50Rm9yQ2hpbGQoUmVuZGVyVGFibGVTZWN0aW9uJiBwYXJl bnQsIGNvbnN0IFJlbmRlck9iamVjdCYgY2hpbGQsIFJlbmRlck9iamVjdComIGJlZm9yZUNoaWxk KTsKIAogcHJpdmF0ZToKICAgICBSZW5kZXJUcmVlQnVpbGRlciYgbV9idWlsZGVyOwo=