180987 2017-12-19 12:28:56 -0800 We forgot to do index masking for in bounds int32 arrays in the FTL 2017-12-20 00:25:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff webkit-bug-importer ysuzuki oldest_to_newest 1383224 0 saam 2017-12-19 12:28:56 -0800 .... 1383225 1 329792 saam 2017-12-19 12:29:38 -0800 Created attachment 329792 patch 1383227 2 329792 keith_miller 2017-12-19 12:30:41 -0800 Comment on attachment 329792 patch r=me. 1383280 3 329792 commit-queue 2017-12-19 13:51:30 -0800 Comment on attachment 329792 patch Clearing flags on attachment: 329792 Committed r226139: <https://trac.webkit.org/changeset/226139> 1383281 4 commit-queue 2017-12-19 13:51:32 -0800 All reviewed patches have been landed. Closing bug. 1383282 5 webkit-bug-importer 2017-12-19 13:52:33 -0800 <rdar://problem/36139961> 1383559 6 ysuzuki 2017-12-20 00:25:15 -0800 This introduces 15.4% regression in Octane/crypto. It seems indexing masking cause very large overhead. Can we have a way to alleviate it? 329792 2017-12-19 12:29:38 -0800 2017-12-19 13:51:30 -0800 patch a-backup.diff text/plain 1913 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2MTM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE3LTEyLTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlIGZvcmdvdCB0byBkbyBpbmRleCBtYXNraW5nIGZvciBpbiBib3VuZHMgaW50MzIgYXJyYXlz IGluIHRoZSBGVEwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MDk4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpM b3dlckRGR1RvQjM6OmNvbXBpbGVHZXRCeVZhbCk6CisKIDIwMTctMTItMTkgIFl1c3VrZSBTdXp1 a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0RGR11bRlRMXSBOZXdSZWdl eHAgc2hvdWQgYmUgZmFzdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dl ckRGR1RvQjMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRM TG93ZXJERkdUb0IzLmNwcAkocmV2aXNpb24gMjI2MTM0KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjM4LDkgKzM2 MzgsMTEgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIAogICAgICAgICAgICAgSW5kZXhlZEFic3Ry YWN0SGVhcCYgaGVhcCA9IG1fbm9kZS0+YXJyYXlNb2RlKCkudHlwZSgpID09IEFycmF5OjpJbnQz MiA/CiAgICAgICAgICAgICAgICAgbV9oZWFwcy5pbmRleGVkSW50MzJQcm9wZXJ0aWVzIDogbV9o ZWFwcy5pbmRleGVkQ29udGlndW91c1Byb3BlcnRpZXM7Ci0gICAgICAgICAgICAKKworICAgICAg ICAgICAgTFZhbHVlIGJhc2UgPSBsb3dDZWxsKG1fbm9kZS0+Y2hpbGQxKCkpOworCiAgICAgICAg ICAgICBpZiAobV9ub2RlLT5hcnJheU1vZGUoKS5pc0luQm91bmRzKCkpIHsKLSAgICAgICAgICAg ICAgICBMVmFsdWUgcmVzdWx0ID0gbV9vdXQubG9hZDY0KGJhc2VJbmRleChoZWFwLCBzdG9yYWdl LCBpbmRleCwgbV9ub2RlLT5jaGlsZDIoKSkpOworICAgICAgICAgICAgICAgIExWYWx1ZSByZXN1 bHQgPSBtX291dC5sb2FkNjQobWFza2VkSW5kZXgoaGVhcCwgc3RvcmFnZSwgaW5kZXgsIGJhc2Us IG1fbm9kZS0+Y2hpbGQyKCkpKTsKICAgICAgICAgICAgICAgICBMVmFsdWUgaXNIb2xlID0gbV9v dXQuaXNaZXJvNjQocmVzdWx0KTsKICAgICAgICAgICAgICAgICBpZiAobV9ub2RlLT5hcnJheU1v ZGUoKS5pc1NhbmVDaGFpbigpKSB7CiAgICAgICAgICAgICAgICAgICAgIERGR19BU1NFUlQoCkBA IC0zNjUzLDggKzM2NTUsNiBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgICAgIH0KICAgICAgICAgICAgIAotICAgICAgICAgICAgTFZhbHVlIGJhc2UgPSBsb3dD ZWxsKG1fbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgCiAgICAgICAgICAgICBMQmFzaWNC bG9jayBmYXN0Q2FzZSA9IG1fb3V0Lm5ld0Jsb2NrKCk7CiAgICAgICAgICAgICBMQmFzaWNCbG9j ayBzbG93Q2FzZSA9IG1fb3V0Lm5ld0Jsb2NrKCk7CiAgICAgICAgICAgICBMQmFzaWNCbG9jayBj b250aW51YXRpb24gPSBtX291dC5uZXdCbG9jaygpOwo=