180937 2017-12-18 11:31:57 -0800 Skip slow jsc tests on embedded platforms 2020-03-02 14:05:27 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 guijemont webkit-unassigned aperez clopez commit-queue guijemont lforschler saam webkit-bug-importer oldest_to_newest 1382810 0 guijemont 2017-12-18 11:31:57 -0800 The tests typeProfiler/deltablue-for-of.js and typeProfiler/getter-richards.js take a very long time in the ftl-no-cjit-type-profiler-force-poly-proto on embedded platform, and thus always timeout. They should be skipped on these platforms. 1382815 1 329657 guijemont 2017-12-18 11:38:41 -0800 Created attachment 329657 Patch Patch skipping the tests on all arm and mips architectures. 1383685 2 329657 aperez 2017-12-20 09:29:30 -0800 Comment on attachment 329657 Patch Informally reviewing: r+ This sounds reasonable to me, given that many ARM/MIPS based-devices readily available for development and actually running the tests tend to be SoC targeted to the embedded market which tend to be limited in memory, speed, or both. 1384099 3 329657 commit-queue 2017-12-21 07:44:00 -0800 Comment on attachment 329657 Patch Clearing flags on attachment: 329657 Committed r226222: <https://trac.webkit.org/changeset/226222> 1384100 4 commit-queue 2017-12-21 07:44:02 -0800 All reviewed patches have been landed. Closing bug. 1385213 5 webkit-bug-importer 2018-01-02 12:59:03 -0800 <rdar://problem/36260881> 1385214 6 webkit-bug-importer 2018-01-02 12:59:06 -0800 <rdar://problem/36260882> 1624711 7 329657 saam 2020-03-02 13:23:56 -0800 Comment on attachment 329657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329657&action=review > JSTests/typeProfiler/getter-richards.js:1 > +//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end Sorry for the 2 year old comment, but just for posterity, this test is wrong because it disables this from running on arm64 1624733 8 saam 2020-03-02 14:05:27 -0800 (In reply to Saam Barati from comment #7) > Comment on attachment 329657 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329657&action=review > > > JSTests/typeProfiler/getter-richards.js:1 > > +//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end > > Sorry for the 2 year old comment, but just for posterity, this test is wrong > because it disables this from running on arm64 "2 year old comment" => "comment on 2 year old patch" 329657 2017-12-18 11:38:41 -0800 2017-12-21 07:44:00 -0800 Patch bug-180937-20171218133840.patch text/plain 2190 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDY1CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE4ODNlMzkzNTEwMjkzOWJjYWM3Mjc2Y2UxNjg5 YjNhYzAyYTNjN2UuLjU4YzhlZGIyNmIwYTA0NDEyYzYxZWE5NDMyYmI1MTI4ZjM4YTE4ZmQgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMjAgQEAKIDIwMTctMTItMTggIEd1aWxsYXVtZSBFbW9udCAgPGd1aWplbW9udEBpZ2Fs aWEuY29tPgogCisgICAgICAgIFNraXAgc2xvdyBqc2MgdGVzdHMgb24gZW1iZWRkZWQgcGxhdGZv cm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA5 MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg dGVzdHMgdHlwZVByb2ZpbGVyL2RlbHRhYmx1ZS1mb3Itb2YuanMgYW5kCisgICAgICAgIHR5cGVQ cm9maWxlci9nZXR0ZXItcmljaGFyZHMuanMgdGFrZSBhIHZlcnkgbG9uZyB0aW1lIGluIHRoZQor ICAgICAgICBmdGwtbm8tY2ppdC10eXBlLXByb2ZpbGVyLWZvcmNlLXBvbHktcHJvdG8gb24gZW1i ZWRkZWQgcGxhdGZvcm0sIGFuZAorICAgICAgICB0aHVzIGFsd2F5cyB0aW1lb3V0LiBUaGV5IHNo b3VsZCBiZSBza2lwcGVkIG9uIHRoZXNlIHBsYXRmb3Jtcy4KKworICAgICAgICAqIHR5cGVQcm9m aWxlci9kZWx0YWJsdWUtZm9yLW9mLmpzOiBTa2lwIG9uIGFybSovbWlwcy4KKyAgICAgICAgKiB0 eXBlUHJvZmlsZXIvZ2V0dGVyLXJpY2hhcmRzLmpzOiBTa2lwIG9uIGFybSovbWlwcy4KKworMjAx Ny0xMi0xOCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CisKICAgICAg ICAgU2tpcCBzdHJlc3MvY2FsbC1hcHBseS1leHBvbmVudGlhbC1ieXRlY29kZS1zaXplLmpzIHVu bGVzcyB4ODYtNjQgb3IgYXJtNjQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4MDcxMgogCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3R5cGVQcm9maWxlci9k ZWx0YWJsdWUtZm9yLW9mLmpzIGIvSlNUZXN0cy90eXBlUHJvZmlsZXIvZGVsdGFibHVlLWZvci1v Zi5qcwppbmRleCA5MDhjMjQzOTk1YjBlM2I1NDk4NzZiNTQ5NWNiMzFkMzNkMjc3MDI1Li44OWY4 MjBjNWE2YzM4YjRiNzhjZjUwZTI2ZGJlZDdkODI0ZWExMjFiIDEwMDY0NAotLS0gYS9KU1Rlc3Rz L3R5cGVQcm9maWxlci9kZWx0YWJsdWUtZm9yLW9mLmpzCisrKyBiL0pTVGVzdHMvdHlwZVByb2Zp bGVyL2RlbHRhYmx1ZS1mb3Itb2YuanMKQEAgLTEsNCArMSw0IEBACi0vL0AgaWYgJGJ1aWxkVHlw ZSA9PSAiZGVidWciIHRoZW4gc2tpcCBlbHNlIHJ1blR5cGVQcm9maWxlciBlbmQKKy8vQCBpZiAk YnVpbGRUeXBlID09ICJkZWJ1ZyIgb3IgJGFyY2hpdGVjdHVyZSA9fiAvYXJtfG1pcHMvIHRoZW4g c2tpcCBlbHNlIHJ1blR5cGVQcm9maWxlciBlbmQKIAogLy8gQ29weXJpZ2h0IDIwMDggdGhlIFY4 IHByb2plY3QgYXV0aG9ycy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KIC8vIENvcHlyaWdodCAxOTk2 IEpvaG4gTWFsb25leSBhbmQgTWFyaW8gV29sY3prby4KZGlmZiAtLWdpdCBhL0pTVGVzdHMvdHlw ZVByb2ZpbGVyL2dldHRlci1yaWNoYXJkcy5qcyBiL0pTVGVzdHMvdHlwZVByb2ZpbGVyL2dldHRl ci1yaWNoYXJkcy5qcwppbmRleCAzYTZiZDVjYTBkNjAwYThiNGU0ODQwMjczZDliNWEyZGE0ZGU1 ODFjLi5iMDJmNTkwODE0Y2IzYzYyMGRhN2Y2MjA4Y2U3OGE5ZTdhOTZlODIyIDEwMDY0NAotLS0g YS9KU1Rlc3RzL3R5cGVQcm9maWxlci9nZXR0ZXItcmljaGFyZHMuanMKKysrIGIvSlNUZXN0cy90 eXBlUHJvZmlsZXIvZ2V0dGVyLXJpY2hhcmRzLmpzCkBAIC0xLDQgKzEsNCBAQAotLy9AIGlmICRi dWlsZFR5cGUgPT0gImRlYnVnIiB0aGVuIHNraXAgZWxzZSBydW5UeXBlUHJvZmlsZXIgZW5kCisv L0AgaWYgJGJ1aWxkVHlwZSA9PSAiZGVidWciIG9yICRhcmNoaXRlY3R1cmUgPX4gL2FybXxtaXBz LyB0aGVuIHNraXAgZWxzZSBydW5UeXBlUHJvZmlsZXIgZW5kCiAKIC8vIENvcHlyaWdodCAyMDA2 LTIwMDggdGhlIFY4IHByb2plY3QgYXV0aG9ycy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KIC8vIENv cHlyaWdodCAyMDE0IEFwcGxlIEluYy4K