180936 2017-12-18 10:50:55 -0800 Conditionally forward declare NSMapTable SPI 2017-12-18 13:24:00 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates benjamin cdumez cmarcelo ews-watchlist mitz webkit-bug-importer oldest_to_newest 1382796 0 dbates 2017-12-18 10:50:55 -0800 Remove include of obsolete header NSMapTablePriv.h. 1382797 1 dbates 2017-12-18 10:51:15 -0800 <rdar://problem/35037796> 1382801 2 dbates 2017-12-18 11:07:09 -0800 (In reply to Daniel Bates from comment #0) > Remove include of obsolete header NSMapTablePriv.h. Actually, we need to continue including this header for a bit longer. 1382802 3 329655 dbates 2017-12-18 11:07:55 -0800 Created attachment 329655 Patch 1382821 4 329655 mitz 2017-12-18 12:13:13 -0800 Comment on attachment 329655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329655&action=review > Source/WTF/wtf/spi/cocoa/NSMapTableSPI.h:28 > +#if USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 120000 This has the effect of using the below declarations in the __IPHONE_OS_VERSION_MAX_ALLOWED >= 120000 case. But I think we shouldn’t make those declarations in that case, because they are already bade in NSMapTable.h, which we import above. My understanding is that the entire SPI header is only needed for older SDK versions (which don’t have the declarations in their NSMapTable.h), so it would be nice to express that with guards around the entire thing. 1382835 5 329662 dbates 2017-12-18 13:01:51 -0800 Created attachment 329662 Patch 1382837 6 329663 dbates 2017-12-18 13:02:57 -0800 Created attachment 329663 Patch 1382847 7 329663 dbates 2017-12-18 13:23:59 -0800 Comment on attachment 329663 Patch Clearing flags on attachment: 329663 Committed r226073: <https://trac.webkit.org/changeset/226073> 1382848 8 dbates 2017-12-18 13:24:00 -0800 All reviewed patches have been landed. Closing bug. 329655 2017-12-18 11:07:55 -0800 2017-12-18 13:01:49 -0800 Patch bug-180936-20171218110754.patch text/plain 1179 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGMyMWU5YTZmZTZjZDQxODQzZGY5N2Iy NmViZWIwMmFiYzA2OGJkMjguLjNmYTk4NDIxNTAzNGM5MWNhZDllOTZkZjQyMjNmYmU1MzZmNWFi MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTItMTggIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIENvbmRpdGlvbmFsbHkgaW5jbHVkZSBoZWFkZXIgTlNN YXBUYWJsZVByaXYuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgwOTM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTAzNzc5Nj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9zcGkvY29jb2Ev TlNNYXBUYWJsZVNQSS5oOgorCiAyMDE3LTEyLTE4ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZl ZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bRGFyd2luXSBEbyBub3QgZGVmaW5lIG1h Y2ggZXhjZXB0aW9ucyBmb3IgR1RLKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvc3BpL2Nv Y29hL05TTWFwVGFibGVTUEkuaCBiL1NvdXJjZS9XVEYvd3RmL3NwaS9jb2NvYS9OU01hcFRhYmxl U1BJLmgKaW5kZXggZTdjMWExNDc5OGUxNmY0ODU5YTY0YzBkZDY1ODY3ZGVkYTdkYzY0NC4uN2Ni NjRjN2VkMjQ3NmIyN2ExMTQ3MzhmNzQyMDA2YjZmZDFhNzJmZCAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvc3BpL2NvY29hL05TTWFwVGFibGVTUEkuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9z cGkvY29jb2EvTlNNYXBUYWJsZVNQSS5oCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbXBvcnQgPEZv dW5kYXRpb24vTlNNYXBUYWJsZS5oPgogCi0jaWYgUExBVEZPUk0oSU9TKSAmJiBVU0UoQVBQTEVf SU5URVJOQUxfU0RLKQorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIFBMQVRGT1JNKElP UykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDEyMDAwMAogI2ltcG9ydCA8 Rm91bmRhdGlvbi9OU01hcFRhYmxlUHJpdi5oPgogI2VuZGlmCiAK 329662 2017-12-18 13:01:51 -0800 2017-12-18 13:02:55 -0800 Patch bug-180936-20171218130150.patch text/plain 1349 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGMyMWU5YTZmZTZjZDQxODQzZGY5N2Iy NmViZWIwMmFiYzA2OGJkMjguLjNmYTk4NDIxNTAzNGM5MWNhZDllOTZkZjQyMjNmYmU1MzZmNWFi MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTItMTggIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIENvbmRpdGlvbmFsbHkgaW5jbHVkZSBoZWFkZXIgTlNN YXBUYWJsZVByaXYuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgwOTM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTAzNzc5Nj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9zcGkvY29jb2Ev TlNNYXBUYWJsZVNQSS5oOgorCiAyMDE3LTEyLTE4ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZl ZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bRGFyd2luXSBEbyBub3QgZGVmaW5lIG1h Y2ggZXhjZXB0aW9ucyBmb3IgR1RLKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvc3BpL2Nv Y29hL05TTWFwVGFibGVTUEkuaCBiL1NvdXJjZS9XVEYvd3RmL3NwaS9jb2NvYS9OU01hcFRhYmxl U1BJLmgKaW5kZXggZTdjMWExNDc5OGUxNmY0ODU5YTY0YzBkZDY1ODY3ZGVkYTdkYzY0NC4uOGE2 ZDY0ZTNkY2UzZmViNTRjMzViOGI0Y2RmN2Q0NDVkYzVlMTVkMiAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvc3BpL2NvY29hL05TTWFwVGFibGVTUEkuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9z cGkvY29jb2EvTlNNYXBUYWJsZVNQSS5oCkBAIC0yNSw3ICsyNSw5IEBACiAKICNpbXBvcnQgPEZv dW5kYXRpb24vTlNNYXBUYWJsZS5oPgogCi0jaWYgUExBVEZPUk0oSU9TKSAmJiBVU0UoQVBQTEVf SU5URVJOQUxfU0RLKQorI2lmIFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9N QVhfQUxMT1dFRCA8IDEyMDAwMAorCisjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKICNpbXBv cnQgPEZvdW5kYXRpb24vTlNNYXBUYWJsZVByaXYuaD4KICNlbmRpZgogCkBAIC0zNiwzICszOCw1 IEBAIHZvaWQgTlNNYXBJbnNlcnQoTlNNYXBUYWJsZSAqLCBjb25zdCB2b2lkICprZXksIGNvbnN0 IHZvaWQgKnZhbHVlKTsKIHZvaWQgTlNNYXBSZW1vdmUoTlNNYXBUYWJsZSAqLCBjb25zdCB2b2lk ICprZXkpOwogCiBXVEZfRVhURVJOX0NfRU5ECisKKyNlbmRpZgo= 329663 2017-12-18 13:02:57 -0800 2017-12-18 13:23:59 -0800 Patch bug-180936-20171218130256.patch text/plain 1348 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGMyMWU5YTZmZTZjZDQxODQzZGY5N2Iy NmViZWIwMmFiYzA2OGJkMjguLjE0NjRiN2ZmZGI5Nzk0OGU3YmFjMjk4OGQ0OWU0NWY4YmU3ODk0 ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTItMTggIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIENvbmRpdGlvbmFsbHkgZm9yd2FyZCBkZWNsYXJlIE5T TWFwVGFibGUgU1BJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODA5MzYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MDM3Nzk2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL3NwaS9jb2NvYS9O U01hcFRhYmxlU1BJLmg6CisKIDIwMTctMTItMTggIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVk cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtEYXJ3aW5dIERvIG5vdCBkZWZpbmUgbWFj aCBleGNlcHRpb25zIGZvciBHVEsrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9zcGkvY29j b2EvTlNNYXBUYWJsZVNQSS5oIGIvU291cmNlL1dURi93dGYvc3BpL2NvY29hL05TTWFwVGFibGVT UEkuaAppbmRleCBlN2MxYTE0Nzk4ZTE2ZjQ4NTlhNjRjMGRkNjU4NjdkZWRhN2RjNjQ0Li44YTZk NjRlM2RjZTNmZWI1NGMzNWI4YjRjZGY3ZDQ0NWRjNWUxNWQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9zcGkvY29jb2EvTlNNYXBUYWJsZVNQSS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3Nw aS9jb2NvYS9OU01hcFRhYmxlU1BJLmgKQEAgLTI1LDcgKzI1LDkgQEAKIAogI2ltcG9ydCA8Rm91 bmRhdGlvbi9OU01hcFRhYmxlLmg+CiAKLSNpZiBQTEFURk9STShJT1MpICYmIFVTRShBUFBMRV9J TlRFUk5BTF9TREspCisjaWYgUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01B WF9BTExPV0VEIDwgMTIwMDAwCisKKyNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogI2ltcG9y dCA8Rm91bmRhdGlvbi9OU01hcFRhYmxlUHJpdi5oPgogI2VuZGlmCiAKQEAgLTM2LDMgKzM4LDUg QEAgdm9pZCBOU01hcEluc2VydChOU01hcFRhYmxlICosIGNvbnN0IHZvaWQgKmtleSwgY29uc3Qg dm9pZCAqdmFsdWUpOwogdm9pZCBOU01hcFJlbW92ZShOU01hcFRhYmxlICosIGNvbnN0IHZvaWQg KmtleSk7CiAKIFdURl9FWFRFUk5fQ19FTkQKKworI2VuZGlmCg==