180926 2017-12-18 00:50:35 -0800 [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID 2017-12-18 18:10:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii commit-queue pvollan thorton webkit-bug-importer wilander oldest_to_newest 1382724 0 fujii 2017-12-18 00:50:35 -0800 [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID I tested with trunk@226017, WinCairo, Debug build. 1) Start MiniBrowser 2) Open http://google.com > SHOULD NEVER BE REACHED > C:\webkit\ga\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient.cpp(126) : WebFrameLoaderClient::pageID Maybe caused by Bug 180682. Callstack: > WTF.dll!WTFCrash() Line 272 C++ Symbols loaded. > WebKit.dll!WebFrameLoaderClient::pageID() Line 126 C++ Symbols loaded. > WebKit.dll!WebCore::setCookies(WebCore::Document & document, const WebCore::URL & url, const WTF::String & cookieString) Line 80 C++ Symbols loaded. > WebKit.dll!WebCore::Document::setCookie(const WTF::String & value) Line 4537 C++ Symbols loaded. > WebKit.dll!WebCore::setJSDocumentCookieSetter::__l2::<lambda>() Line 1267 C++ Symbols loaded. > WebKit.dll!WebCore::AttributeSetter::call<WebCore::ExceptionOr<void> <lambda>(void) >(JSC::ExecState & state, JSC::ThrowScope & throwScope, WebCore::setJSDocumentCookieSetter::__l2::WebCore::ExceptionOr<void> <lambda>(void) && functor) Line 104 C++ Symbols loaded. > WebKit.dll!WebCore::setJSDocumentCookieSetter(JSC::ExecState & state, WebCore::JSDocument & thisObject, JSC::JSValue value, JSC::ThrowScope & throwScope) Line 1269 C++ Symbols loaded. > WebKit.dll!WebCore::IDLAttribute<WebCore::JSDocument>::set<&WebCore::setJSDocumentCookieSetter,0>(JSC::ExecState & state, __int64 thisValue, __int64 encodedValue, const char * attributeName) Line 50 C++ Symbols loaded. > WebKit.dll!WebCore::setJSDocumentCookie(JSC::ExecState * state, __int64 thisValue, __int64 encodedValue) Line 1275 C++ Symbols loaded. > JavaScriptCore.dll!JSC::callCustomSetter(JSC::ExecState * exec, bool(*)(JSC::ExecState *, __int64, __int64) setter, bool isAccessor, JSC::JSValue thisValue, JSC::JSValue value) Line 41 C++ Symbols loaded. > JavaScriptCore.dll!JSC::callCustomSetter(JSC::ExecState * exec, JSC::JSValue customGetterSetter, bool isAccessor, JSC::JSObject * base, JSC::JSValue thisValue, JSC::JSValue value) Line 59 C++ Symbols loaded. > JavaScriptCore.dll!JSC::JSObject::putInlineSlow(JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 794 C++ Symbols loaded. > JavaScriptCore.dll!JSC::JSObject::putInlineForJSObject(JSC::JSCell * cell, JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 229 C++ Symbols loaded. > JavaScriptCore.dll!JSC::JSCell::putInline(JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 374 C++ Symbols loaded. > JavaScriptCore.dll!JSC::JSValue::putInline(JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 912 C++ Symbols loaded. > JavaScriptCore.dll!llint_slow_path_put_by_id(JSC::ExecState * exec, JSC::Instruction * pc) Line 751 C++ Symbols loaded. > [External Code] Annotated Frame > JavaScriptCore.dll!JSC::dateProtoFuncToUTCString(JSC::ExecState * exec) Line 535 C++ Symbols loaded. > [External Code] Annotated Frame 1382728 1 fujii 2017-12-18 00:53:05 -0800 RELEASE_ASSERT_NOT_REACHED of Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm was removed in r225934. https://trac.webkit.org/changeset/225934/webkit#file28 1382731 2 329644 fujii 2017-12-18 00:59:43 -0800 Created attachment 329644 Patch 1383009 3 329644 commit-queue 2017-12-18 18:09:13 -0800 Comment on attachment 329644 Patch Clearing flags on attachment: 329644 Committed r226091: <https://trac.webkit.org/changeset/226091> 1383010 4 commit-queue 2017-12-18 18:09:14 -0800 All reviewed patches have been landed. Closing bug. 1383011 5 webkit-bug-importer 2017-12-18 18:10:27 -0800 <rdar://problem/36121778> 329644 2017-12-18 00:59:43 -0800 2017-12-18 18:09:13 -0800 Patch bug-180926-20171218175942.patch text/plain 1702 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggMmRlZjBhMDI2YTc3YzQzNjk4ZTc3YjRhZGNkNTFjNjA4MGY0MmVmMi4uOGUwNDlmYmQ3ZGI1 ODRhNDQzYjBjZTM2MjdhZGNjMDk0N2JlY2I1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTE4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFNIT1VMRCBORVZFUiBCRSBSRUFDSEVE IGluIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpwYWdlSUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDkyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFwcGx5IHRoZSBzYW1lIGNoYW5nZSBvZiBtYWMvV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQubW0KKyAgICAgICAgb2YgcjIyNTkzNCB0 byB3aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwLgorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2Vi RnJhbWVMb2FkZXJDbGllbnQ6OmZyYW1lSUQgY29uc3QpOiBSZW1vdmVkIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVELgorICAgICAgICAoV2ViRnJhbWVMb2FkZXJDbGllbnQ6OnBhZ2VJRCBjb25z dCk6IERpdHRvLgorCiAyMDE3LTEyLTE2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21h aWwuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBib29sZWFuIHJlc3VsdCBvZiBz dGFydCgpIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdExlZ2Fj eS93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IDBkOThk NmQ1OTgzM2FjNDA5ZmEwMTRiYjczOGIyMzc0ZjkzZWYxYWMuLmM1OTMzNTYxOWU2NzY2MWY0YTQx NzNlMjM3OGQ2NGEzNjhmMDE3MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2lu L1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0TGVnYWN5L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKQEAg LTEyMywxMyArMTIzLDExIEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmZyYW1lTG9hZGVy RGVzdHJveWVkKCkKIAogc3RkOjpvcHRpb25hbDx1aW50NjRfdD4gV2ViRnJhbWVMb2FkZXJDbGll bnQ6OnBhZ2VJRCgpIGNvbnN0CiB7Ci0gICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsK ICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogfQogCiBzdGQ6Om9wdGlvbmFsPHVpbnQ2NF90PiBX ZWJGcmFtZUxvYWRlckNsaWVudDo6ZnJhbWVJRCgpIGNvbnN0CiB7Ci0gICAgUkVMRUFTRV9BU1NF UlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogfQogCg==