180914 2017-12-17 08:29:43 -0800 fix build with -DENABLE_OPENGL=OFF: add missing ENABLE_WEBGL conditionals 2019-09-28 14:00:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enometh webkit-unassigned aperez bugs-noreply calvaris clopez mcatanzaro zan oldest_to_newest 1382595 0 enometh 2017-12-17 08:29:43 -0800 Building webkitgtk-2.19.3 fails with cmake -DENABLE_OPENGL=OFF fails on certain files. Apparently because the code is not enclosed in #if ENABLE(WEBGL) .. #endif blocks as expected. * Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h * Source/WebCore/html/canvas/WebGLContextGroup.h Eg. In file included from ../Source/WebCore/html/canvas/WebGLContextGroup.cpp:27:0, from DerivedSources/WebCore/unified-sources/UnifiedSource252.cpp:2: ../Source/WebCore/html/canvas/WebGLContextGroup.h:37:21: error: 'WebGLRenderingContextBase' has not been declared void addContext(WebGLRenderingContextBase&); ^~~~~~~~~~~~~~~~~~~~~~~~~ * Source/WebCore/html/canvas/WebGLExtension.{h,cpp}: In file included from ../Source/WebCore/html/canvas/OESVertexArrayObject.h:29:0, from ../Source/WebCore/html/canvas/OESVertexArrayObject.cpp:27, from DerivedSources/WebCore/unified-sources/UnifiedSource250.cpp:8: ../Source/WebCore/html/canvas/WebGLExtension.h: In member function 'void WebCore::WebGLExtension::ref()': ../Source/WebCore/html/canvas/WebGLExtension.h:60:27: error: invalid use of incomplete type 'class WebCore::WebGLRenderingContextBase' void ref() { m_context.ref(); } ^ The attached patch outlining those fixes is against webkitgtk-2.19.3 1433275 1 342798 enometh 2018-06-15 03:01:47 -0700 Created attachment 342798 tentative patch 1433284 2 aperez 2018-06-15 04:43:36 -0700 The attached patch looks good to me, but it is missing ChangeLog entries. Could you please use “Tools/Scripts/prepare-ChangeLog” from your WebKit checkout and re-submit the patch with them added? 1433287 3 aperez 2018-06-15 04:46:24 -0700 (In reply to Adrian Perez from comment #2) > The attached patch looks good to me, but it is missing ChangeLog > entries. Could you please use “Tools/Scripts/prepare-ChangeLog” > from your WebKit checkout and re-submit the patch with them added? FWIW, I have also added a couple of reviewers in CC. If you want to get that done automatically next time, the “--suggest-reviewers” flag can be passed to “Tools/Scripts/webkit-patch upload”. 1433340 4 mcatanzaro 2018-06-15 08:00:20 -0700 Please add one blank line above and below the guards, that's more common style in WebKit. Other than that, it looks good. Once you add a ChangeLog, be sure to use the r? flag (to request review) and cq? flag (to request commit). 1575088 5 aperez 2019-09-28 13:59:34 -0700 This was fixed in r47452 — closing. 1575089 6 aperez 2019-09-28 14:00:34 -0700 (In reply to Adrian Perez from comment #5) > This was fixed in r47452 — closing. Correcting myself: it was r247452 342798 2018-06-15 03:01:47 -0700 2018-06-15 03:01:47 -0700 tentative patch opengl.diff text/plain 1339 enometh LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvT0VTVmVydGV4QXJyYXlPYmplY3QuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9PRVNWZXJ0ZXhBcnJheU9iamVjdC5oCkBA IC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiR3JhcGhpY3NUeXBlczNELmgiCiAjaW5jbHVkZSAi V2ViR0xFeHRlbnNpb24uaCIKIAorI2lmIEVOQUJMRShXRUJHTCkKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogY2xhc3MgV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTsKQEAgLTQ3LDMgKzQ4LDQgQEAg cHJpdmF0ZToKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKyNlbmRpZiAgLy8gRU5BQkxF KFdFQkdMKQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTENvbnRleHRHcm91 cC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMQ29udGV4dEdyb3VwLmgK QEAgLTI3LDYgKzI3LDcgQEAKIAogI2luY2x1ZGUgIldlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2Uu aCIKIAorI2lmIEVOQUJMRShXRUJHTCkKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgV2Vi R0xDb250ZXh0R3JvdXAgOiBwdWJsaWMgUmVmQ291bnRlZDxXZWJHTENvbnRleHRHcm91cD4gewpA QCAtNTQsMyArNTUsNCBAQCBwcml2YXRlOgogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQor I2VuZGlmCi0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMRXh0ZW5zaW9uLmgK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xFeHRlbnNpb24uaApAQCAtMjcs NiArMjcsNyBAQAogCiAjaW5jbHVkZSAiV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5oIgogCisj aWYgRU5BQkxFKFdFQkdMKQogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBXZWJHTEV4dGVu c2lvbiB7CkBAIC03MSwzICs3Miw0IEBAIHByb3RlY3RlZDoKIH07CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKKyNlbmRpZiAgLy8gRU5BQkxFKFdFQkdMKQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xWZXJ0ZXhBcnJheU9i amVjdEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFZlcnRleEFy cmF5T2JqZWN0QmFzZS5oCkBAIC0yNSw2ICsyNSw3IEBACiAKICNwcmFnbWEgb25jZQogCisjaWYg RU5BQkxFKFdFQkdMKQogI2luY2x1ZGUgIldlYkdMQnVmZmVyLmgiCiAjaW5jbHVkZSAiV2ViR0xD b250ZXh0T2JqZWN0LmgiCiAKQEAgLTc2LDMgKzc3LDQgQEAgcHJvdGVjdGVkOgogfTsKIAogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQorI2VuZGlmCg==