18091 2008-03-25 16:54:37 -0700 font-size doesn't get animated using -webkit-transition 2008-10-12 15:15:21 -0700 1 1 1 Unclassified WebKit CSS 525.x (Safari 3.1) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 marchant hyatt marchant nickshanks oldest_to_newest 75214 0 marchant 2008-03-25 16:54:37 -0700 See the attached test case 75215 1 20060 marchant 2008-03-25 17:03:46 -0700 Created attachment 20060 example of the bug example of the bug 89664 2 23058 hyatt 2008-08-28 12:32:48 -0700 Created attachment 23058 Support font-size animation 89665 3 23058 darin 2008-08-28 12:45:37 -0700 Comment on attachment 23058 Support font-size animation + // FIXME: Use with caution. Only used for blending font sizes when animating. + void setFontSize(int size) { + FontDescription desc(fontDescription()); + desc.setSpecifiedSize(size); + desc.setComputedSize(size); + setFontDescription(desc); + font().update(font().fontSelector()); + } Since this function is only used through a function pointer, it's not helpful to inline it. So it would be better if this was in a .cpp file instead of the header. The comment says "caution" which I think is too vague. And it says FIXME without being clear what should be fixed. It would be stronger if this said something more like: // Used for blending font sizes when animating. // Would be a bad idea to use this in other cases because <reason header>. r=me, but please consider my comments and consider if you can add a test case 89666 4 hyatt 2008-08-28 12:49:56 -0700 You can really only make manual tests for transitions, since we have no testing framework for them. :( I'll change the function name to setBlendedFontSize and remove the inlining. 95086 5 darin 2008-10-12 15:15:21 -0700 http://trac.webkit.org/changeset/35975 20060 2008-03-25 17:03:46 -0700 2008-03-25 17:03:46 -0700 example of the bug testNSCSSTransition.html application/xhtml+xml 4399 marchant PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPgoKPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDps YW5nPSJlbiIgbGFuZz0iZW4iPgo8aGVhZD4KCTx0aXRsZT5DU1NBbmltYXRpb25UZXN0PC90aXRs ZT4KCTxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBj aGFyc2V0PXV0Zi04IiAvPgoJPG1ldGEgaHR0cC1lcXVpdj0iZXhwaXJlcyIgY29udGVudD0iTW9u LCAwNCBKdWwgMjA1MCAwNzowNzowNyBHTVQiIC8+CgoKCTxzY3JpcHQgdHlwZT0idGV4dC9qYXZh c2NyaXB0Ij4KCWZ1bmN0aW9uIHRlc3RBbmltYXRpb25zIChub2RlKSB7CgkJbm9kZS5jbGFzc05h bWUgPSAiZW5kIjsKCX0KCQoJZnVuY3Rpb24gdGVzdEFuaW1hdGlvbnNUb28gKG5vZGUpIHsKCQlu b2RlLmFkZEV2ZW50TGlzdGVuZXIoIndlYmtpdFRyYW5zaXRpb25FbmRFdmVudCIsZnVuY3Rpb24o KXthbGVydCgiaGVyZSIpO25vZGUuY2xhc3NOYW1lID0gInN0YXJ0VG9vIjt9LGZhbHNlKTsKCgkJ bm9kZS5jbGFzc05hbWUgPSAiZW5kVG9vIjsKCX0KCgkJPC9zY3JpcHQ+CgoJCTxzdHlsZSB0eXBl PSJ0ZXh0L2NzcyI+CgkJCgkJI2NsaWNNZSB7CgkJCS13ZWJraXQtdHJhbnNpdGlvbi1wcm9wZXJ0 eTogYmFja2dyb3VuZC1jb2xvciwgY29sb3IsIGZvbnQtc2l6ZSwgaGVpZ2h0LCB3aWR0aCwgcGFk ZGluZywgdG9wLCBsZWZ0LCBvcGFjaXR5LGJvcmRlcjsKCQkJLXdlYmtpdC10cmFuc2l0aW9uLWR1 cmF0aW9uOiAzcywgM3MsIDNzLCAzcywgM3MsIDNzLCAzcywgM3MsIDNzLCAzczsKCQkJLXdlYmtp dC10cmFuc2l0aW9uLXRpbWluZy1mdW5jdGlvbjplYXNlLWluLW91dCwgZWFzZS1pbi1vdXQsIGVh c2UtaW4tb3V0LCBlYXNlLWluLW91dCwgZWFzZS1pbi1vdXQsIGVhc2UtaW4tb3V0LCBlYXNlLWlu LW91dCwgZWFzZS1pbi1vdXQsIGVhc2UtaW4tb3V0LCBlYXNlLWluLW91dDsKCQl9CgkJCgkJI2Ns aWNNZVRvbyB7CgkJCS13ZWJraXQtdHJhbnNpdGlvbi1wcm9wZXJ0eTogYmFja2dyb3VuZC1jb2xv ciwgY29sb3IsIGZvbnQtc2l6ZSwgaGVpZ2h0LCB3aWR0aCwgcGFkZGluZywgdG9wLCBsZWZ0LCBv cGFjaXR5LGJvcmRlci1sZWZ0LXdpZHRoLGJvcmRlci10b3Atd2lkdGgsYm9yZGVyLXJpZ2h0LXdp ZHRoLGJvcmRlci1ib3R0b20td2lkdGgsYm9yZGVyLWxlZnQtY29sb3IsYm9yZGVyLXRvcC1jb2xv cixib3JkZXItcmlnaHQtY29sb3IsYm9yZGVyLWJvdHRvbXQtY29sb3IgOwoJCQktd2Via2l0LXRy YW5zaXRpb24tZHVyYXRpb246IDNzLCAzcywgM3MsIDNzLCAzcywgM3MsIDNzLCAzcywgM3MsIDNz OwoJCQktd2Via2l0LXRyYW5zaXRpb24tdGltaW5nLWZ1bmN0aW9uOmVhc2UtaW4tb3V0LCBlYXNl LWluLW91dCwgZWFzZS1pbi1vdXQsIGVhc2UtaW4tb3V0LCBlYXNlLWluLW91dCwgZWFzZS1pbi1v dXQsIGVhc2UtaW4tb3V0LCBlYXNlLWluLW91dCwgZWFzZS1pbi1vdXQsIGVhc2UtaW4tb3V0LCBl YXNlLWluLW91dCwgZWFzZS1pbi1vdXQsIGVhc2UtaW4tb3V0LCBlYXNlLWluLW91dCwgZWFzZS1p bi1vdXQsIGVhc2UtaW4tb3V0LCBlYXNlLWluLW91dDsKCQl9CgkJCgoJCQoJCS5zdGFydHsKCQkJ YmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKCQkJY29sb3I6IGJsYWNrOwoJCQlmb250LXNpemUgOiAy MHB4OwoJCQloZWlnaHQgOiAxMDBweDsKCQkJd2lkdGggOiA0MGVtOwoJCQlwb3NpdGlvbjphYnNv bHV0ZTsKCQkJcGFkZGluZzoxMHB4OwoJCQl0b3AgOiAxMDBweDsKCQkJbGVmdCA6IDExMHB4OwoJ CQlvcGFjaXR5IDogMTsKCQkJZmlsdGVyOmFscGhhKG9wYWNpdHk9MTAwKSBwcm9naWQ6RFhJbWFn ZVRyYW5zZm9ybS5NaWNyb3NvZnQuTW90aW9uQmx1cihzdHJlbmd0aD0xMDMsIGRpcmVjdGlvbj0z MTApOwoJCQkvKmZpbHRlcjphbHBoYShvcGFjaXR5PTEwMCk7Ki8KCQkJYm9yZGVyOiAycHggc29s aWQgZGFya21hZ2VudGE7CgkJCS8qY2xpcDogcmVjdCgxMHB4LCA5MHB4LCA3MHB4LCAwcHgpOyov CgkJCS8qb3ZlcmZsb3c6aGlkZGVuOyovCgoJCX0KCQkKCQkuc3RhcnRUb28gewoJCQliYWNrZ3Jv dW5kLWNvbG9yOiBibHVlOwoJCQljb2xvcjogYmxhY2s7CgkJCWZvbnQtc2l6ZSA6IDIwcHg7CgkJ CWhlaWdodCA6IDEwMHB4OwoJCQl3aWR0aCA6IDQwZW07CgkJCXBvc2l0aW9uOmFic29sdXRlOwoJ CQlwYWRkaW5nOjEwcHg7CgkJCXRvcCA6IDI0MHB4OwoJCQlsZWZ0IDogMTEwcHg7CgkJCW9wYWNp dHkgOiAxOwoJCQlmaWx0ZXI6YWxwaGEob3BhY2l0eT0xMDApIHByb2dpZDpEWEltYWdlVHJhbnNm b3JtLk1pY3Jvc29mdC5Nb3Rpb25CbHVyKHN0cmVuZ3RoPTEwMywgZGlyZWN0aW9uPTMxMCk7CgkJ CS8qZmlsdGVyOmFscGhhKG9wYWNpdHk9MTAwKTsqLwoJCQkvL2JvcmRlcjogMnB4IHNvbGlkIGRh cmttYWdlbnRhOwoJCQkKCQkJYm9yZGVyLXN0eWxlOnNvbGlkOwoKCQkJYm9yZGVyLWxlZnQtd2lk dGg6MnB4OwoJCQlib3JkZXItdG9wLXdpZHRoOjJweDsKCQkJYm9yZGVyLXJpZ2h0LXdpZHRoOjJw eDsKCQkJYm9yZGVyLWJvdHRvbS13aWR0aDoycHg7CgoJCQlib3JkZXItbGVmdC1jb2xvcjpkYXJr bWFnZW50YTsKCQkJYm9yZGVyLXRvcC1jb2xvcjpkYXJrbWFnZW50YTsKCQkJYm9yZGVyLXJpZ2h0 LWNvbG9yOmRhcmttYWdlbnRhOwoJCQlib3JkZXItYm90dG9tLWNvbG9yOmRhcmttYWdlbnRhOwoJ CQkKCQkJCgkJCS8qY2xpcDogcmVjdCgxMHB4LCA5MHB4LCA3MHB4LCAwcHgpOyovCgkJCS8qb3Zl cmZsb3c6aGlkZGVuOyovCgoJCX0KCgkJCgkJLmVuZHsKCQkJYmFja2dyb3VuZC1jb2xvcjogZ3Jl ZW47CgkJCWNvbG9yOiB3aGl0ZTsKCQkJZm9udC1zaXplIDogNDBweDsKCQkJaGVpZ2h0IDogNDBw eDsKCQkJd2lkdGggOiA2MGVtOwoJCQlwb3NpdGlvbjogYWJzb2x1dGU7CgkJCXBhZGRpbmc6MnB4 OwoJCQl0b3AgOiA1MDBweDsKCQkJbGVmdCA6IDUwMHB4OwoJCQlvcGFjaXR5IDogMDsKCQkJYm9y ZGVyOiAxMHB4IHNvbGlkIHJlZDsKCQkJYm9yZGVyLXNwYWNpbmc6MTBweCAxMHB4OwoJCQlmaWx0 ZXI6YWxwaGEob3BhY2l0eT0wKSBwcm9naWQ6RFhJbWFnZVRyYW5zZm9ybS5NaWNyb3NvZnQuTW90 aW9uQmx1cihzdHJlbmd0aD0xMDMsIGRpcmVjdGlvbj0zMTApOwoJCQkvKmZpbHRlcjphbHBoYShv cGFjaXR5PTApOyovCgkJCS8qY2xpcDpyZWN0KDVweCwgMjAwcHgsIDgwcHgsIDBweCk7Ki8KCQkJ LypvdmVyZmxvdzpoaWRkZW47Ki8KCQl9CgkJCgkJLmVuZFRvbyB7CgkJCWJhY2tncm91bmQtY29s b3I6IGdyZWVuOwoJCQljb2xvcjogd2hpdGU7CgkJCWZvbnQtc2l6ZSA6IDQwcHg7CgkJCWhlaWdo dCA6IDQwcHg7CgkJCXdpZHRoIDogNjBlbTsKCQkJcG9zaXRpb246IGFic29sdXRlOwoJCQlwYWRk aW5nOjJweDsKCQkJdG9wIDogNTAwcHg7CgkJCWxlZnQgOiA1MDBweDsKCQkJb3BhY2l0eSA6IDA7 CgkJCWJvcmRlci1zcGFjaW5nOjEwcHggMTBweDsKCQkJCgkJCWJvcmRlci1zdHlsZTpzb2xpZDsK CQkKCQkJYm9yZGVyLWxlZnQtd2lkdGg6MTBweDsKCQkJYm9yZGVyLXRvcC13aWR0aDoxMHB4OwoJ CQlib3JkZXItcmlnaHQtd2lkdGg6MTBweDsKCQkJYm9yZGVyLWJvdHRvbS13aWR0aDoxMHB4OwoK CQkJYm9yZGVyLWxlZnQtY29sb3I6cmVkOwoJCQlib3JkZXItdG9wLWNvbG9yOnJlZDsKCQkJYm9y ZGVyLXJpZ2h0LWNvbG9yOnJlZDsKCQkJYm9yZGVyLWJvdHRvbS1jb2xvcjpyZWQ7CgkJCWZpbHRl cjphbHBoYShvcGFjaXR5PTApIHByb2dpZDpEWEltYWdlVHJhbnNmb3JtLk1pY3Jvc29mdC5Nb3Rp b25CbHVyKHN0cmVuZ3RoPTEwMywgZGlyZWN0aW9uPTMxMCk7CgkJCS8qZmlsdGVyOmFscGhhKG9w YWNpdHk9MCk7Ki8KCQkJLypjbGlwOnJlY3QoNXB4LCAyMDBweCwgODBweCwgMHB4KTsqLwoJCQkv Km92ZXJmbG93OmhpZGRlbjsqLwoJCX0KCgkJPC9zdHlsZT4KCgk8L2hlYWQ+Cgk8Ym9keSBpZD0i R2lhbmR1aWEudGVzdC5BcHBLaXQudGVzdE5TQ29tcG9uZW50Ij4KCQk8aDE+VW5mb3J0dW5hdGVs eSBmb250LXNpemUgZG9lc24ndCBhbmltYXRlPC9oMT4KCQk8ZGl2IGlkPSJjbGljTWUiIGNsYXNz PSJzdGFydCIgIG9uY2xpY2s9InRlc3RBbmltYXRpb25zKHRoaXMpOyIgPgoJCQlDbGljIE1lIC0g VXNlcyBib3JkZXI6IHNob3J0aGFuZAoJCTwvZGl2PgoKCQk8ZGl2IGlkPSJjbGljTWVUb28iIGNs YXNzPSJzdGFydFRvbyIgIG9uY2xpY2s9InRlc3RBbmltYXRpb25zVG9vKHRoaXMpOyIgPgoJCQlD bGljIE1lIC0gVXNlcyBhdG9taWMgYm9yZGVyIHByb3BlcnRpZXMKCQk8L2Rpdj4KCgk8L2JvZHk+ Cgk8L2h0bWw+Cg== 23058 2008-08-28 12:32:48 -0700 2008-08-28 12:45:37 -0700 Support font-size animation patch.txt text/plain 2974 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM1OTc0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMDgt MjggIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODA5MQorCisgICAgICAgIGZvbnQtc2l6ZSBzaG91bGQgYmUgYW5pbWF0YWJs ZSB1c2luZyAtd2Via2l0LXRyYW5zaXRpb24uCisKKyAgICAgICAgKiBwYWdlL0FuaW1hdGlvbkNv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QW5pbWF0aW9uQ29udHJvbGxlclByaXZh dGU6OmVuc3VyZVByb3BlcnR5TWFwKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVy U3R5bGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclN0eWxlOjpzZXRGb250U2l6ZSk6CisK IDIwMDgtMDgtMjggIEJyYWQgR2FyY2lhICA8YmdhcmNpYUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBwYWdlL0FuaW1hdGlvbkNvbnRyb2xs ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvQW5pbWF0aW9uQ29udHJvbGxlci5jcHAJKHJldmlz aW9uIDM1OTUwKQorKysgcGFnZS9BbmltYXRpb25Db250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTE2MCw2ICsxMTYwLDcgQEAgdm9pZCBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6 ZW5zdXJlUAogICAgICAgICBnUHJvcGVydHlXcmFwcGVycy0+YXBwZW5kKG5ldyBQcm9wZXJ0eVdy YXBwZXI8ZmxvYXQ+KENTU1Byb3BlcnR5T3BhY2l0eSwgJlJlbmRlclN0eWxlOjpvcGFjaXR5LCAm UmVuZGVyU3R5bGU6OnNldE9wYWNpdHkpKTsKICAgICAgICAgZ1Byb3BlcnR5V3JhcHBlcnMtPmFw cGVuZChuZXcgUHJvcGVydHlXcmFwcGVyPGNvbnN0IENvbG9yJj4oQ1NTUHJvcGVydHlDb2xvciwg JlJlbmRlclN0eWxlOjpjb2xvciwgJlJlbmRlclN0eWxlOjpzZXRDb2xvcikpOwogICAgICAgICBn UHJvcGVydHlXcmFwcGVycy0+YXBwZW5kKG5ldyBQcm9wZXJ0eVdyYXBwZXI8Y29uc3QgQ29sb3Im PihDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xvciwgJlJlbmRlclN0eWxlOjpiYWNrZ3JvdW5kQ29s b3IsICZSZW5kZXJTdHlsZTo6c2V0QmFja2dyb3VuZENvbG9yKSk7CisgICAgICAgIGdQcm9wZXJ0 eVdyYXBwZXJzLT5hcHBlbmQobmV3IFByb3BlcnR5V3JhcHBlcjxpbnQ+KENTU1Byb3BlcnR5Rm9u dFNpemUsICZSZW5kZXJTdHlsZTo6Zm9udFNpemUsICZSZW5kZXJTdHlsZTo6c2V0Rm9udFNpemUp KTsKICAgICAgICAgZ1Byb3BlcnR5V3JhcHBlcnMtPmFwcGVuZChuZXcgUHJvcGVydHlXcmFwcGVy PHVuc2lnbmVkIHNob3J0PihDU1NQcm9wZXJ0eVdlYmtpdENvbHVtblJ1bGVXaWR0aCwgJlJlbmRl clN0eWxlOjpjb2x1bW5SdWxlV2lkdGgsICZSZW5kZXJTdHlsZTo6c2V0Q29sdW1uUnVsZVdpZHRo KSk7CiAgICAgICAgIGdQcm9wZXJ0eVdyYXBwZXJzLT5hcHBlbmQobmV3IFByb3BlcnR5V3JhcHBl cjxmbG9hdD4oQ1NTUHJvcGVydHlXZWJraXRDb2x1bW5HYXAsICZSZW5kZXJTdHlsZTo6Y29sdW1u R2FwLCAmUmVuZGVyU3R5bGU6OnNldENvbHVtbkdhcCkpOwogICAgICAgICBnUHJvcGVydHlXcmFw cGVycy0+YXBwZW5kKG5ldyBQcm9wZXJ0eVdyYXBwZXI8dW5zaWduZWQgc2hvcnQ+KENTU1Byb3Bl cnR5V2Via2l0Q29sdW1uQ291bnQsICZSZW5kZXJTdHlsZTo6Y29sdW1uQ291bnQsICZSZW5kZXJT dHlsZTo6c2V0Q29sdW1uQ291bnQpKTsKSW5kZXg6IHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHls ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCShyZXZpc2lv biAzNTk1MCkKKysrIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCSh3b3JraW5nIGNvcHkp CkBAIC00NCw2ICs0NCw3IEBACiAjaW5jbHVkZSAiRGF0YVJlZi5oIgogI2luY2x1ZGUgIkZsb2F0 UG9pbnQuaCIKICNpbmNsdWRlICJGb250LmgiCisjaW5jbHVkZSAiRm9udFNlbGVjdG9yLmgiCiAj aW5jbHVkZSAiR3JhcGhpY3NUeXBlcy5oIgogI2luY2x1ZGUgIkludFJlY3QuaCIKICNpbmNsdWRl ICJMZW5ndGguaCIKQEAgLTIyNzUsNyArMjI3NiwxNiBAQCBwdWJsaWM6CiAgICAgICAgIH0KICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KLQorICAgIAorICAgIC8vIEZJWE1FOiBVc2Ugd2l0 aCBjYXV0aW9uLiAgT25seSB1c2VkIGZvciBibGVuZGluZyBmb250IHNpemVzIHdoZW4gYW5pbWF0 aW5nLgorICAgIHZvaWQgc2V0Rm9udFNpemUoaW50IHNpemUpIHsKKyAgICAgICAgRm9udERlc2Ny aXB0aW9uIGRlc2MoZm9udERlc2NyaXB0aW9uKCkpOworICAgICAgICBkZXNjLnNldFNwZWNpZmll ZFNpemUoc2l6ZSk7CisgICAgICAgIGRlc2Muc2V0Q29tcHV0ZWRTaXplKHNpemUpOworICAgICAg ICBzZXRGb250RGVzY3JpcHRpb24oZGVzYyk7CisgICAgICAgIGZvbnQoKS51cGRhdGUoZm9udCgp LmZvbnRTZWxlY3RvcigpKTsKKyAgICB9CisgICAgCiAgICAgdm9pZCBzZXRDb2xvcihjb25zdCBD b2xvciAmIHYpIHsgU0VUX1ZBUihpbmhlcml0ZWQsY29sb3IsdikgfQogICAgIHZvaWQgc2V0VGV4 dEluZGVudChMZW5ndGggdikgeyBTRVRfVkFSKGluaGVyaXRlZCxpbmRlbnQsdikgfQogICAgIHZv aWQgc2V0VGV4dEFsaWduKEVUZXh0QWxpZ24gdikgeyBpbmhlcml0ZWRfZmxhZ3MuX3RleHRfYWxp Z24gPSB2OyB9Cg==