180900 2017-12-15 18:53:27 -0800 Web Inspector: Styles Redesign: Command-S should save changes in matching CSS resource 2017-12-18 15:02:45 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1382427 0 nvasilyev 2017-12-15 18:53:27 -0800 When focused on a CSS rule, Command-S should save the owner CSS resource the same way if we were to edit this CSS in Resources tab. The legacy styles sidebar supported it. <rdar://problem/35648633> 1382428 1 329555 nvasilyev 2017-12-15 18:57:29 -0800 Created attachment 329555 Patch 1382429 2 nvasilyev 2017-12-15 19:02:57 -0800 This is essentially the same patch as it was for the old styles sidebar in 2015 Bug 150298 - Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file. 1382850 3 329555 timothy 2017-12-18 13:25:14 -0800 Comment on attachment 329555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329555&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:407 > + url = pathDirectory + "base64.css"; Why base64.css? data.css? WI.frameResourceManager.mainFrame.mainResource.url - ".html" + "-data.css"? 1382909 4 329684 nvasilyev 2017-12-18 14:30:15 -0800 Created attachment 329684 Patch 1382920 5 329684 commit-queue 2017-12-18 15:02:43 -0800 Comment on attachment 329684 Patch Clearing flags on attachment: 329684 Committed r226082: <https://trac.webkit.org/changeset/226082> 1382921 6 commit-queue 2017-12-18 15:02:45 -0800 All reviewed patches have been landed. Closing bug. 329555 2017-12-15 18:57:29 -0800 2017-12-18 14:30:15 -0800 Patch patch.txt text/plain 3427 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJmMTkyMjIuLmEwYTgzMDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTE1ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxl cyBSZWRlc2lnbjogQ29tbWFuZC1TIHNob3VsZCBzYXZlIGNoYW5nZXMgaW4gbWF0Y2hpbmcgQ1NT IHJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODA5MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaGVuIGZvY3VzZWQgb24gYSBDU1Mgc2VsZWN0b3IsIHByb3BlcnR5IG5hbWUgb3IgdmFsdWUs IHByZXNzaW5nIENvbW1hbmQtUyBzaG91bGQgc2F2ZQorICAgICAgICB0aGUgQ1NTIHJlc291cmNl IHRvIHRoZSBmaWxlIHN5c3RlbS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU3By ZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5qczoKKyAgICAgICAgKFdJLlNwcmVh ZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24ucHJvdG90eXBlLmluaXRpYWxMYXlvdXQp OgorICAgICAgICAoV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5wcm90 b3R5cGUuX3NhdmUpOgorCiAyMDE3LTEyLTE1ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjU5NDEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRz aGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlv bi5qcwppbmRleCA3YzBjNWU0Li45NDhlOGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25T ZWN0aW9uLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKQEAgLTEwNCw2ICsxMDQs OSBAQCBXSS5TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uID0gY2xhc3MgU3By ZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uUwogICAgICAgICBpZiAodGhpcy5fc3R5bGUuZWRp dGFibGUpIHsKICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGlj ayIsIHRoaXMuX2hhbmRsZUNsaWNrLmJpbmQodGhpcykpOwogICAgICAgICAgICAgdGhpcy5lbGVt ZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZG93biIsIHRoaXMuX2hhbmRsZU1vdXNlRG93bi5i aW5kKHRoaXMpKTsKKworICAgICAgICAgICAgbmV3IFdJLktleWJvYXJkU2hvcnRjdXQoV0kuS2V5 Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCAiUyIsIHRoaXMuX3NhdmUu YmluZCh0aGlzKSwgdGhpcy5fZWxlbWVudCk7CisgICAgICAgICAgICBuZXcgV0kuS2V5Ym9hcmRT aG9ydGN1dChXSS5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBX SS5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCAiUyIsIHRoaXMuX3NhdmUuYmluZCh0 aGlzKSwgdGhpcy5fZWxlbWVudCk7CiAgICAgICAgIH0KICAgICB9CiAKQEAgLTM3Nyw2ICszODAs MzggQEAgV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiA9IGNsYXNzIFNw cmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblMKICAgICAgICAgcmV0dXJuIG1lZGlhRWxlbWVu dDsKICAgICB9CiAKKyAgICBfc2F2ZShldmVudCkKKyAgICB7CisgICAgICAgIGV2ZW50LnN0b3Ao KTsKKworICAgICAgICBpZiAodGhpcy5fc3R5bGUudHlwZSAhPT0gV0kuQ1NTU3R5bGVEZWNsYXJh dGlvbi5UeXBlLlJ1bGUpIHsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBDYW4ndCBzYXZlIENTUyBp bnNpZGUgPHN0eWxlPjwvc3R5bGU+IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTAzNTc+CisgICAg ICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3QuYmVlcCgpOworICAgICAgICAgICAgcmV0dXJu OworICAgICAgICB9CisKKyAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fc3R5bGUub3duZXJS dWxlIGluc3RhbmNlb2YgV0kuQ1NTUnVsZSk7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMu X3N0eWxlLm93bmVyUnVsZS5zb3VyY2VDb2RlTG9jYXRpb24gaW5zdGFuY2VvZiBXSS5Tb3VyY2VD b2RlTG9jYXRpb24pOworCisgICAgICAgIGxldCBzb3VyY2VDb2RlID0gdGhpcy5fc3R5bGUub3du ZXJSdWxlLnNvdXJjZUNvZGVMb2NhdGlvbi5zb3VyY2VDb2RlOworICAgICAgICBpZiAoc291cmNl Q29kZS50eXBlICE9PSBXSS5SZXNvdXJjZS5UeXBlLlN0eWxlc2hlZXQpIHsKKyAgICAgICAgICAg IC8vIEZJWE1FOiBDYW4ndCBzYXZlIENTUyBpbnNpZGUgc3R5bGU9IiIgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzE1MDM1Nz4KKyAgICAgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5iZWVwKCk7 CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBsZXQgdXJsOworICAg ICAgICBpZiAoc291cmNlQ29kZS51cmxDb21wb25lbnRzLnNjaGVtZSA9PT0gImRhdGEiKSB7Cisg ICAgICAgICAgICBsZXQgbWFpblJlc291cmNlID0gV0kuZnJhbWVSZXNvdXJjZU1hbmFnZXIubWFp bkZyYW1lLm1haW5SZXNvdXJjZTsKKyAgICAgICAgICAgIGxldCBwYXRoRGlyZWN0b3J5ID0gbWFp blJlc291cmNlLnVybC5zbGljZSgwLCAtbWFpblJlc291cmNlLnVybENvbXBvbmVudHMubGFzdFBh dGhDb21wb25lbnQubGVuZ3RoKTsKKyAgICAgICAgICAgIHVybCA9IHBhdGhEaXJlY3RvcnkgKyAi YmFzZTY0LmNzcyI7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgdXJsID0gc291cmNlQ29k ZS51cmw7CisKKyAgICAgICAgY29uc3Qgc2F2ZUFzID0gZXZlbnQuc2hpZnRLZXk7CisgICAgICAg IFdJLnNhdmVEYXRhVG9GaWxlKHt1cmw6IHVybCwgY29udGVudDogc291cmNlQ29kZS5jb250ZW50 fSwgc2F2ZUFzKTsKKyAgICB9CisKICAgICBfaGFuZGxlTW91c2VEb3duKGV2ZW50KQogICAgIHsK ICAgICAgICAgdGhpcy5fd2FzRm9jdXNlZCA9IHRoaXMuX3Byb3BlcnRpZXNFZGl0b3IuaXNGb2N1 c2VkKCk7Cg== 329684 2017-12-18 14:30:15 -0800 2017-12-18 15:02:43 -0800 Patch patch.txt text/plain 3623 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJmMTkyMjIuLjE2ODEyOGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTE4ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxl cyBSZWRlc2lnbjogQ29tbWFuZC1TIHNob3VsZCBzYXZlIGNoYW5nZXMgaW4gbWF0Y2hpbmcgQ1NT IHJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODA5MDAKKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCisKKyAgICAg ICAgV2hlbiBmb2N1c2VkIG9uIGEgQ1NTIHNlbGVjdG9yLCBwcm9wZXJ0eSBuYW1lIG9yIHZhbHVl LCBwcmVzc2luZyBDb21tYW5kLVMgc2hvdWxkIHNhdmUKKyAgICAgICAgdGhlIENTUyByZXNvdXJj ZSB0byB0aGUgZmlsZSBzeXN0ZW0uCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Nw cmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanM6CisgICAgICAgIChXSS5TcHJl YWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLnByb3RvdHlwZS5pbml0aWFsTGF5b3V0 KToKKyAgICAgICAgKFdJLlNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24ucHJv dG90eXBlLl9zYXZlKToKKwogMjAxNy0xMi0xNSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjI1OTQxLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFk c2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rp b24uanMKaW5kZXggN2MwYzVlNC4uMTYzMDZiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9u U2VjdGlvbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCkBAIC0xMDQsNiArMTA0 LDkgQEAgV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiA9IGNsYXNzIFNw cmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblMKICAgICAgICAgaWYgKHRoaXMuX3N0eWxlLmVk aXRhYmxlKSB7CiAgICAgICAgICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xp Y2siLCB0aGlzLl9oYW5kbGVDbGljay5iaW5kKHRoaXMpKTsKICAgICAgICAgICAgIHRoaXMuZWxl bWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLl9oYW5kbGVNb3VzZURvd24u YmluZCh0aGlzKSk7CisKKyAgICAgICAgICAgIG5ldyBXSS5LZXlib2FyZFNob3J0Y3V0KFdJLktl eWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwgIlMiLCB0aGlzLl9zYXZl LmJpbmQodGhpcyksIHRoaXMuX2VsZW1lbnQpOworICAgICAgICAgICAgbmV3IFdJLktleWJvYXJk U2hvcnRjdXQoV0kuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwg V0kuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgIlMiLCB0aGlzLl9zYXZlLmJpbmQo dGhpcyksIHRoaXMuX2VsZW1lbnQpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0zNzcsNiArMzgw LDQyIEBAIFdJLlNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24gPSBjbGFzcyBT cHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TCiAgICAgICAgIHJldHVybiBtZWRpYUVsZW1l bnQ7CiAgICAgfQogCisgICAgX3NhdmUoZXZlbnQpCisgICAgeworICAgICAgICBldmVudC5zdG9w KCk7CisKKyAgICAgICAgaWYgKHRoaXMuX3N0eWxlLnR5cGUgIT09IFdJLkNTU1N0eWxlRGVjbGFy YXRpb24uVHlwZS5SdWxlKSB7CisgICAgICAgICAgICAvLyBGSVhNRTogQ2FuJ3Qgc2F2ZSBDU1Mg aW5zaWRlIDxzdHlsZT48L3N0eWxlPiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTUwMzU3PgorICAg ICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmJlZXAoKTsKKyAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgfQorCisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuX3N0eWxlLm93bmVy UnVsZSBpbnN0YW5jZW9mIFdJLkNTU1J1bGUpOworICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlz Ll9zdHlsZS5vd25lclJ1bGUuc291cmNlQ29kZUxvY2F0aW9uIGluc3RhbmNlb2YgV0kuU291cmNl Q29kZUxvY2F0aW9uKTsKKworICAgICAgICBsZXQgc291cmNlQ29kZSA9IHRoaXMuX3N0eWxlLm93 bmVyUnVsZS5zb3VyY2VDb2RlTG9jYXRpb24uc291cmNlQ29kZTsKKyAgICAgICAgaWYgKHNvdXJj ZUNvZGUudHlwZSAhPT0gV0kuUmVzb3VyY2UuVHlwZS5TdHlsZXNoZWV0KSB7CisgICAgICAgICAg ICAvLyBGSVhNRTogQ2FuJ3Qgc2F2ZSBDU1MgaW5zaWRlIHN0eWxlPSIiIDxodHRwczovL3dlYmtp dC5vcmcvYi8xNTAzNTc+CisgICAgICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3QuYmVlcCgp OworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgbGV0IHVybDsKKyAg ICAgICAgaWYgKHNvdXJjZUNvZGUudXJsQ29tcG9uZW50cy5zY2hlbWUgPT09ICJkYXRhIikgewor ICAgICAgICAgICAgbGV0IG1haW5SZXNvdXJjZSA9IFdJLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLm1h aW5GcmFtZS5tYWluUmVzb3VyY2U7CisgICAgICAgICAgICBpZiAobWFpblJlc291cmNlLnVybENv bXBvbmVudHMubGFzdFBhdGhDb21wb25lbnQuZW5kc1dpdGgoIi5odG1sIikpCisgICAgICAgICAg ICAgICAgdXJsID0gbWFpblJlc291cmNlLnVybC5yZXBsYWNlKC9cLmh0bWwkLywgIi1kYXRhLmNz cyIpOworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgbGV0IHBhdGhEaXJlY3Rv cnkgPSBtYWluUmVzb3VyY2UudXJsLnNsaWNlKDAsIC1tYWluUmVzb3VyY2UudXJsQ29tcG9uZW50 cy5sYXN0UGF0aENvbXBvbmVudC5sZW5ndGgpOworICAgICAgICAgICAgICAgIHVybCA9IHBhdGhE aXJlY3RvcnkgKyAiZGF0YS5jc3MiOworICAgICAgICAgICAgfQorICAgICAgICB9IGVsc2UKKyAg ICAgICAgICAgIHVybCA9IHNvdXJjZUNvZGUudXJsOworCisgICAgICAgIGNvbnN0IHNhdmVBcyA9 IGV2ZW50LnNoaWZ0S2V5OworICAgICAgICBXSS5zYXZlRGF0YVRvRmlsZSh7dXJsOiB1cmwsIGNv bnRlbnQ6IHNvdXJjZUNvZGUuY29udGVudH0sIHNhdmVBcyk7CisgICAgfQorCiAgICAgX2hhbmRs ZU1vdXNlRG93bihldmVudCkKICAgICB7CiAgICAgICAgIHRoaXMuX3dhc0ZvY3VzZWQgPSB0aGlz Ll9wcm9wZXJ0aWVzRWRpdG9yLmlzRm9jdXNlZCgpOwo=