180885 2017-12-15 14:49:03 -0800 Plugin processes are repeatedly spun up to do nothing 2017-12-16 09:57:14 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham andersca beidson bfulgham commit-queue ggaren webkit-bug-importer oldest_to_newest 1382314 0 bfulgham 2017-12-15 14:49:03 -0800 The code in 'WebsiteDataStore::removeData' calls State::deleteData, even if there are no hostnames with data to be deleted. This causes a PluginProcess to be spun up for each plugin type, which is told to delete data from no websites. The processes then shut down. We shouldn't be doing this. 1382315 1 webkit-bug-importer 2017-12-15 14:50:53 -0800 <rdar://problem/36082564> 1382323 2 bfulgham 2017-12-15 15:07:08 -0800 I noticed this problem while doing further debugging and testing after the changes for Bug 180819. However, this bug existed before then. 1382325 3 329523 bfulgham 2017-12-15 15:10:02 -0800 Created attachment 329523 Patch 1382326 4 bfulgham 2017-12-15 15:11:23 -0800 Another fix might be to have State::deleteData() return early if hostNames or plugins is empty. 1382328 5 bfulgham 2017-12-15 15:14:44 -0800 Yikes! That has been that way since 2015! 1382331 6 329523 ggaren 2017-12-15 15:15:55 -0800 Comment on attachment 329523 Patch r=me 1382332 7 ggaren 2017-12-15 15:18:22 -0800 Can we API test this? Seems like the kind of subtle mistake that might happen again. 1382369 8 329538 bfulgham 2017-12-15 16:34:10 -0800 Created attachment 329538 Patch for landing 1382503 9 329538 commit-queue 2017-12-16 09:57:13 -0800 Comment on attachment 329538 Patch for landing Clearing flags on attachment: 329538 Committed r225999: <https://trac.webkit.org/changeset/225999> 1382504 10 commit-queue 2017-12-16 09:57:14 -0800 All reviewed patches have been landed. Closing bug. 329523 2017-12-15 15:10:02 -0800 2017-12-15 16:34:08 -0800 Patch bug-180885-20171215151002.patch text/plain 1348 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU5ODgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTE1ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFBsdWdpbiBwcm9jZXNzZXMgYXJl IHJlcGVhdGVkbHkgc3B1biB1cCB0byBkbyBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA4ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzM2MDgyNTY0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpyZW1vdmVEYXRhKTogRG9uJ3QgYXNrIHBsdWdp bnMgdG8gcmVtb3ZlIGRhdGEgd2hlbiBubyB3ZWJzaXRlcyBhcmUKKyAgICAgICAgcGFzc2VkIHRv IHRoZSBmdW5jdGlvbi4KKwogMjAxNy0xMi0xNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBHVEsgYnVpbGQuCkluZGV4OiBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0 b3JlLmNwcAkocmV2aXNpb24gMjI1OTg0KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi c2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMjUsNyAr MTEyNSw4IEBAIHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6cmVtb3ZlRGF0YShPcHRpb24KICAgICAg ICAgICAgIFZlY3RvcjxTdHJpbmc+IG1faG9zdE5hbWVzOwogICAgICAgICB9OwogCi0gICAgICAg IFN0YXRlOjpkZWxldGVEYXRhKCpjYWxsYmFja0FnZ3JlZ2F0b3IsIHBsdWdpbnMoKSwgV1RGTW92 ZShob3N0TmFtZXMpKTsKKyAgICAgICAgaWYgKCFob3N0TmFtZXMuaXNFbXB0eSgpKQorICAgICAg ICAgICAgU3RhdGU6OmRlbGV0ZURhdGEoKmNhbGxiYWNrQWdncmVnYXRvciwgcGx1Z2lucygpLCBX VEZNb3ZlKGhvc3ROYW1lcykpOwogICAgIH0KICNlbmRpZgogCg== 329538 2017-12-15 16:34:10 -0800 2017-12-16 09:57:13 -0800 Patch for landing bug-180885-20171215163409.patch text/plain 3291 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU5ODgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTE1ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFBsdWdpbiBwcm9jZXNzZXMgYXJl IHJlcGVhdGVkbHkgc3B1biB1cCB0byBkbyBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA4ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzM2MDgyNTY0PgorCisgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgorCisgICAg ICAgIFRlc3RlZCBieSBUZXN0V2ViS2l0QVBJLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNp dGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0 YVN0b3JlOjpyZW1vdmVEYXRhKTogRG9uJ3QgYXNrIHBsdWdpbnMgdG8gcmVtb3ZlIGRhdGEgd2hl biBubyB3ZWJzaXRlcyBhcmUKKyAgICAgICAgcGFzc2VkIHRvIHRoZSBmdW5jdGlvbi4KKwogMjAx Ny0xMi0xNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIEZpeCBHVEsgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJz aXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAkocmV2aXNpb24gMjI1 OTg0KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFT dG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMjUsNyArMTEyNSw4IEBAIHZvaWQgV2Vic2l0 ZURhdGFTdG9yZTo6cmVtb3ZlRGF0YShPcHRpb24KICAgICAgICAgICAgIFZlY3RvcjxTdHJpbmc+ IG1faG9zdE5hbWVzOwogICAgICAgICB9OwogCi0gICAgICAgIFN0YXRlOjpkZWxldGVEYXRhKCpj YWxsYmFja0FnZ3JlZ2F0b3IsIHBsdWdpbnMoKSwgV1RGTW92ZShob3N0TmFtZXMpKTsKKyAgICAg ICAgaWYgKCFob3N0TmFtZXMuaXNFbXB0eSgpKQorICAgICAgICAgICAgU3RhdGU6OmRlbGV0ZURh dGEoKmNhbGxiYWNrQWdncmVnYXRvciwgcGx1Z2lucygpLCBXVEZNb3ZlKGhvc3ROYW1lcykpOwog ICAgIH0KICNlbmRpZgogCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU5OTEpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0xMi0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJm dWxnaGFtQGFwcGxlLmNvbT4KKworICAgICAgICBQbHVnaW4gcHJvY2Vzc2VzIGFyZSByZXBlYXRl ZGx5IHNwdW4gdXAgdG8gZG8gbm90aGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwODg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjA4MjU2 ND4KKworICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KKworICAgICAgICAqIFRl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tIVFRQQ29va2llU3RvcmUubW06CisgICAg ICAgIChydW5UZXN0V2l0aFdlYnNpdGVEYXRhU3RvcmUpOiBDaGVjayB0aGF0IGRlbGV0aW5nIHdl YnNpdGUgZGF0YSBkaWQgbm90CisgICAgICAgIHRyaWdnZXIgYW55IHBsdWdpbiBwcm9jZXNzZXMg dG8gc3RhcnQgdXAuCisKIDIwMTctMTItMTUgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRh QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRpbmcgbXlzZWxmIHRvIGNvbnRy aWJ1dG9ycy5qc29uCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1dLSFRUUENvb2tpZVN0b3JlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvV0tIVFRQQ29va2llU3RvcmUubW0JKHJldmlzaW9uIDIyNTk4MykK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tIVFRQQ29va2llU3Rv cmUubW0JKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAKICNpbXBvcnQgIlRlc3ROYXZp Z2F0aW9uRGVsZWdhdGUuaCIKICNpbXBvcnQgPFdlYktpdC9XS0ZvdW5kYXRpb24uaD4KICNpbXBv cnQgPFdlYktpdC9XS0hUVFBDb29raWVTdG9yZS5oPgorI2ltcG9ydCA8V2ViS2l0L1dLUHJvY2Vz c1Bvb2xQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tXZWJzaXRlRGF0YVN0b3JlUHJpdmF0 ZS5oPgogI2ltcG9ydCA8V2ViS2l0L19XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLmg+ CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CkBAIC03MSw2ICs3MiwxMCBAQCBzdGF0aWMgdm9p ZCBydW5UZXN0V2l0aFdlYnNpdGVEYXRhU3RvcmUoCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6 cnVuKCZnb3RGbGFnKTsKICAgICBnb3RGbGFnID0gZmFsc2U7CiAKKyAgICAvLyBUcmlnZ2VyaW5n IHJlbW92ZURhdGEgd2hlbiB3ZSBkb24ndCBoYXZlIHBsdWdpbiBkYXRhIHRvIHJlbW92ZSBzaG91 bGQgbm90IHRyaWdnZXIgdGhlIHBsdWdpbiBwcm9jZXNzIHRvIGxhdW5jaC4KKyAgICBpZCBwb29s ID0gW1dLUHJvY2Vzc1Bvb2wgX3NoYXJlZFByb2Nlc3NQb29sXTsKKyAgICBFWFBFQ1RfRVEoW3Bv b2wgX3BsdWdpblByb2Nlc3NDb3VudF0sIHN0YXRpY19jYXN0PHNpemVfdD4oMCkpOworCiAgICAg Z2xvYmFsQ29va2llU3RvcmUgPSBkYXRhU3RvcmUuaHR0cENvb2tpZVN0b3JlOwogICAgIFJldGFp blB0cjxDb29raWVPYnNlcnZlcj4gb2JzZXJ2ZXIxID0gYWRvcHROUyhbW0Nvb2tpZU9ic2VydmVy IGFsbG9jXSBpbml0XSk7CiAgICAgUmV0YWluUHRyPENvb2tpZU9ic2VydmVyPiBvYnNlcnZlcjIg PSBhZG9wdE5TKFtbQ29va2llT2JzZXJ2ZXIgYWxsb2NdIGluaXRdKTsK