180867 2017-12-15 10:03:55 -0800 imported/w3c/web-platform-tests/service-workers/service-worker/update.https.html is sometimes crashing in Debug builds 2017-12-15 11:58:25 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf cdumez beidson cdumez commit-queue jlewis3 ryanhaddad webkit-bug-importer oldest_to_newest 1382179 0 youennf 2017-12-15 10:03:55 -0800 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000011a2dce04 WTFCrash + 36 (Assertions.cpp:272) 1 com.apple.WebCore 0x000000010ddc4fa5 WebCore::SWServer::runServiceWorker(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>) + 213 (SWServer.cpp:521) 2 com.apple.WebCore 0x000000010ddc5365 WebCore::SWServer::runServiceWorkerIfNecessary(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WTF::Function<void (bool, WebCore::SWServerToContextConnection&)>&&) + 309 (SWServer.cpp:506) 3 com.apple.WebKit 0x00000001070cff84 WebKit::WebSWServerConnection::startFetch(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&) + 308 (WebSWServerConnection.cpp:127) 4 com.apple.WebKit 0x00000001070e6618 void IPC::callMemberFunctionImpl<WebKit::WebSWServerConnection, void (WebKit::WebSWServerConnection::*)(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&), std::__1::tuple<unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest, WebCore::FetchOptions, IPC::FormDataReference>, 0ul, 1ul, 2ul, 3ul, 4ul>(WebKit::WebSWServerConnection*, void (WebKit::WebSWServerConnection::*)(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&), std::__1::tuple<unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest, WebCore::FetchOptions, IPC::FormDataReference>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul>) + 376 (HandleMessage.h:41) 5 com.apple.WebKit 0x00000001070e6108 void IPC::callMemberFunction<WebKit::WebSWServerConnection, void (WebKit::WebSWServerConnection::*)(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&), std::__1::tuple<unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest, WebCore::FetchOptions, IPC::FormDataReference>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul> >(std::__1::tuple<unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest, WebCore::FetchOptions, IPC::FormDataReference>&&, WebKit::WebSWServerConnection*, void (WebKit::WebSWServerConnection::*)(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&)) + 88 (HandleMessage.h:47) 6 com.apple.WebKit 0x00000001070e3337 void IPC::handleMessage<Messages::WebSWServerConnection::StartFetch, WebKit::WebSWServerConnection, void (WebKit::WebSWServerConnection::*)(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&)>(IPC::Decoder&, WebKit::WebSWServerConnection*, void (WebKit::WebSWServerConnection::*)(unsigned long long, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, WebCore::ResourceRequest&&, WebCore::FetchOptions&&, IPC::FormDataReference&&)) + 471 (HandleMessage.h:127) 7 com.apple.WebKit 0x00000001070e274c WebKit::WebSWServerConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 636 (WebSWServerConnectionMessageReceiver.cpp:73) 8 com.apple.WebKit 0x0000000106a116c3 WebKit::StorageToWebProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 851 (StorageToWebProcessConnection.cpp:91) 9 com.apple.WebKit 0x0000000106552373 IPC::Connection::dispatchMessage(IPC::Decoder&) + 51 (Connection.cpp:902) 10 com.apple.WebKit 0x0000000106549778 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 712 (Connection.cpp:930) 11 com.apple.WebKit 0x0000000106552970 IPC::Connection::dispatchOneMessage() + 1520 (Connection.cpp:959) 1382180 1 youennf 2017-12-15 10:04:21 -0800 See https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r225957%20(4641)/imported/w3c/web-platform-tests/service-workers/service-worker/update.https-crash-log.txt 1382191 2 cdumez 2017-12-15 10:18:14 -0800 Hitting this assertion: auto addResult = m_runningOrTerminatingWorkers.add(identifier, *worker); ASSERT_UNUSED(addResult, addResult.isNewEntry); 1382193 3 cdumez 2017-12-15 10:19:53 -0800 (In reply to Chris Dumez from comment #2) > Hitting this assertion: > auto addResult = m_runningOrTerminatingWorkers.add(identifier, *worker); > ASSERT_UNUSED(addResult, addResult.isNewEntry); I believe the assertion is wrong. It is possible for the worker to be already in m_runningOrTerminatingWorkers but its state is Terminating (not Running). 1382196 4 329496 cdumez 2017-12-15 10:22:55 -0800 Created attachment 329496 Patch 1382229 5 329496 commit-queue 2017-12-15 11:57:05 -0800 Comment on attachment 329496 Patch Clearing flags on attachment: 329496 Committed r225976: <https://trac.webkit.org/changeset/225976> 1382230 6 commit-queue 2017-12-15 11:57:07 -0800 All reviewed patches have been landed. Closing bug. 1382232 7 webkit-bug-importer 2017-12-15 11:58:25 -0800 <rdar://problem/36078659> 329496 2017-12-15 10:22:55 -0800 2017-12-15 11:57:05 -0800 Patch bug-180867-20171215102254.patch text/plain 1608 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQwZGZhZWI5ZjU5ZGE2 YjlhZDRjM2FhNDY1NDVjNjgxNWI0M2VmMC4uNTVjMTAxZjViOGY5NTc2MjMxOTFiMWU4Yjc3MTU5 ZmQ3ZDE5NzBjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvdXBkYXRlLmh0dHBz Lmh0bWwgaXMgc29tZXRpbWVzIGNyYXNoaW5nIGluIERlYnVnIGJ1aWxkcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwODY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFzc2VydGlvbiB0byBtYWtl IHN1cmUgdGhlIHdvcmtlciBpcyB0ZXJtaW5hdGluZyBpZiBpdCBpcyBhbHJlYWR5IGluIG1fcnVu bmluZ09yVGVybWluYXRpbmdXb3JrZXJzLgorCisgICAgICAgICogd29ya2Vycy9zZXJ2aWNlL3Nl cnZlci9TV1NlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTV1NlcnZlcjo6cnVuU2Vydmlj ZVdvcmtlcik6CisKIDIwMTctMTItMTUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBTZXJ2aWNlIFdvcmtlciBSZWdpc3RyYXRpb24gcHJvbWlzZSBpcyBzb21ldGlt ZXMgbm90IHJlamVjdGVkIHdoZW4gdGhlIHNjcmlwdCBsb2FkIGZhaWxzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IDk0Zjlm YTA1NjMwMTFjZjNiODJhOTAxZTJhNjk2MTQ4NDhkYWMxNWIuLjdmMTY4Njg0MTlkMmEzMmY5ZjA4 NmNkZDk5NGVjYjIzZWFlMmM3ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv c2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv c2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC01MTgsNyArNTE4LDcgQEAgYm9vbCBTV1Nl cnZlcjo6cnVuU2VydmljZVdvcmtlcihTZXJ2aWNlV29ya2VySWRlbnRpZmllciBpZGVudGlmaWVy KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBhdXRvIGFkZFJlc3VsdCA9IG1fcnVubmlu Z09yVGVybWluYXRpbmdXb3JrZXJzLmFkZChpZGVudGlmaWVyLCAqd29ya2VyKTsKLSAgICBBU1NF UlRfVU5VU0VEKGFkZFJlc3VsdCwgYWRkUmVzdWx0LmlzTmV3RW50cnkpOworICAgIEFTU0VSVF9V TlVTRUQoYWRkUmVzdWx0LCBhZGRSZXN1bHQuaXNOZXdFbnRyeSB8fCB3b3JrZXItPmlzVGVybWlu YXRpbmcoKSk7CiAKICAgICB3b3JrZXItPnNldFN0YXRlKFNXU2VydmVyV29ya2VyOjpTdGF0ZTo6 UnVubmluZyk7CiAK