180866 2017-12-15 08:59:01 -0800 AX: macOS VoiceOver doesn't announce when details element is expanded when using role group 2018-05-29 23:31:11 -0700 1 1 1 Unclassified WebKit Accessibility Safari 11 Mac OS X 10.11 RESOLVED FIXED InRadar P2 Normal --- 1 anika.henke webkit-unassigned aboxhall apinheiro cfleizach commit-queue darin dmazzoni ews-watchlist jcraig jdiggs n_wang samuel_white webkit-bug-importer oldest_to_newest 1382165 0 anika.henke 2017-12-15 08:59:01 -0800 When you expand a details element which has the ARIA role "group" or access one which is already expanded, it wrongly announces that it is collapsed in VoiceOver on OS X 11. Steps to reproduce: 1. Activate VoiceOver on OS X 2. Open http://jsbin.com/cequcu in Safari 3. Navigate to the first details element ("Open this") 4. Hit the space bar to open the element Result: VoiceOver says "Open this, collapsed, summary". Expected: VoiceOver should say "Open this, expanded, summary" like it does in the second example (which doesn't include the group role). Although the group role is the default implicit role of the details element [http://w3c.github.io/html/interactive-elements.html#elementdef-details] and it is recommended not to use it in such a case [http://w3c.github.io/html/dom.html#do-not-set], it should also not make the element behave any differently. 1382166 1 webkit-bug-importer 2017-12-15 09:00:39 -0800 <rdar://problem/36074338> 1428314 2 341546 n_wang 2018-05-29 18:34:46 -0700 Created attachment 341546 patch 1428317 3 341546 cfleizach 2018-05-29 19:00:29 -0700 Comment on attachment 341546 patch View in context: https://bugs.webkit.org/attachment.cgi?id=341546&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:-2800 > - return object.roleValue() == AccessibilityRole::Details; What if someone made a details element into a landmark. Would we still expose expanded status? Also is the attribute name exposed in this case? We might want to list out the allowed roles a details can have and still have an expanded status 1428325 4 n_wang 2018-05-29 19:59:02 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 341546 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341546&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:-2800 > > - return object.roleValue() == AccessibilityRole::Details; > > What if someone made a details element into a landmark. Would we still > expose expanded status? Yes I think so. > > Also is the attribute name exposed in this case? > > We might want to list out the allowed roles a details can have and still > have an expanded status I don't see a list of allowed roles in any spec for details element. Do you have any suggestions? Or I can only allow details element with group role for this particular case 1428341 5 341546 commit-queue 2018-05-29 21:01:20 -0700 Comment on attachment 341546 patch Clearing flags on attachment: 341546 Committed r232285: <https://trac.webkit.org/changeset/232285> 1428342 6 commit-queue 2018-05-29 21:01:22 -0700 All reviewed patches have been landed. Closing bug. 1428355 7 341546 darin 2018-05-29 21:44:47 -0700 Comment on attachment 341546 patch View in context: https://bugs.webkit.org/attachment.cgi?id=341546&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2800 > + return object.node() && is<HTMLDetailsElement>(object.node()); No need to do a null check if using is<>, which returns false for null. So it would be better to just write: return is<HTMLDetailsElement>(object.node()); 1428365 8 n_wang 2018-05-29 23:31:11 -0700 (In reply to Darin Adler from comment #7) > Comment on attachment 341546 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341546&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2800 > > + return object.node() && is<HTMLDetailsElement>(object.node()); > > No need to do a null check if using is<>, which returns false for null. So > it would be better to just write: > > return is<HTMLDetailsElement>(object.node()); Ok updated https://trac.webkit.org/changeset/232287/ 341546 2018-05-29 18:34:46 -0700 2018-05-29 21:01:20 -0700 patch patch.txt text/plain 4337 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjI4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA1LTI5ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IG1hY09TIFZvaWNlT3ZlciBkb2Vz bid0IGFubm91bmNlIHdoZW4gZGV0YWlscyBlbGVtZW50IGlzIGV4cGFuZGVkIHdoZW4gdXNpbmcg cm9sZSBncm91cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTgwODY2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjA3NDMzOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgdXNlIGlzPEhU TUxEZXRhaWxzRWxlbWVudD4gdG8gY2hlY2sgZm9yIHRoZSBkZXRhaWxzIHBhcmVudCBpbnN0ZWFk CisgICAgICAgIG9mIHVzaW5nIHRoZSByb2xlLgorCisgICAgICAgIEFkZGVkIHRlc3QgY2FzZXMg dG8gdGhlIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6 aXNFeHBhbmRlZCBjb25zdCk6CisKIDIwMTgtMDUtMjkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIGNvbnNpc3RlbmN5IGNoZWNrIGJldHdlZW4gVVJM IGFuZCBDRlVSTApJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCShyZXZpc2lvbiAyMzIyNTkpCisrKyBTb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNzk3LDcgKzI3OTcsNyBAQCBib29sIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmlzRXhwYW5k ZWQoKSBjCiAgICAgLy8gU3VtbWFyeSBlbGVtZW50IHNob3VsZCB1c2UgaXRzIGRldGFpbHMgcGFy ZW50J3MgZXhwYW5kZWQgc3RhdHVzLgogICAgIGlmIChpc1N1bW1hcnkoKSkgewogICAgICAgICBp ZiAoY29uc3QgQWNjZXNzaWJpbGl0eU9iamVjdCogcGFyZW50ID0gQWNjZXNzaWJpbGl0eU9iamVj dDo6bWF0Y2hlZFBhcmVudCgqdGhpcywgZmFsc2UsIFtdIChjb25zdCBBY2Nlc3NpYmlsaXR5T2Jq ZWN0JiBvYmplY3QpIHsKLSAgICAgICAgICAgIHJldHVybiBvYmplY3Qucm9sZVZhbHVlKCkgPT0g QWNjZXNzaWJpbGl0eVJvbGU6OkRldGFpbHM7CisgICAgICAgICAgICByZXR1cm4gb2JqZWN0Lm5v ZGUoKSAmJiBpczxIVE1MRGV0YWlsc0VsZW1lbnQ+KG9iamVjdC5ub2RlKCkpOwogICAgICAgICB9 KSkKICAgICAgICAgICAgIHJldHVybiBwYXJlbnQtPmlzRXhwYW5kZWQoKTsKICAgICB9CkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiAyMzIyNTkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wNS0yOSAgTmFuIFdhbmcgIDxuX3dhbmdAYXBw bGUuY29tPgorCisgICAgICAgIEFYOiBtYWNPUyBWb2ljZU92ZXIgZG9lc24ndCBhbm5vdW5jZSB3 aGVuIGRldGFpbHMgZWxlbWVudCBpcyBleHBhbmRlZCB3aGVuIHVzaW5nIHJvbGUgZ3JvdXAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDg2NgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzYwNzQzMzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9kZXRhaWxzLXN1bW1h cnktZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL2RldGFpbHMtc3Vt bWFyeS5odG1sOgorCiAyMDE4LTA1LTI5ICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgQVg6IHNldFZhbHVlIG9uIGNvbnRlbnRlZGl0YWJsZSBzaG91bGQgcHJlc2VydmUg d2hpdGVzcGFjZQpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvZGV0YWlscy1z dW1tYXJ5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L21hYy9kZXRhaWxzLXN1bW1hcnktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMzIyNTkpCisr KyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9kZXRhaWxzLXN1bW1hcnktZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yLDYgKzIsOSBAQCBTb21lIG9wZW4gaW5mbwogRGV0YWls cyBhYm91dCB0aGUgb3BlbiB0b3BpYy4KIAogU29tZSBvcGVuIGluZm8KK1NvbWUgb3BlbiBpbmZv CitEZXRhaWxzIGFib3V0IHRoZSBvcGVuIHRvcGljLgorCiBUaGlzIHRlc3RzIHNvbWUgYmFzaWMg YXR0cmlidXRlcyBhYm91dCB0aGUgZGV0YWlscyBlbGVtZW50LgogCiBPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCkBAIC0yNCw2ICsyNyw4IEBAIFBBU1MgZGV0YWlsczEuaXNFeHBhbmRlZCBpcyB0 cnVlCiBQQVNTIHN1bW1hcnkxLmlzRXhwYW5kZWQgaXMgdHJ1ZQogUEFTUyBkZXRhaWxzMi5zdWJy b2xlIGlzICdBWFN1YnJvbGU6IEFYRGV0YWlscycKIFBBU1MgZGV0YWlsczIuaXNFeHBhbmRlZCBp cyBmYWxzZQorUEFTUyBkZXRhaWxzMy5zdWJyb2xlIGlzICdBWFN1YnJvbGU6IEFYQXBwbGljYXRp b25Hcm91cCcKK1BBU1MgZGV0YWlsczMuaXNFeHBhbmRlZCBpcyB0cnVlCiBSZWNlaXZlZCBBWEV4 cGFuZGVkQ2hhbmdlZCBub3RpZmljYXRpb24gCiBSZWNlaXZlZCBBWEV4cGFuZGVkQ2hhbmdlZCBu b3RpZmljYXRpb24gCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCkluZGV4OiBMYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9kZXRhaWxzLXN1bW1hcnkuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9kZXRhaWxzLXN1bW1hcnkuaHRtbAko cmV2aXNpb24gMjMyMjU5KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvZGV0YWls cy1zdW1tYXJ5Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE1LDYgKzE1LDExIEBACiAgIDxwPkRl dGFpbHMgYWJvdXQgdGhlIG9wZW4gdG9waWMuPC9wPgogPC9kZXRhaWxzPgogCis8ZGV0YWlscyBv cGVuIGlkPSJkZXRhaWxzMyIgcm9sZT0iZ3JvdXAiPgorICA8c3VtbWFyeT5Tb21lIG9wZW4gaW5m bzwvc3VtbWFyeT4KKyAgPHA+RGV0YWlscyBhYm91dCB0aGUgb3BlbiB0b3BpYy48L3A+Cis8L2Rl dGFpbHM+CisKIDxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgogPGRpdiBpZD0iY29uc29sZSI+PC9k aXY+CiAKQEAgLTc5LDYgKzg0LDExIEBACiAgICAgICAgIHZhciBkZXRhaWxzMiA9IGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgiZGV0YWlsczIiKTsKICAgICAg ICAgc2hvdWxkQmUoImRldGFpbHMyLnN1YnJvbGUiLCAiJ0FYU3Vicm9sZTogQVhEZXRhaWxzJyIp OwogICAgICAgICBzaG91bGRCZUZhbHNlKCJkZXRhaWxzMi5pc0V4cGFuZGVkIik7CisKKyAgICAg ICAgLy8gRXhwYW5kZWQgc3RhdHVzIHNob3VsZCBiZSBjb3JyZWN0IHdoZW4gZGV0YWlsIGhhcyBn cm91cCByb2xlCisgICAgICAgIHZhciBkZXRhaWxzMyA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVy LmFjY2Vzc2libGVFbGVtZW50QnlJZCgiZGV0YWlsczMiKTsKKyAgICAgICAgc2hvdWxkQmUoImRl dGFpbHMzLnN1YnJvbGUiLCAiJ0FYU3Vicm9sZTogQVhBcHBsaWNhdGlvbkdyb3VwJyIpOworICAg ICAgICBzaG91bGRCZVRydWUoImRldGFpbHMzLmlzRXhwYW5kZWQiKTsKICAgICB9CiAKIDwvc2Ny aXB0Pgo=