180848 2017-12-14 16:45:05 -0800 check-webkit-style: Stop warning about underscores in webrtc source 2017-12-14 19:28:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180757 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ews-watchlist glenn joepeck lforschler thorton webkit-bug-importer youennf oldest_to_newest 1381908 0 ddkilzer 2017-12-14 16:45:05 -0800 Warnings about underscores in function names in webrtc code should be suppressed. 1381911 1 329421 ddkilzer 2017-12-14 16:48:51 -0800 Created attachment 329421 Patch v1 1381917 2 329423 ddkilzer 2017-12-14 16:52:32 -0800 Created attachment 329423 Patch v2 1381991 3 329423 joepeck 2017-12-14 19:04:55 -0800 Comment on attachment 329423 Patch v2 rs=me 1381992 4 329423 joepeck 2017-12-14 19:05:40 -0800 Comment on attachment 329423 Patch v2 r=me. You changed the existing comment. Did you want to keep both? 1381994 5 329423 joepeck 2017-12-14 19:06:08 -0800 Comment on attachment 329423 Patch v2 Oh it said `and`! cq+ 1382013 6 329423 commit-queue 2017-12-14 19:26:31 -0800 Comment on attachment 329423 Patch v2 Clearing flags on attachment: 329423 Committed r225957: <https://trac.webkit.org/changeset/225957> 1382014 7 commit-queue 2017-12-14 19:26:33 -0800 All reviewed patches have been landed. Closing bug. 1382017 8 webkit-bug-importer 2017-12-14 19:28:10 -0800 <rdar://problem/36065806> 329421 2017-12-14 16:48:51 -0800 2017-12-14 16:52:31 -0800 Patch v1 bug-180848-20171214164850.patch text/plain 1602 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1OTA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWVhZjA5N2I2YTU4MDk1NjYwMTU3OWQyMGY2NTQ1NWNk Yzg5Y2VlOS4uN2EyYzE5ZmIxYmE4MTQ3YzA2YzE5MTBkMTA2YzIxNzVkYzJkN2RmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTEyLTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBTdG9wIHdhcm5pbmcgYWJvdXQgdW5kZXJzY29yZXMg aW4gd2VicnRjIHNvdXJjZQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTgwODQ4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICAoX1BBVEhfUlVMRVNfU1BFQ0lG SUVSKTogU3VwcHJlc3MgcmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2NvcmVzCisgICAgICAgIHdh cm5pbmdzIHVuZGVyIFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjLgor CiAyMDE3LTEyLTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAg ICAgICB3ZWJraXRweTogQmV0dGVyIG5hbWUtdmVyc2lvbiBtYXBwaW5nIChGb2xsb3ctdXAgZml4 KQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CmluZGV4IDhlMGNjMThiYzQz NzAyZWJjODBlMmNhYzEyOTMxNjVjMjk3MDRhN2QuLjU5YzcyZWE3NTVlYjA3Y2EwMmViMDAzYjU1 N2RhYjUyOTNkM2EyZjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkK QEAgLTI1Miw4ICsyNTIsOSBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICBvcy5w YXRoLmpvaW4oJ1NvdXJjZScsICdXZWJDb3JlJywgJ1BBTCcsICdwYWwnLCAnc3BpJywgJ2NvY29h JywgJ1Bhc3NLaXRTUEkuaCcpXSwKICAgICAgWyItYnVpbGQvaW5jbHVkZSJdKSwKIAotICAgIChb ICAjIFNvbWUgU1BJIGhlYWRlcnMgaGF2ZSBpZGVudGlmaWVyIG5hbWVzIHdpdGggdW5kZXJzY29y ZXMuCi0gICAgICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJDb3JlJywgJ1BBTCcsICdwYWwn LCAnc3BpJyldLAorICAgIChbICAjIGxpYndlYnJ0YyBzb3VyY2UgYW5kIHNvbWUgU1BJIGhlYWRl cnMgaGF2ZSBpZGVudGlmaWVyIG5hbWVzIHdpdGggdW5kZXJzY29yZXMuCisgICAgICBvcy5wYXRo LmpvaW4oJ1NvdXJjZScsICdXZWJDb3JlJywgJ1BBTCcsICdwYWwnLCAnc3BpJyksCisgICAgICBv cy5wYXRoLmpvaW4oJ1NvdXJjZScsICdUaGlyZFBhcnR5JywgJ2xpYndlYnJ0YycsICdTb3VyY2Un LCAnd2VicnRjJyldLAogICAgICBbIi1yZWFkYWJpbGl0eS9uYW1pbmcvdW5kZXJzY29yZXMiXSks CiBdCiAK 329423 2017-12-14 16:52:32 -0800 2017-12-14 19:26:31 -0800 Patch v2 bug-180848-20171214165231.patch text/plain 1536 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1OTA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWVhZjA5N2I2YTU4MDk1NjYwMTU3OWQyMGY2NTQ1NWNk Yzg5Y2VlOS4uN2EyYzE5ZmIxYmE4MTQ3YzA2YzE5MTBkMTA2YzIxNzVkYzJkN2RmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTEyLTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBTdG9wIHdhcm5pbmcgYWJvdXQgdW5kZXJzY29yZXMg aW4gd2VicnRjIHNvdXJjZQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTgwODQ4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICAoX1BBVEhfUlVMRVNfU1BFQ0lG SUVSKTogU3VwcHJlc3MgcmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2NvcmVzCisgICAgICAgIHdh cm5pbmdzIHVuZGVyIFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjLgor CiAyMDE3LTEyLTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAg ICAgICB3ZWJraXRweTogQmV0dGVyIG5hbWUtdmVyc2lvbiBtYXBwaW5nIChGb2xsb3ctdXAgZml4 KQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CmluZGV4IDhlMGNjMThiYzQz NzAyZWJjODBlMmNhYzEyOTMxNjVjMjk3MDRhN2QuLmFmYmNhNDM4ZDkxYjQ5ODNlNGU1NjBiNzEy ZTMwN2NhYjVjN2I2MmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkK QEAgLTI1Miw3ICsyNTIsOCBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICBvcy5w YXRoLmpvaW4oJ1NvdXJjZScsICdXZWJDb3JlJywgJ1BBTCcsICdwYWwnLCAnc3BpJywgJ2NvY29h JywgJ1Bhc3NLaXRTUEkuaCcpXSwKICAgICAgWyItYnVpbGQvaW5jbHVkZSJdKSwKIAotICAgIChb ICAjIFNvbWUgU1BJIGhlYWRlcnMgaGF2ZSBpZGVudGlmaWVyIG5hbWVzIHdpdGggdW5kZXJzY29y ZXMuCisgICAgKFsgICMgbGlid2VicnRjIHNvdXJjZSBhbmQgc29tZSBTUEkgaGVhZGVycyBoYXZl IGlkZW50aWZpZXIgbmFtZXMgd2l0aCB1bmRlcnNjb3Jlcy4KKyAgICAgIG9zLnBhdGguam9pbign U291cmNlJywgJ1RoaXJkUGFydHknLCAnbGlid2VicnRjJywgJ1NvdXJjZScsICd3ZWJydGMnKSwK ICAgICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYkNvcmUnLCAnUEFMJywgJ3BhbCcsICdz cGknKV0sCiAgICAgIFsiLXJlYWRhYmlsaXR5L25hbWluZy91bmRlcnNjb3JlcyJdKSwKIF0K