180842 2017-12-14 14:39:12 -0800 srflx and relay ICE candidates lack raddr (rel-addr) and rport (rel-port) attributes if getUserMedia access has not been granted 2017-12-14 18:16:09 -0800 1 1 1 Unclassified WebKit WebRTC Safari 11 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mroberts youennf achristensen commit-queue eric.carlson jonlee webkit-bug-importer youennf oldest_to_newest 1381837 0 mroberts 2017-12-14 14:39:12 -0800 Reproduction Steps: 1. Create an RTCPeerConnection with STUN (and/or TURN) servers 2. Negotiate (doesn't matter if Safari offers or answers first) 3. Wait for ICE candidates You can execute these steps using the following JSFiddle: https://jsfiddle.net/Lm7Lebz4/ Expected Result: srflx and relay candidates include the raddr (rel-addr) and rport (rel-port) attributes required by RFC 5245, Section 15.1: https://tools.ietf.org/html/rfc5245#section-15.1 Actual Result: srflx and relay candidates lack raddr and rport. *** If you call `getUserMedia` before executing Steps 1–3 above, you will get a different result! raddr and rport will be present. These two cases are represented in the JSFiddle by the two buttons. Note: you may wish to simply copy the JavaScript from the JSFiddle, paste it into the browser console, and invoke `test(true)` or `test(false)` yourself, since calling `getUserMedia` first will trigger > NotAllowedError (DOM Exception 35): The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission. when invoked from JSFiddle. *** Other notes: I'm investigating ICE failures between Safari and Firefox when Safari is not sharing any media. I'm not sure if this is the cause of the failure or a symptom of some other issue. This issue also resembles this WebRTC Issue 1202: https://bugs.chromium.org/p/webrtc/issues/detail?id=1202 1381841 1 youennf 2017-12-14 14:46:34 -0800 Hi Mark, thanks for the report. host candidates are filtered out for privacy reasons and so are raddr/rport information on reflexive and relay candidates. I would be interested to know whether this causes any actual issue. 1381852 2 mroberts 2017-12-14 15:09:59 -0800 Hi Youenn, Thanks for the quick response. > host candidates are filtered out for privacy reasons Yes, this is what I expected. I think I remember you mentioning this at Kranky Geek. IMO, there should be no problem there. > and so are raddr/rport information on reflexive and relay candidates. However, this seems to be the source of the interop problem with Firefox. If I write a little function to patch these up before sending them out: function patchIceCandidate(candidate) { var candidateStr = candidate.candidate; var type = candidateStr.match(/typ ([^ ]*)/)[1]; switch (type) { case 'srflx': case 'prflx': case 'relay': var raddr = candidateStr.match(/raddr ([^ ]*)/); var rport = candidateStr.match(/rport ([^ ]*)/); if (!raddr || !rport) { console.warn(type + ' ICE candidate lacks raddr and/or rport: ' + candidateStr); if (!raddr) { candidateStr = candidateStr.replace('generation', 'raddr 0.0.0.0 generation'); } if (!rport) { candidateStr = candidateStr.replace('generation', 'rport 0 generation'); } candidate = new RTCIceCandidate({ candidate: candidateStr, sdpMid: candidate.sdpMid, sdpMLineIndex: candidate.sdpMLineIndex }); } default: break; } return candidate; } Then there are no more ICE failures in Firefox. I can understand filtering the raddr and rport attributes if they include sensitive information; however, I suppose Firefox may be a bit stricter in its parsing of ICE candidates (since technically raddr and rport are required). Strangely, though, it doesn't raise an error. I will probably open an issue with them next. Also, I can understand filtering the raddr and rport attributes if they includes sensitive information; however, in the test I shared, I see they are just set to 0.0.0.0 and 0 _if `getUserMedia` was previously called_ (note that it doesn't matter if the resulting MediaStreamTracks are added to any RTCPeerConnections or not). So maybe instead of filtering, Safari could use these dummy values? Thanks! Mark 1381858 3 mroberts 2017-12-14 15:14:17 -0800 Here is an example error in Firefox's about:webrtc under "Connection Log" when such an ICE candidate is provided by Safari: > ICE(PC:1513292453729479 (id=2147483657 url=https://simpler-signaling.appspot.com/?iceTransportPolicy=relay)): Error parsing attribute: candidate:1735000762 1 udp 33562623 34.203.251.116 58685 typ relay generation 0 ufrag 4S1R network-cost 50 1381869 4 329409 youennf 2017-12-14 15:43:22 -0800 Created attachment 329409 Patch 1381968 5 329409 commit-queue 2017-12-14 18:14:08 -0800 Comment on attachment 329409 Patch Clearing flags on attachment: 329409 Committed r225955: <https://trac.webkit.org/changeset/225955> 1381969 6 commit-queue 2017-12-14 18:14:10 -0800 All reviewed patches have been landed. Closing bug. 1381971 7 webkit-bug-importer 2017-12-14 18:16:09 -0800 <rdar://problem/36064667> 329409 2017-12-14 15:43:22 -0800 2017-12-14 18:14:08 -0800 Patch bug-180842-20171214154322.patch text/plain 1785 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU5ZGI0YmZjNjM5YTQz NzBmYjFiN2I1NWZkNmQ5NDJmYTdkMDZiNi4uOGEwYzNkM2JhMjJmMWU1ZDE1NTU1MjU4MzQzYTU5 MTIzNmRjZjdlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTEyLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBzcmZseCBhbmQgcmVsYXkg SUNFIGNhbmRpZGF0ZXMgbGFjayByYWRkciAocmVsLWFkZHIpIGFuZCBycG9ydCAocmVsLXBvcnQp IGF0dHJpYnV0ZXMgaWYgZ2V0VXNlck1lZGlhIGFjY2VzcyBoYXMgbm90IGJlZW4gZ3JhbnRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwODQyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFudWFsbHkg dGVzdGVkIHNpbmNlIHRoZXJlIGlzIG5vIHdheSB0byBnYXRoZXIgcmVmbGV4aXZlIG9yIHN0dW4g Y2FuZGlkYXRlcyBpbiBXZWJLaXQgQ0kuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt L1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaWx0ZXJJQ0VD YW5kaWRhdGUpOgorCisyMDE3LTEyLTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KKwogICAgICAgICBVcGRhdGUgdG8gbGlid2VicnRjIHJldmlzaW9uIDRlNzBhNzI1NzFkZDI2 Yjg1YzIzODVlOWM2MThlMzQzNDI4ZGY1ZDMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MDg0MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHAKaW5kZXgg MmFkODRiZDk4MjU4ZjdjY2Y2ZTU5Y2U1YTIyNjJkNjFlYTUzMGU1OS4uNDY4N2UyMzI0NmY5YTc5 NjY3ZGM1ZWJhYjY0ODIwMTlkNGZkNzExOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNwcApAQCAt MzM2LDcgKzMzNiwxMyBAQCBzdGF0aWMgU3RyaW5nIGZpbHRlcklDRUNhbmRpZGF0ZShTdHJpbmcm JiBzZHApCiAgICAgICAgICAgICBza2lwTmV4dEl0ZW0gPSBmYWxzZTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQotICAgICAgICBpZiAoaXRlbSA9PSAicmFkZHIiIHx8IGl0ZW0gPT0g InJwb3J0IikgeworICAgICAgICBpZiAoaXRlbSA9PSAicmFkZHIiKSB7CisgICAgICAgICAgICBm aWx0ZXJlZFNEUC5hcHBlbmQoIiByYWRkciAwLjAuMC4wIik7CisgICAgICAgICAgICBza2lwTmV4 dEl0ZW0gPSB0cnVlOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIGlm IChpdGVtID09ICJycG9ydCIpIHsKKyAgICAgICAgICAgIGZpbHRlcmVkU0RQLmFwcGVuZCgiIHJw b3J0IDAiKTsKICAgICAgICAgICAgIHNraXBOZXh0SXRlbSA9IHRydWU7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0K