180840 2017-12-14 14:21:31 -0800 Fix assertion in JSObject's structure setting methods 2017-12-14 14:31:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1381825 0 keith_miller 2017-12-14 14:21:31 -0800 Fix assertion in JSObject's structure setting methods 1381828 1 329404 keith_miller 2017-12-14 14:23:43 -0800 Created attachment 329404 Patch 1381829 2 329404 mark.lam 2017-12-14 14:25:57 -0800 Comment on attachment 329404 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329404&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + added to them they call the generic code. The generic code Please add a comma between "them they". 1381832 3 keith_miller 2017-12-14 14:29:01 -0800 Addressed comments and landed in: https://trac.webkit.org/r225933 1381833 4 webkit-bug-importer 2017-12-14 14:31:28 -0800 <rdar://problem/36058568> 329404 2017-12-14 14:23:43 -0800 2017-12-14 14:25:57 -0800 Patch bug-180840-20171214142342.patch text/plain 2615 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm MWFmZGZkZThmYTUzNmIyZWY4MWRhMTYwYjgyMDczNzhhMjMxNDExLi5jZWUxMWE4M2ZiNWI5ZjY3 ZTUwMDRhNzg4OWVmNDQ4MDZlMzFkOTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0xMi0xNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggYXNzZXJ0aW9uIGluIEpTT2JqZWN0J3Mgc3RydWN0dXJlIHNl dHRpbmcgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgwODQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSSBmb3Jnb3QgdGhhdCB3aGVuIFR5cGVkIEFycmF5cyBoYXZlIG5vbi1pbmRleGVkIHBy b3BlcnRpZXMKKyAgICAgICAgYWRkZWQgdG8gdGhlbSB0aGV5IGNhbGwgdGhlIGdlbmVyaWMgY29k ZS4gVGhlIGdlbmVyaWMgY29kZQorICAgICAgICBpbiB0dXJuIGNhbGxzIHRoZSByZWd1bGFyIHN0 cnVjdHVyZSBzZXR0aW5nIG1ldGhvZHMuIFRodXMsCisgICAgICAgIHRoZXNlIGFzc2VydGlvbnMg d2VyZSBpbnZhbGlkIGFuZCB3ZSBzaG91bGQganVzdCBhdm9pZCBzZXR0aW5nCisgICAgICAgIHRo ZSBpbmRleGluZyBtYXNrIGlmIHdlIGhhdmUgYSBUeXBlZCBBcnJheS4KKworICAgICAgICAqIHJ1 bnRpbWUvSlNPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OnNldEJ1dHRlcmZseSk6 CisgICAgICAgIChKU0M6OkpTT2JqZWN0OjpudWtlU3RydWN0dXJlQW5kU2V0QnV0dGVyZmx5KToK KwogMjAxNy0xMi0xMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU09iamVjdHMgc2hvdWxkIGhhdmUgYSBtYXNrIGZvciBsb2FkaW5nIGluZGV4ZWQg cHJvcGVydGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNP YmplY3QuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKaW5kZXgg ZDZhY2VhYWUyYzcxZmU0ZmM4YzdhZTA0MDE0NGUzYzM0NmQwNzA2ZC4uMGFlOWIyZjIxZWMwM2Y1 OGIwMzEzYTdiNDJlMzZkZTc4YWU5YmM5MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPYmplY3QuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU09iamVjdC5oCkBAIC0xMjY1LDggKzEyNjUsOCBAQCBpbmxpbmUgdm9pZCBKU09iamVjdDo6 c2V0QnV0dGVyZmx5V2l0aEluZGV4aW5nTWFzayhWTSYgdm0sIEJ1dHRlcmZseSogYnV0dGVyZmx5 LAogCiBpbmxpbmUgdm9pZCBKU09iamVjdDo6c2V0QnV0dGVyZmx5KFZNJiB2bSwgQnV0dGVyZmx5 KiBidXR0ZXJmbHkpCiB7Ci0gICAgQVNTRVJUKCFzdHJ1Y3R1cmUoKS0+aGlqYWNrc0luZGV4aW5n SGVhZGVyKCkpOwotICAgIG1fYnV0dGVyZmx5SW5kZXhpbmdNYXNrID0gYnV0dGVyZmx5LT5jb21w dXRlSW5kZXhpbmdNYXNrKCk7CisgICAgaWYgKExJS0VMWSghc3RydWN0dXJlKHZtKS0+aGlqYWNr c0luZGV4aW5nSGVhZGVyKCkpKQorICAgICAgICBtX2J1dHRlcmZseUluZGV4aW5nTWFzayA9IGJ1 dHRlcmZseS0+Y29tcHV0ZUluZGV4aW5nTWFzaygpOwogICAgIEFTU0VSVChtX2J1dHRlcmZseUlu ZGV4aW5nTWFzayA+PSBidXR0ZXJmbHktPnZlY3Rvckxlbmd0aCgpKTsKICAgICBpZiAoaXNYODYo KSB8fCB2bS5oZWFwLm11dGF0b3JTaG91bGRCZUZlbmNlZCgpKSB7CiAgICAgICAgIFdURjo6c3Rv cmVTdG9yZUZlbmNlKCk7CkBAIC0xMjgwLDggKzEyODAsOCBAQCBpbmxpbmUgdm9pZCBKU09iamVj dDo6c2V0QnV0dGVyZmx5KFZNJiB2bSwgQnV0dGVyZmx5KiBidXR0ZXJmbHkpCiAKIGlubGluZSB2 b2lkIEpTT2JqZWN0OjpudWtlU3RydWN0dXJlQW5kU2V0QnV0dGVyZmx5KFZNJiB2bSwgU3RydWN0 dXJlSUQgb2xkU3RydWN0dXJlSUQsIEJ1dHRlcmZseSogYnV0dGVyZmx5KQogewotICAgIEFTU0VS VCghdm0uZ2V0U3RydWN0dXJlKG9sZFN0cnVjdHVyZUlEKS0+aGlqYWNrc0luZGV4aW5nSGVhZGVy KCkpOwotICAgIG1fYnV0dGVyZmx5SW5kZXhpbmdNYXNrID0gYnV0dGVyZmx5LT5jb21wdXRlSW5k ZXhpbmdNYXNrKCk7CisgICAgaWYgKExJS0VMWSghdm0uZ2V0U3RydWN0dXJlKG9sZFN0cnVjdHVy ZUlEKS0+aGlqYWNrc0luZGV4aW5nSGVhZGVyKCkpKQorICAgICAgICBtX2J1dHRlcmZseUluZGV4 aW5nTWFzayA9IGJ1dHRlcmZseS0+Y29tcHV0ZUluZGV4aW5nTWFzaygpOwogICAgIEFTU0VSVCht X2J1dHRlcmZseUluZGV4aW5nTWFzayA+PSBidXR0ZXJmbHktPnZlY3Rvckxlbmd0aCgpKTsKICAg ICBpZiAoaXNYODYoKSB8fCB2bS5oZWFwLm11dGF0b3JTaG91bGRCZUZlbmNlZCgpKSB7CiAgICAg ICAgIHNldFN0cnVjdHVyZUlERGlyZWN0bHkobnVrZShvbGRTdHJ1Y3R1cmVJRCkpOwo=