180832 2017-12-14 13:08:49 -0800 [Web Animations] Use is<> when possible 2017-12-14 14:16:47 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts dino webkit-bug-importer oldest_to_newest 1381768 0 graouts 2017-12-14 13:08:49 -0800 [Web Animations] Use is<> when possible 1381770 1 329389 graouts 2017-12-14 13:09:24 -0800 Created attachment 329389 Patch 1381772 2 329389 dino 2017-12-14 13:10:41 -0800 Comment on attachment 329389 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329389&action=review > Source/WebCore/animation/WebAnimation.cpp:748 > - downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated(); > + if (is<KeyframeEffect>(m_effect)) > + downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState(); Did you intend to make this change? 1381773 3 graouts 2017-12-14 13:14:10 -0800 (In reply to Dean Jackson from comment #2) > Comment on attachment 329389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329389&action=review > > > Source/WebCore/animation/WebAnimation.cpp:748 > > - downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated(); > > + if (is<KeyframeEffect>(m_effect)) > > + downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState(); > > Did you intend to make this change? Not with the method change name, will fix in commit. 1381820 4 graouts 2017-12-14 14:15:33 -0800 Committed r225929: <https://trac.webkit.org/changeset/225929> 1381823 5 webkit-bug-importer 2017-12-14 14:16:47 -0800 <rdar://problem/36058088> 329389 2017-12-14 13:09:24 -0800 2017-12-14 13:10:41 -0800 Patch bug-180832-20171214220923.patch text/plain 2749 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNmNGRkYmFmYjBhYmVm ZmI5ODAwYzVhYzhjYmVlNzkxZDM2NjY5Yy4uN2EzZTIyNTliM2Y5ODBjMGRlNjg3NTFkOTM3NWE2 NTQ0ZGNiNWMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEyLTE0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBVc2UgaXM8PiB3aGVuIHBvc3NpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODA4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZG9wdCBpczw+IHdoZW4gcG9zc2libGUuCisKKyAgICAgICAgKiBh bmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkFuaW1hdGlv bjo6c2V0RWZmZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OldlYkFuaW1hdGlvbjo6c2V0VGltZWxp bmUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViQW5pbWF0aW9uOjpzdGFydE9yU3RvcEFjY2VsZXJh dGVkKToKKwogMjAxNy0xMi0xNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgog CiAgICAgICAgIFtXZWIgQW5pbWF0aW9uc10gSW1wbGVtZW50IHRoZSBmaW5pc2goKSBtZXRob2Qg b24gQW5pbWF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2ViQW5p bWF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb24uY3BwCmlu ZGV4IDE3MmZlY2RmYWU0OWFjZmI3ZDQwYmVmMThmMzUyZTA5NTM5NDI1Y2IuLjE5NjcwZjIwMDVk NDI5MTU1N2ZmMTMzZjEyNzhhNWQyZjMyNjhmMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2FuaW1hdGlvbi9XZWJBbmltYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlv bi9XZWJBbmltYXRpb24uY3BwCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgV2ViQW5pbWF0aW9uOjpz ZXRFZmZlY3QoUmVmUHRyPEFuaW1hdGlvbkVmZmVjdD4mJiBlZmZlY3QpCiAgICAgICAgIG1fZWZm ZWN0LT5zZXRBbmltYXRpb24obnVsbHB0cik7CiAKICAgICAgICAgLy8gVXBkYXRlIHRoZSBFbGVt ZW50IHRvIEFuaW1hdGlvbiBtYXAuCi0gICAgICAgIGlmIChtX3RpbWVsaW5lICYmIG1fZWZmZWN0 LT5pc0tleWZyYW1lRWZmZWN0KCkpIHsKKyAgICAgICAgaWYgKG1fdGltZWxpbmUgJiYgaXM8S2V5 ZnJhbWVFZmZlY3Q+KG1fZWZmZWN0KSkgewogICAgICAgICAgICAgYXV0byoga2V5ZnJhbWVFZmZl Y3QgPSBkb3duY2FzdDxLZXlmcmFtZUVmZmVjdD4obV9lZmZlY3QuZ2V0KCkpOwogICAgICAgICAg ICAgYXV0byogdGFyZ2V0ID0ga2V5ZnJhbWVFZmZlY3QtPnRhcmdldCgpOwogICAgICAgICAgICAg aWYgKHRhcmdldCkKQEAgLTg5LDcgKzg5LDcgQEAgdm9pZCBXZWJBbmltYXRpb246OnNldEVmZmVj dChSZWZQdHI8QW5pbWF0aW9uRWZmZWN0PiYmIGVmZmVjdCkKIAogICAgICAgICBlZmZlY3QtPnNl dEFuaW1hdGlvbih0aGlzKTsKIAotICAgICAgICBpZiAobV90aW1lbGluZSAmJiBlZmZlY3QtPmlz S2V5ZnJhbWVFZmZlY3QoKSkgeworICAgICAgICBpZiAobV90aW1lbGluZSAmJiBpczxLZXlmcmFt ZUVmZmVjdD4oZWZmZWN0KSkgewogICAgICAgICAgICAgYXV0byoga2V5ZnJhbWVFZmZlY3QgPSBk b3duY2FzdDxLZXlmcmFtZUVmZmVjdD4oZWZmZWN0LmdldCgpKTsKICAgICAgICAgICAgIGF1dG8q IHRhcmdldCA9IGtleWZyYW1lRWZmZWN0LT50YXJnZXQoKTsKICAgICAgICAgICAgIGlmICh0YXJn ZXQpCkBAIC0xMTQsNyArMTE0LDcgQEAgdm9pZCBXZWJBbmltYXRpb246OnNldFRpbWVsaW5lKFJl ZlB0cjxBbmltYXRpb25UaW1lbGluZT4mJiB0aW1lbGluZSkKICAgICBpZiAodGltZWxpbmUpCiAg ICAgICAgIHRpbWVsaW5lLT5hZGRBbmltYXRpb24oKnRoaXMpOwogCi0gICAgaWYgKG1fZWZmZWN0 ICYmIG1fZWZmZWN0LT5pc0tleWZyYW1lRWZmZWN0KCkpIHsKKyAgICBpZiAoaXM8S2V5ZnJhbWVF ZmZlY3Q+KG1fZWZmZWN0KSkgewogICAgICAgICBhdXRvKiBrZXlmcmFtZUVmZmVjdCA9IGRvd25j YXN0PEtleWZyYW1lRWZmZWN0PihtX2VmZmVjdC5nZXQoKSk7CiAgICAgICAgIGF1dG8qIHRhcmdl dCA9IGtleWZyYW1lRWZmZWN0LT50YXJnZXQoKTsKICAgICAgICAgaWYgKHRhcmdldCkgewpAQCAt NzQ0LDggKzc0NCw4IEBAIHZvaWQgV2ViQW5pbWF0aW9uOjphY2NlbGVyYXRlZFJ1bm5pbmdTdGF0 ZURpZENoYW5nZSgpCiAKIHZvaWQgV2ViQW5pbWF0aW9uOjpzdGFydE9yU3RvcEFjY2VsZXJhdGVk KCkKIHsKLSAgICBpZiAobV9lZmZlY3QgJiYgbV9lZmZlY3QtPmlzS2V5ZnJhbWVFZmZlY3QoKSkK LSAgICAgICAgZG93bmNhc3Q8S2V5ZnJhbWVFZmZlY3Q+KCptX2VmZmVjdCkuc3RhcnRPclN0b3BB Y2NlbGVyYXRlZCgpOworICAgIGlmIChpczxLZXlmcmFtZUVmZmVjdD4obV9lZmZlY3QpKQorICAg ICAgICBkb3duY2FzdDxLZXlmcmFtZUVmZmVjdD4oKm1fZWZmZWN0KS51cGRhdGVBY2NlbGVyYXRl ZFBsYXlTdGF0ZSgpOwogfQogCiBXZWJBbmltYXRpb24mIFdlYkFuaW1hdGlvbjo6cmVhZHlQcm9t aXNlUmVzb2x2ZSgpCg==