180810 2017-12-14 06:25:50 -0800 build-jsc: allow to build out of tree 2017-12-21 09:51:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 guijemont webkit-unassigned clopez commit-queue guijemont lforschler webkit-bug-importer oldest_to_newest 1381598 0 guijemont 2017-12-14 06:25:50 -0800 At least in the case of cmake, we can build jsc out of tree if building with cmake directly, but build-jsc does not allow it. 1381599 1 329350 guijemont 2017-12-14 06:31:22 -0800 Created attachment 329350 Patch Patch fixing the issue for cmake. I don't know how to fix this for other build systems and don't have a way of testing them. 1384125 2 329350 commit-queue 2017-12-21 09:50:34 -0800 Comment on attachment 329350 Patch Clearing flags on attachment: 329350 Committed r226225: <https://trac.webkit.org/changeset/226225> 1384126 3 commit-queue 2017-12-21 09:50:35 -0800 All reviewed patches have been landed. Closing bug. 1384128 4 webkit-bug-importer 2017-12-21 09:51:23 -0800 <rdar://problem/36179798> 329350 2017-12-14 06:31:22 -0800 2017-12-21 09:50:34 -0800 Patch bug-180810-20171214083121.patch text/plain 2447 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1Nzk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM5YzZiZWE3ODNkNjA3MWU2MjhjMWQ4YzVkMDJjNzRj MzI0MGEzZC4uMDg0Y2Y3Njk5NmMxODc0M2UyNzVkOTY3Y2IyM2UyNTMwMTdmZjJjYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE3LTEyLTE0ICBHdWlsbGF1bWUgRW1vbnQgIDxndWlqZW1vbnRAaWdhbGlhLmNvbT4K KworICAgICAgICBidWlsZC1qc2M6IGFsbG93IHRvIGJ1aWxkIG91dCBvZiB0cmVlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODA4MTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQt anNjOgorCiAyMDE3LTEyLTEyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gQnVtcCBHU3RyZWFtZXIgdmVyc2lvbiB0 byAxLjEyIGluIGpoYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjIGIv VG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKaW5kZXggYzczNjBiOTIzZWJmZjE4OWM0NzgzODQ3ZWQ0 NTU1YjA1NjBkOGYzOS4uMzk2YmNhY2M3YTJlM2M3ZDdjNzMxZGQwNzk1NWU2ODcxMTUyNmNlZSAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9i dWlsZC1qc2MKQEAgLTUwLDYgKzUwLDcgQEAgbXkgJGZvcmNlQ0xvb3AgPSAwOwogbXkgJGNsaSA9 IDA7CiBteSAkbWFrZUFyZ3MgPSAiIjsKIG15IEBjbWFrZUFyZ3M7CitteSAkYnVpbGREaXIgPSAi IjsKIG15ICRjb3B5TGlicmFyaWVzID0gMTsKIG15ICRzdGFydFRpbWUgPSB0aW1lKCk7CiAKQEAg LTgyLDYgKzgzLDcgQEAgVXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8g cGFzcyB0byBidWlsZCBzeXN0ZW1dCiAgIC0tY2xpICAgICAgICAgICAgICAgICAgICAgICAgIEJ1 aWxkIHRoZSBuZXcganNjIGNvbW1hbmQgbGluZSBpbnRlcmZhY2UgKGRlZmF1bHQ6ICRjbGkpCiAg IC0tbWFrZWFyZ3M9PGFyZ3VtZW50cz4gICAgICAgIE9wdGlvbmFsIE1ha2VmaWxlIGZsYWdzCiAg IC0tY21ha2VhcmdzPTxhcmd1bWVudHM+ICAgICAgIE9uZSBvciBtb3JlIG9wdGlvbmFsIENNYWtl IGZsYWdzIChlLmcuIC0tY21ha2VhcmdzPSItREZPTz1iYXIgLURDTUFLRV9QUkVGSVhfUEFUSD0v dXNyL2xvY2FsIikKKyAgLS1idWlsZC1kaXI9PHBhdGg+ICAgICAgICAgICAgQnVpbGQgb3V0IG9m IHRyZWUgaW4gZGlyZWN0b3J5IGF0IDxwYXRoPgogRU9GCiAKIG15ICVvcHRpb25zID0gKApAQCAt OTMsNyArOTUsOCBAQCBteSAlb3B0aW9ucyA9ICgKICAgICAnY2xpIScgPT4gXCRjbGksCiAgICAg J2NvcHktbGlicmFyaWVzIScgPT4gXCRjb3B5TGlicmFyaWVzLAogICAgICdtYWtlYXJncz1zJyA9 PiBcJG1ha2VBcmdzLAotICAgICdjbWFrZWFyZ3M9cycgPT4gXEBjbWFrZUFyZ3MKKyAgICAnY21h a2VhcmdzPXMnID0+IFxAY21ha2VBcmdzLAorICAgICdidWlsZC1kaXI9cycgPT4gXCRidWlsZERp cgogKTsKIAogZm9yZWFjaCAoQGZlYXR1cmVzKSB7CkBAIC0xMTUsNiArMTE4LDExIEBAIGlmIChp c0FwcGxlV2luV2ViS2l0KCkpIHsKICAgICAkZnRsSklUID0gMDsKIH0KIAoraWYgKCRidWlsZERp ciAmJiAhaXNDTWFrZUJ1aWxkKCkpIHsKKyAgICBwcmludCBTVERFUlIgIi0tYnVpbGQtZGlyIGlz IGN1cnJlbnRseSBvbmx5IHN1cHBvcnRlZCBmb3IgY21ha2UgYnVpbGRzIjsKKyAgICBleGl0IDE7 Cit9CisKIGlmIChpc0pTQ09ubHkoKSAmJiBpc1dpbmRvd3MoKSkgewogICAgIChzeXN0ZW0oInB5 dGhvbiBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtd2luY2Fpcm8tbGlicy5weSIpID09IDAp IG9yIGRpZTsKICAgICBzeXN0ZW0oInB5dGhvbiBUb29scy9TY3JpcHRzL3VwZGF0ZS12c3doZXJl LnB5Iik7CkBAIC0xMzUsNiArMTQzLDEwIEBAIGlmICgkZm9yY2VDTG9vcCkgewogaWYgKGlzQ01h a2VCdWlsZCgpKSB7CiAgICAgcHVzaCBAY21ha2VBcmdzLCAkZm9yY2VDTG9vcCA/ICIgLURFTkFC TEVfSklUPU9GRiIgOiAiIC1ERU5BQkxFX0pJVD1PTiI7CiAgICAgcHVzaCBAY21ha2VBcmdzLCAk ZnRsSklUID8gIiAtREVOQUJMRV9GVExfSklUPU9OIiA6ICIgLURFTkFCTEVfRlRMX0pJVD1PRkYi OworICAgIGlmICgkYnVpbGREaXIpIHsKKyAgICAgICAgcHVzaCBAY21ha2VBcmdzLCAiICIgLiBz b3VyY2VEaXIoKTsKKyAgICAgICAgc2V0QmFzZVByb2R1Y3REaXIoJGJ1aWxkRGlyKTsKKyAgICB9 CiAKICAgICBteSBAZmVhdHVyZUFyZ3MgPSBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKTsKIAo=