180804 2017-12-14 03:39:28 -0800 [DFG] Reduce register pressure of WeakMapGet to be used for 32bit 2017-12-15 05:59:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist guijemont keith_miller mark.lam msaboff ryanhaddad saam webkit-bug-importer oldest_to_newest 1381564 0 ysuzuki 2017-12-14 03:39:28 -0800 [DFG] Reduce register pressure of WeakMapGet to be used for 32bit 1381565 1 329343 ysuzuki 2017-12-14 03:39:57 -0800 Created attachment 329343 Patch 1381568 2 329343 ysuzuki 2017-12-14 03:41:06 -0800 Comment on attachment 329343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329343&action=review > Source/JavaScriptCore/dfg/DFGRegisterBank.h:150 > + } Helper method for debugging. 1381657 3 329343 saam 2017-12-14 09:49:24 -0800 Comment on attachment 329343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329343&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10977 > + std::optional<GPRTemporary> index; Why optional? Does GPRTemporary have an empty constructor? If not, maybe it’s worth adding and you can just WTFMove() to it below instead of emplace > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10982 > + index.emplace(this, Reuse, hash); Does Reuse only reuse if we’re the last user of the value? 1381940 4 329343 ysuzuki 2017-12-14 17:38:11 -0800 Comment on attachment 329343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329343&action=review >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10977 >> + std::optional<GPRTemporary> index; > > Why optional? Does GPRTemporary have an empty constructor? If not, maybe it’s worth adding and you can just WTFMove() to it below instead of emplace OK, changed to using WTFMove(GPRTemporary()). >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10982 >> + index.emplace(this, Reuse, hash); > > Does Reuse only reuse if we’re the last user of the value? Yes, so this Reuse is just an optimization. 1381950 5 ysuzuki 2017-12-14 17:45:34 -0800 Committed r225952: <https://trac.webkit.org/changeset/225952> 1381955 6 webkit-bug-importer 2017-12-14 17:49:23 -0800 <rdar://problem/36064081> 1382139 7 ysuzuki 2017-12-15 05:59:04 -0800 Committed r225971: <https://trac.webkit.org/changeset/225971> 329343 2017-12-14 03:39:57 -0800 2017-12-14 09:49:24 -0800 Patch bug-180804-20171214203956.patch text/plain 5468 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MWM3YTJhZGY5NTY4MmQ0OTg5NGFkYTc1MTE3OTdhYWM3OWE4ZWU3Li5jYWVlZTAxMWIxY2Q0OTIx Mzc4NmYyZmFkNjFkM2Y4OGE3Y2M2NDA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0xMi0xNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbREZHXSBSZWR1Y2UgcmVnaXN0ZXIgcHJlc3N1cmUgb2YgV2Vha01h cEdldCB0byBiZSB1c2VkIGZvciAzMmJpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwODA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBmaXhlcyAzMmJpdCBmYWlsdXJlcyBvZiBKU0MgYnkgcmVk dWNpbmcgcmVnaXN0ZXIgcHJlc3N1cmUgb2YgV2Vha01hcEdldC4KKworICAgICAgICAqIGRmZy9E RkdSZWdpc3RlckJhbmsuaDoKKyAgICAgICAgKEpTQzo6REZHOjpSZWdpc3RlckJhbms6OmxvY2tl ZENvdW50IGNvbnN0KToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAg ICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlV2Vha01hcEdldCk6CisKIDIw MTctMTItMTMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBPY3Rh bmUvcmljaGFyZHMgcmVncmVzc2VkIGJ5IGEgd2hvcHBpbmcgMjAlIGJlY2F1c2UgZWxpbWluYXRl Q29tbW9uU3ViZXhwcmVzc2lvbnMgaGFzIGEgd2VpcmQgZml4cG9pbnQgcmVxdWlyZW1lbnQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUmVnaXN0ZXJCYW5rLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1JlZ2lzdGVyQmFuay5oCmluZGV4IGEzMzIzZTZh Y2JkNWVkMDdiZmQ0NDUzMzVkZGQ5OTNhZjgwYWQwNzkuLmUwNGYzY2FkYjA0Yjc0NWQyYzU3MGU1 OGFlZmNjYzk4M2UyYzRkZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHUmVnaXN0ZXJCYW5rLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdSZWdp c3RlckJhbmsuaApAQCAtMTM5LDYgKzEzOSwxNiBAQCBjbGFzcyBSZWdpc3RlckJhbmsgewogICAg ICAgICByZXR1cm4gYWxsb2NhdGVJbnRlcm5hbChjdXJyZW50TG93ZXN0LCBzcGlsbE1lKTsKICAg ICB9CiAKKyAgICB1aW50MzJfdCBsb2NrZWRDb3VudCgpIGNvbnN0CisgICAgeworICAgICAgICB1 aW50MzJfdCBjb3VudCA9IDA7CisgICAgICAgIGZvciAodWludDMyX3QgaSA9IDAgOyBpIDwgTlVN X1JFR1M7ICsraSkgeworICAgICAgICAgICAgaWYgKG1fZGF0YVtpXS5sb2NrQ291bnQpCisgICAg ICAgICAgICAgICAgKytjb3VudDsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gY291bnQ7Cisg ICAgfQorCiAgICAgLy8gQWxsb2NhdGVzIHRoZSBnaXZlbiByZWdpc3RlciwgZXZlbiBpZiB0aGlz IHdpbGwgZm9yY2UgYSBzcGlsbC4KICAgICBWaXJ0dWFsUmVnaXN0ZXIgYWxsb2NhdGVTcGVjaWZp YyhSZWdJRCByZWcpCiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcAppbmRleCBmMmIyMTlhOTkxNTI0NGRjMjhiYjdhZGRiNjExMmE5NDBi ZmQxNDgwLi5kOTRlMzFlZjhlODBiMjA5NTE4MmEzOTlmMmUxMTgxNWE1ZjNjNThlIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcApAQCAtMTA5 NjYsNDEgKzEwOTY2LDUyIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVNYXBTZXQoTm9k ZSogbm9kZSkKIAogdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVdlYWtNYXBHZXQoTm9kZSog bm9kZSkKIHsKLSAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCB3ZWFrTWFwKHRoaXMsIG5vZGUtPmNo aWxkMSgpKTsKLSAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCBrZXkodGhpcywgbm9kZS0+Y2hpbGQy KCkpOwotICAgIFNwZWN1bGF0ZUludDMyT3BlcmFuZCBoYXNoKHRoaXMsIG5vZGUtPmNoaWxkMygp KTsKLSAgICBKU1ZhbHVlUmVnc1RlbXBvcmFyeSByZXN1bHQodGhpcyk7Ci0KICAgICBHUFJUZW1w b3JhcnkgbWFzayh0aGlzKTsKLSAgICBHUFJUZW1wb3JhcnkgaW5kZXgodGhpcyk7CiAgICAgR1BS VGVtcG9yYXJ5IGJ1ZmZlcih0aGlzKTsKLSAgICBHUFJUZW1wb3JhcnkgYnVja2V0KHRoaXMpOwot Ci0gICAgR1BSUmVnIHdlYWtNYXBHUFIgPSB3ZWFrTWFwLmdwcigpOwotICAgIEdQUlJlZyBrZXlH UFIgPSBrZXkuZ3ByKCk7Ci0gICAgR1BSUmVnIGhhc2hHUFIgPSBoYXNoLmdwcigpOworICAgIEpT VmFsdWVSZWdzVGVtcG9yYXJ5IHJlc3VsdCh0aGlzKTsKIAogICAgIEdQUlJlZyBtYXNrR1BSID0g bWFzay5ncHIoKTsKLSAgICBHUFJSZWcgaW5kZXhHUFIgPSBpbmRleC5ncHIoKTsKICAgICBHUFJS ZWcgYnVmZmVyR1BSID0gYnVmZmVyLmdwcigpOwotICAgIEdQUlJlZyBidWNrZXRHUFIgPSBidWNr ZXQuZ3ByKCk7CiAgICAgSlNWYWx1ZVJlZ3MgcmVzdWx0UmVncyA9IHJlc3VsdC5yZWdzKCk7CiAK LSAgICBpZiAobm9kZS0+Y2hpbGQxKCkudXNlS2luZCgpID09IFdlYWtNYXBPYmplY3RVc2UpCi0g ICAgICAgIHNwZWN1bGF0ZVdlYWtNYXBPYmplY3Qobm9kZS0+Y2hpbGQxKCksIHdlYWtNYXBHUFIp OwotICAgIGVsc2UKLSAgICAgICAgc3BlY3VsYXRlV2Vha1NldE9iamVjdChub2RlLT5jaGlsZDEo KSwgd2Vha01hcEdQUik7CisgICAgc3RkOjpvcHRpb25hbDxHUFJUZW1wb3Jhcnk+IGluZGV4Owor ICAgIEdQUlJlZyBpbmRleEdQUiB7IEludmFsaWRHUFJSZWcgfTsKKyAgICB7CisgICAgICAgIFNw ZWN1bGF0ZUludDMyT3BlcmFuZCBoYXNoKHRoaXMsIG5vZGUtPmNoaWxkMygpKTsKKyAgICAgICAg R1BSUmVnIGhhc2hHUFIgPSBoYXNoLmdwcigpOworICAgICAgICBpbmRleC5lbXBsYWNlKHRoaXMs IFJldXNlLCBoYXNoKTsKKyAgICAgICAgaW5kZXhHUFIgPSBpbmRleC0+Z3ByKCk7CisgICAgICAg IG1faml0Lm1vdmUoaGFzaEdQUiwgaW5kZXhHUFIpOworICAgIH0KKworICAgIHsKKyAgICAgICAg U3BlY3VsYXRlQ2VsbE9wZXJhbmQgd2Vha01hcCh0aGlzLCBub2RlLT5jaGlsZDEoKSk7CisgICAg ICAgIEdQUlJlZyB3ZWFrTWFwR1BSID0gd2Vha01hcC5ncHIoKTsKKyAgICAgICAgaWYgKG5vZGUt PmNoaWxkMSgpLnVzZUtpbmQoKSA9PSBXZWFrTWFwT2JqZWN0VXNlKQorICAgICAgICAgICAgc3Bl Y3VsYXRlV2Vha01hcE9iamVjdChub2RlLT5jaGlsZDEoKSwgd2Vha01hcEdQUik7CisgICAgICAg IGVsc2UKKyAgICAgICAgICAgIHNwZWN1bGF0ZVdlYWtTZXRPYmplY3Qobm9kZS0+Y2hpbGQxKCks IHdlYWtNYXBHUFIpOworCisgICAgICAgIEFTU0VSVChXZWFrTWFwSW1wbDxXZWFrTWFwQnVja2V0 PFdlYWtNYXBCdWNrZXREYXRhS2V5Pj46Om9mZnNldE9mQ2FwYWNpdHkoKSA9PSBXZWFrTWFwSW1w bDxXZWFrTWFwQnVja2V0PFdlYWtNYXBCdWNrZXREYXRhS2V5VmFsdWU+Pjo6b2Zmc2V0T2ZDYXBh Y2l0eSgpKTsKKyAgICAgICAgQVNTRVJUKFdlYWtNYXBJbXBsPFdlYWtNYXBCdWNrZXQ8V2Vha01h cEJ1Y2tldERhdGFLZXk+Pjo6b2Zmc2V0T2ZCdWZmZXIoKSA9PSBXZWFrTWFwSW1wbDxXZWFrTWFw QnVja2V0PFdlYWtNYXBCdWNrZXREYXRhS2V5VmFsdWU+Pjo6b2Zmc2V0T2ZCdWZmZXIoKSk7Cisg ICAgICAgIG1faml0LmxvYWQzMihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyh3ZWFrTWFwR1BSLCBX ZWFrTWFwSW1wbDxXZWFrTWFwQnVja2V0PFdlYWtNYXBCdWNrZXREYXRhS2V5Pj46Om9mZnNldE9m Q2FwYWNpdHkoKSksIG1hc2tHUFIpOworICAgICAgICBtX2ppdC5sb2FkUHRyKE1hY3JvQXNzZW1i bGVyOjpBZGRyZXNzKHdlYWtNYXBHUFIsIFdlYWtNYXBJbXBsPFdlYWtNYXBCdWNrZXQ8V2Vha01h cEJ1Y2tldERhdGFLZXk+Pjo6b2Zmc2V0T2ZCdWZmZXIoKSksIGJ1ZmZlckdQUik7CisgICAgfQor CisgICAgU3BlY3VsYXRlQ2VsbE9wZXJhbmQga2V5KHRoaXMsIG5vZGUtPmNoaWxkMigpKTsKKyAg ICBHUFJSZWcga2V5R1BSID0ga2V5LmdwcigpOwogICAgIHNwZWN1bGF0ZU9iamVjdChub2RlLT5j aGlsZDIoKSwga2V5R1BSKTsKIAotICAgIEFTU0VSVChXZWFrTWFwSW1wbDxXZWFrTWFwQnVja2V0 PFdlYWtNYXBCdWNrZXREYXRhS2V5Pj46Om9mZnNldE9mQ2FwYWNpdHkoKSA9PSBXZWFrTWFwSW1w bDxXZWFrTWFwQnVja2V0PFdlYWtNYXBCdWNrZXREYXRhS2V5VmFsdWU+Pjo6b2Zmc2V0T2ZDYXBh Y2l0eSgpKTsKLSAgICBBU1NFUlQoV2Vha01hcEltcGw8V2Vha01hcEJ1Y2tldDxXZWFrTWFwQnVj a2V0RGF0YUtleT4+OjpvZmZzZXRPZkJ1ZmZlcigpID09IFdlYWtNYXBJbXBsPFdlYWtNYXBCdWNr ZXQ8V2Vha01hcEJ1Y2tldERhdGFLZXlWYWx1ZT4+OjpvZmZzZXRPZkJ1ZmZlcigpKTsKLSAgICBt X2ppdC5sb2FkMzIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3Mod2Vha01hcEdQUiwgV2Vha01hcElt cGw8V2Vha01hcEJ1Y2tldDxXZWFrTWFwQnVja2V0RGF0YUtleT4+OjpvZmZzZXRPZkNhcGFjaXR5 KCkpLCBtYXNrR1BSKTsKLSAgICBtX2ppdC5sb2FkUHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNz KHdlYWtNYXBHUFIsIFdlYWtNYXBJbXBsPFdlYWtNYXBCdWNrZXQ8V2Vha01hcEJ1Y2tldERhdGFL ZXk+Pjo6b2Zmc2V0T2ZCdWZmZXIoKSksIGJ1ZmZlckdQUik7CisjaWYgVVNFKEpTVkFMVUUzMl82 NCkKKyAgICBHUFJSZWcgYnVja2V0R1BSID0gcmVzdWx0UmVncy50YWdHUFIoKTsKKyNlbHNlCisg ICAgR1BSVGVtcG9yYXJ5IGJ1Y2tldCh0aGlzKTsKKyAgICBHUFJSZWcgYnVja2V0R1BSID0gYnVj a2V0LmdwcigpOworI2VuZGlmCisKICAgICBtX2ppdC5zdWIzMihUcnVzdGVkSW1tMzIoMSksIG1h c2tHUFIpOwotICAgIG1faml0Lm1vdmUoaGFzaEdQUiwgaW5kZXhHUFIpOwogCiAgICAgTWFjcm9B c3NlbWJsZXI6OkxhYmVsIGxvb3AgPSBtX2ppdC5sYWJlbCgpOwotCiAgICAgbV9qaXQuYW5kMzIo bWFza0dQUiwgaW5kZXhHUFIpOwogICAgIGlmIChub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgPT0g V2Vha1NldE9iamVjdFVzZSkgewogICAgICAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihXZWFrTWFw QnVja2V0PFdlYWtNYXBCdWNrZXREYXRhS2V5PikgPT0gc2l6ZW9mKHZvaWQqKSwgIiIpOwo=