180790 2017-12-13 18:10:48 -0800 logVMFailure should not simulate crash on iOS 2020-11-04 10:29:41 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218571 InRadar P2 Normal --- 1 saam saam commit-queue ddkilzer fpizlo ggaren jfbastien keith_miller webkit-bug-importer oldest_to_newest 1381443 0 saam 2017-12-13 18:10:48 -0800 Reasons I don't think we should do this: 1. Gigacage will often fail 2. I think user controlled allocations in JS may bottom out in tryVMAllocate. Since the allocation size is often user controlled, and JS gracefully handles tryVMAllocate failing, and throws an OOM, it seems weird to consider this a crash. 1381472 1 329313 saam 2017-12-13 19:47:50 -0800 Created attachment 329313 patch I will wait for feedback from Dave before landing since we were talking about it offline already. An alternative patch could be to just log if the allocation is under some threshold, say 1MB or 10MB. 1381674 2 329313 jfbastien 2017-12-14 10:47:51 -0800 Comment on attachment 329313 patch r=me 1381675 3 329313 keith_miller 2017-12-14 10:49:34 -0800 Comment on attachment 329313 patch Do we want to log a failure on MacOS still? 1381677 4 saam 2017-12-14 10:51:22 -0800 (In reply to Keith Miller from comment #3) > Comment on attachment 329313 [details] > patch > > Do we want to log a failure on MacOS still? Logging only does things for iOS. Also, I'm not convinced we ever want to log if this is a user controlled input. 1381690 5 329313 commit-queue 2017-12-14 11:10:58 -0800 Comment on attachment 329313 patch Clearing flags on attachment: 329313 Committed r225912: <https://trac.webkit.org/changeset/225912> 1381691 6 commit-queue 2017-12-14 11:10:59 -0800 All reviewed patches have been landed. Closing bug. 1381692 7 webkit-bug-importer 2017-12-14 11:11:16 -0800 <rdar://problem/36052852> 329313 2017-12-13 19:47:50 -0800 2017-12-14 11:10:58 -0800 patch c-backup.diff text/plain 1370 saam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNTg5MCkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTEzICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIGxvZ1ZNRmFpbHVyZSBzaG91bGQg bm90IHNpbXVsYXRlIGNyYXNoIG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIEdpZ2FjYWdlIGFsbG9jYXRpb24gb24gaU9TIGlzIGV4cGVj dGVkIHRvIGZhaWwgaW4gY2VydGFpbiBjaXJjdW1zdGFuY2VzLiAKKyAgICAgICAgTGV0J3Mgbm90 IHNpbXVsYXRlIGEgY3Jhc2ggb24gZmFpbHVyZSBiZWNhdXNlIHNpbmNlIHRoaXMgaXMgZXhwZWN0 ZWQgYmVoYXZpb3IuCisKKyAgICAgICAgKiBibWFsbG9jL1ZNQWxsb2NhdGUuaDoKKyAgICAgICAg KGJtYWxsb2M6OnRyeVZNQWxsb2NhdGUpOgorCiAyMDE3LTEyLTExICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgdXNpbmcgZGVwcmVjYXRlZCB0 YXJnZXQgY29uZGl0aW9uYWwgZm9yIHNpbXVsYXRvciBidWlsZHMKSW5kZXg6IFNvdXJjZS9ibWFs bG9jL2JtYWxsb2MvVk1BbGxvY2F0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvVk1BbGxvY2F0ZS5oCShyZXZpc2lvbiAyMjU4ODgpCisrKyBTb3VyY2UvYm1hbGxvYy9i bWFsbG9jL1ZNQWxsb2NhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTIyLDEwICsxMjIsOCBAQCBp bmxpbmUgdm9pZCogdHJ5Vk1BbGxvY2F0ZShzaXplX3Qgdm1TaXplCiB7CiAgICAgdm1WYWxpZGF0 ZSh2bVNpemUpOwogICAgIHZvaWQqIHJlc3VsdCA9IG1tYXAoMCwgdm1TaXplLCBQUk9UX1JFQUQg fCBQUk9UX1dSSVRFLCBNQVBfUFJJVkFURSB8IE1BUF9BTk9OIHwgQk1BTExPQ19OT1JFU0VSVkUs IEJNQUxMT0NfVk1fVEFHLCAwKTsKLSAgICBpZiAocmVzdWx0ID09IE1BUF9GQUlMRUQpIHsKLSAg ICAgICAgbG9nVk1GYWlsdXJlKHZtU2l6ZSk7CisgICAgaWYgKHJlc3VsdCA9PSBNQVBfRkFJTEVE KQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICB9CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0K IAo=