180780 2017-12-13 16:21:35 -0800 [WPE] WebCrypto should be a public option. 2017-12-13 17:45:08 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 179009 1 clopez clopez achristensen annulen bugs-noreply cgarcia clopez commit-queue ews-watchlist mcatanzaro oldest_to_newest 1381355 0 clopez 2017-12-13 16:21:35 -0800 On bug 179009 the WebCrypto has been turned into a private option. On top of that the dependency on libtasn1 and gcrypt > 1.6.0 has been forced even if one doesn't enable web_crypto by default. I think this is wrong. ENABLE_WEB_CRYPTO should remain a public option for WPE (at least as long as it is also public one on the GTK port). Also, when this option is disabled the build dependencies on libtasn1 or gcrypt > 1.6.0 is not needed. Making our build dependencies soft, makes easier to build WPE en embedded systems. Please don't raise them more than strictly needed. Also having public options allows external developers building systems to disable feature without having to dive into our cmake code. Disabling features when don't needed allows for a lower footprint. Let's try to keep public the options that make sense. 1381374 1 329283 clopez 2017-12-13 16:36:53 -0800 Created attachment 329283 Patch 1381375 2 ews-watchlist 2017-12-13 16:38:51 -0800 Attachment 329283 did not pass style-queue: ERROR: Source/cmake/OptionsWPE.cmake:86: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1381386 3 329286 clopez 2017-12-13 16:45:18 -0800 Created attachment 329286 Patch fix style 1381429 4 329286 commit-queue 2017-12-13 17:45:07 -0800 Comment on attachment 329286 Patch Clearing flags on attachment: 329286 Committed r225888: <https://trac.webkit.org/changeset/225888> 1381430 5 commit-queue 2017-12-13 17:45:08 -0800 All reviewed patches have been landed. Closing bug. 329283 2017-12-13 16:36:53 -0800 2017-12-13 16:45:02 -0800 Patch bug-180780-20171214013651.patch text/plain 2517 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDRkZjBl OGFmYTkyODYyYzZhZDFkYWNiYTMyZjljOWIxMzI5MjNkOTQuLmI0MDUxODUxMmY3MTUyNjAzYmZi NWU1YTYxMDhiMjJjMzE1NTg3ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0xNyw2ICsxNyw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFTEVSQVRFRF8y RF9DQU5WQVMgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9FTkNSWVBURURfTUVESUEgUFVCTElDICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJF U30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfSklUIFBVQkxJQyBP TikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJEUklWRVIgUFVC TElDIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9DUllQ VE8gUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1hT TFQgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoVVNFX1NZU1RF TV9NQUxMT0MgUFVCTElDIE9GRikKIApAQCAtNjAsOSArNjEsOCBAQCBmaW5kX3BhY2thZ2UoSGFy ZkJ1enogMC45LjE4IFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKElDVSBSRVFVSVJFRCkKIGZpbmRf cGFja2FnZShKUEVHIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKExpYkVwb3h5IDEuNC4wIFJFUVVJ UkVEKQotZmluZF9wYWNrYWdlKExpYkdjcnlwdCAxLjcuMCBSRVFVSVJFRCkKK2ZpbmRfcGFja2Fn ZShMaWJHY3J5cHQgMS42LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoTGliU291cCAyLjQyLjAg UkVRVUlSRUQpCi1maW5kX3BhY2thZ2UoTGlidGFzbjEgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2Uo TGliWG1sMiAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShQTkcgUkVRVUlSRUQpCiBmaW5k X3BhY2thZ2UoU3FsaXRlIFJFUVVJUkVEKQpAQCAtNzUsNiArNzUsMTYgQEAgaWYgKEVOQUJMRV9B Q0NFTEVSQVRFRF8yRF9DQU5WQVMpCiAgICAgZmluZF9wYWNrYWdlKENhaXJvR0wgMS4xMC4yIFJF UVVJUkVEIENPTVBPTkVOVFMgY2Fpcm8tZWdsKQogZW5kaWYgKCkKIAoraWYgKEVOQUJMRV9TVUJU TEVfQ1JZUFRPKQorICAgIGZpbmRfcGFja2FnZShMaWJ0YXNuMSBSRVFVSVJFRCkKKyAgICBpZiAo Tk9UIExJQlRBU04xX0ZPVU5EKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJ0YXNu MSBpcyByZXF1aXJlZCB0byBlbmFibGUgV2ViIENyeXB0byBBUEkgc3VwcG9ydC4iKQorICAgIGVu ZGlmICgpCisgICAgaWYgKExJQkdDUllQVF9WRVJTSU9OIFZFUlNJT05fTEVTUyAxLjcuMCkKKyAg ICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAibGliZ2NyeXB0IDEuNy4wIGlzIHJlcXVpcmVkIHRv IGVuYWJsZSBXZWIgQ3J5cHRvIEFQSSBzdXBwb3J0LiIpCisgICAgZW5kaWYgKCkKK2VuZGlmKCkK KwogaWYgKEVOQUJMRV9YU0xUKQogICAgIGZpbmRfcGFja2FnZShMaWJYc2x0IDEuMS43IFJFUVVJ UkVEKQogZW5kaWYgKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAz Zjg2YWNkMjAwNzJkMWYyZjU3N2Q1NWFlMzRkYzk0MzUyNTRkNTMwLi4yMDA4MmFkMGFjZjMxM2U5 OTQyNTYxODZiZGI0NmZlYzAyMWYzZTg2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMTItMTMgIENhcmxvcyBBbGJlcnRvIExvcGV6 IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gV2ViQ3J5cHRvIHNo b3VsZCBiZSBhIHB1YmxpYyBvcHRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODA3ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYWtlIEVOQUJMRV9XRUJfQ1JZUFRPIHB1YmxpYyBhbmQgbG93ZXIg dGhlIGRlcGVuZGVuY3kgcmVxdWlyZW1lbnRzCisgICAgICAgIHdoZW4gdGhpcyBvcHRpb24gaXMg bm90IGVuYWJsZWQuIFRoaXMgaXMgYWxzbyBob3cgdGhlIEdUSysgcG9ydAorICAgICAgICBjb25m aWd1cmVzIHRoZSB2aXNpYmlsaXR5IG9mIHRoaXMgb3B0aW9uIGFuZCBpdHMgZGVwZW5kZW5jaWVz LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2U6CisKIDIwMTctMTIt MTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjE5LjMg cmVsZWFzZS4K 329286 2017-12-13 16:45:18 -0800 2017-12-13 17:45:07 -0800 Patch bug-180780-20171214014517.patch text/plain 2518 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDRkZjBl OGFmYTkyODYyYzZhZDFkYWNiYTMyZjljOWIxMzI5MjNkOTQuLjIxZTAxZDZiOTE2MTViYTc1NWZj ZDU5Zjc4YWI1MjU5YjQ2Yzc2ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0xNyw2ICsxNyw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFTEVSQVRFRF8y RF9DQU5WQVMgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9FTkNSWVBURURfTUVESUEgUFVCTElDICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJF U30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfSklUIFBVQkxJQyBP TikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJEUklWRVIgUFVC TElDIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9DUllQ VE8gUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1hT TFQgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoVVNFX1NZU1RF TV9NQUxMT0MgUFVCTElDIE9GRikKIApAQCAtNjAsOSArNjEsOCBAQCBmaW5kX3BhY2thZ2UoSGFy ZkJ1enogMC45LjE4IFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKElDVSBSRVFVSVJFRCkKIGZpbmRf cGFja2FnZShKUEVHIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKExpYkVwb3h5IDEuNC4wIFJFUVVJ UkVEKQotZmluZF9wYWNrYWdlKExpYkdjcnlwdCAxLjcuMCBSRVFVSVJFRCkKK2ZpbmRfcGFja2Fn ZShMaWJHY3J5cHQgMS42LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoTGliU291cCAyLjQyLjAg UkVRVUlSRUQpCi1maW5kX3BhY2thZ2UoTGlidGFzbjEgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2Uo TGliWG1sMiAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShQTkcgUkVRVUlSRUQpCiBmaW5k X3BhY2thZ2UoU3FsaXRlIFJFUVVJUkVEKQpAQCAtNzUsNiArNzUsMTYgQEAgaWYgKEVOQUJMRV9B Q0NFTEVSQVRFRF8yRF9DQU5WQVMpCiAgICAgZmluZF9wYWNrYWdlKENhaXJvR0wgMS4xMC4yIFJF UVVJUkVEIENPTVBPTkVOVFMgY2Fpcm8tZWdsKQogZW5kaWYgKCkKIAoraWYgKEVOQUJMRV9TVUJU TEVfQ1JZUFRPKQorICAgIGZpbmRfcGFja2FnZShMaWJ0YXNuMSBSRVFVSVJFRCkKKyAgICBpZiAo Tk9UIExJQlRBU04xX0ZPVU5EKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJ0YXNu MSBpcyByZXF1aXJlZCB0byBlbmFibGUgV2ViIENyeXB0byBBUEkgc3VwcG9ydC4iKQorICAgIGVu ZGlmICgpCisgICAgaWYgKExJQkdDUllQVF9WRVJTSU9OIFZFUlNJT05fTEVTUyAxLjcuMCkKKyAg ICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAibGliZ2NyeXB0IDEuNy4wIGlzIHJlcXVpcmVkIHRv IGVuYWJsZSBXZWIgQ3J5cHRvIEFQSSBzdXBwb3J0LiIpCisgICAgZW5kaWYgKCkKK2VuZGlmICgp CisKIGlmIChFTkFCTEVfWFNMVCkKICAgICBmaW5kX3BhY2thZ2UoTGliWHNsdCAxLjEuNyBSRVFV SVJFRCkKIGVuZGlmICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg M2Y4NmFjZDIwMDcyZDFmMmY1NzdkNTVhZTM0ZGM5NDM1MjU0ZDUzMC4uMjAwODJhZDBhY2YzMTNl OTk0MjU2MTg2YmRiNDZmZWMwMjFmM2U4NiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEyLTEzICBDYXJsb3MgQWxiZXJ0byBMb3Bl eiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIFdlYkNyeXB0byBz aG91bGQgYmUgYSBwdWJsaWMgb3B0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWFrZSBFTkFCTEVfV0VCX0NSWVBUTyBwdWJsaWMgYW5kIGxvd2Vy IHRoZSBkZXBlbmRlbmN5IHJlcXVpcmVtZW50cworICAgICAgICB3aGVuIHRoaXMgb3B0aW9uIGlz IG5vdCBlbmFibGVkLiBUaGlzIGlzIGFsc28gaG93IHRoZSBHVEsrIHBvcnQKKyAgICAgICAgY29u ZmlndXJlcyB0aGUgdmlzaWJpbGl0eSBvZiB0aGlzIG9wdGlvbiBhbmQgaXRzIGRlcGVuZGVuY2ll cy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgorCiAyMDE3LTEy LTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc0dUSy5jbWFrZSBhbmQgTkVXUyBmb3IgMi4xOS4z IHJlbGVhc2UuCg==