180776 2017-12-13 15:46:52 -0800 Web Inspector: UncaughtExceptionReporter fails on early errors 2017-12-14 09:10:26 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1381334 0 joepeck 2017-12-13 15:46:52 -0800 UncaughtExceptionReporter fails on early errors Generating the UI encounters its own exceptions. 1381336 1 329275 joepeck 2017-12-13 15:48:53 -0800 Created attachment 329275 [PATCH] Proposed Fix 1381627 2 329275 bburg 2017-12-14 08:48:54 -0800 Comment on attachment 329275 [PATCH] Proposed Fix rs=me 1381638 3 329275 commit-queue 2017-12-14 09:09:17 -0800 Comment on attachment 329275 [PATCH] Proposed Fix Clearing flags on attachment: 329275 Committed r225908: <https://trac.webkit.org/changeset/225908> 1381639 4 commit-queue 2017-12-14 09:09:18 -0800 All reviewed patches have been landed. Closing bug. 1381640 5 webkit-bug-importer 2017-12-14 09:10:26 -0800 <rdar://problem/36049138> 329275 2017-12-13 15:48:53 -0800 2017-12-14 09:09:17 -0800 [PATCH] Proposed Fix uncaught-1.patch text/plain 4674 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBmNWYyMjNmZjc5Li40OTEwMWY3ZmE5MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTctMTItMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBVbmNhdWdodEV4Y2VwdGlvblJlcG9ydGVyIGZhaWxzIG9uIGVhcmx5IGVycm9ycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNzc2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L0RlYnVnL1VuY2F1Z2h0RXhjZXB0aW9uUmVwb3J0ZXIuanM6CisgICAgICAgICh1cmxMYXN0UGF0 aENvbXBvbmVudCk6CisgICAgICAgIChoYW5kbGVFcnJvcik6CisgICAgICAgIChoYW5kbGVVbmNh dWdodEV4Y2VwdGlvbik6CisgICAgICAgIFVSTFV0aWxpdGllcyBwYXJzZVVSTCBtaWdodCBub3Qg YmUgYXZhaWxhYmxlLCBzbyBoYXZlIGEgc21hbGwKKyAgICAgICAgaGVscGVyIGZvciBnZXR0aW5n IGEgZ29vZCBuYW1lIGZyb20gYSBVUkwgLyBmaWxlbmFtZS4KKworICAgICAgICAoaGFuZGxlVW5j YXVnaHRFeGNlcHRpb25SZWNvcmQpOgorICAgICAgICAoZGlzbWlzc0Vycm9yU2hlZXQpOgorICAg ICAgICBXcmFwIGBXSWAgbmFtZXNwYWNlIGFjY2Vzc2VzIGluIGEgdHJ5L2NhdGNoIHNpbmNlIGBX SWAgbWlnaHQgbm90IGJlIGF2YWlsYWJsZS4KKyAgICAgICAgU2FmZWx5IGNoZWNrIGdsb2JhbCB2 YXJpYWJsZXMgdGhlcmUgd2VyZSBgRm9vYCBhcyBgd2luZG93LkZvb2AgdG8gYXZvaWQgZXJyb3Jz CisgICAgICAgIGlmIHRoZXkgYXJlIG5vdCBhY3R1YWxseSBhdmFpbGFibGUuCisKIDIwMTctMTIt MDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXJ2 aWNlV29ya2VyIEluc3BlY3RvcjogVmFyaW91cyBpc3N1ZXMgaW5zcGVjdGluZyBzZXJ2aWNlIHdv cmtlciBvbiBtb2JpbGUudHdpdHRlci5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnL1VuY2F1Z2h0RXhjZXB0aW9uUmVwb3J0ZXIuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Zy9VbmNhdWdodEV4Y2VwdGlv blJlcG9ydGVyLmpzCmluZGV4IDQwZjkwNWNkMmYwLi4wODgyMGQ1MGZlOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWcvVW5jYXVnaHRFeGNlcHRp b25SZXBvcnRlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9E ZWJ1Zy9VbmNhdWdodEV4Y2VwdGlvblJlcG9ydGVyLmpzCkBAIC01MCwxMCArNTAsMjEgQEAgZnVu Y3Rpb24gdW5ibG9ja0V2ZW50SGFuZGxlcnMoKSB7CiAgICAgICAgIGRvY3VtZW50LnJlbW92ZUV2 ZW50TGlzdGVuZXIobmFtZSwgc3RvcEV2ZW50UHJvcGFnYXRpb24sIHRydWUpOwogfQogCitmdW5j dGlvbiB1cmxMYXN0UGF0aENvbXBvbmVudCh1cmwpIHsKKyAgICBpZiAoIXVybCkKKyAgICAgICAg cmV0dXJuICIiOworCisgICAgbGV0IHNsYXNoSW5kZXggPSB1cmwubGFzdEluZGV4T2YoIi8iKTsK KyAgICBpZiAoc2xhc2hJbmRleCA9PT0gLTEpCisgICAgICAgIHJldHVybiB1cmw7CisKKyAgICBy ZXR1cm4gdXJsLnNsaWNlKHNsYXNoSW5kZXggKyAxKTsKK30KKwogZnVuY3Rpb24gaGFuZGxlRXJy b3IoZXJyb3IpIHsKICAgICBoYW5kbGVVbmNhdWdodEV4Y2VwdGlvblJlY29yZCh7CiAgICAgICAg IG1lc3NhZ2U6IGVycm9yLm1lc3NhZ2UsCi0gICAgICAgIHVybDogcGFyc2VVUkwoZXJyb3Iuc291 cmNlVVJMKS5sYXN0UGF0aENvbXBvbmVudCwKKyAgICAgICAgdXJsOiB1cmxMYXN0UGF0aENvbXBv bmVudChlcnJvci5zb3VyY2VVUkwpLAogICAgICAgICBsaW5lTnVtYmVyOiBlcnJvci5saW5lLAog ICAgICAgICBjb2x1bW5OdW1iZXI6IGVycm9yLmNvbHVtbiwKICAgICAgICAgc3RhY2s6IGVycm9y LnN0YWNrLApAQCAtNjQsNyArNzUsNyBAQCBmdW5jdGlvbiBoYW5kbGVFcnJvcihlcnJvcikgewog ZnVuY3Rpb24gaGFuZGxlVW5jYXVnaHRFeGNlcHRpb24oZXZlbnQpIHsKICAgICBoYW5kbGVVbmNh dWdodEV4Y2VwdGlvblJlY29yZCh7CiAgICAgICAgIG1lc3NhZ2U6IGV2ZW50Lm1lc3NhZ2UsCi0g ICAgICAgIHVybDogcGFyc2VVUkwoZXZlbnQuZmlsZW5hbWUpLmxhc3RQYXRoQ29tcG9uZW50LAor ICAgICAgICB1cmw6IHVybExhc3RQYXRoQ29tcG9uZW50KGV2ZW50LmZpbGVuYW1lKSwKICAgICAg ICAgbGluZU51bWJlcjogZXZlbnQubGluZW5vLAogICAgICAgICBjb2x1bW5OdW1iZXI6IGV2ZW50 LmNvbG5vLAogICAgICAgICBzdGFjazogdHlwZW9mIGV2ZW50LmVycm9yID09PSAib2JqZWN0IiAm JiBldmVudC5lcnJvciAhPT0gbnVsbCA/IGV2ZW50LmVycm9yLnN0YWNrIDogbnVsbCwKQEAgLTcy LDggKzgzLDEwIEBAIGZ1bmN0aW9uIGhhbmRsZVVuY2F1Z2h0RXhjZXB0aW9uKGV2ZW50KSB7CiB9 CiAKIGZ1bmN0aW9uIGhhbmRsZVVuY2F1Z2h0RXhjZXB0aW9uUmVjb3JkKGV4Y2VwdGlvblJlY29y ZCkgewotICAgIGlmICghV0kuc2V0dGluZ3MuZW5hYmxlVW5jYXVnaHRFeGNlcHRpb25SZXBvcnRl ci52YWx1ZSkKLSAgICAgICAgcmV0dXJuOworICAgIHRyeSB7CisgICAgICAgIGlmICghV0kuc2V0 dGluZ3MuZW5hYmxlVW5jYXVnaHRFeGNlcHRpb25SZXBvcnRlci52YWx1ZSkKKyAgICAgICAgICAg IHJldHVybjsKKyAgICB9IGNhdGNoIHsgfQogCiAgICAgaWYgKCF3aW5kb3cuX191bmNhdWdodEV4 Y2VwdGlvbnMpCiAgICAgICAgIHdpbmRvdy5fX3VuY2F1Z2h0RXhjZXB0aW9ucyA9IFtdOwpAQCAt OTcsNyArMTEwLDcgQEAgZnVuY3Rpb24gaGFuZGxlVW5jYXVnaHRFeGNlcHRpb25SZWNvcmQoZXhj ZXB0aW9uUmVjb3JkKSB7CiAgICAgICAgIC8vIFNpZ25hbCB0aGF0IGxvYWRpbmcgaXMgZG9uZSBl dmVuIHRob3VnaCB3ZSBjYW4ndCBndWFyYW50ZWUgdGhhdAogICAgICAgICAvLyBldmFsdWF0aW5n IGNvZGUgb24gdGhlIGluc3BlY3RvciBwYWdlIHdpbGwgZG8gYW55dGhpbmcgdXNlZnVsLgogICAg ICAgICAvLyBXaXRob3V0IHRoaXMsIHRoZSBmcm9udGVuZCBob3N0IG1heSBuZXZlciBzaG93IHRo ZSB3aW5kb3cuCi0gICAgICAgIGlmIChJbnNwZWN0b3JGcm9udGVuZEhvc3QpCisgICAgICAgIGlm ICh3aW5kb3cuSW5zcGVjdG9yRnJvbnRlbmRIb3N0KQogICAgICAgICAgICAgSW5zcGVjdG9yRnJv bnRlbmRIb3N0LmxvYWRlZCgpOwogCiAgICAgICAgIC8vIERvbid0IHRlbGwgSW5zcGVjdG9yRnJv bnRlbmRBUEkgdGhhdCBsb2FkaW5nIGlzIGRvbmUsIHNpbmNlIGl0IGNhbgpAQCAtMTE1LDcgKzEy OCw5IEBAIGZ1bmN0aW9uIGRpc21pc3NFcnJvclNoZWV0KCkgewogICAgIHdpbmRvdy5fX3VuY2F1 Z2h0RXhjZXB0aW9ucyA9IFtdOwogCiAgICAgLy8gRG8gdGhpcyBsYXN0IGluIGNhc2UgV2ViSW5z cGVjdG9yJ3MgaW50ZXJuYWwgc3RhdGUgaXMgY29ycnVwdGVkLgotICAgIFdJLnVwZGF0ZVdpbmRv d1RpdGxlKCk7CisgICAgdHJ5IHsKKyAgICAgICAgV0kudXBkYXRlV2luZG93VGl0bGUoKTsKKyAg ICB9IGNhdGNoIHsgfQogCiAgICAgLy8gRklYTUUgKDE1MTk1OSk6IHRlbGwgdGhlIGZyb250ZW5k IGhvc3QgdG8gaGlkZSBhIGRyYWdnYWJsZSB0aXRsZSBiYXIuCiB9CkBAIC0xMjcsNyArMTQyLDcg QEAgZnVuY3Rpb24gY3JlYXRlRXJyb3JTaGVldCgpIHsKICAgICAgICAgZG9jdW1lbnQud3JpdGUo Ijxib2R5PjwvYm9keT48L2h0bWw+Iik7CiAKICAgICAvLyBGSVhNRSAoMTUxOTU5KTogdGVsbCB0 aGUgZnJvbnRlbmQgaG9zdCB0byBzaG93IGEgZHJhZ2dhYmxlIHRpdGxlIGJhci4KLSAgICBpZiAo SW5zcGVjdG9yRnJvbnRlbmRIb3N0KQorICAgIGlmICh3aW5kb3cuSW5zcGVjdG9yRnJvbnRlbmRI b3N0KQogICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3QuaW5zcGVjdGVkVVJMQ2hhbmdlZCgi SW50ZXJuYWwgRXJyb3IiKTsKIAogICAgIC8vIE9ubHkgYWxsb3cgb25lIHNoZWV0IGVsZW1lbnQg YXQgYSB0aW1lLgpAQCAtMTk1LDcgKzIxMCw3IEBAIGZ1bmN0aW9uIGNyZWF0ZUVycm9yU2hlZXQo KSB7CiAgICAgICAgIHJldHVybiBzdHJpbmcubGVuZ3RoID4gNTAwID8gc3RyaW5nLnN1YnN0cigw LCA1MDApICsgIuKApiIgOiBzdHJpbmc7CiAgICAgfQogCi0gICAgaWYgKEluc3BlY3RvckJhY2tl bmQgJiYgSW5zcGVjdG9yQmFja2VuZC5jdXJyZW50RGlzcGF0Y2hTdGF0ZSkgeworICAgIGlmICh3 aW5kb3cuSW5zcGVjdG9yQmFja2VuZCAmJiBJbnNwZWN0b3JCYWNrZW5kLmN1cnJlbnREaXNwYXRj aFN0YXRlKSB7CiAgICAgICAgIGxldCBzdGF0ZSA9IEluc3BlY3RvckJhY2tlbmQuY3VycmVudERp c3BhdGNoU3RhdGU7CiAgICAgICAgIGlmIChzdGF0ZS5ldmVudCkgewogICAgICAgICAgICAgdG9w TGV2ZWxJdGVtcy5wdXNoKCJEaXNwYXRjaCBTb3VyY2U6ICAgICAgUHJvdG9jb2wgRXZlbnQiKTsK