180766 2017-12-13 13:07:55 -0800 Only use CookieStorageShim when we aren't using NetworkSession 2018-01-02 12:59:40 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ap bfulgham jer.noble webkit-bug-importer oldest_to_newest 1381260 0 achristensen 2017-12-13 13:07:55 -0800 Only use CookieStorageShim when we aren't using NetworkSession 1381261 1 329247 achristensen 2017-12-13 13:09:06 -0800 Created attachment 329247 Patch 1381469 2 329247 ap 2017-12-13 19:34:36 -0800 Comment on attachment 329247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329247&action=review > Source/WebKit/ChangeLog:3 > + Only use CookieStorageShim when we aren't using NetworkSession Don’t we need it on 10.11 for media? 1381708 3 achristensen 2017-12-14 11:35:06 -0800 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 329247 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329247&action=review > > > Source/WebKit/ChangeLog:3 > > + Only use CookieStorageShim when we aren't using NetworkSession > > Don’t we need it on 10.11 for media? Yes we do. That's why I enclosed it in !USE(NETWORK_SESSION). Otherwise I would've just removed it. 1381748 4 ap 2017-12-14 12:27:44 -0800 I was unclear. What I meant to ask was, do we have platforms that use network session, but still use in-process media loading? 1384142 5 achristensen 2017-12-21 10:28:30 -0800 (In reply to Alexey Proskuryakov from comment #4) > I was unclear. What I meant to ask was, do we have platforms that use > network session, but still use in-process media loading? No 1384895 6 329247 bfulgham 2017-12-28 14:07:55 -0800 Comment on attachment 329247 Patch Looks reasonable. Keep an eye on legacy bots after landing, please. 1385147 7 achristensen 2018-01-02 09:18:28 -0800 http://trac.webkit.org/r226324 1385218 8 webkit-bug-importer 2018-01-02 12:59:40 -0800 <rdar://problem/36260898> 329247 2017-12-13 13:09:06 -0800 2017-12-28 14:07:55 -0800 Patch bug-180766-20171213130905.patch text/plain 2431 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU4NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTEzICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgT25seSB1c2UgQ29v a2llU3RvcmFnZVNoaW0gd2hlbiB3ZSBhcmVuJ3QgdXNpbmcgTmV0d29ya1Nlc3Npb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDc2NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL21hYy9D b29raWVTdG9yYWdlU2hpbS5oOgorICAgICAgICAqIFNoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNo aW0ubW06CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViUHJvY2Vzczo6aW5pdGlhbGl6ZVdlYlByb2Nlc3MpOgorCiAyMDE3LTEyLTEzICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChy MjI1Nzg5KTogQVBJIHRlc3RzIFdLUHJvY2Vzc1Bvb2wuSW5pdGlhbFdhcm1lZFByb2Nlc3NVc2Vk IGFuZCBXZWJLaXQuV2Vic2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzIGFyZSBmYWlsaW5nLgpJbmRl eDogU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLmgJKHJldmlz aW9uIDIyNTgyNSkKKysrIFNvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9Db29raWVTdG9yYWdlU2hp bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw4ICsyMyw5IEBACiAgKiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotI2lmbmRlZiBDb29raWVTdG9yYWdlU2hpbV9oCi0jZGVm aW5lIENvb2tpZVN0b3JhZ2VTaGltX2gKKyNwcmFnbWEgb25jZQorCisjaWYgIVVTRShORVRXT1JL X1NFU1NJT04pCiAKICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNsdWRlIDx3dGYv TmV2ZXJEZXN0cm95ZWQuaD4KQEAgLTQ3LDQgKzQ4LDQgQEAgcHJpdmF0ZToKIAogfQogCi0jZW5k aWYgLy8gQ29va2llU3RvcmFnZVNoaW1faAorI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0L1No YXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9TaGFyZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLm1tCShyZXZpc2lvbiAyMjU4MjUpCisrKyBT b3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0JKHdvcmtpbmcgY29w eSkKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJDb29r aWVTdG9yYWdlU2hpbS5oIgogCisjaWYgIVVTRShORVRXT1JLX1NFU1NJT04pCisKICNpbmNsdWRl ICJDb29raWVTdG9yYWdlU2hpbUxpYnJhcnkuaCIKICNpbmNsdWRlICJOZXR3b3JrQ29ubmVjdGlv blRvV2ViUHJvY2Vzcy5oIgogI2luY2x1ZGUgIk5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5oIgpA QCAtMTMzLDMgKzEzNSw2IEBAIC0gKHZvaWQpX2dldENvb2tpZUhlYWRlcnNGb3JUYXNrOihOU1VS TFMKIH0KIAogQGVuZAorCisjZW5kaWYKKwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlByb2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmNwcAkocmV2aXNpb24gMjI1ODI1KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlByb2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODIsNyArMzgyLDcgQEAgdm9p ZCBXZWJQcm9jZXNzOjppbml0aWFsaXplV2ViUHJvY2VzcyhXZQogCiAgICAgZW5zdXJlTmV0d29y a1Byb2Nlc3NDb25uZWN0aW9uKCk7CiAKLSNpZiBQTEFURk9STShDT0NPQSkKKyNpZiBQTEFURk9S TShDT0NPQSkgJiYgIVVTRShORVRXT1JLX1NFU1NJT04pCiAgICAgQ29va2llU3RvcmFnZVNoaW06 OnNpbmdsZXRvbigpLmluaXRpYWxpemUoKTsKICNlbmRpZgogICAgIHNldFRlcm1pbmF0aW9uVGlt ZW91dChwYXJhbWV0ZXJzLnRlcm1pbmF0aW9uVGltZW91dCk7Cg==