180756 2017-12-13 10:22:16 -0800 REGRESSION(225597): Can't select a text box or web view on a page when VO is on. 2017-12-14 08:33:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham simon.fraser webkit-bug-importer oldest_to_newest 1381169 0 pvollan 2017-12-13 10:22:16 -0800 We should use the NSApplication run loop until we can initialize accessibility without it. 1381170 1 pvollan 2017-12-13 10:22:53 -0800 <rdar://problem/35996158> 1381177 2 329231 pvollan 2017-12-13 10:30:52 -0800 Created attachment 329231 Patch 1381201 3 329231 bfulgham 2017-12-13 11:06:37 -0800 Comment on attachment 329231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329231&action=review Looks good. Please address the confusing comment. r=me assuming EWS is fine. > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=180756 <rdar://problem/35996158> > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:593 > +#endif I wonder if we really need to exclude this. Surely we want to avoid calling into _AXUIElementNotify... if NSApp is not running? > Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:80 > + // Leak a boost onto the WebContent process if the NSApplication run loop is not used. I don't know what Leak a boost" means? 1381238 4 pvollan 2017-12-13 12:21:50 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 329231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329231&action=review > > Looks good. Please address the confusing comment. r=me assuming EWS is fine. > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=180756 > > <rdar://problem/35996158> > > > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:593 > > +#endif > > I wonder if we really need to exclude this. Surely we want to avoid calling > into _AXUIElementNotify... if NSApp is not running? > I excluded this in case it has some unknown performance implications. > > Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:80 > > + // Leak a boost onto the WebContent process if the NSApplication run loop is not used. > > I don't know what Leak a boost" means? I will change the comment before landing. Thanks for reviewing! 1381239 5 pvollan 2017-12-13 12:23:17 -0800 Committed r225863: <https://trac.webkit.org/changeset/225863/webkit> 1381241 6 329231 simon.fraser 2017-12-13 12:34:45 -0800 Comment on attachment 329231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329231&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + No new tests. Why is there no explanatory text here? What did you change? Why? 1381622 7 pvollan 2017-12-14 08:33:23 -0800 (In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 329231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329231&action=review > > > Source/WebCore/ChangeLog:8 > > + Reviewed by NOBODY (OOPS!). > > + > > + No new tests. > > Why is there no explanatory text here? What did you change? Why? This patch basically reverts https://trac.webkit.org/changeset/225597/webkit, and goes back to using the NSApplication run loop, since using the NSRunLoop broke VoiceOver functionality. We will attempt to use the NSRunLoop again, when we have a way to initialize accessibility in the WebContent process. 329231 2017-12-13 10:30:52 -0800 2017-12-13 11:06:37 -0800 Patch bug-180756-20171213103051.patch text/plain 5499 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNTg0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTEzICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKDIyNTU5 Nyk6IENhbid0IHNlbGVjdCBhIHRleHQgYm94IG9yIHdlYiB2aWV3IG9uIGEgcGFnZSB3aGVuIFZP IGlzIG9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTgwNzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL0V2ZW50TG9vcE1hYy5tbToK KyAgICAgICAgKFdlYkNvcmU6OkV2ZW50TG9vcDo6Y3ljbGUpOgorCiAyMDE3LTEyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgaXM8SFRNTFRleHRGb3JtQ29u dHJvbEVsZW1lbnQ+IHJlcG9ydHMgdGhlIGlucHV0IHR5cGUuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvRXZlbnRMb29wTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9FdmVudExvb3BNYWMubW0JKHJldmlzaW9uIDIyNTg0NykKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9FdmVudExvb3BNYWMubW0JKHdvcmtpbmcgY29weSkK QEAgLTMwLDEwICszMCwxMiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgRXZlbnRMb29w OjpjeWNsZSgpCiB7CisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0 MDAKICAgICBpZiAoIVtOU0FwcCBpc1J1bm5pbmddKSB7CiAgICAgICAgIFtbTlNSdW5Mb29wIGN1 cnJlbnRSdW5Mb29wXSBydW5VbnRpbERhdGU6W05TRGF0ZSBkYXRlV2l0aFRpbWVJbnRlcnZhbFNp bmNlTm93OjAuMDVdXTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKyNlbmRpZgogICAgIFtOU0Fw cCBzZXRXaW5kb3dzTmVlZFVwZGF0ZTpZRVNdOwogICAgIGlmIChOU0V2ZW50ICpldmVudCA9IFtO U0FwcCBuZXh0RXZlbnRNYXRjaGluZ01hc2s6TlNFdmVudE1hc2tBbnkgdW50aWxEYXRlOltOU0Rh dGUgZGF0ZVdpdGhUaW1lSW50ZXJ2YWxTaW5jZU5vdzowLjA1XSBpbk1vZGU6TlNEZWZhdWx0UnVu TG9vcE1vZGUgZGVxdWV1ZTpZRVNdKQogICAgICAgICBbTlNBcHAgc2VuZEV2ZW50OmV2ZW50XTsK SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjU4NTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEyLTEzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKDIyNTU5Nyk6 IENhbid0IHNlbGVjdCBhIHRleHQgYm94IG9yIHdlYiB2aWV3IG9uIGEgcGFnZSB3aGVuIFZPIGlz IG9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgw NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQ bGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW06CisgICAgICAgIChJUEM6OkFjY2Vzc2li aWxpdHlQcm9jZXNzU3VzcGVuZGVkTm90aWZpY2F0aW9uKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv TGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6c2hv dWxkTGVha0Jvb3N0KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0VudHJ5UG9pbnQvbWFjL1hQQ1Nl cnZpY2UvV2ViQ29udGVudFNlcnZpY2UvSW5mby1PU1gucGxpc3Q6CisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6aW5pdGlh bGl6ZVByb2Nlc3MpOgorCiAyMDE3LTEyLTEzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU10gVGFrZSBwcm9jZXNzIGFzc2VydGlvbiB0byBwcmV2ZW50IHRo ZSBzZXJ2aWNlIHdvcmtlciBwcm9jZXNzIGZyb20gZ2V0dGluZyBzdXNwZW5kZWQKSW5kZXg6IFNv dXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tCShyZXZp c2lvbiAyMjU4NDcpCisrKyBTb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlv bk1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTg2LDkgKzU4NiwxMSBAQCBib29sIENvbm5lY3Rp b246OmtpbGwoKQogc3RhdGljIHZvaWQgQWNjZXNzaWJpbGl0eVByb2Nlc3NTdXNwZW5kZWROb3Rp ZmljYXRpb24oYm9vbCBzdXNwZW5kZWQpCiB7CiAjaWYgUExBVEZPUk0oTUFDKQorI2lmIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwCiAgICAgLy8gQ2FsbGluZyBfQVhV SUVsZW1lbnROb3RpZnlQcm9jZXNzU3VzcGVuZFN0YXR1cyB3aWxsIGNyYXNoIGlmIHRoZSBOU0Fw cGxpY2F0aW9uIGV2ZW50IGxvb3AgaXMgbm90IHJ1bm5pbmcuCiAgICAgaWYgKCFbTlNBcHAgaXNS dW5uaW5nXSkKICAgICAgICAgcmV0dXJuOworI2VuZGlmCiAgICAgX0FYVUlFbGVtZW50Tm90aWZ5 UHJvY2Vzc1N1c3BlbmRTdGF0dXMoc3VzcGVuZGVkID8gQVhTdXNwZW5kU3RhdHVzU3VzcGVuZGVk IDogQVhTdXNwZW5kU3RhdHVzUnVubmluZyk7CiAjZWxpZiBQTEFURk9STShJT1MpCiAgICAgVUlB Y2Nlc3NpYmlsaXR5UG9zdE5vdGlmaWNhdGlvbihrQVhQaWRTdGF0dXNDaGFuZ2VkTm90aWZpY2F0 aW9uLCBAeyBAInBpZCIgOiBAKGdldHBpZCgpKSwgQCJzdXNwZW5kZWQiIDogQChzdXNwZW5kZWQp IH0pOwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NM YXVuY2hlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCShyZXZpc2lvbiAyMjU4NDcpCisrKyBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC03Niw5ICs3NiwxMyBAQCBzdGF0aWMgYm9vbCBzaG91bGRMZWFrQm9v c3QoY29uc3QgUHJvY2VzCiAgICAgVU5VU0VEX1BBUkFNKGxhdW5jaE9wdGlvbnMpOwogICAgIHJl dHVybiB0cnVlOwogI2Vsc2UKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwMTQwMAorICAgIC8vIExlYWsgYSBib29zdCBvbnRvIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mg aWYgdGhlIE5TQXBwbGljYXRpb24gcnVuIGxvb3AgaXMgbm90IHVzZWQuCisgICAgaWYgKGxhdW5j aE9wdGlvbnMucHJvY2Vzc1R5cGUgPT0gUHJvY2Vzc0xhdW5jaGVyOjpQcm9jZXNzVHlwZTo6V2Vi KQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAgIC8vIE9uIE1hYywgbGVhayBhIGJv b3N0IG9udG8gdGhlIE5ldHdvcmtQcm9jZXNzLgotICAgIHJldHVybiBsYXVuY2hPcHRpb25zLnBy b2Nlc3NUeXBlID09IFByb2Nlc3NMYXVuY2hlcjo6UHJvY2Vzc1R5cGU6Ok5ldHdvcmsKLSAgICAg ICAgfHwgbGF1bmNoT3B0aW9ucy5wcm9jZXNzVHlwZSA9PSBQcm9jZXNzTGF1bmNoZXI6OlByb2Nl c3NUeXBlOjpXZWI7CisgICAgcmV0dXJuIGxhdW5jaE9wdGlvbnMucHJvY2Vzc1R5cGUgPT0gUHJv Y2Vzc0xhdW5jaGVyOjpQcm9jZXNzVHlwZTo6TmV0d29yazsKICNlbmRpZgogfQogCkluZGV4OiBT b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCShyZXZpc2lvbiAyMjU4NDcpCisr KyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTIxNiw3ICsyMTYsNyBAQCBXZWJQcm9jZXNzOjp+V2ViUHJvY2VzcygpCiAKIHZvaWQgV2Vi UHJvY2Vzczo6aW5pdGlhbGl6ZVByb2Nlc3MoY29uc3QgQ2hpbGRQcm9jZXNzSW5pdGlhbGl6YXRp b25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogewotI2lmIFBMQVRGT1JNKENPQ09BKSAmJiAhUExB VEZPUk0oSU9TKQorI2lmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMDE0MDAKICAgICAvLyBUaGlzIGNhbGwgaXMgbmVlZGVkIHdoZW4gdGhlIFdl YlByb2Nlc3MgaXMgbm90IHJ1bm5pbmcgdGhlIE5TQXBwbGljYXRpb24gZXZlbnQgbG9vcC4KICAg ICAvLyBPdGhlcndpc2UsIGNhbGxpbmcgZW5hYmxlU2FuZGJveFN0eWxlRmlsZVF1YXJhbnRpbmUo KSB3aWxsIGZhaWwuCiAgICAgbGF1bmNoU2VydmljZXNDaGVja0luKCk7CkluZGV4OiBTb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvRW50cnlQb2ludC9tYWMvWFBDU2VydmljZS9XZWJDb250ZW50U2Vy dmljZS9JbmZvLU9TWC5wbGlzdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvRW50cnlQb2ludC9tYWMvWFBDU2VydmljZS9XZWJDb250ZW50U2VydmljZS9JbmZvLU9TWC5w bGlzdAkocmV2aXNpb24gMjI1ODQ3KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0VudHJ5 UG9pbnQvbWFjL1hQQ1NlcnZpY2UvV2ViQ29udGVudFNlcnZpY2UvSW5mby1PU1gucGxpc3QJKHdv cmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAKIAkJPGtleT5TZXJ2aWNlVHlwZTwva2V5Pgog CQk8c3RyaW5nPkFwcGxpY2F0aW9uPC9zdHJpbmc+CiAJCTxrZXk+UnVuTG9vcFR5cGU8L2tleT4K LQkJPHN0cmluZz5OU1J1bkxvb3A8L3N0cmluZz4KKwkJPHN0cmluZz5fTlNBcHBsaWNhdGlvbk1h aW48L3N0cmluZz4KIAkJPGtleT5fTXVsdGlwbGVJbnN0YW5jZXM8L2tleT4KIAkJPHRydWUvPgog CQk8a2V5Pl9IaWdoQml0c0FTTFI8L2tleT4K