180754 2017-12-13 09:55:12 -0800 Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list 2017-12-13 10:38:14 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates achristensen aestes simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1381150 0 dbates 2017-12-13 09:55:12 -0800 Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list. 1381155 1 329227 dbates 2017-12-13 09:59:44 -0800 Created attachment 329227 Patch 1381158 2 329227 wenson_hsieh 2017-12-13 10:02:21 -0800 Comment on attachment 329227 Patch Good catch, rs=me 1381181 3 329227 dbates 2017-12-13 10:35:19 -0800 Comment on attachment 329227 Patch Clearing flags on attachment: 329227 Committed r225853: <https://trac.webkit.org/changeset/225853> 1381182 4 dbates 2017-12-13 10:35:20 -0800 All reviewed patches have been landed. Closing bug. 1381185 5 webkit-bug-importer 2017-12-13 10:38:14 -0800 <rdar://problem/36024673> 329227 2017-12-13 09:59:44 -0800 2017-12-13 10:35:19 -0800 Patch bug-180754-20171213095944.patch text/plain 4723 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1ODQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBkN2I3MmM0YWUyZWJmYmNh NDQ5N2NkMTQ5YTA0YjdhMGMzYWNiMDEuLjMwODIxODdmZjBhMjFiNTU4NGUwMDA2NjlhMjQyMzY5 ZDE5YTg5MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTctMTItMTMgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgb3V0LXBhcmFtZXRlciBp biBBUEk6OkZvcm1DbGllbnQ6OndpbGxCZWdpbklucHV0U2Vzc2lvbigpIHRvIHRoZSBlbmQgb2Yg dGhlIHBhcmFtZXRlciBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODA3NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBHcm91cCBhbGwgaW4tcGFyYW1ldGVycyBpbiB0aGUgc2lnbmF0dXJlIG9mIEFQ STo6Rm9ybUNsaWVudDo6d2lsbEJlZ2luSW5wdXRTZXNzaW9uKCkgYXQKKyAgICAgICAgdGhlIGZy b250IG9mIHRoZSBwYXJhbWV0ZXIgbGlzdCBpbnN0ZWFkIG9mIGludGVyc3BlcnNpbmcgaW4tIGFu ZCBvdXQtIHBhcmFtZXRlcnMuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VkLiBT bywgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvbWFjL1dLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlci5tbToKKyAg ICAgICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyIF9zZXRG b3JtRGVsZWdhdGU6XSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUElJ bmplY3RlZEJ1bmRsZUZvcm1DbGllbnQuaDoKKyAgICAgICAgKEFQSTo6SW5qZWN0ZWRCdW5kbGU6 OkZvcm1DbGllbnQ6OndpbGxCZWdpbklucHV0U2Vzc2lvbik6CisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjplbGVtZW50 RGlkRm9jdXMpOgorCiAyMDE3LTEyLTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc0dUSy5jbWFr ZSBhbmQgTkVXUyBmb3IgMi4xOS4zIHJlbGVhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVnSW5Ccm93 c2VyQ29udGV4dENvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xs ZXIubW0KaW5kZXggMmQ0MWU1ZTNlYzg4YTNjOGIxMjRlYTJiNTg5ODIyNjhjNGM4NGU4NS4uZjJk OTRhOTU2M2UxZDYxZTBiMTc0NDY2NzNlODY4NjNlMjY5NmQ3MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1 Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250 ZXh0Q29udHJvbGxlci5tbQpAQCAtNTI4LDcgKzUyOCw3IEBAIC0gKHZvaWQpX3NldEZvcm1EZWxl Z2F0ZTooaWQgPFdLV2ViUHJvY2Vzc1BsdWdJbkZvcm1EZWxlZ2F0ZVByaXZhdGU+KWZvcm1EZWxl Z2F0CiAgICAgICAgICAgICAgICAgW2Zvcm1EZWxlZ2F0ZSBfd2ViUHJvY2Vzc1BsdWdJbkJyb3dz ZXJDb250ZXh0Q29udHJvbGxlcjptX2NvbnRyb2xsZXIgdGV4dERpZENoYW5nZUluVGV4dEZpZWxk OndyYXBwZXIoKldlYktpdDo6SW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlOjpnZXRPckNyZWF0ZShp bnB1dEVsZW1lbnQpKSBpbkZyYW1lOndyYXBwZXIoKmZyYW1lKSBpbml0aWF0ZWRCeVVzZXJUeXBp bmc6aW5pdGlhdGVkQnlVc2VyVHlwaW5nXTsKICAgICAgICAgfQogCi0gICAgICAgIHZvaWQgd2ls bEJlZ2luSW5wdXRTZXNzaW9uKFdlYlBhZ2UqLCBFbGVtZW50KiBlbGVtZW50LCBXZWJGcmFtZSog ZnJhbWUsIFJlZlB0cjxBUEk6Ok9iamVjdD4mIHVzZXJEYXRhLCBib29sIHVzZXJJc0ludGVyYWN0 aW5nKSBvdmVycmlkZQorICAgICAgICB2b2lkIHdpbGxCZWdpbklucHV0U2Vzc2lvbihXZWJQYWdl KiwgRWxlbWVudCogZWxlbWVudCwgV2ViRnJhbWUqIGZyYW1lLCBib29sIHVzZXJJc0ludGVyYWN0 aW5nLCBSZWZQdHI8QVBJOjpPYmplY3Q+JiB1c2VyRGF0YSkgb3ZlcnJpZGUKICAgICAgICAgewog ICAgICAgICAgICAgYXV0byBmb3JtRGVsZWdhdGUgPSBtX2NvbnRyb2xsZXItPl9mb3JtRGVsZWdh dGUuZ2V0KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9BUElJbmplY3RlZEJ1bmRsZUZvcm1DbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUElJbmplY3RlZEJ1bmRsZUZvcm1DbGllbnQuaAppbmRl eCAxZmQ2ZDNkYjIxM2M4YzVkZGEyYWY1ZDRjMjQ0NjViNDViMmI1MDgyLi41NDQ5MjI3ZTM4ODk2 NmVmMDE5MzU2YTQyYWJmNmQ4MjM2Y2Y5OTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJSW5qZWN0ZWRCdW5kbGVGb3JtQ2xpZW50LmgKKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSUluamVjdGVkQnVu ZGxlRm9ybUNsaWVudC5oCkBAIC03MSw3ICs3MSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZv aWQgd2lsbFNlbmRTdWJtaXRFdmVudChXZWJLaXQ6OldlYlBhZ2UqLCBXZWJDb3JlOjpIVE1MRm9y bUVsZW1lbnQqLCBXZWJLaXQ6OldlYkZyYW1lKiwgV2ViS2l0OjpXZWJGcmFtZSosIGNvbnN0IFZl Y3RvcjxzdGQ6OnBhaXI8V1RGOjpTdHJpbmcsIFdURjo6U3RyaW5nPj4mKSB7IH0KICAgICB2aXJ0 dWFsIHZvaWQgZGlkQXNzb2NpYXRlRm9ybUNvbnRyb2xzKFdlYktpdDo6V2ViUGFnZSosIGNvbnN0 IFZlY3RvcjxSZWZQdHI8V2ViQ29yZTo6RWxlbWVudD4+JikgeyB9CiAgICAgdmlydHVhbCBib29s IHNob3VsZE5vdGlmeU9uRm9ybUNoYW5nZXMoV2ViS2l0OjpXZWJQYWdlKikgeyByZXR1cm4gZmFs c2U7IH0KLSAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlZ2luSW5wdXRTZXNzaW9uKFdlYktpdDo6V2Vi UGFnZSosIFdlYkNvcmU6OkVsZW1lbnQqLCBXZWJLaXQ6OldlYkZyYW1lKiwgUmVmUHRyPEFQSTo6 T2JqZWN0PiYgdXNlckRhdGEsIGJvb2wgdXNlcklzSW50ZXJhY3RpbmcpIHsgVU5VU0VEX1BBUkFN KHVzZXJEYXRhKTsgfQorICAgIHZpcnR1YWwgdm9pZCB3aWxsQmVnaW5JbnB1dFNlc3Npb24oV2Vi S2l0OjpXZWJQYWdlKiwgV2ViQ29yZTo6RWxlbWVudCosIFdlYktpdDo6V2ViRnJhbWUqLCBib29s IHVzZXJJc0ludGVyYWN0aW5nLCBSZWZQdHI8QVBJOjpPYmplY3Q+JiB1c2VyRGF0YSkgeyBVTlVT RURfUEFSQU0odXNlckRhdGEpOyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBJbmplY3RlZEJ1bmRs ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCBl ODQ1N2NlMTc2NmM2YTdkOTIxNGExNDJjMTQyNjJmODAzZDEzZTgxLi5kMjg3NjNhN2JjZDQ3ZGYy ZjY4ZWY4ZjNhNmI3NTUwODc3MDA4MzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtNDg1Nyw3ICs0ODU3LDcgQEAgdm9pZCBXZWJQYWdlOjpl bGVtZW50RGlkRm9jdXMoV2ViQ29yZTo6Tm9kZSogbm9kZSkKICAgICAgICAgZ2V0QXNzaXN0ZWRO b2RlSW5mb3JtYXRpb24oaW5mb3JtYXRpb24pOwogICAgICAgICBSZWZQdHI8QVBJOjpPYmplY3Q+ IHVzZXJEYXRhOwogCi0gICAgICAgIG1fZm9ybUNsaWVudC0+d2lsbEJlZ2luSW5wdXRTZXNzaW9u KHRoaXMsIGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUpLCBXZWJGcmFtZTo6ZnJvbUNvcmVGcmFtZSgq bm9kZS0+ZG9jdW1lbnQoKS5mcmFtZSgpKSwgdXNlckRhdGEsIG1fdXNlcklzSW50ZXJhY3Rpbmcp OworICAgICAgICBtX2Zvcm1DbGllbnQtPndpbGxCZWdpbklucHV0U2Vzc2lvbih0aGlzLCBkb3du Y2FzdDxFbGVtZW50Pihub2RlKSwgV2ViRnJhbWU6OmZyb21Db3JlRnJhbWUoKm5vZGUtPmRvY3Vt ZW50KCkuZnJhbWUoKSksIG1fdXNlcklzSW50ZXJhY3RpbmcsIHVzZXJEYXRhKTsKIAogICAgICAg ICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlN0YXJ0QXNzaXN0aW5nTm9kZShpbmZvcm1h dGlvbiwgbV91c2VySXNJbnRlcmFjdGluZywgbV9oYXNQZW5kaW5nQmx1ck5vdGlmaWNhdGlvbiwg VXNlckRhdGEoV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkudHJhbnNmb3JtT2JqZWN0c1RvSGFuZGxl cyh1c2VyRGF0YS5nZXQoKSkuZ2V0KCkpKSk7CiAjZWxpZiBQTEFURk9STShNQUMpCg==