180717 2017-12-12 13:31:40 -0800 Web Inspector: SyncTestSuite should complain if passed an async setup/test/teardown function 2017-12-12 15:15:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1380809 0 bburg 2017-12-12 13:31:40 -0800 It took me a few hours to figure this mistake out for some reason. We can verify this easily. 1380811 1 329146 bburg 2017-12-12 13:34:40 -0800 Created attachment 329146 Patch 1380866 2 329146 hi 2017-12-12 14:52:07 -0800 Comment on attachment 329146 Patch r=me 1380885 3 329146 commit-queue 2017-12-12 15:13:08 -0800 Comment on attachment 329146 Patch Clearing flags on attachment: 329146 Committed r225814: <https://trac.webkit.org/changeset/225814> 1380886 4 commit-queue 2017-12-12 15:13:10 -0800 All reviewed patches have been landed. Closing bug. 1380892 5 webkit-bug-importer 2017-12-12 15:15:56 -0800 <rdar://problem/36006166> 329146 2017-12-12 13:34:40 -0800 2017-12-12 15:13:08 -0800 Patch bug-180717-20171212133439.patch text/plain 5196 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1NDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw ZWM2N2Y5NGExYTg0NjViMjIzN2U1Mzg5NjFmNTMyYzE0NjgxN2RlLi4wNzhhMGNiMGJiODhmY2Vh NjM5ZDk1MjQ4ZDFhZmZkYTgzMjVlMDdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0xMi0xMiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTeW5jVGVzdFN1aXRlIHNob3VsZCBjb21wbGFpbiBpZiBw YXNzZWQgYW4gYXN5bmMgc2V0dXAvdGVzdC90ZWFyZG93biBmdW5jdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwNzE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Rlc3Qv VGVzdFN1aXRlLmpzOgorICAgICAgICAoU3luY1Rlc3RTdWl0ZS5wcm90b3R5cGUuYWRkVGVzdENh c2UpOgorICAgICAgICBSYWlzZSBhbiBleGNlcHRpb24gaWYgdGVzdC9zZXR1cC90ZWFyZG93biBp cyBhbiBhc3luYyBmdW5jdGlvbi4gSXQgd29uJ3Qgd29yay4KKwogMjAxNy0xMi0wOSAgQnJpYW4g QnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0 IGFzeW5jIHNldHVwKCkgYW5kIGFzeW5jIHRlYXJkb3duKCkgaW4gQXN5bmNUZXN0U3VpdGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvVGVzdFN1 aXRlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9UZXN0U3Vp dGUuanMKaW5kZXggZTRjZjc1ZDhmMGRhZTM3NzlhMDczYzJmMDcwYmYwY2FmZDNkMGRiNS4uZWQ4 ZDk1NWY0NTlmMjEzOGQ3ZTBjYzllZjhkNTEwYmEyNGI0ZmVkMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9UZXN0U3VpdGUuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9UZXN0U3VpdGUuanMKQEAgLTE3 OSw2ICsxNzksMTQgQEAgQXN5bmNUZXN0U3VpdGUgPSBjbGFzcyBBc3luY1Rlc3RTdWl0ZSBleHRl bmRzIFRlc3RTdWl0ZQogCiBTeW5jVGVzdFN1aXRlID0gY2xhc3MgU3luY1Rlc3RTdWl0ZSBleHRl bmRzIFRlc3RTdWl0ZQogeworICAgIGFkZFRlc3RDYXNlKHRlc3RjYXNlKQorICAgIHsKKyAgICAg ICAgaWYgKFt0ZXN0Y2FzZS5zZXR1cCwgdGVzdGNhc2UudGVhcmRvd24sIHRlc3RjYXNlLnRlc3Rd LnNvbWUoKGZuKSA9PiBmbiAmJiBmbltTeW1ib2wudG9TdHJpbmdUYWddID09PSAiQXN5bmNGdW5j dGlvbiIpKQorICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJUcmllZCB0byBwYXNzIGEgdGVz dCBjYXNlIHdpdGggYW4gYXN5bmMgYHNldHVwYCwgYHRlc3RgLCBvciBgdGVhcmRvd25gIGZ1bmN0 aW9uLCBidXQgdGhpcyBpcyBhIHN5bmNocm9ub3VzIHRlc3Qgc3VpdGUuIikKKworICAgICAgICBz dXBlci5hZGRUZXN0Q2FzZSh0ZXN0Y2FzZSk7CisgICAgfQorCiAgICAgcnVuVGVzdENhc2VzQW5k RmluaXNoKCkKICAgICB7CiAgICAgICAgIHRoaXMucnVuVGVzdENhc2VzKCk7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzJm YjRiOWQ3OTEzOTA5MWI2YmZmNmViNGI4N2ZjMzRmNjZhMTlhYi4uOGQ2MWYzOTg3ZWQ1ZjRjYTRj ZjdjN2YwZjg3MzhlYzk0NzNkMDEyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEyLTEy ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFN5bmNUZXN0U3VpdGUgc2hvdWxkIGNvbXBsYWluIGlmIHBhc3NlZCBhbiBhc3luYyBzZXR1cC90 ZXN0L3RlYXJkb3duIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODA3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbmV3IHRlc3QgY2FzZXMgZm9yIG1vcmUgc3RyaWN0IHJlcXVpcmVt ZW50cyBmb3IgdGVzdCBjYXNlIGFyZ3VtZW50cy4KKworICAgICAgICAqIGluc3BlY3Rvci91bml0 LXRlc3RzL3N5bmMtdGVzdC1zdWl0ZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9y L3VuaXQtdGVzdHMvc3luYy10ZXN0LXN1aXRlLmh0bWw6CisKIDIwMTctMTItMDkgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc3VwcG9ydCBh c3luYyBzZXR1cCgpIGFuZCBhc3luYyB0ZWFyZG93bigpIGluIEFzeW5jVGVzdFN1aXRlCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9zeW5jLXRlc3Qtc3VpdGUt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvc3luYy10ZXN0 LXN1aXRlLWV4cGVjdGVkLnR4dAppbmRleCA3ODdkNWJkNzM1NWQzZjFlYTczNzFjYjE3NDUwYzc3 YTIzMmEwNDM4Li5jMjcxOThiYmE1MWM3NzA1MGJmM2M5MThlYTQwMTMwNmI0YTg2ODFjIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9zeW5jLXRlc3Qtc3VpdGUt ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL3N5bmMt dGVzdC1zdWl0ZS1leHBlY3RlZC50eHQKQEAgLTEzLDYgKzEzLDkgQEAgUEFTUzogc2hvdWxkIG5v dCBiZSBhYmxlIHRvIHNwZWNpZnkgbm9uLUZ1bmN0aW9uIGBzZXR1cGAgcGFyYW1ldGVyLgogUEFT Uzogc2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNwZWNpZnkgbm9uLUZ1bmN0aW9uIGB0ZWFyZG93bmAg cGFyYW1ldGVyLgogUEFTUzogc2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNwZWNpZnkgbm9uLUZ1bmN0 aW9uIGB0ZWFyZG93bmAgcGFyYW1ldGVyLgogUEFTUzogc2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNw ZWNpZnkgbm9uLUZ1bmN0aW9uIGB0ZWFyZG93bmAgcGFyYW1ldGVyLgorUEFTUzogc2hvdWxkIG5v dCBiZSBhYmxlIHRvIHNwZWNpZnkgYXN5bmMgYHRlc3RgIHBhcmFtZXRlci4KK1BBU1M6IHNob3Vs ZCBub3QgYmUgYWJsZSB0byBzcGVjaWZ5IGFzeW5jIGBzZXR1cGAgcGFyYW1ldGVyLgorUEFTUzog c2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNwZWNpZnkgYXN5bmMgYHRlYXJkb3duYCBwYXJhbWV0ZXIu CiBQQVNTOiBzaG91bGQgbm90IGJlIGFibGUgdG8gcnVuIGVtcHR5IHRlc3Qgc3VpdGUuCiAKID09 IFJ1bm5pbmcgdGVzdCBzdWl0ZTogU3luY1Rlc3RTdWl0ZS5SdW5Ud2ljZVN1aXRlCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9zeW5jLXRlc3Qtc3VpdGUuaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL3N5bmMtdGVzdC1zdWl0ZS5odG1s CmluZGV4IGNiYzA2YmY5ZDljNWIzNWZhNGM5OTAzMjE2Yzk1MjY3NjYzZmFjZTEuLjkzOTBlOGRm N2JjMWE2NzYwMjFmOTVhNjc5ZmJkNWYwM2I0YjAyOWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci91bml0LXRlc3RzL3N5bmMtdGVzdC1zdWl0ZS5odG1sCisrKyBiL0xheW91dFRl c3RzL2luc3BlY3Rvci91bml0LXRlc3RzL3N5bmMtdGVzdC1zdWl0ZS5odG1sCkBAIC0xMzUsNiAr MTM1LDM2IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgIH0gY2F0Y2ggKGUpIHsKICAgICAgICAgUHJv dG9jb2xUZXN0LmxvZygiUEFTUzogc2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNwZWNpZnkgbm9uLUZ1 bmN0aW9uIGB0ZWFyZG93bmAgcGFyYW1ldGVyLiIpOwogICAgIH0KKyAgICB0cnkgeworICAgICAg ICBiYWRBcmdzU3VpdGUuYWRkVGVzdENhc2UoeworICAgICAgICAgICAgbmFtZTogImZvbyIsCisg ICAgICAgICAgICBhc3luYyB0ZXN0KCkge30sCisgICAgICAgIH0pOworICAgICAgICBQcm90b2Nv bFRlc3QubG9nKCJGQUlMOiBzaG91bGQgbm90IGJlIGFibGUgdG8gc3BlY2lmeSBhc3luYyBgdGVz dGAgcGFyYW1ldGVyLiIpOworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgUHJvdG9jb2xUZXN0 LmxvZygiUEFTUzogc2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNwZWNpZnkgYXN5bmMgYHRlc3RgIHBh cmFtZXRlci4iKTsKKyAgICB9CisgICAgdHJ5IHsKKyAgICAgICAgYmFkQXJnc1N1aXRlLmFkZFRl c3RDYXNlKHsKKyAgICAgICAgICAgIG5hbWU6ICJmb28iLAorICAgICAgICAgICAgYXN5bmMgc2V0 dXAoKSB7fSwKKyAgICAgICAgICAgIHRlc3QoKSB7fSwKKyAgICAgICAgfSk7CisgICAgICAgIFBy b3RvY29sVGVzdC5sb2coIkZBSUw6IHNob3VsZCBub3QgYmUgYWJsZSB0byBzcGVjaWZ5IGFzeW5j IGBzZXR1cGAgcGFyYW1ldGVyLiIpOworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgUHJvdG9j b2xUZXN0LmxvZygiUEFTUzogc2hvdWxkIG5vdCBiZSBhYmxlIHRvIHNwZWNpZnkgYXN5bmMgYHNl dHVwYCBwYXJhbWV0ZXIuIik7CisgICAgfQorICAgIHRyeSB7CisgICAgICAgIGJhZEFyZ3NTdWl0 ZS5hZGRUZXN0Q2FzZSh7CisgICAgICAgICAgICBuYW1lOiAiZm9vIiwKKyAgICAgICAgICAgIHRl c3QoKSB7fSwKKyAgICAgICAgICAgIGFzeW5jIHRlYXJkb3duKCkge30sCisgICAgICAgIH0pOwor ICAgICAgICBQcm90b2NvbFRlc3QubG9nKCJGQUlMOiBzaG91bGQgbm90IGJlIGFibGUgdG8gc3Bl Y2lmeSBhc3luYyBgdGVhcmRvd25gIHBhcmFtZXRlci4iKTsKKyAgICB9IGNhdGNoIChlKSB7Cisg ICAgICAgIFByb3RvY29sVGVzdC5sb2coIlBBU1M6IHNob3VsZCBub3QgYmUgYWJsZSB0byBzcGVj aWZ5IGFzeW5jIGB0ZWFyZG93bmAgcGFyYW1ldGVyLiIpOworICAgIH0KKwogICAgIGxldCBydW5F bXB0eVN1aXRlID0gUHJvdG9jb2xUZXN0LmNyZWF0ZVN5bmNTdWl0ZSgiU3luY1Rlc3RTdWl0ZS5S dW5FbXB0eVN1aXRlIik7CiAgICAgdHJ5IHsKICAgICAgICAgcnVuRW1wdHlTdWl0ZS5ydW5UZXN0 Q2FzZXMoKTsK