180709 2017-12-12 11:24:11 -0800 WebGL TextureMapperShaderProgram shaders don't compile in MSVC 2017-12-12 13:12:28 -0800 1 1 1 Unclassified WebKit WebGL Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen cmarcelo commit-queue darin dino don.olmstead ews-watchlist kondapallykalyan luiz magomez mcatanzaro mmaxfield noam pvollan webkit-bug-importer zan oldest_to_newest 1380741 0 chris.reid 2017-12-12 11:24:11 -0800 MSVC likes to expand __VA_ARGS__ differently than clang and gcc which is causing shader programs to not compile in TextureMapperShaderProgram.cpp due to "#if USE(OPENGL_ES_2)" being added to the shader programs. 1380743 1 chris.reid 2017-12-12 11:29:05 -0800 Here's a simple program compiled in MSVC to show what is happening and the difference in expansion: MSVC: http://rextester.com/PXT40494 CLANG: http://rextester.com/SZXMYM65465 (GCC acts the same as CLANG) 1380770 2 329138 chris.reid 2017-12-12 12:22:56 -0800 Created attachment 329138 patch 1380772 3 ews-watchlist 2017-12-12 12:25:59 -0800 Attachment 329138 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:66: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:187: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1380797 4 329138 commit-queue 2017-12-12 13:11:15 -0800 Comment on attachment 329138 patch Clearing flags on attachment: 329138 Committed r225800: <https://trac.webkit.org/changeset/225800> 1380798 5 commit-queue 2017-12-12 13:11:16 -0800 All reviewed patches have been landed. Closing bug. 1380800 6 webkit-bug-importer 2017-12-12 13:12:28 -0800 <rdar://problem/36002359> 329138 2017-12-12 12:22:56 -0800 2017-12-12 13:11:15 -0800 patch 180709.diff text/plain 2368 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYzc5NDU1NGFiMC4uZjYzMGU5ZjQ0ZTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0xMi0xMiAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgV2ViR0wgVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0gc2hhZGVy cyBkb24ndCBjb21waWxlIGluIE1TVkMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MDcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisg ICAgICAgIFZlcnRleCBhbmQgRnJhZ21lbnQgc2hhZGVycyB3ZXJlIG5vdCBjb21waWxpbmcgYmVj YXVzZSBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAgd2FzCisgICAgICAgIHN0cmluZ2lm eWluZyAiI2lmIFVTRShPUEVOR0xfRVNfMikgLi4uICNlbmRpZiIgaW50byB0aGUgc2hhZGVycyBy YXRoZXIgdGhhbiBldmFsdWF0aW5nIHRoZXNlCisgICAgICAgIHByZXByb2Nlc3NvciBkaXJlY3Rp dmVzIGJlZm9yZSB0aGUgU1RSSU5HSUZZIGV4cGFuc2lvbi4KKworICAgICAgICBNb3ZlZCB0aGVz ZSAjaWYgY29uZGl0aW9ucyBvdXRzaWRlIG9mIFNUUklOR0lGWSB0byByZW1vdmUgY29tcGlsZXIg YW1iaWd1aXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJTaGFkZXJQcm9ncmFtLmNwcDoKKwogMjAxNy0xMi0xMSAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZsb2F0aW5nT2JqZWN0cy9GbG9hdGluZ09iamVjdCBj bGFzc2VzIHNob3VsZCBob2xkIHdlYWsgcmVmZXJlbmNlcyB0byByZW5kZXJlcnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy U2hhZGVyUHJvZ3JhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCmluZGV4IDY2N2QxNWYxMDkxLi5jOTU2 NGM3OGNjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCkBA IC01OCwxMCArNTgsMTIgQEAgc3RhdGljIGNvbnN0IGNoYXIqIHZlcnRleFRlbXBsYXRlTFQzMjBW YXJzID0KICNpZiBVU0UoT1BFTkdMX0VTXzIpCiAgICAgVEVYVFVSRV9TUEFDRV9NQVRSSVhfUFJF Q0lTSU9OX0RJUkVDVElWRQogI2VuZGlmCi0gICAgU1RSSU5HSUZZKAogI2lmIFVTRShPUEVOR0xf RVNfMikKKyAgICBTVFJJTkdJRlkoCiAgICAgICAgIHByZWNpc2lvbiBUZXh0dXJlU3BhY2VNYXRy aXhQcmVjaXNpb24gZmxvYXQ7CisgICAgKQogI2VuZGlmCisgICAgU1RSSU5HSUZZKAogICAgICAg ICBhdHRyaWJ1dGUgdmVjNCBhX3ZlcnRleDsKICAgICAgICAgdmFyeWluZyB2ZWMyIHZfdGV4Q29v cmQ7CiAgICAgICAgIHZhcnlpbmcgdmVjMiB2X3RyYW5zZm9ybWVkVGV4Q29vcmQ7CkBAIC0xNjgs MTYgKzE3MCwyMSBAQCBzdGF0aWMgY29uc3QgY2hhciogZnJhZ21lbnRUZW1wbGF0ZUhlYWRlckNv bW1vbiA9CiAjaWYgVVNFKE9QRU5HTF9FU18yKQogICAgIFRFWFRVUkVfU1BBQ0VfTUFUUklYX1BS RUNJU0lPTl9ESVJFQ1RJVkUKICNlbmRpZgotICAgIFNUUklOR0lGWSgKICNpZiBVU0UoT1BFTkdM X0VTXzIpCisgICAgU1RSSU5HSUZZKAogICAgICAgICBwcmVjaXNpb24gVGV4dHVyZVNwYWNlTWF0 cml4UHJlY2lzaW9uIGZsb2F0OworICAgICkKICNlbmRpZgorICAgIFNUUklOR0lGWSgKICAgICAg ICAgdW5pZm9ybSBtYXQ0IHVfdGV4dHVyZVNwYWNlTWF0cml4OwogICAgICAgICB1bmlmb3JtIG1h dDQgdV90ZXh0dXJlQ29sb3JTcGFjZU1hdHJpeDsKKyAgICApCiAjaWYgVVNFKE9QRU5HTF9FU18y KQorICAgIFNUUklOR0lGWSgKICAgICAgICAgcHJlY2lzaW9uIG1lZGl1bXAgZmxvYXQ7CisgICAg KQogI2VuZGlmCi0gICAgKTsKKyAgICA7CiAKIC8vIElucHV0L291dHB1dCB2YXJpYWJsZXMgZGVm aW5pdGlvbiBmb3IgYm90aCBHTEVTIGFuZCBPcGVuR0wgPCAzLjIuCiBzdGF0aWMgY29uc3QgY2hh ciogZnJhZ21lbnRUZW1wbGF0ZUxUMzIwVmFycyA9Cg==